"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31161
Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intranet, this is ignored in (Curl)HttpRequest because the proxy url is not cleared. This commit makes sure at lowest level - namel in the public function proxySetup() - that a optional(true) value of noProxy is observed and that it (now) also clears the proxy url. (I have been told that I am allowed to commit this patch. Please carefully review, as usual). Wikinaut's comment: "+ if ( $this->proxy && !$this->noProxy ) Shouldn't this be an OR statement? " No. This was one of the core changes, as it makes sure that the processing _continues_ here in the case that $this->noProxy is true. Without that patch, processing stopped and a proxy value was not cleared. In other words, if noProxy is set true, the function must not return but continue in order to clear any proxy value. (I use this fix in our enterprise wiki since many days, and everything works very well - fetching feeds from the intranet without proxy and from the extranet with proxy.) _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
