No offense to those who have chimed in, but seriously, this is a silly
discussion.
Do we really have the bandwidth to be 15 messages deep on this thread?
- Trevor
On Thu, Mar 29, 2012 at 5:24 PM, Tim Starling tstarl...@wikimedia.orgwrote:
On 29/03/12 00:10, Chad wrote:
Hi everyone,
The doctrine of toleration requires a positive as well as a negative
statement. It is not only wrong to burn a man on account of his creed,
but it is right to encourage the open avowal and defence of every
opinion sincerely maintained. Every man who says frankly and fully
what he thinks is so far
I disagree, the previous message would sound really bit offensive to
people who submitted the patch, and is nothing motivating for the
volunteers who spend their time trying to help with the project.
Imagine you send a code to open source project in a good faith and get
the reply: I'd be more
On Fri, Mar 30, 2012 at 2:10 AM, Trevor Parscal tpars...@wikimedia.org wrote:
No offense to those who have chimed in, but seriously, this is a silly
discussion.
I personally don't care what it says (the development version currently
says THIS IS THE WORST PATCH EVER!!!). I was fine with I'd
On Thu, Mar 29, 2012 at 8:24 PM, Tim Starling tstarl...@wikimedia.org wrote:
I don't really want Gerrit putting words into my mouth regardless of
how nice they sound. There will always be cases where the phrase is
inappropriate and offputting, regardless of which one you choose.
How about Set
Le 30/03/12 13:18, Chad a wrote :
THIS IS THE WORST PATCH EVER!!!
Does it automatically abandon the previous nominee? That would great to
have since we will be guaranteed to only have one bad patch at any time.
--
Antoine hashar Musso
___
Le 30/03/12 08:10, Trevor Parscal a écrit :
No offense to those who have chimed in, but seriously, this is a silly
discussion.
I guess that is how our community has always ran. That is very much
alike the diff colors drama we had when deploying 1.19 on enwiki.
Do we really have the bandwidth
On Fri, Mar 30, 2012 at 7:58 AM, Antoine Musso hashar+...@free.fr wrote:
Le 30/03/12 08:10, Trevor Parscal a écrit :
No offense to those who have chimed in, but seriously, this is a silly
discussion.
I guess that is how our community has always ran. That is very much
alike the diff colors
On Mar 30, 2012, at 2:24 AM, Tim Starling wrote:
On 29/03/12 00:10, Chad wrote:
Hi everyone,
There's been some comments that the phrasing for a -1 vote in
Gerrit (I'd prefer that you didn't submit this) is kind of personal
and we can do better.
I did some testing and this is totally
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote:
Can we just set it to an empty string and let the numbers and hand-written
comment speak for themselves?
I think this will be more confusing. You need some text for
the radio field.
In any case these summaries are not meant
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote:
I couldn't agree more. So far all proposal make implications that sometimes
simply aren't appropriate. Either they leave no room for fixing it (Don't
submit it), or are too much foccused on fixing something small, but
On Mar 30, 2012, at 3:07 PM, Chad wrote:
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote:
Can we just set it to an empty string and let the numbers and hand-written
comment speak for themselves?
I think this will be more confusing. You need some text for
the radio
On Fri, Mar 30, 2012 at 9:27 AM, Krinkle krinklem...@gmail.com wrote:
On Mar 30, 2012, at 3:07 PM, Chad wrote:
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote:
Can we just set it to an empty string and let the numbers and hand-written
comment speak for themselves?
I
Tim Starling wrote:
I don't really want Gerrit putting words into my mouth regardless of
how nice they sound. There will always be cases where the phrase is
inappropriate and offputting, regardless of which one you choose.
I agree with Tim here, I was thinking the same on this thread. Gerrit
On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen rm...@wikimedia.org wrote:
I agree. Having 'you' or 'i' makes the message personal when the focus
should remain on the commit itself.
+ 1
This patch needs improvement. | Needs improvement, this patch does. ( if
we go with the yoda job )
I've
On 03/29/2012 09:20 AM, Chad wrote:
On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen rm...@wikimedia.org wrote:
I agree. Having 'you' or 'i' makes the message personal when the focus
should remain on the commit itself.
+ 1
This patch needs improvement. | Needs improvement, this patch does. ( if
2012/3/29 Chad innocentkil...@gmail.com:
On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen rm...@wikimedia.org wrote:
I agree. Having 'you' or 'i' makes the message personal when the focus
should remain on the commit itself.
+ 1
This patch needs improvement. | Needs improvement, this patch does.
It sounds better. Shame on your that you don't like Yoda
On Thu, Mar 29, 2012 at 3:20 PM, Chad innocentkil...@gmail.com wrote:
On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen rm...@wikimedia.org wrote:
I agree. Having 'you' or 'i' makes the message personal when the focus
should remain on the
+1 for There is a problem with this patchset, please improve.
Fix suggests you've broken something
(Yoda version would be Problem to be improved with this patchset there
is.) Does Gerrit support a yoda speak language... would make reviewing
even more fun ;-)?
On Thu, Mar 29, 2012 at 2:34 PM,
On Thu, Mar 29, 2012 at 9:42 AM, Jon Robson jrob...@wikimedia.org wrote:
+1 for There is a problem with this patchset, please improve.
Alright, sounds good to me. Thanks for the input everyone.
I'll get this fixed soon.
-Chad
___
Wikitech-l mailing
+1 for There is a problem with this patchset
(without , please improve).
I think that keeps it more neutral without saying anything the user doesn't
intend to say. It also keeps free ambiguity in the intention (to be
disambiguated
in a comment) between 'wontfix' and 'fixme'.
-- Krinkle
On Mar
On Thu, Mar 29, 2012 at 7:07 AM, Chad innocentkil...@gmail.com wrote:
On Thu, Mar 29, 2012 at 9:42 AM, Jon Robson jrob...@wikimedia.org wrote:
+1 for There is a problem with this patchset, please improve.
Alright, sounds good to me. Thanks for the input everyone.
I'll get this fixed soon.
On 29/03/12 00:10, Chad wrote:
Hi everyone,
There's been some comments that the phrasing for a -1 vote in
Gerrit (I'd prefer that you didn't submit this) is kind of personal
and we can do better.
I did some testing and this is totally configurable :) It won't change
for old comments that
Hi everyone,
There's been some comments that the phrasing for a -1 vote in
Gerrit (I'd prefer that you didn't submit this) is kind of personal
and we can do better.
I did some testing and this is totally configurable :) It won't change
for old comments that were already submitted, but we can
* I found a problem in this revision
* There is a problem in this revision
* Thank you for submitting your revision, but there is some error in your code
Some suggestions :)
On Wed, Mar 28, 2012 at 3:10 PM, Chad innocentkil...@gmail.com wrote:
Hi everyone,
There's been some comments that
This patch cannot be merged in the current state or something like that.
—vvv
On Wed, Mar 28, 2012 at 5:10 PM, Chad innocentkil...@gmail.com wrote:
Hi everyone,
There's been some comments that the phrasing for a -1 vote in
Gerrit (I'd prefer that you didn't submit this) is kind of personal
+1 for There is a problem with this revision.
as it doesn't make use of any personal words like 'you' or 'i'
Maybe even append 'Please fix' to give an action to the sender.
e.g. There is a problem with this revision. Please fix.
On Wed, Mar 28, 2012 at 2:17 PM, Petr Bena benap...@gmail.com
I support the less personal wording, but cannot is more like -2.
-1 is more like should not.
--
Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
http://aharoni.wordpress.com
“We're living in pieces,
I want to live in peace.” – T. Moore
2012/3/28 Victor Vasiliev vasi...@gmail.com:
This
Le 28/03/12 15:10, Chad a écrit :
There's been some comments that the phrasing for a -1 vote in
Gerrit (I'd prefer that you didn't submit this) is kind of personal
and we can do better.
Better as make it even more personal ? :-D
My suggestion is:
This patchset needs to be improved
That
I agree. Having 'you' or 'i' makes the message personal when the focus
should remain on the commit itself.
+ 1
This patch needs improvement. | Needs improvement, this patch does. ( if
we go with the yoda job )
On Wed, Mar 28, 2012 at 8:29 AM, Antoine Musso hashar+...@free.fr wrote:
Le
30 matches
Mail list logo
