Re: [Wikitech-l] Min php version

2015-07-23 Thread Bartosz Dziewoński
On Thu, 23 Jul 2015 12:19:13 +0200, bawolff wrote: Just for reference, in this case, I'm pretty sure the code in question has unit tests Yes, it does. (For posterity, my example was commit 5042d260ce5190cce0c325b7cb5b618b3cff73bc, which fixed 5.3 compat breakage caught by 5ed35b04c99abbd

Re: [Wikitech-l] Min php version

2015-07-23 Thread bawolff
> > (Also, that only catches incompatibilities in code that has unit tests. ;) > I've ran into 5.3 compat breakages in the past when I added new features > with tests, that used some existing code without tests.) > Just for reference, in this case, I'm pretty sure the code in question has unit tes

Re: [Wikitech-l] Min php version

2015-07-22 Thread Bartosz Dziewoński
On Wed, 22 Jul 2015 22:18:57 +0200, Eran Rosenthal wrote: side note: How come php 5.3.3 support broken accidentally? Isn't Jenkins script validates compatibility with the min php? :) We run unit tests, but on PHP 5.3.10, according to the console output. (For example https://integration.

Re: [Wikitech-l] Min php version

2015-07-22 Thread Thomas Mulhall
Maybe another php bump to something like 5.3.6. I think one php 5.3 usage goes down then we should switch to something like php 5.5 or 5.6 or even php 7 if php 7 get enough popularity. On Wednesday, 22 July 2015, 21:19, Eran Rosenthal wrote: side note: How come php 5.3.3 support b

Re: [Wikitech-l] Min php version

2015-07-22 Thread Eran Rosenthal
side note: How come php 5.3.3 support broken accidentally? Isn't Jenkins script validates compatibility with the min php? :) On Wed, Jul 22, 2015 at 9:36 PM, Krinkle wrote: > > > On 20 Jul 2015, at 22:42, Legoktm wrote: > > > > OTOH, if we never bump our version requirements, there's less incen

Re: [Wikitech-l] Min php version

2015-07-22 Thread Krinkle
> On 20 Jul 2015, at 22:42, Legoktm wrote: > > OTOH, if we never bump our version requirements, there's less incentive > for hosting providers to upgrade their PHP. [1] has some interesting > arguments regarding this. > > [1] http://blog.ircmaxell.com/2014/12/on-php-version-requirements.html >

Re: [Wikitech-l] Min php version

2015-07-22 Thread Erik Bernhardson
On Tue, Jul 21, 2015 at 1:22 PM, Gergo Tisza wrote: > On Tue, Jul 21, 2015 at 11:27 AM, Tyler Romeo > wrote: > > > One thing I forgot to mention: while you're considering Debian and Ubuntu > > support, make sure to also take into account MediaWiki support. > > > > Even if we upgrade our minimum

Re: [Wikitech-l] Min php version

2015-07-22 Thread Bartosz Dziewoński
On Tue, 21 Jul 2015 22:22:41 +0200, Gergo Tisza wrote: On Tue, Jul 21, 2015 at 11:27 AM, Tyler Romeo wrote: Even if we upgrade our minimum PHP version now, older versions of MediaWiki with the 5.3 requirement will still be supported and receive security updates. So the only difference wi

Re: [Wikitech-l] Min php version

2015-07-21 Thread Gergo Tisza
On Tue, Jul 21, 2015 at 11:27 AM, Tyler Romeo wrote: > One thing I forgot to mention: while you're considering Debian and Ubuntu > support, make sure to also take into account MediaWiki support. > > Even if we upgrade our minimum PHP version now, older versions of > MediaWiki with the 5.3 require

Re: [Wikitech-l] Min php version

2015-07-21 Thread Tyler Romeo
One thing I forgot to mention: while you're considering Debian and Ubuntu support, make sure to also take into account MediaWiki support. Even if we upgrade our minimum PHP version now, older versions of MediaWiki with the 5.3 requirement will still be supported and receive security updates. So

Re: [Wikitech-l] Min php version

2015-07-21 Thread Greg Grossmeier
> Debian 6.0 is supported until February 2016 and has PHP 5.3.3 > > Ubuntu 12.04 is supported until April 2017 and has PHP 5.3.10 > > RHEL 6/Centos is supported until June 2017 (and limited supported until > 2020) and has PHP 5.3.3 (but they also provide officially supported 5.4/5.5 > packages)

Re: [Wikitech-l] Min php version

2015-07-21 Thread bawolff
On Tue, Jul 21, 2015 at 2:44 AM, Moritz Muhlenhoff wrote: > Hi, > > On Tue, Jul 21, 2015 at 8:13 AM, Tyler Romeo wrote: > >> Just as a counter-argument (and, to be clear, I do support raising our >> minimum version), just because PHP has EOL'ed a version does not mean that >> some distributions (

Re: [Wikitech-l] Min php version

2015-07-21 Thread Moritz Muhlenhoff
Hi, On Tue, Jul 21, 2015 at 8:13 AM, Tyler Romeo wrote: > Just as a counter-argument (and, to be clear, I do support raising our > minimum version), just because PHP has EOL'ed a version does not mean that > some distributions (esp. Debian, Ubuntu) are not providing additional > support and secu

Re: [Wikitech-l] Min php version

2015-07-20 Thread Stas Malyshev
Hi! > What I'm answering is the proposal that removing support for PHP 5.3 > will motivate the user to upgrade their PHP, when that isn't the case. It may not motivate them to upgrade their PHP if their hosting can not provide that, but it will motivate them to upgrade their hosting, if the hosti

Re: [Wikitech-l] Min php version

2015-07-20 Thread Tyler Romeo
Just as a counter-argument (and, to be clear, I do support raising our minimum version), just because PHP has EOL'ed a version does not mean that some distributions (esp. Debian, Ubuntu) are not providing additional support and security updates. If I remember from the last time we had this disc

Re: [Wikitech-l] Min php version

2015-07-20 Thread Legoktm
On 07/20/2015 09:18 AM, David Gerard wrote: > What I'm answering is the proposal that removing support for PHP 5.3 > will motivate the user to upgrade their PHP, when that isn't the case. > > I recall this has been the conclusion reached on this list previously > - that this will cause problems fo

Re: [Wikitech-l] Min php version

2015-07-20 Thread David Gerard
On 20 July 2015 at 17:03, Greg Grossmeier wrote: > >> If this is all their host provides, however, this will in practice >> lead only to never-updated MediaWiki running on never-updated PHP. > Not much anyone other than the host or the user can do about that. > Certainly nothing we (MW devs and

Re: [Wikitech-l] Min php version

2015-07-20 Thread Greg Grossmeier
> If this is all their host provides, however, this will in practice > lead only to never-updated MediaWiki running on never-updated PHP. Not much anyone other than the host or the user can do about that. Certainly nothing we (MW devs and/or WMF) can. -- | Greg GrossmeierGPG: B2FA 2

Re: [Wikitech-l] Min php version

2015-07-20 Thread David Gerard
On 19 July 2015 at 19:41, Stas Malyshev wrote: > The users should really seriously consider upgrading. 5.3 is EOL for a > year now (which means, not even security fixes for a year) and 5.4 is > going EOL in 2 months. If any of these sites are public-facing (and due > to the nature of wikis, many

Re: [Wikitech-l] Min php version

2015-07-19 Thread Stas Malyshev
Hi! > Hi php 5.5 is still probly years from being minium in mediawiki due > to so many users use php 5.3 and 5.4. The users should really seriously consider upgrading. 5.3 is EOL for a year now (which means, not even security fixes for a year) and 5.4 is going EOL in 2 months. If any of these sit

Re: [Wikitech-l] Min php version

2015-07-19 Thread Thomas Mulhall
Hi php 5.5 is still probly years from being minium in mediawiki due to so many users use php 5.3 and 5.4. It would be a bigger impact on mediawiki then when we switch to 5.3 from the prevous minium of 5.2. On Sunday, 19 July 2015, 15:15, Bryan Davis wrote: On Sun, Jul 19, 2015 at 4

Re: [Wikitech-l] Min php version

2015-07-19 Thread Bryan Davis
On Sun, Jul 19, 2015 at 4:35 AM, bawolff wrote: > According to our docs/internal checks, our min php version is 5.3.3. > However as of 6e283d394f31, MediaWiki doesn't work with php 5.3.3 (You > aren't allowed to implement an interface using an abstract method, on > that version of PHP so you get "

Re: [Wikitech-l] Min php version

2015-07-19 Thread Legoktm
On 07/19/2015 04:35 AM, bawolff wrote: > According to our docs/internal checks, our min php version is 5.3.3. > However as of 6e283d394f31, MediaWiki doesn't work with php 5.3.3 (You > aren't allowed to implement an interface using an abstract method, on > that version of PHP so you get "Fatal erro

[Wikitech-l] Min php version

2015-07-19 Thread bawolff
According to our docs/internal checks, our min php version is 5.3.3. However as of 6e283d394f31, MediaWiki doesn't work with php 5.3.3 (You aren't allowed to implement an interface using an abstract method, on that version of PHP so you get "Fatal error: Can't inherit abstract function IDatabase::g