Re: [Wikitech-l] New Gerrit privilege policy

2019-03-18 Thread Daniel Kinzler
Am 16.03.19 um 18:40 schrieb Zppix: > So your basically telling me, I can’t decide who gets the power to +2 on for > example a toolforge tool I actively am the primary maintainer of? Instead it > has to be requested. The relevant part of the policy reads: | If there is a consensus of trusted de

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-17 Thread Tim Starling
On 17/3/19 11:25 pm, MA wrote: > Hello, > > Would still be > acceptable? > > Creating repos also involve self-merging stuff (.gitreview files > mostly; also sometimes importing from GitHub). If you're doing it already and nobody cares, it's

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-17 Thread MA
Hello, Would still be acceptable? Creating repos also involve self-merging stuff (.gitreview files mostly; also sometimes importing from GitHub). Best regards, M. ___ Wikitech-l mailing list Wiki

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-17 Thread Tim Starling
On 17/3/19 7:43 am, Amir Sarabadani wrote: > I just want to point out that this wasn't "handed down by a CTO", it was a > RFC [1] that and was open for discussion to everyone and was discussed > extensively (and the RFC changed because of these discussions, look at the > history of the page), then

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Tim Starling
On 17/3/19 12:48 am, Merlijn van Deen (valhallasw) wrote: > On Sat, 16 Mar 2019 at 03:01, Tim Starling wrote: > >> No, managing +2 permissions is not up to the maintainer of the tool, >> that's the whole point of the change. >> > > I feel that this policy, although well-meaning, and a step forwa

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Amir Sarabadani
I just want to point out that this wasn't "handed down by a CTO", it was a RFC [1] that and was open for discussion to everyone and was discussed extensively (and the RFC changed because of these discussions, look at the history of the page), then had an IRC meeting that was also open to everyone,

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Yuri Astrakhan
I agree that while possibly made with good intentions, policy changes like these should go through dev community discussion + vote, not be handed down from a CTO. Wikipedia as a movement started that way, and many people participated in it because of its transparency and community-driven process.

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Zppix
Andre, from what im gathering from this thread thats not what I understand, so i redact the part of my last email about toolforge, however my point on this policy change should of been put to a community vote/consensus is valid. -- Devin “Zppix” CCENT Volunteer Wikimedia Developer Africa Wikimed

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Andre Klapper
On Sat, 2019-03-16 at 12:40 -0500, Zppix wrote: > So your basically telling me, I can’t decide who gets the power to +2 > on for example a toolforge tool I actively am the primary maintainer > of? Instead it has to be requested. I do not disagree with a lot of > the changes to technical policies, b

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Zppix
So your basically telling me, I can’t decide who gets the power to +2 on for example a toolforge tool I actively am the primary maintainer of? Instead it has to be requested. I do not disagree with a lot of the changes to technical policies, but with this change it seems to restrict ability to s

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Isarra Yos
On 16/03/2019 14:35, Bartosz Dziewoński wrote: On 2019-03-16 14:48, Merlijn van Deen (valhallasw) wrote: 1. According to the policy, self-+2'ing is grounds for revocation of Gerrit privileges. For a Toolforge tool, self +2-ing is common and expected: the repository is hosted on Gerrit to allow

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Bartosz Dziewoński
On 2019-03-16 14:48, Merlijn van Deen (valhallasw) wrote: 1. According to the policy, self-+2'ing is grounds for revocation of Gerrit privileges. For a Toolforge tool, self +2-ing is common and expected: the repository is hosted on Gerrit to allow for CI and to make contributions from others easi

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Isarra Yos
On 16/03/2019 13:48, Merlijn van Deen (valhallasw) wrote: On Sat, 16 Mar 2019 at 03:01, Tim Starling wrote: No, managing +2 permissions is not up to the maintainer of the tool, that's the whole point of the change. I feel that this policy, although well-meaning, and a step forwards for Media

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Merlijn van Deen (valhallasw)
On Sat, 16 Mar 2019 at 03:01, Tim Starling wrote: > No, managing +2 permissions is not up to the maintainer of the tool, > that's the whole point of the change. > I feel that this policy, although well-meaning, and a step forwards for MediaWiki and other WMF-production software, is unreasonably

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-16 Thread Andre Klapper
On Sat, 2019-03-16 at 12:59 +1100, Tim Starling wrote: > On 16/3/19 7:53 am, Andre Klapper wrote: > > What is supposed to happen with > > https://phabricator.wikimedia.org/tag/repository-ownership-requests/ ? > > I archived it. Thanks! I've updated its Phab project description to explain where to

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-15 Thread Tim Starling
On 14/3/19 1:00 pm, Gergo Tisza wrote: > On Wed, Mar 13, 2019 at 5:33 PM Tim Starling > wrote: > >> File a task in Phabricator under the Gerrit-Privilege-Requests >> project, recommending that the person be given access, giving your >> reasons and mentioning that you are the maintainer of the pro

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-15 Thread Tim Starling
On 16/3/19 7:53 am, Andre Klapper wrote: > On Wed, 2019-03-13 at 15:24 +1100, Tim Starling wrote: >> * The Phabricator projects for requesting access have changed. I'm in >> the process of moving the tickets over. > > What is supposed to happen with > https://phabricator.wikimedia.org/tag/reposito

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-15 Thread Andre Klapper
On Wed, 2019-03-13 at 15:24 +1100, Tim Starling wrote: > * The Phabricator projects for requesting access have changed. I'm in > the process of moving the tickets over. What is supposed to happen with https://phabricator.wikimedia.org/tag/repository-ownership-requests/ ? Do you plan to archive th

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-13 Thread Gergo Tisza
On Wed, Mar 13, 2019 at 5:33 PM Tim Starling wrote: > File a task in Phabricator under the Gerrit-Privilege-Requests > project, recommending that the person be given access, giving your > reasons and mentioning that you are the maintainer of the project in > question. Wait for at least a week for

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-13 Thread Tim Starling
File a task in Phabricator under the Gerrit-Privilege-Requests project, recommending that the person be given access, giving your reasons and mentioning that you are the maintainer of the project in question. Wait for at least a week for comments. Then a Gerrit administrator should add the person a

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-13 Thread Zppix
Hello, So what is the process for adding people to +2 on gerrit repos im the primary maintainer of (for example my ZppixBot toolforge gerrit repo) -- Devin “Zppix” CCENT Volunteer Wikimedia Developer Africa Wikimedia Developers Member and Mentor Volunteer Mozilla Support Team Member (SUMO) Quora.

Re: [Wikitech-l] New Gerrit privilege policy

2019-03-12 Thread Physikerwelt
On Wed, Mar 13, 2019 at 5:25 AM Tim Starling wrote: > > Following approval by TechCom and WMF Interim CTO Erika Bjune, I've > moved the new Gerrit privilege policy page out of my userspace to > > https://www.mediawiki.org/wiki/Gerrit/Privilege_policy > > This is a merge of two pages: [[Gerrit/+2]]

[Wikitech-l] New Gerrit privilege policy

2019-03-12 Thread Tim Starling
Following approval by TechCom and WMF Interim CTO Erika Bjune, I've moved the new Gerrit privilege policy page out of my userspace to https://www.mediawiki.org/wiki/Gerrit/Privilege_policy This is a merge of two pages: [[Gerrit/+2]] and [[Gerrit/Project ownership]], with some additional changes.