Le 08/11/12 19:43, Daniel Friesen wrote:
> And I really don't like the idea of B. I can easily see people
> mentioning bugs that are related to a commit in the commit message but
> not directly fixed by it.
We could use an explicit convention such as: close #1234
--
Antoine "hashar" Musso
__
>
> Maybe we need a Waiting_merge status in bugzilla.
>
I would like that. I find the "patch-in-gerrit" keyword very easy to
miss, and really "patch in gerrit" and "open" are two very different
stages of a bugs lifestyle.
-bawolff
___
Wikitech-l mailin
On 08/11/12 20:00, Chad wrote:
> I don't really like that idea either. How about instead of auto-closing, we
> at least have Gerrit tell BZ a patch was committed/submitted? That would
> save the "I've put a patch in " step, and would prompt people on the
> CC list to possibly close when Gerrit says
>> And I really don't like the idea of B. I can easily see
>> people mentioning bugs that are related to a commit in the
>> commit message but not directly fixed by it.
>
> Then why did you invent B only to rail against it? Just use
> a reasonable pattern, e. g. "This fixes bug #(\d+)\."
>
At my
Stephan Gambke wrote:
> is there a recommended work flow for bugfixing?
> Right now what I do is submit a patch to gerrit and, if I remember, set
> some tag in bugzilla. At some point somebody approves and merges the
> patch. Then, if I remember, I set the bug to resolved/fixed in bugzilla.
> T
"Daniel Friesen" wrote:
>> is there a recommended work flow for bugfixing?
>> Right now what I do is submit a patch to gerrit and, if I remember, set
>> some tag in bugzilla. At some point somebody approves and merges the
>> patch. Then, if I remember, I set the bug to resolved/fixed in bugzilla
On 11/08/2012 07:43 PM, Daniel Friesen wrote:
>> Would it be possible/sensible to automatically close a bug when the
>> patch is merged? Or did I miss something?
>
> That would require two things:
> A) Far more integration between Gerrit and Bugzilla than we currently have.
> B) An assumption that
What about changes like https://gerrit.wikimedia.org/r/#/c/29422/,
which mentions bug 1, but obviously doesn't entirely fix it?
It wouldn't be put into the branch, or maybe it would be put into the
branch but the branch would never get closed. But I like Chad's idea
better, currently.
--
Mar
2012/11/8 Mark Holmquist :
>> And I really don't like the idea of B. I can easily see people
>> mentioning bugs that are related to a commit in the commit message but
>> not directly fixed by it.
>
>
> Maybe we should start a new branch per-bug instead, and merge the branch
> when the bug is fixed?
On Thu, Nov 8, 2012 at 1:57 PM, Mark Holmquist wrote:
>> And I really don't like the idea of B. I can easily see people
>> mentioning bugs that are related to a commit in the commit message but
>> not directly fixed by it.
>
>
> Maybe we should start a new branch per-bug instead, and merge the bra
And I really don't like the idea of B. I can easily see people
mentioning bugs that are related to a commit in the commit message but
not directly fixed by it.
Maybe we should start a new branch per-bug instead, and merge the branch
when the bug is fixed? That might help with this issue.
--
M
2012/11/8 Stephan Gambke :
> Hi,
>
> is there a recommended work flow for bugfixing?
>
> Right now what I do is submit a patch to gerrit and, if I remember, set
> some tag in bugzilla. At some point somebody approves and merges the
> patch. Then, if I remember, I set the bug to resolved/fixed in bu
On Thu, 2012-11-08 at 13:00 -0500, Chad wrote:
> > Would it be possible/sensible to automatically close a bug when the
> > patch is merged? Or did I miss something?
> >
>
> In theory, yes. Someone already started writing a plugin to do the same thing
> for Jira[0]. Might be a good starting place f
On Thu, 08 Nov 2012 09:54:43 -0800, Stephan Gambke
wrote:
Hi,
is there a recommended work flow for bugfixing?
Right now what I do is submit a patch to gerrit and, if I remember, set
some tag in bugzilla. At some point somebody approves and merges the
patch. Then, if I remember, I set the bu
On Thu, Nov 8, 2012 at 12:54 PM, Stephan Gambke wrote:
> Hi,
>
> is there a recommended work flow for bugfixing?
>
> Right now what I do is submit a patch to gerrit and, if I remember, set
> some tag in bugzilla. At some point somebody approves and merges the
> patch. Then, if I remember, I set th
Hi,
is there a recommended work flow for bugfixing?
Right now what I do is submit a patch to gerrit and, if I remember, set
some tag in bugzilla. At some point somebody approves and merges the
patch. Then, if I remember, I set the bug to resolved/fixed in bugzilla.
There is a bit too much rememb
16 matches
Mail list logo
