Re: [Wikitech-l] gerrit tab width

2012-08-12 Thread Antoine Musso
Le 09/08/12 13:24, Platonides a écrit : For a review tool, we want to spot spaces instead of tabs, so we should use an uncommon tab size. I vote for 7 spaces. Just replace whitespaces by meaningful characters, should be easy to implements in any code review tool. -- Antoine hashar Musso

Re: [Wikitech-l] gerrit tab width

2012-08-12 Thread Tim Starling
On 13/08/12 06:24, Antoine Musso wrote: Le 09/08/12 13:24, Platonides a écrit : For a review tool, we want to spot spaces instead of tabs, so we should use an uncommon tab size. I vote for 7 spaces. Just replace whitespaces by meaningful characters, should be easy to implements in any code

Re: [Wikitech-l] gerrit tab width

2012-08-09 Thread Dmitriy Sintsov
8 Август 2012 г. 22:43:15 пользователь bawolff (bawolff...@gmail.com) написал: I use 8 :P (Seriously though, everything looks so crunched up with 4 space tab width... Makes me claustrophobic!) Tab 8 encourages to make less structural nesting like foreach( if ( foreach ( if () ) ) ) in one

[Wikitech-l] gerrit tab width

2012-08-09 Thread Platonides
For a review tool, we want to spot spaces instead of tabs, so we should use an uncommon tab size. I vote for 7 spaces. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] gerrit tab width

2012-08-09 Thread Krinkle
Regarding how to calculate the line-width (for the 80-100 convention), the way my old editor used to do it made the most sense to me: Consider a tab 1 character (because it is). That also gives the most flexibility in indenting/outdenting blocks without having to worry frequently about it being

Re: [Wikitech-l] gerrit tab width

2012-08-09 Thread Trevor Parscal
Sadly the length of lines is a poor measure of the nested-ness of a program, and sufficiently complex algorithms aren't always better broken into multiple parts, such as in cases where the loops are very tight and the function call overhead would be costly. - Trevor On Wed, Aug 8, 2012 at 11:09

Re: [Wikitech-l] gerrit tab width

2012-08-09 Thread Chad
On Wed, Aug 8, 2012 at 11:09 PM, Dmitriy Sintsov ques...@rambler.ru wrote: Tab 8 encourages to make less structural nesting like foreach( if ( foreach ( if () ) ) ) in one method, because such lines would become too long. Instead there will be large amount of smaller functions / methods. But

[Wikitech-l] gerrit tab width

2012-08-08 Thread Adam Wight
It should be 4 spaces... I found where the default is set, here's a quick untested patch with no configurability. You can also change your personal preferences under Differences - Preferences diff --git

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Chad
On Wed, Aug 8, 2012 at 10:29 AM, Adam Wight awi...@wikimedia.org wrote: It should be 4 spaces... I found where the default is set, here's a quick untested patch with no configurability. You can also change your personal preferences under Differences - Preferences diff --git

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Derric Atzrott
Also, it should be 4 spaces is a matter of opinion--everyone likes different tab widths depending on their preferences and monitor size. To prove his point, I'm personally partial to 2 spaces and have all of my editors set up accordingly. Thank you, Derric Atzrott Computer Specialist

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Mark Holmquist
Also, it should be 4 spaces is a matter of opinion--everyone likes different tab widths depending on their preferences and monitor size. http://www.mediawiki.org/wiki/CC#Tab_size you should make no assumptions appears to support Chad's statement. However, I'm pretty sure that in reality, many

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Adam Wight
On 08/08/2012 11:07 AM, Mark Holmquist wrote: Also, it should be 4 spaces is a matter of opinion--everyone likes different tab widths depending on their preferences and monitor size. http://www.mediawiki.org/wiki/CC#Tab_size you should make no assumptions appears to support Chad's statement.

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Trevor Parscal
I've always wondered about something: Given the 2 rules: - Lines should be broken at between 80 and 100 columns.[1] - You should make no assumptions about the number of spaces per tab.[2] I have a couple of questions: - What should we do if someone who uses 1 space tabs writes a 99

[Wikitech-l] gerrit tab width

2012-08-08 Thread bawolff
On 08/08/2012 11:07 AM, Mark Holmquist wrote: Also, it should be 4 spaces is a matter of opinion--everyone likes different tab widths depending on their preferences and monitor size. http://www.mediawiki.org/wiki/CC#Tab_size you should make no assumptions appears to support Chad's

Re: [Wikitech-l] gerrit tab width

2012-08-08 Thread Nabil Maynard
Lines have a 20 column range for breaking. If you are particularly worried about tab variation, split the difference -- if you personally aim for a cut-off of 90 columns, you'll still fall in the 80-100 column range for most tab variations (until you get into multiple tabs, but at that point two