Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-09 Thread Vivek Ghaisas
Another solution is to use a JS parser, such as Acorn [1] to parse the JS. It can be used as a command line tool (passing the --silent) option to it, which makes it only return the exit code which we can use to check whether the syntax was valid or not. The bigger question, probably, is that

Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-08 Thread Legoktm
Hi, On 09/07/2015 01:20 PM, Antoine Musso wrote: > Jenkins jobs start failing on some repositories release branches because > they are lacking the CI [entry points]. For example if the 'npm' job > has been enabled, the master branch has a 'package.json' but the release > branches do not. That

Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-08 Thread Ricordisamoa
Il 08/09/2015 10:26, Legoktm ha scritto: Hi, On 09/07/2015 01:20 PM, Antoine Musso wrote: Jenkins jobs start failing on some repositories release branches because they are lacking the CI [entry points]. For example if the 'npm' job has been enabled, the master branch has a 'package.json' but

Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-08 Thread Antoine Musso
Le 08/09/2015 10:26, Legoktm a écrit : >> > The commands being run would need be tweaked but at the very minimal >> > each branches should check: >> > >> > * the i18n files using grunt-banana-checker (in package.json) >> > * php lint (jakub-onderka/php-parallel-lint) (in composer.json) > phplint

Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-08 Thread Antoine Musso
Le 08/09/2015 10:26, Legoktm a écrit : > Another idea I've been thinking about is making the "npm" and > "composer-test" jobs pass if no package.json/composer.json is present. > In addition to fixing the release branch issue, it also would allow us > to make CI/zuul more self-service. We could

Re: [Wikitech-l] npm/composer entry points in release branches

2015-09-08 Thread Vivek Ghaisas
I Googled for npm packages that check JS syntax and came across a package called syntax-checker [1] which checks several languages. I looked at the source and found the lines where it checks the syntax of each language [2]. For languages other than JS, it just uses the interpreter/compiler with a

[Wikitech-l] npm/composer entry points in release branches

2015-09-07 Thread Antoine Musso
Hello, Jenkins jobs start failing on some repositories release branches because they are lacking the CI [entry points]. For example if the 'npm' job has been enabled, the master branch has a 'package.json' but the release branches do not. That causes CI to reject backports. I would like us to