have any questions about these changes, please
let me know and I’ll do my best to help you.
Thanks,
Trevor Parscal
--
- Trevor
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
+1 Toby
I'd also like to express my continued support for this work. I believe in
ground-up projects, so I've always given staff space to work on them.
However, especially as the CoC becomes more mature and complete, If there's
anything more I can do to help, please let me know.
- Trevor
On
As we approach another quarterly planning cycle, I'd like to bring my
proposal for how we can improve our quarterly planning and review process.
https://www.mediawiki.org/wiki/Wikimedia_Engineering/Goals_Proposal
Do people support implementing these changes for the Q4 planning cycle? If
you have
VisualEditor is very extendable by design. You can do pretty much anything
you want with a plugin, and we've demonstrated this with many existing
plugins that provide all sorts of interesting features.
The APIs for adding features to VisualEditor, while perhaps not as well
documented as we'd like
ResourceLoader is happy to ring files to the client from anywhere below the
base path you set when creating a file module. If that base path js the
root of the extension then you can just put the shared js code in a folder
accessible by both node.js and ResoriceLoader, maybe a /lib folder or
I think right now we are scratching the surface. We have some big ideas
about everything from basic adjustments to full on derivative tracking
and non-detailed destructive image editing.
While we are prototyping and proving the concept, it's all really going to
come down to what features we can
The flat approach to NPM is a game changer for us, and a Bower killer.
Timo? Had a lot of insight at the time, I'd like to see him be invoked in
this decision. Any thoughts Timo?
- Trevor
On Thursday, November 5, 2015, Jon Robson wrote:
> It's been a year now, over 3-6
+1
On Thursday, October 8, 2015, Tim Starling wrote:
> In a recent meeting of the MediaWiki Architecture Committee, it was
> agreed that Timo Tijhof (Krinkle) would be invited to join the
> committee. Timo accepted this invitation.
>
> Timo is a talented software
Hi (and sorry for cross-posting)
I’d first like to say that I’m excited about Danny’s new role and the
positive impact I know he will have on the relatively new Community Tech
team, and that he will be missed in the Editing group. This change now
leaves an open position, which we are in the
Interesting. What is the cause of the slower speed?
- Trevor
On Tuesday, August 11, 2015, Gabriel Wicke gwi...@wikimedia.org wrote:
On Tue, Aug 11, 2015 at 5:16 PM, Trevor Parscal tpars...@wikimedia.org
javascript:;
wrote:
Is it possible use part of the Parsoid code to do
Is it possible use part of the Parsoid code to do this?
- Trevor
On Tuesday, August 11, 2015, Tim Starling tstarl...@wikimedia.org wrote:
I'm elevating this task of mine to RFC status:
https://phabricator.wikimedia.org/T89331
Running the output of the MediaWiki parser through HTML Tidy
Seeing ResourceLoader calls on CSI makes that whole project finally worth
it.
- Trevor
On Sun, May 24, 2015 at 10:06 PM, Steven Walling steven.wall...@gmail.com
wrote:
There's a pretty hilarious American police procedural TV show in 2015
called CSI: Cyber, featuring mostly cybercrime.
anticipating this landing on
the editing side.
- Trevor
On Wednesday, May 13, 2015, Brian Wolff bawo...@gmail.com wrote:
On 5/13/15, Trevor Parscal tpars...@wikimedia.org javascript:; wrote:
The team has some hires, and there will be some needed focus on hiring at
least some of them as backend
The team has some hires, and there will be some needed focus on hiring at
least some of them as backend/MediaWiki core engineers. This is mostly
because we acknowledge the sizable backlog of tasks in that area as well as
the need to make improvements in that area to support future work.
I'll
There is a Multimedia team under Editing, and it includes Mark Holmquist of
the former Multimedia team as to lead engineer. The teams roadmap is in the
works, but 3D is something that's been coming up a lot lately, so the team
should be able to at least make some plans around figuring it out
Hey all,
OOjs UI 0.10.0 was released on Wednesday. It will be in MW from 1.26wmf4+.
As there are several breaking changes, please look carefully over them to
determine if they affect your code.
Breaking changes since last release:
- [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow
Pine,
I'm glad to hear VE had your back. This actually reminds me, there's a
feature we never really advertised in VisualEditor where a CSV file can be
dragged into the editor and a table is created from its contents.
Give it a try. And thank Ed Sanders for all things tables and Copy/Paste.
-
OOjs UI 0.9.0 was released on Wednesday. It will be in MW from 1.25wmf21+.
As there are several breaking changes, please look carefully over them to
determine if they affect your code.
*Breaking changes since last release:*
- [BREAKING CHANGE] Remove innerOverlay (Ed Sanders)
We've tagged
OOjs UI 0.8.0 has been released today. It will be in MW from 1.25wmf19+.
*Breaking changes since last release:*
- [BREAKING CHANGE] Make default distribution provide SVG with PNG
fallback (Bartosz Dziewoński)
We've tagged this as a breaking change, but the only breakage is renaming
the
On Fri, Feb 13, 2015 at 12:59 AM, Ricordisamoa ricordisa...@openmailbox.org
wrote:
the overflow of the lookup menu is now clipped by the dialog :-/
Could you please add a bug to phabricator with reproduction steps?
Thanks,
Trevor
___
Wikitech-l
We really need to just evolve Vector. It's not a sacred cow, and it's sort
of sad how little it's been changed since I made in back in 2009. How it
looks, how it works and how it responds to different devices can all be
changed incrementally, and we can do this without continued or additional
last release:*
- [BREAKING CHANGE] Remove window isolation (Trevor Parscal)
Window isolation is a feature we introduced to solve certain problems in
VisualEditor a while back. It essentially places the content of a window
inside an iframe. We've since made improvements to VisualEditor
Today I had the *fun* job of presenting and answering questions for 2 hours
and 15 minutes straight. I didn't actually realize this would turn out to
be the marathon that it did, but I feel like it turned out better than
expected. I was especially impressed with the positive attitude that
everyone
It's really exciting to see people let go of unnecessary authority,
dismantle bureaucracy and resist building empires. I applaud the restraint
the committee is using here. I think it speaks volumes about who they are
as leaders.
As Brion suggests, it's important to retain the idea of getting some
I challenge the very foundation of arguments based on this 95% statistic.
The 95% statistic is bogus, not because it's inaccurate, but because it's
misleading.
The number of MediaWiki instances out there is meaningless. The value we
get from 3rd party use correlates much more strongly with the
95% is pretty extreme.
I have always questioned the balance being struck here, and would welcome
an adjustment of the minimum requirements to run MediaWiki. In many cases,
if we can just require shell access we can automate away the complexity for
the typical use cases.
- Trevor
On Thu, Jan 15,
In my opinion, we've been at odds with social media because...
1. social media contributions are rarely the kinds of contributions we
desire and;
2. social media websites often operate in ways that conflict with our
values and;
3. social media behaviors are not often seen has
+1
Roan doesn't architect software, software architects Roan.
- Trevor
On Wed, Oct 22, 2014 at 2:56 PM, Ori Livneh o...@wikimedia.org wrote:
On Wed, Oct 22, 2014 at 1:17 PM, Brion Vibber bvib...@wikimedia.org
wrote:
Hey all --
Announcement time!
The MediaWiki Architecture
Jon, this is really awesome. I'm excited to be sharing more code.
I'll be taking a look at these patches with Roan today.
- Trevor
On Fri, Sep 12, 2014 at 11:43 AM, Tomasz Finc tf...@wikimedia.org wrote:
On Fri, Sep 12, 2014 at 11:32 AM, Jon Robson jrob...@wikimedia.org
wrote:
After this
is a PHP
implementation of Mustache. This doesn't seem to be the case though.
We need a templating solution that works both on the server and the
client.
On Tue, Aug 26, 2014 at 5:21 PM, Trevor Parscal tpars...@wikimedia.org
wrote:
Thanks for summarizing the meeting Jon.
So, let's get Twig
Thanks for summarizing the meeting Jon.
So, let's get Twig/Swig into core then, eh? :)
- Trevor
On Tue, Aug 26, 2014 at 3:53 PM, Jon Robson jrob...@wikimedia.org wrote:
Shahyar, Juliusz, Trevor, Kaldari, Roan and I sat down yesterday and
talked about the future of skins. Hopefully this mail
On Fri, Aug 22, 2014 at 12:14 PM, S Page sp...@wikimedia.org wrote:
On Fri, Aug 22, 2014 at 11:34 AM, Jon Robson jdlrob...@gmail.com wrote:
Trevor is working on a template widget for oojs which will
make this possible
Great, though I don't understand what this is. Is this a specific
I want to suggest that we give Brandon a lot of slack here, and be as
supportive as possible.
This is a prototype of a design, which is far better than a mockup of a
design. It is not an actual implementation, but that is totally fine. I
want to see more of this kind of thing, and by being more
Seems reasonable for us to consider adding a way to specify packed in RL
to skip additional processing of that module.
- Trevor
On Sun, Jul 13, 2014 at 6:35 PM, Krinkle krinklem...@gmail.com wrote:
On 13 Jul 2014, at 19:40, Max Semenik maxsem.w...@gmail.com wrote:
You can bypass
Jon, I know you mean well, and that you are passionate about solving this
problem, but I do not believe this is the right approach. I've communicated
that in another thread with a smaller group, and you did not respond to me.
Now you are changing key details in the proposal, but the extension code
Indeed, this thread is a bit silly.
If someone wants to make an extension that provides a feature, and someone
else wants to use it, there's nothing wrong with that. But why would such a
thing need proposing?
If the point of Mantle is only to provide a way to bring templates to the
client, then
/HTML_templating_library/Knockoff_-_Tassembly/Mobile_spike
Ryan Kaldari
On Thu, Jul 3, 2014 at 12:05 PM, Trevor Parscal tpars...@wikimedia.org
wrote:
Indeed, this thread is a bit silly.
If someone wants to make an extension that provides a feature, and
someone
else
I'm happy to see us talking about leaving these old browsers behind, but it
seems a few existing policies and situations may have been overlooked in
this thread thus far.
Hopefully this list of things to consider will be helpful:
1. We are planning on moving away from jQuery UI this year as
Also, please note that includes/lib is meant to be a place for external
libraries. Some of the libraries are ones we have ported or written
ourselves, but we should continue using this space as external libraries
increase in number and change in nature.
- Trevor
On Tue, May 27, 2014 at 9:12 AM,
We are very open to breaking it out into submodules. We should be able to
do this very quickly. In many cases, users of OOUI are only in need of a
few base classes, and we've recently done much more to divide up the style
code to make it possible to load things a la carte. I believe this is
I normally don't chime in on these threads, but I feel compelled.
Rob made a significant contribution to VisualEditor and this change is a
well deserved nod to his growth as an engineer as well as a step in the
right direction to spread knowledge around the organization.
Congrats on the new
We are introducing recommended fields which will be automatically added
when the template is added. We already support required fields which are
automatically added, but we are adding recommended fields so that required
can be reserved for actually required fields. In time, we expect required
will
wrote:
Hoi,
Is there a way to link such templates easily to Wikidata?
Thanks,
GerardM
Op 22 apr. 2014 17:51 schreef Trevor Parscal tpars...@wikimedia.org:
We are introducing recommended fields which will be automatically added
when the template is added. We already support
Our goal should be to relinquish control of image sizing to the view, not
build in more or different ways to specify it in the model.
Images should be given semantic classifications, and the skin should decide
how to best display the image. Maybe it will be inline with the content,
maybe it will
Have you read
http://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoaderyet?
- Trevor
On Sun, Mar 16, 2014 at 6:04 AM, Justin Folvarcik jfolvar...@gmail.comwrote:
I have a couple questions about the formSpecialPage class and how it works.
For starters, I cannot seem to make
Sorry if that was like RTFM. If you have more specific ResourceLoader
questions, please feel free to ask.
- Trevor
On Sun, Mar 16, 2014 at 7:22 AM, Trevor Parscal tpars...@wikimedia.orgwrote:
Have you read
http://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoaderyet
, Trevor Parscal wrote:
By making all skins extensions it would also force us to make a few
new
APIs which are needed to no longer have skin extensions be
second-class
citizens.
This should happen.
- Trevor
Quite so. Think hitting on some of this could
I'm going to start working on some RL modifications to make it possible for
skins outside of core to add skinStyles to other modules, which will help
with making non-core skins equally capable.
- Trevor
On Wed, Mar 12, 2014 at 12:00 PM, Jon Robson jdlrob...@gmail.com wrote:
Yes this is an
It might be easier to revamp the skin system if there were fewer skins to
port.
- Trevor
On Mon, Mar 10, 2014 at 6:48 PM, MZMcBride z...@mzmcbride.com wrote:
Tomasz Finc wrote:
On Mon, Mar 10, 2014 at 2:10 PM, Jon Robson jdlrob...@gmail.com wrote:
Why is Cologne Blue still in core?
A
I support moving it to an extension and enabling it on deployed sites as to
avoid an disruption in service for the users of the skin.
- Trevor
On Tue, Mar 11, 2014 at 12:21 PM, Jon Robson jdlrob...@gmail.com wrote:
It might be easier to revamp the skin system if there were fewer skins to
I don't think anyone is suggesting removing or even moving Monobook. I
think we are more talking about assigning effort more proportionally to
preference of users. Cologne Blue is not the clear favorite of any group of
users that we know of.
- Trevor
On Tue, Mar 11, 2014 at 12:36 PM, Risker
By making all skins extensions it would also force us to make a few new
APIs which are needed to no longer have skin extensions be second-class
citizens.
This should happen.
- Trevor
On Tue, Mar 11, 2014 at 2:38 PM, Isarra Yos zhoris...@gmail.com wrote:
On 11/03/14 21:21, Jon Robson wrote:
I just wanted to add that in the past, as many people know, we tried a few
different kinds of testing and even hired a usability testing firm to help
us. We conducted research in a lab here in SF and also did some remote
testing, compensating participants with gift cards.
We learned that lab
So, it sounds like we will either maybe drop 5.3 after April, or my newborn
son will be riding a bicycle before we can use Traits in PHP.
Hoping for the former, willing to accept the latter.
- Trevor
On Fri, Feb 21, 2014 at 9:19 AM, AlisonW t...@alisonwheeler.com wrote:
and on my one
Is that the rule then, we have to make MediaWiki work on anything Ubuntu
still supports?
Is there a rule?
- Trevor
On Thu, Feb 20, 2014 at 12:25 AM, Markus Krötzsch
mar...@semantic-mediawiki.org wrote:
On 20/02/14 05:17, Jamie Thingelstad wrote:
Regarding PHP 5.3 support, I put together a
PHP 5.4 added a few important features[1], namely traits, shorthand array
syntax, and function array dereferencing. I've heard that 5.3 is nearing
end of life.
I propose we drop support for PHP 5.3 soon, if possible.
- Trevor
[1] http://php.net/manual/en/migration54.new-features.php
Steffen,
ResourceLoader guarantees the order of module execution if there are
dependencies, such that child always comes after parent, which always comes
after grandparent in a dependency chain. Due to the concatenation of
modules in the order requested, it's unlikely that modules will be
VisualEditor is MIT licensed. It was originally GPLv2 by default as per my
contract with Wikimedia, but early on we got written permission from all
authors to change it. We did this because we wanted to ensure maximum
license compatibility for re-use in non-MediaWiki systems.
- Trevor
On Mon,
Don't forget using git (or git compatible system) as a revision backend.
Extensions being developed on-wiki, gadgets defining their own API
extensions, JavaScript templates generating HTML DOM trees, human
sacrifice, dogs and cats living together... mass hysteria!
- Trevor
On Fri, Jul 26, 2013
On Fri, Jul 26, 2013 at 3:43 PM, Yuvi Panda yuvipa...@gmail.com wrote:
On Sat, Jul 27, 2013 at 4:11 AM, Trevor Parscal tpars...@wikimedia.org
wrote:
Don't forget using git (or git compatible system) as a revision backend.
That is darcs!
Somehow I missed that.
Reading the page, thinking
I have avoided getting involved so I could stay focused on fixing bugs and
making improvements to VisualEditor.
This thread has served it's purpose; to surface various arguments about
whether the preference to disable VisualEditor should be hidden or not. The
conclusion has been reached. The
I've already commented on the bug and in Gerrit, but I will also echo here.
First off, thank you for taking the time to work on VisualEditor, and even
submitting a patch directly into Gerrit. We hope to get more patches this
way.
In this particular case, the solution being offered isn't going to
On Wed, Dec 12, 2012 at 11:32 AM, Daniel Barrett d...@vistaprint.comwrote:
Will the method for hooking into VE be the same as for WikiEditor? Or
will extension
developers need to support both editors in two different ways?
In general they are both conceptually and technically incompatible.
Whether it be a targeted list of browsers, a list of browsers we explicitly
ignore, or something else entirely, anything that helps us balance
engineering resources is a good thing.
In 2010 I suggested a rule, which became somewhat of a policy, that WMF
won't spend time/money supporting browsers
I've supported this change for a very long time, glad to see it's on the
table.
+1
- Trevor
On Fri, Nov 2, 2012 at 11:23 PM, Ori Livneh o...@wikimedia.org wrote:
Hi,
Change 31065 drops the possessive prefix from toolbar labels, per the
outcome of the discussion on bug 41672. Unless there
I'm glad this area is getting a lot of interest - unfortunately I haven't
been able to keep up on this thread but I wanted to give a suggestion
related to adding icons.
It's reasonable to take an option that provides a URL to an icon image, but
we should have a common (customizable per skin and
as sprites.
--
Munaf Assaf
On Wednesday, September 19, 2012 at 11:41 AM, Trevor Parscal wrote:
I'm glad this area is getting a lot of interest - unfortunately I haven't
been able to keep up on this thread but I wanted to give a suggestion
related to adding icons.
It's reasonable
On Wed, Sep 19, 2012 at 11:54 AM, Munaf Assaf mas...@wikimedia.org wrote:
I wasn't clear; that's exactly what we're doing in the Agora CSS library.
You are adding an icon feature to me.notify in the Agora CSS library?
I know the answer is no, we are creating icons that can be used for that
In VisualEditor we ended up putting all CSS rules that include images in
*.icons-raster.css and *.icons-vector.css files, which are loaded
dynamically based on the window.devicePixelRatio property.
It has it's flaws, but the good thing is that it spares the device from
loading both versions. I
It's important to separate supporting retina display mobile and desktop
devices. Apple's web site uses the load both method to show off the retina
display MacBook - which is more likely to have a faster internet connection
and is a more powerful machine in general.
- Trevor
On Tue, Sep 18, 2012
On Thu, Aug 30, 2012 at 3:24 AM, Daniel Werner
daniel.wer...@wikimedia.dewrote:
By the way, you can also use
$( 'div/', { 'class': 'foo', 'title': 'myTitle', ... } );
Just be aware this also allows you to use things like 'html' and 'text'
which are not attributes at all, but call .html() or
On Tue, Aug 28, 2012 at 12:57 AM, Tim Starling tstarl...@wikimedia.orgwrote:
Personally, I would use document.getElementById() to do that. It's
standard, and it's faster and more secure.
I think your premature optimization disorder (POD) is flaring up again.
jQuery performance is something
On Tue, Aug 28, 2012 at 10:06 AM, Jon Robson jdlrob...@gmail.com wrote:
I knew there was a good reason I use $( 'div/' )
One of those things I learn then forget why I'm doing it. I've apparently
not being following styling guidelines ;-)
Actually you were following the guidelines, but they
Rob is correct that using addClass is the preferable way to go for classes,
and attr is the preferable way to go for other attributes. They are both
are safe since they use setAttribute internally which escapes the values.
- Trevor
On Tue, Aug 28, 2012 at 10:29 AM, Rob Lanphier
jQuery internally maps 'tagName' to document.createElement( 'tagName' ).
This is a feature, and is used throughout jQuery internally. It's not very
well documented as such, but Timo is adding it to the documentation as to
resolve the confusion around this. $( 'div' ) is a shortcut added to
jQuery
On Tue, Aug 28, 2012 at 11:00 AM, Ryan Kaldari rkald...@wikimedia.orgwrote:
In that case, perhaps we should just say that all of the options are fine:
$( 'div' )
$( 'div/' )
$( 'div/div' )
but emphasize not to use attributes in the tag creation.
Unless you are creating an input or a
On Tue, Aug 28, 2012 at 11:15 AM, Daniel Friesen dan...@nadir-seen-fire.com
wrote:
That's an unintentional side effect. jQuery does not officially support $(
'div' ) without a closing /div or /.
And yet they use it themselves internally? As I mentioned, Timo is a jQuery
maintainer and said
+1
Thank you for grounding this conversation in reality.
- Trevor
On Tue, Aug 28, 2012 at 12:18 PM, Krinkle krinklem...@gmail.com wrote:
Okay, sorry for being away for 30 minutes while I enjoyed dinner.
Someone[1] pointed me to this thread and suggested I chime in, so here I
go.
On Aug
$( 'div' ) is the way to go.
- Trevor
On Mon, Aug 27, 2012 at 4:37 PM, Mark Holmquist mtrac...@member.fsf.orgwrote:
Hence, I think we should change our coding conventions to always use `$(
'div /' )`.
+1 for valid XHTML. Considering that bytes are cheap and validity is good,
this seems
The idea that we are trying to attract new users at the detriment of the
existing ones is putting words in our mouths, but I do know what you mean.
The good news is that many of us are very conscious about these issues.
Here are some excerpts, for instance from the VisualEditor software design
VisualEditor doesn't use a 3rd party framework, mostly because I don't
really believe in them - that's another topic though. Here are some
thoughts on this topic:
- I suggest you create some classes (JavaScript prototypes) in a
namespace, such as a global 'WikiData' object (which can be
That was unfortunate - I've been ridiculed (by Max) for things I've said
before as well, I feel your pain Ori.
That said however, I generally agree with this piece. I have more faith
than the author seems to have that we are on the right track to doing
better work in the future, but the points
Well said. Thank you for sharing.
- Trevor
On Tue, Aug 21, 2012 at 12:18 PM, Ori Livneh o...@wikimedia.org wrote:
On Tuesday, August 21, 2012 at 12:04 PM, Trevor Parscal wrote:
One of the most important points here is about experimenting on users;
and
it should be taken seriously. I
On Tue, Aug 21, 2012 at 1:20 PM, S Page sp...@wikimedia.org wrote:
(There is My preferences Appearance check Exclude me from feature
experiments; though it's probable some artifacts will leak out, as
happened for a few weeks in the bug he references.)
As the person who implemented that
Trevor Parscal changed our jsMessage setup to be a
floating auto-hiding notification bubble.
https://gerrit.wikimedia.org/**r/#/c/17605/https://gerrit.wikimedia.org/r/#/c/17605/
The end implementation felt half-baked to me. Since it just swapped text
for notification replacement. And didn't support
Sadly the length of lines is a poor measure of the nested-ness of a
program, and sufficiently complex algorithms aren't always better broken
into multiple parts, such as in cases where the loops are very tight and
the function call overhead would be costly.
- Trevor
On Wed, Aug 8, 2012 at 11:09
I've always wondered about something:
Given the 2 rules:
- Lines should be broken at between 80 and 100 columns.[1]
- You should make no assumptions about the number of spaces per tab.[2]
I have a couple of questions:
- What should we do if someone who uses 1 space tabs writes a 99
I think a better answer to your question is: nothing that's been
officially resourced at this time.
We currently have a 2-device strategy, which means we redirect some devices
to a mobile site, and the rest remain at the normal desktop site. The
closest thing to responsive design we have in
The namespace separator might be ugly, but it's in good company with the
rest of the syntax of PHP.
- Trevor
On Wed, May 16, 2012 at 4:48 PM, Terry Chay tc...@wikimedia.org wrote:
On May 16, 2012, at 3:52 PM, Max Semenik wrote:
Frankly, the namespace syntax in PHP is so atrocitous that I
I think you could use a multi-step process to solve this problem with the
help of the community.
1. Detect when inline styles are used on a page and add that page to a
list of pages that might have problems being rendered on mobile.
1. Make a special page that displays this list and
+1 to all the points for using return values.
If we have to implement an output buffer in Lua, we have probably
failed. Output buffering is is messy and prone to error. It's certainly not
a good design from a usability standpoint, and it's generally messy to deal
with.
Template invocations
No offense to those who have chimed in, but seriously, this is a silly
discussion.
Do we really have the bandwidth to be 15 messages deep on this thread?
- Trevor
On Thu, Mar 29, 2012 at 5:24 PM, Tim Starling tstarl...@wikimedia.orgwrote:
On 29/03/12 00:10, Chad wrote:
Hi everyone,
Good advice here, but I would just say we should mention that git --amend
is still recommended if you committed something and then realized there was
a mistake.
- Using it to fix a typo or minor error in a commit = awesome.
- Using it to pile up tons of changes across tons of files = not
Adding the borders to top/bottom is not a good thing though, because long
changes result in ugly rendering with lots of parallel lines. I will look
into the padding issue.
- Trevor
On Sat, Mar 3, 2012 at 1:33 AM, Erwin Dokter er...@darcoury.nl wrote:
On 03-03-2012 09:35, Erwin Dokter wrote:
, Mar 3, 2012 at 8:15 PM, Steven Walling steven.wall...@gmail.comwrote:
On Thursday, March 1, 2012, Trevor Parscal tpars...@wikimedia.org wrote:
I've gone ahead and resolved bug #11374 after committing r112836.
Screenshot of new diff styles:
https://bugzilla.wikimedia.org/attachment.cgi?id
Erwin,
I'm happy to continue working with you on this if you have more ideas.
Please don't just give up because the process isn't perfect. It's our
responsibility together as a community to continue improving it. I'm sorry
if you haven't had a great experience so far with this. I am personally
it as white.
See r113098
- Trevor
On Mon, Mar 5, 2012 at 2:31 PM, Erwin Dokter er...@darcoury.nl wrote:
On 05-03-2012 20:51, Trevor Parscal wrote:
Erwin,
I'm happy to continue working with you on this if you have more ideas.
Please don't just give up because the process isn't perfect. It's our
that changeset looked on my localhost.
- Trevor
On Fri, Mar 2, 2012 at 2:59 PM, Erwin Dokter er...@darcoury.nl wrote:
On 02-03-2012 23:31, Antoine Musso wrote:
Le 01/03/12 22:38, Trevor Parscal a écrit :
I've gone ahead and resolved bug #11374 after committing r112836.
Screenshot of new
Timo and I are going to come up with a patch that can solve the same
problems that these reverted changes were trying to solve, and do so
without regressing the accessibility of the site. I noted that the changes
broke at least two rules:
1. Don't rely on color along
2. Contrast ratio between
Trevor Parscal:
2. Contrast ratio between background and foreground colors on the
changed
text portion of a diff is not high enough
see https://en.wikipedia.org/wiki/Web_colors#X11_color_names
dark background colours == bold white (text) colour
Aie! :(
--
Best regards,
Max
1 - 100 of 275 matches
Mail list logo