Re: [AppDB] Fix Bug links

2006-07-10 Thread Chris Morgan
On Saturday 08 July 2006 4:27 pm, Tony Lambregts wrote: This patch is meant to start a discussion more than anything else. We currently have no way of sorting test results in a reasonable order. If we sort by testedRating the order is not what we want. IE: Bronze, Garbage, Gold, Platinum and

http://source.winehq.org/git shows no history anymore

2006-07-10 Thread Paul Vriens
Hi, I was curious about some changes made in the past and tried to get the history. All I get is empty pages (expect for the headers). Any idea? Cheers, Paul.

[AppDB] Fix Bug links

2006-07-10 Thread Tony Lambregts
This patch is meant to start a discussion more than anything else. We currently have no way of sorting test results in a reasonable order. If we sort by testedRating the order is not what we want. IE: Bronze, Garbage, Gold, Platinum and Silver. It might be better in the long run to replace

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-10 Thread Ge van Geldorp
From: Alexandre Julliard [mailto:[EMAIL PROTECTED] We really shouldn't be including string.h here. Does this work for you? diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index fc330ce..dcba4ae 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -37,8 +37,6 @@

re: Possible bug in WINE or NDISWRAPPER

2006-07-10 Thread Dan Kegel
Jacob wrote: [I use both Wine and NDISWRAPPER. After a while, my network breaks. Is this a bug in Wine, or in NDISWRAPPER?] I don't know where the bug is, but it's not in Wine. Wine is a pure user-level app, it *can't* break the system's networking. It's either a bug in NDISWRAPPER or in the

Re: [AppDB] - speed loading of the main page by optimizing screenshot class

2006-07-10 Thread Tony Lambregts
Chris Morgan wrote: I think this is the cleanest this can be done until we get php5 on the server, then we'll be able to private the images in the screenshot class. This patch defers loading the thumbnail and screenshot images into memory until they are necessary. Doing so requires that we

Re: Issue with French Canadian Keyboard Under SLED 10

2006-07-10 Thread Jonathan Ernst
Le vendredi 07 juillet 2006 à 13:20 -0400, Michael Lessard a écrit : Hi everybody ! We still have an issue with wine 0.9.16 and french canadian keyboard accent, we use locale fr_FR.UTF-8 ... Why don't you use fr_CA if you have a french canadian keyboard? signature.asc Description: Ceci

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-10 Thread Alexandre Julliard
Ge van Geldorp [EMAIL PROTECTED] writes: I'm not sure why the typedef is duplicated so many times. Wouldn't it be better to define it only in stddef.h, #ifdef'ing it on __x86_64__ and then include stddef.h from the other files? Unfortunately that's not how MS does it. Another option might

Re: [AppDB] - clean up testResult::ShowTestResult() and testResult::ShowVersionsTestingTable()

2006-07-10 Thread Tony Lambregts
Chris Morgan wrote: Eliminate redundant parameters from these functions. Have version class check to see if the $iTestingId seems valid. Patch removes a query for each call to testResult::ShowTestResult() because we don't actually have to re-query the database for information already stored

Re: riched20: add stub ITextDocument

2006-07-10 Thread Alexandre Julliard
Juan Lang [EMAIL PROTECTED] writes: +#define DECL_IFACE(ifc) const I##ifc##Vtbl *lp##ifc##Vtbl; + +#define IFACE2IMPL(cls,ifc,iface) ((cls*)((BYTE*)(iface)-offsetof(cls,lp##ifc##Vtbl))) +#define IMPL2IFACE(ifc,x) ((I##ifc*)(x)-lp##ifc##Vtbl) Please avoid that sort of macros, it makes

git annoyances: how to force git to fetch a particular file

2006-07-10 Thread Dan Kegel
What's the right way to force a get of a particular file? With cvs, you can just remove the file and do 'cvs update foo.c', but I'm having trouble RTF git M, and the otherwise helpful http://wiki.winehq.org/GitWine doesn't seem to mention this case. (Every so often, it seems like git fetch

Re: riched20: add stub ITextDocument

2006-07-10 Thread Stefan Dösinger
Am Montag 10 Juli 2006 12:24 schrieb Alexandre Julliard: Juan Lang [EMAIL PROTECTED] writes: +#define DECL_IFACE(ifc) const I##ifc##Vtbl *lp##ifc##Vtbl; + +#define IFACE2IMPL(cls,ifc,iface) ((cls*)((BYTE*)(iface)-offsetof(cls,lp##ifc##Vtbl))) +#define IMPL2IFACE(ifc,x)

Re: riched20: add stub ITextDocument

2006-07-10 Thread Alexandre Julliard
Stefan Dösinger [EMAIL PROTECTED] writes: If I read the macros correctly they are for defining COM interfaces and casts from implementation pointer to interface pointer. DDraw has a couple of macros for that in dlls/ddraw/ddcomimpl.h, perhaps we should move this file to include/wine/? No,

Re: msi: Implement the InstallServices action

2006-07-10 Thread Robert Shearman
James Hawkins wrote: +static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) +{ ... +service = CreateServiceW(hscm, name, disp, SERVICE_START | GENERIC_ALL, + serv_type, start_type, err_control, file-TargetPath, +

Re: [WINED3D 1] Place immediate constants in the same array as global constants.

2006-07-10 Thread H. Verbeet
On 10/07/06, Ivan Gyurdiev [EMAIL PROTECTED] wrote: Also note that there's diffrent lifetime rules for immediate constants in d3d8 and d3d9, and as far as I know we implement one of them wrong. Here I stick with the current behavior, which I think is d3d9-compliant. Yes. In d3d8 constants set

Re: git annoyances: how to force git to fetch a particular file

2006-07-10 Thread Paweł Różański
Actually i use cg-restore from the cogito suite (can be mostly used parallel with git). It's a quite big shell script which call more than one git function) cg-diff with colors is nice too... or cg-log -s (shows log similar to web based shortlog git viewer) I hope this helps.. -- Paweł Różański

Re: [WINED3D 1] Place immediate constants in the same array as global constants.

2006-07-10 Thread Ivan Gyurdiev
H. Verbeet wrote: On 10/07/06, Ivan Gyurdiev [EMAIL PROTECTED] wrote: Also note that there's diffrent lifetime rules for immediate constants in d3d8 and d3d9, and as far as I know we implement one of them wrong. Here I stick with the current behavior, which I think is d3d9-compliant. Yes. In

Re: git annoyances: how to force git to fetch a particular file

2006-07-10 Thread Alexandre Julliard
Dan Kegel [EMAIL PROTECTED] writes: What's the right way to force a get of a particular file? With cvs, you can just remove the file and do 'cvs update foo.c', but I'm having trouble RTF git M, and the otherwise helpful http://wiki.winehq.org/GitWine doesn't seem to mention this case. git

Re: DDraw: Split up the ddraw refcount

2006-07-10 Thread Stefan Dösinger
Am Montag 10 Juli 2006 10:47 schrieb Stefan Dösinger: Here is a patch with the improvement suggestions from AJ. The changes to the older versions are: * Use the counter from InterlockedDecrement to check if the object has to be destroyed * Get rid of IDirectDrawImpl::DoNotDestroy * Minor

Re: Issue with French Canadian Keyboard Under SLED 10

2006-07-10 Thread Michael Lessard
we try with fr_CA and we have same issue :( Jonathan Ernst wrote: Le vendredi 07 juillet 2006 à 13:20 -0400, Michael Lessard a écrit : Hi everybody ! We still have an issue with wine 0.9.16 and french canadian keyboard accent, we use locale fr_FR.UTF-8 ... Why

GDI: SetDiBits uses hdc with DIB_RGB_COLORS (Notes Client problem)

2006-07-10 Thread Stefan Siebert
Hello, I've tracked a bug on the Notes Client. It is related to Lotus Notes workspace, which shows the database symbols and their icons. Up to Wine 0.909 the icons were colored correctly. From 0.910 on the icons are black (seems that just the BitBlt mask is shown only). I found the patch for

Re: [WINED3D 1] Place immediate constants in the same array as global constants.

2006-07-10 Thread H. Verbeet
On 10/07/06, Ivan Gyurdiev [EMAIL PROTECTED] wrote: H. Verbeet wrote: Yes. In d3d8 constants set with the def instructions persist between shaders. It is not so simple. 1) msdn does not make it clear whether that's visible on the app side If I had to guess I'd say it is, but it shouldn't be

Re: Fix potential NULL deref in IWineD3DSurfaceImpl_LockRect

2006-07-10 Thread Stefan Dösinger
Am Montag 10 Juli 2006 17:41 schrieb Chris: On Thursday 06 July 2006 22:19, you wrote: This patch fixes an issue in the aforementioned function, that would cause a NULL deref if swapchain and targetSwapChain are NULL and iface == myDevice-renderTarget. This fixes a crash for me when trying

Re: Fix potential NULL deref in IWineD3DSurfaceImpl_LockRect

2006-07-10 Thread Chris
On Monday 10 July 2006 09:43, you wrote: I can't find this patch anywhere via google and I don't have it in my mails here, so I can't comment on the patch directly, but from your description I'd say that the NULL deref was introduced by a patch of mine(the one which enabled single buffering).

lotus notes and wine

2006-07-10 Thread Dan Kegel
http://linux.slashdot.org/linux/06/07/10/121246.shtml says that IBM has Lotus Notes running in Java (on Eclipse!). Two readers commented that they've used the code, and it's uncomfortably bloated. I bet there's still a window of opportunity for Wine here. James Hawkins is fixing the wine bugs

Re: msi: Implement the InstallServices action

2006-07-10 Thread James Hawkins
On 7/10/06, Robert Shearman [EMAIL PROTECTED] wrote: James Hawkins wrote: +static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param) +{ ... +service = CreateServiceW(hscm, name, disp, SERVICE_START | GENERIC_ALL, + serv_type, start_type, err_control,

Pb WineD3D: power of 2 surface and non power of 2 DIB section

2006-07-10 Thread Christian Costa
Hi, When calling CreateSurface, a power of 2 surface is created and then the necessary memory is allocated. If we try to get the DC with GetDC, a DIB section is created with the original size of the surface and data from the surface is copied to the DIB section The power of 2 surface being

Re: widl/parser.y: Correct use of free()?

2006-07-10 Thread Kuba Ober
On Saturday 08 July 2006 12:28, Andrew Talbot wrote: Hi, I am trying to constify some of the name strings in this file. But I am running into problems caused by what seems to be an unusual use of the free() function. To my novice eye, it appears that, in functions such as get_type(), the

Re: widl/parser.y: Correct use of free()?

2006-07-10 Thread Andrew Talbot
Kuba Ober wrote: I didn't look at the code in question, so what follows is just an off-the-top-of-my-head suggestion. Could those strings be implicitly allocated by yacc? You may want to look at yacc documentation -- I assume that the .y file is processed by yacc to generate a .c source. You

riched20 - patch ping

2006-07-10 Thread Krzysztof Foltman
These could get in unchanged, perhaps? http://www.winehq.org/pipermail/wine-patches/2006-June/028096.html http://www.winehq.org/pipermail/wine-patches/2006-June/027940.html http://www.winehq.org/pipermail/wine-patches/2006-June/027978.html This is the one I want comments for before I split it

New Bugzilla Season begins

2006-07-10 Thread Vijay Kiran Kamuju
Hi all, I would say lets start, checking out all the old bugs. And close all the bugs which have been fixed by latest 0.9.17 The bug count is near to 1910 or more. Last time when we did this exercise was when 0.9 was to be released. Say lets start the season again. And close all the bugs that

Re: Speed up GetTextExtentExPointW (Take 3)

2006-07-10 Thread Dan Hipschman
On Mon, Jul 10, 2006 at 10:12:55PM +0100, Huw Davies wrote: There are GetTextExtentPoint entry points in both winex11.drv and wineps.drv. Both of these will need to be updated to GetTextExtentExPoint. Thanks for pointing that out. -for(idx = 0; idx count; idx++) { -

Re: Link or rename wcmd.exe to cmd.exe?

2006-07-10 Thread Neal Gompa
Forwarded because accidently did not add wine-devel to it. Also, noting that this is about Wine, not ReactOS. But both still apply.-- Forwarded message --From: Neal Gompa [EMAIL PROTECTED]Date: Jul 10, 2006 5:59 PMSubject: Re: Link or rename wcmd.exe to cmd.exe?To: Thomas Kho

winehq.org slowness?

2006-07-10 Thread Dan Kegel
winehq.org, particularly bugs.winehq.org, seems slow lately. What's up? Is the culprit something simple like bandwidth, ram, or cpu?

ntoskernl rpms for SuSE 10.1

2006-07-10 Thread Vitaliy Margolen
If anyone interested in giving a test run of new ntoskrnl implementation and don't want to compile Wine, here is the SuSE 10.1 rpms: http://www.kievinfo.com/wine-0.9.17-1.2.i586.rpm And source: http://www.kievinfo.com/wine-0.9.17-1.2.src.rpm Vitaliy