Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Tomas Carnecky
Peter Seebach wrote: > In message <[EMAIL PROTECTED]>, "Dmitry Timoshkov" writes: >> Usually xmodmap is used to redefine keys behaviour in X11, no need for 3rd >> party >> apps. > > If xmodmap could do this, I'd agree. > > Xmodmap can't map "F13" to "Control-F1", though, and many Windows apps ca

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Peter Seebach
In message <[EMAIL PROTECTED]>, "Dmitry Timoshkov" writes: >Usually xmodmap is used to redefine keys behaviour in X11, no need for 3rd >party >apps. If xmodmap could do this, I'd agree. Xmodmap can't map "F13" to "Control-F1", though, and many Windows apps can't hack F13. Xmodmap can only map k

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Dmitry Timoshkov
"Peter Seebach" <[EMAIL PROTECTED]> wrote: If this is not how Windows handles those keys then that's obviously a not acceptable solution for Wine. How windows handles them is "you run a second app that hooks keys". Can I run one app under Wine that intercepts and modifies key codes for anothe

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Peter Seebach
In message <[EMAIL PROTECTED]>, "Dmitry Timoshkov" writes: >> I have implemented and tested a patch which is almost certainly unsuitable >> for production, but which is very convenient to me; it is this patch I >> enclose. This patch replaces F13-F24 with "control-alt-F1" through >> "control-alt-F

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Dmitry Timoshkov
"Peter Seebach" <[EMAIL PROTECTED]> wrote: Hi! I'm new to Wine, but not a total newbie at C. I have a very specific interest: I would like Wine to support more keys. Background: Windows has support for no fewer than 24 function keys; in fact, possibly, as many as 32. However, right now, Wi

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Peter Seebach
Someone asked for a copy in unified diff format. So, here's the version that also translates F25-F32 into control-alt-shift (F1-F8). I don't know my way around the rest of the tree to encode this cleanly as an option for winecfg. --- wine-0.9.29/dlls/winex11.drv/keyboard.c 2007-01-09 09:42

Re: Howdy! Newbie with keyboard patches.

2007-01-22 Thread Peter Seebach
In message <[EMAIL PROTECTED]>, Peter Seebach writes: >I have implemented and tested a patch which is almost certainly unsuitable >for production, but which is very convenient to me; it is this patch I >enclose. This patch replaces F13-F24 with "control-alt-F1" through >"control-alt-F12", and F25-

Howdy! Newbie with keyboard patches.

2007-01-22 Thread Peter Seebach
Hi! I'm new to Wine, but not a total newbie at C. I have a very specific interest: I would like Wine to support more keys. Background: Windows has support for no fewer than 24 function keys; in fact, possibly, as many as 32. However, right now, Wine only supports 16 of them. It is insanely t

Re: kernel32: Don't require full access to the newly created process and thread.

2007-01-22 Thread Vitaliy Margolen
Robert Shearman wrote: > Vitaliy Margolen wrote: >> -req->process_access = PROCESS_ALL_ACCESS; >> +req->process_access = MAXIMUM_ALLOWED | PROCESS_ALL_ACCESS; >> req->process_attr = (psa && (psa->nLength >= sizeof(*psa)) >> && psa->bInheritHandle) ? OBJ_INHERIT : 0; >> -

Re: comctl32: Fix the updown control test to pass under XP

2007-01-22 Thread Lei Zhang
Hey, I was just about to send a similar patch in as well. I mentioned this in a different thread yesterday, but the updown ok_sequence_() function is not honoring the optional flag, you need this chunk of code as well: diff --git a/dlls/comctl32/tests/updown.c b/dlls/comctl32/tests/updown.c @@ -2

Re: [AppDB] Langauge fixes for the FAQ

2007-01-22 Thread Kuba Ober
> > I tend to prefer 'howto' or 'how to' rather than 'how-to'. > > Also, plurals normally don't have a single quote. So I'd write > > 'howtos'. Alternately this could be rephrased as 'How can I submit a > > how to?'. > > how-to is not really a normal word, and to my knowledge, these kinds of > word

Re: [4] snmpapi: Implement SnmpUtil{DbgPrint, IdsToA, OidToA, PrintAsnAny, PrintOid}.

2007-01-22 Thread Kuba Ober
On Monday 22 January 2007 08:13, Hans Leidekker wrote: > On Monday 22 January 2007 12:49, Alexandre Julliard wrote: > > You don't want to use stdio functions in Wine. If apps really depend > > on these functions you'd have to use msvcrt, but otherwise you can > > simply use TRACE (or not implement

Re: kernel32: Don't require full access to the newly created process and thread.

2007-01-22 Thread Vitaliy Margolen
Robert Shearman wrote: > Vitaliy Margolen wrote: >> -req->process_access = PROCESS_ALL_ACCESS; >> +req->process_access = MAXIMUM_ALLOWED | PROCESS_ALL_ACCESS; >> req->process_attr = (psa && (psa->nLength >= sizeof(*psa)) >> && psa->bInheritHandle) ? OBJ_INHERIT : 0; >> -

Re: SHELL32: Implement the property sheet extension array functions (resend)

2007-01-22 Thread Thomas Weidenmueller
Any feedback for why the patch hasn't been accepted? - Thomas

Re: user32: WM_SETFONT on button shouldn't repaint directly

2007-01-22 Thread Clinton Stimpson
Anything wrong with this patch? It hasn't been accepted. Thanks, Clint Clinton Stimpson wrote: This patch includes a couple improvements over the patch submitted yesterday. Fix WM_SETFONT on a button to invalidate the rect instead of painting it directly. Test included. Thanks, Clinton

Re: [4] snmpapi: Implement SnmpUtil{DbgPrint, IdsToA, OidToA, PrintAsnAny, PrintOid}.

2007-01-22 Thread Hans Leidekker
On Monday 22 January 2007 12:49, Alexandre Julliard wrote: > You don't want to use stdio functions in Wine. If apps really depend > on these functions you'd have to use msvcrt, but otherwise you can > simply use TRACE (or not implement them at all). What's the alternative for sprintf? -Hans

Re: [PATCH 1/14] winex11.drv: Make X11DRV_window_to_X_rect use hwnd instead of win_data

2007-01-22 Thread Pierre d'Herbemont
On 22 janv. 07, at 13:31, Alexandre Julliard wrote: Pierre d'Herbemont <[EMAIL PROTECTED]> writes: -void X11DRV_window_to_X_rect( struct x11drv_win_data *data, RECT *rect ) +void X11DRV_window_to_X_rect( HWND hwnd, RECT *rect ) { RECT rc; -if (!data->managed) return; +if (!is

Re: [PATCH 1/14] winex11.drv: Make X11DRV_window_to_X_rect use hwnd instead of win_data

2007-01-22 Thread Alexandre Julliard
Pierre d'Herbemont <[EMAIL PROTECTED]> writes: > -void X11DRV_window_to_X_rect( struct x11drv_win_data *data, RECT *rect ) > +void X11DRV_window_to_X_rect( HWND hwnd, RECT *rect ) > { > RECT rc; > > -if (!data->managed) return; > +if (!is_window_managed(hwnd)) return; > if (Is

Re: [PATCH 7/14] user32: Send the WM_NCCREATE message from user32's CreateWindow

2007-01-22 Thread Pierre d'Herbemont
On 22 janv. 07, at 11:50, Robert Shearman wrote: Pierre d'Herbemont wrote: @@ -1031,18 +1032,6 @@ BOOL X11DRV_CreateWindow( HWND hwnd, CRE /* get class or window DC if needed */ alloc_window_dce( data ); -/* send WM_NCCREATE */ -TRACE( "hwnd %p cs %d,%d %dx%d\n", hwnd, cs->x

Re: [2/2] shell32: Add proper support for SHGetFileInfo(SHGFI_ICONLOCATION | SHGFI_USEFILEATTRIBUTES).

2007-01-22 Thread Francois Gouget
On Thu, 18 Jan 2007, Frank Richter wrote: > On 18.01.2007 16:23, Francois Gouget wrote: > > +if (dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > > +{ > > +lstrcpyW(psfi->szDisplayName, swShell32Name); > > +psfi->iIcon = -IDI_SHELL_FOLDER; > >

Re: [4] snmpapi: Implement SnmpUtil{DbgPrint, IdsToA, OidToA, PrintAsnAny, PrintOid}.

2007-01-22 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > +/*** > + * SnmpUtilPrintOid(SNMPAPI.@) > + */ > +void WINAPI SnmpUtilPrintOid(AsnObjectIdentifier *oid) > +{ > +unsigned int i; > + > +TRACE("(%p)\n", oid); > + >

Re: server: Reverse return value and status in token_access_check to be consistent.

2007-01-22 Thread Robert Shearman
Vitaliy Margolen wrote: Change Log: - server: Reverse return value and status in token_access_check to be consistent. - server: Do not set successful status by default. Set it explicitly in each case. - advapi32: Add few tests. It is some-what confusing to have token_access_check return 2 s

Re: [PATCH 7/14] user32: Send the WM_NCCREATE message from user32's CreateWindow

2007-01-22 Thread Robert Shearman
Pierre d'Herbemont wrote: @@ -1031,18 +1032,6 @@ BOOL X11DRV_CreateWindow( HWND hwnd, CRE /* get class or window DC if needed */ alloc_window_dce( data ); -/* send WM_NCCREATE */ -TRACE( "hwnd %p cs %d,%d %dx%d\n", hwnd, cs->x, cs->y, cs->cx, cs->cy ); -if (unicode) -

Re: kernel32: Don't require full access to the newly created process and thread.

2007-01-22 Thread Robert Shearman
Vitaliy Margolen wrote: -req->process_access = PROCESS_ALL_ACCESS; +req->process_access = MAXIMUM_ALLOWED | PROCESS_ALL_ACCESS; req->process_attr = (psa && (psa->nLength >= sizeof(*psa)) && psa->bInheritHandle) ? OBJ_INHERIT : 0; -req->thread_access = THREAD_A

Re: user32: Some apps pass a color bitmap as a mask toCreateIconIndirect, convert it to b/w

2007-01-22 Thread Dmitry Timoshkov
"Kirill K. Smirnov" <[EMAIL PROTECTED]> wrote: these patches http://www.winehq.org/pipermail/wine-patches/2007-January/035014.html http://www.winehq.org/pipermail/wine-patches/2007-January/035052.html totally break qip IM icons. (www.qip.ru). I suspect the reason is hidden in GetDIBits(...) -

Re: [PATCH 1/2] ntdll: Implement RtlDecodePointer and RtlEncodePointer

2007-01-22 Thread Alexandre Julliard
Mike McCormack <[EMAIL PROTECTED]> writes: > +/* there's no ntdll.RtlInterlockedCompareExchangePointer() ... */ > +RtlEnterCriticalSection( &pointer_obfuscator_cs ); No, but we have interlocked_cmpxchg_ptr() in libwine... -- Alexandre Julliard [EMAIL PROTECTED]

Re: [PATCH 3/8] server: export few functions we will need for security descriptor checks.

2007-01-22 Thread Dmitry Timoshkov
"Vitaliy Margolen" <[EMAIL PROTECTED]> wrote: +++ b/server/security.h @@ -41,10 +41,16 @@ extern const LUID SeCreateGlobalPrivileg extern const PSID security_interactive_sid; +extern void map_generic_mask(unsigned int *mask, const GENERIC_MAPPING *mapping); +++ b/server/token.c /* maps fro