Re: winscard stub dll

2007-05-16 Thread Mounir IDRASSI
Hi Francois, Thanks for your modifications. I'll review your patch and submit it if I have no comments, ِCheers, Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Francois Gouget wrote: Hi, Here's a new version of the patch that removes the casts as suggested by

Re: ADVAPI32: Fix return value to indicate error when NULL string is passed in

2007-05-16 Thread Alexandre Julliard
Rolf Kalbermatter [EMAIL PROTECTED] writes: -if (ret) +if (ret || (!lpDisplayName size)) { if (lpDisplayName *lpcchBuffer) *lpDisplayName = 0; -if (ret == ERROR_MORE_DATA) +if ((!ret !lpDisplayName) || ret == ERROR_MORE_DATA) These complex

review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Vit Hrachovy
Hi, the attached patch adds new editable combobox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. I've tried to implement Frank's comments to English language only. Please consider this patch as a proposal, so if it gets positive review, I'll propagate the changes to all

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Laurent Vromman
case CBN_SELCHANGE: { SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0); switch (LOWORD(wParam)) { - case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break; - } +case

Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

2007-05-16 Thread Alexandre Julliard
Misha Koshelev [EMAIL PROTECTED] writes: --- dlls/msi/automation.c| 36 +++- dlls/msi/msiserver.idl |4 ++ dlls/msi/msiserver_dispids.h |1 + dlls/msi/tests/automation.c | 74 -- This one fails make test

Re: mshtml: Change the binding flags when silent operation is requested by the DISPID_AMBIENT_SILENT property.

2007-05-16 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: The binding flags should be have BINDF_SILENTOPERATION and BIND_NO_UI added. This breaks the tests: ../../../tools/runtest -q -P wine -M shdocvw.dll -T ../../.. -p shdocvw_test.exe.so webbrowser.c touch webbrowser.ok webbrowser.c:197: Test failed:

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Vit Hrachovy
On Wed, May 16, 2007 at 03:18:22PM +0200, Laurent Vromman wrote: case CBN_SELCHANGE: { SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0); switch (LOWORD(wParam)) { - case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg);

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Laurent Vromman
It is not really as I wish. I have just noticed that there is two different kind of indentation in the mentioned switch loop, which looked strange on the moment. I am really not a wine master, others will maybe fixed us. Laurent On Wed, 16 May 2007 15:59:06 +0200, Vit Hrachovy [EMAIL

Re: Direct X 10 game demo

2007-05-16 Thread Tom Spear
On 5/15/07, EA Durbin [EMAIL PROTECTED] wrote: The lost planet demo utilizing Direct X 10 is out, for those of you interested in developing/testing Direct X 10. I'm curious. When we do start work on DX10, are we going to set it up so that it will only work if the user uses winver ~= vista or

Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

2007-05-16 Thread Misha Koshelev
On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: --- dlls/msi/automation.c| 36 +++- dlls/msi/msiserver.idl |4 ++ dlls/msi/msiserver_dispids.h |1 + dlls/msi/tests/automation.c | 74

Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

2007-05-16 Thread Michael Stefaniuc
Misha Koshelev wrote: On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: --- dlls/msi/automation.c| 36 +++- dlls/msi/msiserver.idl |4 ++ dlls/msi/msiserver_dispids.h |1 + dlls/msi/tests/automation.c

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Frank Richter
I would make the combobox editable (plain CBS_DROPDOWN), just add all preset memory sizes, and WM_SETTEXT the value read from the registry. -f.r.

Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

2007-05-16 Thread Misha Koshelev
On Wed, 2007-05-16 at 17:23 +0200, Michael Stefaniuc wrote: Misha Koshelev wrote: On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: --- dlls/msi/automation.c| 36 +++- dlls/msi/msiserver.idl |4 ++

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Frank Richter
On 16.05.2007 18:18, Frank Richter wrote: I would make the combobox editable (plain CBS_DROPDOWN), Er, you do that already. Pays off to read... just add all preset memory sizes, and WM_SETTEXT the value read from the registry. Might be code-wise a bit simpler than your GETCURSEL approach,

Re: Direct X 10 game demo

2007-05-16 Thread Stefan Dösinger
Am Mittwoch 16 Mai 2007 16:25 schrieb Tom Spear: On 5/15/07, EA Durbin [EMAIL PROTECTED] wrote: The lost planet demo utilizing Direct X 10 is out, for those of you interested in developing/testing Direct X 10. I'm curious. When we do start work on DX10, are we going to set it up so that

Re: Direct X 10 game demo

2007-05-16 Thread Jesse Allen
On 5/16/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Mittwoch 16 Mai 2007 16:25 schrieb Tom Spear: On 5/15/07, EA Durbin [EMAIL PROTECTED] wrote: The lost planet demo utilizing Direct X 10 is out, for those of you interested in developing/testing Direct X 10. I'm curious. When we do

Re: Direct X 10 game demo

2007-05-16 Thread Kovács András
This game isn't check windows version on installing. 2007. május 16. 20.32 dátummal Jesse Allen ezt írta: On 5/16/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Mittwoch 16 Mai 2007 16:25 schrieb Tom Spear: On 5/15/07, EA Durbin [EMAIL PROTECTED] wrote: The lost planet demo utilizing

Re: Direct X 10 game demo

2007-05-16 Thread Stefan Dösinger
snip Past that I don't see any reason why they would code additional version checks after that. All the games that I've seen don't do that. snip I don't see a reason why it needs* to check the version of windows. Those are windows apps, keep that in mind ;-) Never expect sane behavior from

Re: Direct X 10 game demo

2007-05-16 Thread Tom Spear
On 5/16/07, Stefan Dösinger [EMAIL PROTECTED] wrote: snip Past that I don't see any reason why they would code additional version checks after that. All the games that I've seen don't do that. snip I don't see a reason why it needs* to check the version of windows. Those are windows apps,

Re: [PATCH 4/8, try3] msi: automation: Implement Installer::ProductInfo.

2007-05-16 Thread Misha Koshelev
On Wed, 2007-05-16 at 17:23 +0200, Michael Stefaniuc wrote: Misha Koshelev wrote: On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: --- dlls/msi/automation.c| 36 +++- dlls/msi/msiserver.idl |4 ++

Bug 219 and some bugzilla in general.

2007-05-16 Thread Vitaliy Margolen
Is it just me or did anyone else have a feeling that our bugilla turned into some kind of forum by selected individuals? I understand all the excitement from this new shiny ntoskrnl, but what _exactly_ does it have to do with safedisk in general? And what all the other apps this person claims that

Re: ntoskrnl.exe: Implemented IoCreateSymbolicLink

2007-05-16 Thread Vitaliy Margolen
Alexandre Julliard wrote: +attr.Attributes = OBJ_CASE_INSENSITIVE | OBJ_OPENIF; +attr.SecurityDescriptor = NULL; +attr.SecurityQualityOfService = NULL; + +TRACE( %s - %s\n, debugstr_us(name), debugstr_us(target) ); +/* FIXME: store handle somewhere */

Set background image for virtual desktop

2007-05-16 Thread Vijay Kiran Kamuju
Hi, Is it possible to set background image for the virtual desktop in wine? If so how do we set it? (I am bored see same old single color virtual desktop ;) ) Cheers, VJ PS: - Any new areas I could work on since d3drm work is complete