Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]

2007-06-28 Thread Misha Koshelev
On 6/27/07, Evan Stade wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]

2007-06-28 Thread Misha Koshelev
On 6/27/07, Evan Stade wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact

Re: msi [1/10]: Implement MsiSourceListGetInfoA

2007-06-28 Thread James Hawkins
On 6/28/07, James Hawkins <[EMAIL PROTECTED]> wrote: Hi, Correctly handled pcchValue. Changelog: * Implement MsiSourceListGetInfoA. Please disregard this series. -- James Hawkins

shelllink patches

2007-06-28 Thread Misha Koshelev
Btw, in case it was not clear from the patches themselves, without these patches out shelllinks for non-executables currently point to the application that is assigned to open them (e.g., notepad), rather than to the actual file as on native. Misha

Re: request to change appdb message

2007-06-28 Thread Jesse Allen
On 6/28/07, Louis Lenders <[EMAIL PROTECTED]> wrote: Ben Hodgetts (Enverex atomnet.co.uk> writes: > > Me and Chris Morgan changed it to this because we were sick of people > pasting pages and pages of terminal output into the What works or What > doesn't work boxes of the test data which is NOT

illegal characters in file names

2007-06-28 Thread Lei Zhang
Hi, I noticed a mismatch between the list of illegal characters in file names between Wine and Windows. On Wine the list of characters is: /:<>| and on Windows, it is: \/:*?"<>| Is this intentional or something we should fix? - Lei

Re: Direct3D Game test framework

2007-06-28 Thread Stefan Dösinger
Am Donnerstag, 28. Juni 2007 18:05 schrieb Stefan Dösinger: > So whats left? > *) Make the Email system send custom test return data, not just success / > failure I found a simple solution for that: I just dump the results onto the log channel, which is sent to the server which can then grep the n

Re: request to change appdb message

2007-06-28 Thread Chris Morgan
On 6/28/07, Louis Lenders <[EMAIL PROTECTED]> wrote: Ben Hodgetts (Enverex atomnet.co.uk> writes: > > Me and Chris Morgan changed it to this because we were sick of people > pasting pages and pages of terminal output into the What works or What > doesn't work boxes of the test data which is NOT

Re: msi 1: Implement MsiSourceListGetInfoA [try2]

2007-06-28 Thread James Hawkins
On 6/28/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "James Hawkins" <[EMAIL PROTECTED]> writes: > By this definition, for any particular property requested, the size > returned should be exactly the same for both the A and W call. This > eliminates the need for a W size variable, and in f

Re: msi 1: Implement MsiSourceListGetInfoA [try2]

2007-06-28 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > By this definition, for any particular property requested, the size > returned should be exactly the same for both the A and W call. This > eliminates the need for a W size variable, and in fact, setting the > returned A size by manipulating the retur

Re: request to change appdb message

2007-06-28 Thread Louis Lenders
Ben Hodgetts (Enverex atomnet.co.uk> writes: > > Me and Chris Morgan changed it to this because we were sick of people > pasting pages and pages of terminal output into the What works or What > doesn't work boxes of the test data which is NOT where it belongs. The > information in test data s

WinXP winsock test broken by commit e39dca6af6c87a30ab1d907c0468de2602a6e442

2007-06-28 Thread Kai Blin
The tests added in patch commit e39dca6af6c87a30ab1d907c0468de2602a6e442 Author: Damjan Jovanovic <[EMAIL PROTECTED]> Date: Thu Mar 22 08:03:28 2007 +0200 ws2_32: WSASendTo should always re-enable the FD_WRITE event. break the ws2_32 sock.c tests on WinXP SP2. sock.c:1832: Test failed: Wait

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]

2007-06-28 Thread Evan Stade
On 6/27/07, Evan Stade <[EMAIL PROTECTED]> wrote: Hi, [try2] The patch I sent yesterday was not properly todo_wined. Also, this test is a bit more extensive (about twice as many points drawn). It uses various point-type combination (even non-sensical ones such as PT_LINETO | PT_MOVETO) to test

Something wrong with my two patches?

2007-06-28 Thread Markus Gömmel
On 21 and 22 June I submitted two small patches (for comctl32/datetime.c and user32/msgbox.c). Both should be ok, but definitly the first one (datetime.c)... Something wrong with them or only some normal delay in putting them into git? My last small patch went into git within 2 days... Only

Re: msi 1: Implement MsiSourceListGetInfoA [try2]

2007-06-28 Thread James Hawkins
On 6/28/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "James Hawkins" <[EMAIL PROTECTED]> writes: > +ret = MsiSourceListGetInfoW(product, usersid, dwContext, dwOptions, > + property, value, pcchValue); > +if (ret == ERROR_SUCCESS) > +WideCharTo

Re: Crosscompile failures for gdiplus

2007-06-28 Thread Stefan Leichter
Am Thursday 28 June 2007 10:45 schrieb Paul Vriens: > Hi, > > Ever since gdiplus tests (roughly 2 weeks ago) got added to Wine we have > crosscompile failures: > > i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclarati

Re: wincrypt: add missing defines

2007-06-28 Thread Juan Lang
No, Yahoo mail has falsely identified it as a virus. Switching to another account.. --Juan --- Mounir IDRASSI <[EMAIL PROTECTED]> wrote: > You forgot the attachement... Building a website is a piece

Re: wincrypt: add missing defines

2007-06-28 Thread Mounir IDRASSI
You forgot the attachement... Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Juan Lang wrote: > --Juan > > > > > Choose the right car based on your needs. Check out Yaho

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.

2007-06-28 Thread Robert Shearman
Jacek Caban wrote: Robert Shearman wrote: Jacek Caban wrote: Hi, I've just sent a test showing that native doesn't implement these interfaces so we shouldn't either. It's strange because IDL declaration says something else. All of the interfaces that the patch implements or

Re: Direct3D Game test framework

2007-06-28 Thread Stefan Dösinger
Hi, With Francois' help I could build a test package for 3DMark2000 now: http://stud4.tuwien.ac.at/~e0526822/3dmark2000.tar.bz2 It runs two tests, one at 640x480, another one at 1024x768, writes the results to a file and reads the file back. No benchmark results are sent to the server yet(just

Wine networking broke on Debian Sid

2007-06-28 Thread Ben Hodgetts (Enverex)
Just to make this clear before starting this is a Sid issue (as far as I can tell) not a Wine issue. Anyway, to the point. Networking is broken on Debian Sid and has been for at least a week. I can't find out what has changed in Sid for it to stop working but basically anyone running Wine on S

Re: cabinent: add a comment about parm passing

2007-06-28 Thread Alexandre Julliard
Jeff L <[EMAIL PROTECTED]> writes: > Mainly because the logic is a bit difficult. It depends on the length > being 0 to terminate the for loop and prevent the null reference. It > is not obvious and easily missed the first time through. Wine has a > number of things like that and more comments w

Re: request to change appdb message

2007-06-28 Thread Ben Hodgetts (Enverex)
Me and Chris Morgan changed it to this because we were sick of people pasting pages and pages of terminal output into the What works or What doesn't work boxes of the test data which is NOT where it belongs. The information in test data should be written in plain English, not pastes of lots of

Re: cabinent: add a comment about parm passing

2007-06-28 Thread Jeff L
James Hawkins wrote: On 6/27/07, Jeff Latimer <[EMAIL PROTECTED]> wrote: Coverity CID 43 Forward_Null is false. This adds a comment explaining the NULL pass is ok. Why do we need a comment for that? Mainly because the logic is a bit difficult. It depends on the length being 0 to terminate th

Re: Direct3D Game test framework

2007-06-28 Thread Stefan Dösinger
> > The problem with vnc is recording a cxtest test(ie button clicks, > > keystrokes). That doesn't have to be fast, just beeing able to init glx > > is ok. But I agree on the non-trivial point. So far I've used manually > > coded keystrokes instead of button clicks, and it works, although it a > >

Re: Direct3D Game test framework

2007-06-28 Thread H. Verbeet
On 28/06/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Am Donnerstag, 28. Juni 2007 09:09 schrieb H. Verbeet: > On 28/06/07, Steven Edwards <[EMAIL PROTECTED]> wrote: > > Could we add an extension to vnc to use Mesa? > > I suspect it would be non-trivial, but more importantly I think it > would

Re: msi 1: Implement MsiSourceListGetInfoA [try2]

2007-06-28 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > +ret = MsiSourceListGetInfoW(product, usersid, dwContext, dwOptions, > + property, value, pcchValue); > +if (ret == ERROR_SUCCESS) > +WideCharToMultiByte(CP_ACP, 0, value, -1, szValue, *pcchValue, NULL,

Re: Direct3D Game test framework

2007-06-28 Thread Stefan Dösinger
Am Donnerstag, 28. Juni 2007 09:09 schrieb H. Verbeet: > On 28/06/07, Steven Edwards <[EMAIL PROTECTED]> wrote: > > Could we add an extension to vnc to use Mesa? > > I suspect it would be non-trivial, but more importantly I think it > would defeat the purpose of measuring performance on different >

Crosscompile failures for gdiplus

2007-06-28 Thread Paul Vriens
Hi, Ever since gdiplus tests (roughly 2 weeks ago) got added to Wine we have crosscompile failures: i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual

request to change appdb message

2007-06-28 Thread Louis. Lenders
Hi, since a few weeks the following message is displayed when you try to submit test results into appdb: Please DO NOT include crash or Wine debug output. Instead report the crash as a bug in the Wine bugzilla at http://bugs.winehq.org. We ask that you use bugzilla because developers do not m

Re: Direct3D Game test framework

2007-06-28 Thread H. Verbeet
On 28/06/07, Steven Edwards <[EMAIL PROTECTED]> wrote: Could we add an extension to vnc to use Mesa? I suspect it would be non-trivial, but more importantly I think it would defeat the purpose of measuring performance on different hardware configurations.