Re: The BS_GROUPBOX style should only be used if the HasBorderattribute is set

2007-12-20 Thread Dmitry Timoshkov
James Hawkins [EMAIL PROTECTED] wrote: Changelog: * The BS_GROUPBOX style should only be used if the HasBorder attribute is set. Alexandre, please don't apply this patch. I sent another patch that reverts commit 96e4320feb22b3a2c9564de100c09990622edb59 which is the real source of the problem.

Re: [5/6] WineD3D: Move the GL info structure into the adapter

2007-12-20 Thread H. Verbeet
On 20/12/2007, Stefan Dösinger [EMAIL PROTECTED] wrote: +#define WINED3D_ATR_TYPE(type) GLINFO_LOCATION.glTypeLookup[type].d3dType +#define WINED3D_ATR_SIZE(type) GLINFO_LOCATION.glTypeLookup[type].size +#define WINED3D_ATR_GLTYPE(type)

Re: [patch 1/2, try 2] wined3d: rewrite IWineD3DSurfaceImpl_BltOverride colorfill codepath

2007-12-20 Thread H. Verbeet
On 20/12/2007, Stefan Dösinger [EMAIL PROTECTED] wrote: Hi Alexander, I had a look at your patches again, and another issue came to my mind: I am not sure how the scissor rectangle and viewport affects ColorFill blits. IDirect3DDevice::Clear is limited by the viewport, the scissor test and

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer

2007-12-20 Thread Robert Shearman
Maarten Lankhorst wrote: @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U if ((pStubMsg-Buffer + size pStubMsg-Buffer) || /* integer overflow of pStubMsg-Buffer */ (pStubMsg-Buffer + size pStubMsg-BufferEnd))

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer

2007-12-20 Thread Maarten Lankhorst
Hi Rob, Robert Shearman schreef: Maarten Lankhorst wrote: @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U if ((pStubMsg-Buffer + size pStubMsg-Buffer) || /* integer overflow of pStubMsg-Buffer */ (pStubMsg-Buffer + size

Re: msi: Revert commit 96e4320feb22b3a2c9564de100c09990622edb59

2007-12-20 Thread Dmitry Timoshkov
Hi Mikołaj, Mikołaj Zalewski [EMAIL PROTECTED] wrote: As I wrote in http://www.winehq.org/pipermail/wine-patches/2007-October/045479.html the problem was in the Photoshop CS2 installer where the groupbox consumed mouse events. They didn't arrive to the edit box (which was created earlier)

Re: kernel32: invalidate local copy of console input event handle while reallocating console.

2007-12-20 Thread Alexandre Julliard
Kirill K. Smirnov [EMAIL PROTECTED] writes: @@ -378,10 +381,7 @@ BOOL WINAPI CloseConsoleHandle(HANDLE handle) */ HANDLE WINAPI GetConsoleInputWaitHandle(void) { -static HANDLE console_wait_event; - -/* FIXME: this is not thread safe */ -if (!console_wait_event) +if

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer

2007-12-20 Thread Robert Shearman
Maarten Lankhorst wrote: Hi Rob, Robert Shearman schreef: Maarten Lankhorst wrote: @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U if ((pStubMsg-Buffer + size pStubMsg-Buffer) || /* integer overflow of pStubMsg-Buffer */

Re: try2:winefile:Save font settings for registry

2007-12-20 Thread Dmitry Timoshkov
Ivan Sinitsin [EMAIL PROTECTED] wrote: + if( RegQueryValueExW( hKey, reg_logfont, NULL, type, + (LPBYTE) logfont, size ) != ERROR_SUCCESS ) { + hFont=GetStockObject(DEFAULT_GUI_FONT); + GetObject(hFont,sizeof(logfont),logfont); +} There is no need to

Re: try2:winefile:Save font settings for registry

2007-12-20 Thread Ivan Sinitsin
В сообщении от Thursday 20 December 2007 15:28:32 вы написали: Ivan Sinitsin [EMAIL PROTECTED] wrote: + if( RegQueryValueExW( hKey, reg_logfont, NULL, type, + (LPBYTE) logfont, size ) != ERROR_SUCCESS ) { + hFont=GetStockObject(DEFAULT_GUI_FONT); +

Re: try2:winefile:Save font settings for registry

2007-12-20 Thread Dmitry Timoshkov
Ivan Sinitsin [EMAIL PROTECTED] wrote: I have corrected the mistakes. Do I understand you right? Yes, attached patch looks good for me. -- Dmitry.

Wine Direct3D progress

2007-12-20 Thread Mirek Slugeň
Hi, I tried some test with current git 2007_12_20 for compare with version 2007_07_19, just for fun :) OLD CONFIGURATION: Configuration: Core 2 Duo [EMAIL PROTECTED], 2GB RAM, GF 6800 GS Options in wine registry: GLSL, FBO, VideoMemorySize 256, PS, VS, SoftwareEmulation Patches: 3DMark hack

Re: Wine Direct3D progress

2007-12-20 Thread H. Verbeet
On 20/12/2007, Mirek Slugeň [EMAIL PROTECTED] wrote: OLD CONFIGURATION: Configuration: Core 2 Duo [EMAIL PROTECTED], 2GB RAM, GF 6800 GS Options in wine registry: GLSL, FBO, VideoMemorySize 256, PS, VS, SoftwareEmulation Patches: 3DMark hack ACTUAL CONFIGURATION (bold results):

Re: Wine Direct3D progress

2007-12-20 Thread Christoph Frick
On Thu, Dec 20, 2007 at 03:58:05PM +0100, H. Verbeet wrote: OLD CONFIGURATION: Configuration: Core 2 Duo [EMAIL PROTECTED], 2GB RAM, GF 6800 GS Options in wine registry: GLSL, FBO, VideoMemorySize 256, PS, VS, SoftwareEmulation Patches: 3DMark hack ACTUAL CONFIGURATION (bold

Re: kernel32: Remove unneeded casts

2007-12-20 Thread Robert Shearman
Andrew Talbot wrote: /* All local heap allocations are aligned on 4-byte boundaries */ #define LALIGN(word) (((word) + 3) ~3) -#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((char*)(ptr)+(arena))) +#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((ptr)+(arena))) Don't

Problem with winelib

2007-12-20 Thread Nagarjuna Bandi
Dear Wine Developers Team, I am using the wine for porting windows applications under linux. This is a very powerful tool for doing this job thank you very much for providing us a such tool. Here i am getting problem with winelib when i trying to build the notepad

Re: msi: Revert commit 96e4320feb22b3a2c9564de100c09990622edb59

2007-12-20 Thread Mikołaj Zalewski
I have no idea what Mikolaj tried to fix with this patch but As I wrote in http://www.winehq.org/pipermail/wine-patches/2007-October/045479.html the problem was in the Photoshop CS2 installer where the groupbox consumed mouse events. They didn't arrive to the edit box (which was created

Re: Problem with winelib

2007-12-20 Thread Juan Lang
Hi Nagarjuna, dialog.o(.text+0x1a5): In function `DIALOG_StringMsgBox': : undefined reference to `wnsprintfW' That looks like a typo to me. It should just be wnsprintf. --Juan

Re: Problem with winelib

2007-12-20 Thread Steven Edwards
On Dec 20, 2007 1:42 AM, Nagarjuna Bandi [EMAIL PROTECTED] wrote: Here i am getting problem with winelib when i trying to build the notepad application with the given guidelines in winelib user guide i had made the changes to Makefile you are specifying but i got another error msg like

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-20 Thread Robert Shearman
Huang, Zhangrong wrote: See dlls/ole32/compobj.c, static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, BOOL apartment_threaded, REFCLSID rclsid, REFIID riid, void **ppv) {

RE: kernel32: Remove unneeded casts

2007-12-20 Thread Rolf Kalbermatter
Robert Shearman wrote: Andrew Talbot wrote: /* All local heap allocations are aligned on 4-byte boundaries */ #define LALIGN(word) (((word) + 3) ~3) -#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((char*)(ptr)+(arena))) +#define ARENA_PTR(ptr,arena)

Re: Wine Direct3D progress

2007-12-20 Thread Stefan Dösinger
Am Donnerstag, 20. Dezember 2007 16:45:11 schrieb Christoph Frick: Changing the graphics card skews the results a bit :-/ Unfortunately it's pretty hard to say how much of an impact that has per test. and changing drivers (assumption) and the patches won't help either. Yeah, the different

Re: dll to .so wrapper

2007-12-20 Thread Kuba Ober
On Wednesday 19 December 2007, bridd wrote: On Wed, 2007-12-19 at 22:26 +0100, Maarten Lankhorst wrote: This topic comes up from time to time, usually with mild variations. The problem is that wine sets up its own environment and memory layout. In the end you will need a .exe (or winelib

RE: loader: Add --compile-info option to Wine.

2007-12-20 Thread Rolf Kalbermatter
Peter Beutner wrote: just tested again with current git and it worked with every gcc version I had at hand here: 4.2.2, 4.1.2, 4.0.4 and 3.4.6. And what did you test there? As far as I understood the issue, it's not that Wine won't work at all (at least for most of those gcc versions). Those gcc

The #winehq Wine channel

2007-12-20 Thread Andrew Riedi
There are two main issues I would like to address. 1) Normally the current #winehq OPs to a great job, but they are only human and only have so many waking hours. I noticed recently that it took a little longer than normal for #winehq's topic to be updated to the latest release. I would like to

Re: loader: Add --compile-info option to Wine.

2007-12-20 Thread Peter Beutner
Rolf Kalbermatter schrieb: Peter Beutner wrote: just tested again with current git and it worked with every gcc version I had at hand here: 4.2.2, 4.1.2, 4.0.4 and 3.4.6. And what did you test there? That safedisc 2.x works. Wine successfully passes the statistical code analysis. And

Re: Problem with winelib

2007-12-20 Thread Dmitry Timoshkov
Juan Lang [EMAIL PROTECTED] wrote: dialog.o(.text+0x1a5): In function `DIALOG_StringMsgBox': : undefined reference to `wnsprintfW' That looks like a typo to me. It should just be wnsprintf. That's not a typo, just a missing shlwapi import in the Makefile. -- Dmitry.

Re: loader: Add --compile-info option to Wine.

2007-12-20 Thread Austin English
Another factor to consider is that individual distributions may work while others do not. Vanilla gcc may work, but after Ubuntu/Suse/etc apply their patches, this may not be the case. -Austin On Dec 20, 2007 8:11 PM, Peter Beutner [EMAIL PROTECTED] wrote: Rolf Kalbermatter schrieb: Peter

Re: advapi32: Fix domain length setting in LookupAccountNameW

2007-12-20 Thread Zac Brown
Zac Brown wrote: Hi, Changelog: * Fix value setting for *cchReferencedDomainName in LookupAccountNameW * Fix LookupAccountNameA conversion from WCHAR to CHAR by setting proper '\0' Notes: * This patch addresses bug 10612 -Zac Brown

Re: mapi32: Resolve FIXME regarding attachment lists in MAPISendMailfunction

2007-12-20 Thread Dmitry Timoshkov
Mark Neyhart [EMAIL PROTECTED] wrote: diff --git a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c old mode 100644 new mode 100755 Please fix file permissions before submitting patches. -- Dmitry.

Re: user32: add stub for GetLayeredWindowAttributes

2007-12-20 Thread Dmitry Timoshkov
Louis. Lenders [EMAIL PROTECTED] wrote: +BOOL WINAPI GetLayeredWindowAttributes( HWND hWnd,COLORREF* prgbKey, +BYTE* pbAlpha, DWORD* pdwFlags ) +{ +FIXME((%p,0x%.8x,%d,%d): stub!\n, hWnd, *prgbKey, *pbAlpha, *pdwFlags); +return TRUE; +}

[1/4 try 3] wined3d: Activate GL context before making any GL calls in stretch_rect_fbo

2007-12-20 Thread Allan Tong
Third try, this time without the incomplete FBO error in the ddraw tests. With this set of patches, all D3D tests should pass with FBO offscreen rendering. - Allan From d8e8ac26c66f3c4b822604c2c634ad9f492da907 Mon Sep 17 00:00:00 2001 From: Allan Tong [EMAIL PROTECTED] Date: Thu, 13 Dec 2007

Re: Wine Direct3D progress

2007-12-20 Thread Tom Wickline
On Dec 20, 2007 9:33 AM, Mirek Slugeň [EMAIL PROTECTED] wrote: 3DMark 2006 game tests: 768/126/1149 points game 1: 5.2/1.2/9.3 fps game 2: 7.6/0.9/9.7 fps hdr game tests: 298/167/1022 points game 1: 1.976/1.4/8.8 fps game 2: 3.989/1.9/11.6 fps cpu tests: 2412/2426/2665 points

Wine desktop integration: double-clicking files in file managers

2007-12-20 Thread Vincent Povirk
I have attached a patch that adds a wrapper script to Wine for starting files from Linux file managers such as nautilus and modifies wine.desktop to use the script for exe, msi, lnk, chm, and hlp files. The wrapper sets the working directory to the directory containing the file and starts it