Re: [1/5] WineD3D: Unroll loops in ARB if needed (try 2)

2009-06-15 Thread Henri Verbeet
2009/6/14 Stefan Dösinger ste...@codeweavers.com: A few fixes from the first version: *) Copypaste index issues fixed *) aL is incremeted at the end of the loop, not at the beginning *) emulated c[aL + offset] indexing works The loop codepath is now tested as well, not just the rep stuff -

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/14 Stefan Dösinger ste...@codeweavers.com: +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum internal, GLsizei width, GLsizei height, GLenum format, GLenum type, + DWORD client_store_flag) { I think that's ugly. More

Re: winapi: Fix a $blevel / $plevel mismatch.

2009-06-15 Thread Francois Gouget
Ignore this one, I patched the wrong place. On Mon, 15 Jun 2009, Francois Gouget wrote: [...] } elsif(s/^\}//) { $blevel--; - if($blevel = 0) { + if($plevel = 0) { $self-_parse_c_error($_, $line, $column, file, } without {); -- Francois

Request for Patchreview

2009-06-15 Thread André Hentschel
Can someone please review my patch http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html. Its about the Installer-Button in Appwiz.cpl Thanks Best Regards André Hentschel

re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified

2009-06-15 Thread Dan Kegel
Brent wrote: This was causing some apps to crash with invalid read from address 0x4. Which apps? Is there a bug report for this? - Dan

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 09:16:07 schrieb Henri Verbeet: 2009/6/14 Stefan Dösinger ste...@codeweavers.com: +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum internal, GLsizei width, GLsizei height, GLenum format, GLenum type, + DWORD

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/15 Stefan Dösinger ste...@codeweavers.com: In the current code, we don't do that, because only via ddraw.dll the use of client storage can change, and only d3d9 can use sRGB textures. No, SFLAG_CLIENT only depends on the availability of the extension, and other surface flags. Since

Re: Duplicates page: Permission denied

2009-06-15 Thread Jeremy Newman
Alright. Should load now. -Newman Ken Sharp wrote: Since the upgrade of Bugzilla, the duplicates page reports permission denied. http://bugs.winehq.org/duplicates.cgi Can anyone with the relevant access check the permissions? This is http://bugs.winehq.org/show_bug.cgi?id=18665

Re: Request for Patchreview

2009-06-15 Thread Juan Lang
Hi André, Can someone please review my patch http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html. I have a couple minor comments: + + IDS_INSTALL_FILTER, Installation Program\0*Instal*.exe;*Setup*.exe;*.msi\0Programs\0*.com;*.cmd;*.exe\0All Files (*.*)\0*.*\0\0 Nit: the

Wine Direct Input Issue

2009-06-15 Thread MD.IMAM HOSSAIN
Dear Wine Developers, The latest WINE 1.1.23 has a small regression about Direct Input. The game HITMAN 3 CONTRACTS has a problem with mouse clicking. By WINE 1.1.23 and HITMAN 3 CONTRACTS mouse clicking does not work. It is worked fine with wine 1.1.11. Since the game is a third person shooter

Re: Wine Direct Input Issue

2009-06-15 Thread Austin English
On Mon, Jun 15, 2009 at 12:05 PM, MD.IMAM HOSSAINimamdxl8...@gmail.com wrote: Dear Wine Developers, The latest WINE 1.1.23 has a small regression about Direct Input. The game HITMAN 3 CONTRACTS has a problem with mouse clicking. By WINE 1.1.23 and HITMAN 3 CONTRACTS mouse clicking does not

Re: Request for Patchreview

2009-06-15 Thread André Hentschel
Juan Lang schrieb: Hi André, Can someone please review my patch http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html. I have a couple minor comments: + + IDS_INSTALL_FILTER, Installation Program\0*Instal*.exe;*Setup*.exe;*.msi\0Programs\0*.com;*.cmd;*.exe\0All Files

Re: Trouble cloning git via http

2009-06-15 Thread Kai Blin
On Monday 15 June 2009 17:49:05 Juan Lang wrote: Anyone else cloning git via http? I'm behind an annoying proxy server, and when I try to clone, I get: error: Unable to find afce86b4bc6198575bbe6046d12fd77efe01cd46 under http://source.winehq.org/git/wine.git Cannot obtain needed object

Re: Trouble cloning git via http

2009-06-15 Thread Juan Lang
Hi Kai, Have you tried cloning from repo.or.cz? The git http protocol is really stupid and can't search multiple packs. repo.or.cz seems to do a decent job of keeping the repos repacked. Cool, that worked. Thanks! --Juan

Re: Request for Patchreview

2009-06-15 Thread Juan Lang
First thing, i tested it on some Win-Versions, and it took everything like Instal*.exe and *Setup*.exe Really, name a exe-file Instalblahblah.exe and the installer-dialog will show it. Second thing, the .com and .cmd belongs to normal Program-selection, not to the installers. but we can

Re: Request for Patchreview

2009-06-15 Thread André Hentschel
Juan Lang schrieb: First thing, i tested it on some Win-Versions, and it took everything like Instal*.exe and *Setup*.exe Really, name a exe-file Instalblahblah.exe and the installer-dialog will show it. Second thing, the .com and .cmd belongs to normal Program-selection, not to the installers.

Re: wined3d: Reserve two varyings for ATI DX10 cards

2009-06-15 Thread Henri Verbeet
2009/6/15 Robert Key hpestile...@gmail.com: Changelog: * This reserves 2 varyings for gl_FrontColor and gl_FrontSecondaryColor   for ATI DX10 cards. This should fix bug #17437 once the new fglrx   drivers get released this week. That doesn't look quite right. gl_FrontColor and

Re: Request for Patchreview

2009-06-15 Thread Juan Lang
Thanks André. My tests worked with Instal*.exe files on english Windows, too. I bet it is because of the instal~1.exe writing. (8.3 and 6##.3) Ah, right. Very good, leave this as it is then. Sorry for the sloppy review, there are a couple more things I'd like to ask about: My tests worked

Re: wined3d: Reserve two varyings for ATI DX10 cards

2009-06-15 Thread Robert Key
On Monday 15 June 2009 14:01:33 Henri Verbeet wrote: 2009/6/15 Robert Key hpestile...@gmail.com: Changelog: * This reserves 2 varyings for gl_FrontColor and gl_FrontSecondaryColor for ATI DX10 cards. This should fix bug #17437 once the new fglrx drivers get released this week.

Re: wined3d: Reserve two varyings for ATI DX10 cards

2009-06-15 Thread Henri Verbeet
2009/6/15 Robert Key hpestile...@gmail.com: This is what it looks like fixed, before it was doing IN[15] + gl_FrontColor + gl_FrontSecondaryColor. We should probably just avoid writing to gl_FrontColor / gl_FrontSecondaryColor if they're not read. How does the attached patch work? diff --git

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified

2009-06-15 Thread Brent Roman
Hi Dan, The app I've been trying to run for years under Wine is: http://www.quadravox.com/AQ430.htm The version I use is 2.0.6.9, but I strongly suspect the problem will show up in their current versions as well. You may download a 30-day trial version to verify the bug fix. However, I think

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 16:19:22 schrieb Henri Verbeet: 2009/6/15 Stefan Dösinger ste...@codeweavers.com: In the current code, we don't do that, because only via ddraw.dll the use of client storage can change, and only d3d9 can use sRGB textures. No, SFLAG_CLIENT only depends on the

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/15 Stefan Dösinger ste...@codeweavers.com: Am Montag, 15. Juni 2009 16:19:22 schrieb Henri Verbeet: 2009/6/15 Stefan Dösinger ste...@codeweavers.com: In the current code, we don't do that, because only via ddraw.dll the use of client storage can change, and only d3d9 can use sRGB

Re: wined3d: Reserve two varyings for ATI DX10 cards

2009-06-15 Thread Robert Key
On Monday 15 June 2009 14:39:48 Henri Verbeet wrote: 2009/6/15 Robert Key hpestile...@gmail.com: This is what it looks like fixed, before it was doing IN[15] + gl_FrontColor + gl_FrontSecondaryColor. We should probably just avoid writing to gl_FrontColor / gl_FrontSecondaryColor if they're

[Bug 18786] patch

2009-06-15 Thread Guy Albertelli
Hello Juan, Could you look at bug 18786 and my suggested patch to get MINITAB working again. It is a partial revert of one of your patches from 6/25/08 (see comment #7). I have verified that the associated tests (dlls/inetmib1/tests/main.c) exercise that code both pre and post revert. However

Re: [2/4] [wined3d] add ps_np2fixup_info_t structure

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 20:23:05 schrieb Tobias Jakobi: + * This structure is shared between the GLSL and the ARB backend.*/ +typedef struct ps_np2fixup_info_s { +WORDidx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ +WORDactive; /* bitfield

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 22:20:33 schrieb Henri Verbeet: Sure, but unless you split up SFLAG_CONVERTED first, that flag is also the same for RGB and sRGB. You've got a point here, I'll put the patch into my hack collection for now until I find something better. Probably we should put the per GL