Re: [PATCH 7/7] wined3d: Move A4L4 conversion to the formats table.

2010-04-13 Thread Paul Vriens
On 04/13/2010 12:46 AM, Greg Geldorp wrote: From: Ge van Geldorp From: Roderick Colenbrander I'm not sure how the bot works but it looks like it concatenated some of my patches together and then applied to them. I have no idea to what Wine version it was since it applies fine on Wine git here.

TestBot moved to new address

2010-04-13 Thread Greg Geldorp
The TestBot has moved to a new location: http://testbot.winehq.org You will be automatically redirected if you use the old address. Thanks to Jeremy Newman who helped me set this up. Ge.

Re: [PATCH 7/7] wined3d: Move A4L4 conversion to the formats table.

2010-04-13 Thread Sven Baars
Greg Geldorp schreef: From: Ge van Geldorp From: Roderick Colenbrander I'm not sure how the bot works but it looks like it concatenated some of my patches together and then applied to them. I have no idea to what Wine version it was since it applies fine on Wine git here. It could be

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
Hi Sven, From: Sven Baars you could, instead of only checking for the author, also try to check for the maximum amount of patches. If you find patch [Patch 1/7], I assume you currently wait for all 7 patches. Now if a patch 1/3 comes in between, you'll see that the maximum is different, in

Re: Detecting patch sets

2010-04-13 Thread Wolfram Sang
you could, instead of only checking for the author, also try to check for the maximum amount of patches. If you find patch [Patch 1/7], I assume you currently wait for all 7 patches. Now if a patch 1/3 comes in between, you'll see that the maximum is different, in this case 3, so you'll know

Re: Detecting patch sets

2010-04-13 Thread Michael Stefaniuc
Wolfram Sang wrote: you could, instead of only checking for the author, also try to check for the maximum amount of patches. If you find patch [Patch 1/7], I assume you currently wait for all 7 patches. Now if a patch 1/3 comes in between, you'll see that the maximum is different, in this case

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
From: Wolfram Sang This should be a pretty rare case given that most people will use some generators like 'git format-patch' or 'quilt' for their patch-series. I'd say if such an error ever occurs, the series could be manually fixed/resent. That way, you don't need to code some UI and the

Re: winmm: MCI system commands are not eligible for auto-open. (try 2)

2010-04-13 Thread Juan Lang
Hi Dmitry, And another rule is that the patch which changes the behaviour of an API needs to have an appropriate test case which does not pass before the patch (i.e. has the todo_wine around it), and passes after the patch (i.e. the patch removes the corresponding todo_wine). Your patch

Re: 1/3 d3d9: Add an initial ColorFill regression test.

2010-04-13 Thread Stefan Dösinger
Ideas for future tests: * default pool textures * default pool rendertarget textures * default pool depth stencil textures * managed pool textures * default pool depthstencil surfaces Am 12.04.2010 um 21:06 schrieb Roderick Colenbrander:

Re: Detecting patch sets

2010-04-13 Thread Dan Kegel
Hi Ge, when I was running patchwatcher, taking the number of patches in the series helped more than it hurt. (It's fairly frequent for people to submit two patchsets, and fairly infrequent for the second patchset to have the same number of patches.) The darn interface needed babysitting, though,

Re: Working on DOS VGA.

2010-04-13 Thread Damjan Jovanovic
On Thu, Apr 1, 2010 at 4:47 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 01.04.2010 um 11:24 schrieb Roderick Colenbrander: First of all welcome to Wine. Myself I'm a bit worried about whether we should improve our DOS support even further. The problem is that more and more people are

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
From: Dan Kegel when I was running patchwatcher, taking the number of patches in the series helped more than it hurt. (It's fairly frequent for people to submit two patchsets, and fairly infrequent for the second patchset to have the same number of patches.) Thanks Dan, I think we have a

Re: Detecting patch sets

2010-04-13 Thread Sven Baars
How about this: First check it the normal way, also taking the maximum patch number into account. If a patch with a number higher than the maximum comes in that also changes tests, then you run the whole patchset again. If a set is not complete after x hours after the last patch has been

Re: ddraw: Do not restore the display mode from inside SetCooperativeLevel

2010-04-13 Thread Johan Gill
It seems this patch wasn't accepted yet. Are there any issues I should know about? Regards Johan Gill

Re: user32: BM_SETSTATE handler needs to repaint the button including focus rectangle.

2010-04-13 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@codeweavers.com writes: While playing with the button painting bug I noticed that the button doesn't repaint its focus when you hold mouse button and move it outside and then back to the button. It looks to me that you should fix the push button paint routine, instead

Re: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.

2010-04-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.nl/JobDetails.pl?Key=1407 Your paranoid android.

Re: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.

2010-04-13 Thread Henri Verbeet
On 13 April 2010 11:36, Marvin test...@testbot.winehq.org wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

RE: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.

2010-04-13 Thread Greg Geldorp
From: Henri Verbeet On 13 April 2010 11:36, Marvin test...@testbot.winehq.org wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full

RE: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.

2010-04-13 Thread Hans Leidekker
On Tue, 2010-04-13 at 13:10 -0700, Greg Geldorp wrote: From: Henri Verbeet On 13 April 2010 11:36, Marvin test...@testbot.winehq.org wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.

2010-04-13 Thread Stefan Dösinger
Am 13.04.2010 um 20:46 schrieb Henri Verbeet: +if (wined3d_settings.strict_draw_ordering) wglFlush(); /* Flush to ensure ordering across contexts. */ I'd prefer to have this in an (inline) function.

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.

2010-04-13 Thread Henri Verbeet
On 13 April 2010 23:13, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 13.04.2010 um 20:46 schrieb Henri Verbeet: +    if (wined3d_settings.strict_draw_ordering) wglFlush(); /* Flush to ensure ordering across contexts. */ I'd prefer to have this in an (inline) function. I'm not sure I see

Re: [1/1] wcmd/tests: Attrib tests (resend)

2010-04-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1423 Your paranoid

Re: user32: BM_SETSTATE handler needs to repaint the button including focus rectangle.

2010-04-13 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: While playing with the button painting bug I noticed that the button doesn't repaint its focus when you hold mouse button and move it outside and then back to the button. It looks to me that you should fix the push button paint routine,

Future implementation

2010-04-13 Thread Luis Busquets
Could someone please confirm the following points?: 1. Sound system. The configuration that wine will implement is: winmm -- WASAPI -- OpenAL and DirectSound -- OpenAL After that is done wineoss, winejack, winealsa, ... will be removed from the tree. 2. Integration of DosBOX or other

Re: Future implementation

2010-04-13 Thread Ben Klein
On 14 April 2010 14:35, Luis Busquets luis.busqu...@ilidium.com wrote: Could someone please confirm the following points?: 1. Sound system. The configuration that wine will implement is: winmm -- WASAPI -- OpenAL and DirectSound -- OpenAL After that is done wineoss, winejack, winealsa, ...