Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote: > On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > > I cannnot make sure my patch 99266 was rejected. > > I can't really tell why it was rejected but I can tell there are mixed > space/tabs in the SetLastError lines. > > I gues

Re: add ualapi directory (try 11)

2013-09-28 Thread Marcus Meissner
On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote: > > > > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: > <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapir...@gmail.com> > From: Akira Nakagawa > Date: Mon, 23 Sep 2013 17:00:

Re: my patch was wrong at dlls/kernel32/computernames.c

2013-08-29 Thread Marcus Meissner
On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote: > From > if ( isalnumW ( wc ) ) return wc; > for ( i = 0; i < 17; i++ ) > To > if ( isalnumW ( wc ) ) return wc; > for ( i = 0; i < 16; i++ ) > and the original version was wrong,too. > It counts the NULL of the end. Thats why you should

Re: Process for reporting security bugs?

2013-08-12 Thread Marcus Meissner
On Mon, Aug 12, 2013 at 10:40:48PM +0900, Andrew Church wrote: > Hi Marcus, > > >If it is not a high severe issue you can also just mail this mailinglist > >here (wine-devel). > > Thanks for the info. As it turns out, it's an already-known issue > (unixfs allows full host filesystem access throu

Re: Process for reporting security bugs?

2013-08-12 Thread Marcus Meissner
Hi, On Sat, Aug 10, 2013 at 01:12:24PM +0900, Andrew Church wrote: > [Please cc: me on any replies since I'm not subscribed to the list.] > > Hi, > > Is there a specific process for reporting security-related bugs in Wine? > I've looked through winehq.org but haven't found any mention of such;

Re: [PATCH] oleaut32: ERR on 32bit typelibs on 64bit

2013-08-02 Thread Marcus Meissner
On Fri, Aug 02, 2013 at 04:29:07PM +0200, Alexandre Julliard wrote: > Marcus Meissner writes: > > > Triggered by the Novell Groupwise installer currently, > > from the ISBE64W.exe Installshield Helper program. > > > > The typelib is contained directly in ISBE64W.e

Re: NtCreateFile fails

2013-07-29 Thread Marcus Meissner
On Mon, Jul 29, 2013 at 04:02:03PM +0200, Mislav Blazevic wrote: > First of all, pardon my ignorance, I am new to wine and winapi. > > I am trying to implement apphelp.dll and I ran into issues with > NtCreateFile: It always returns 0xc103, STATUS_NOT_A_DIRECTORY, and I > am not sure what that

Coverity Status

2013-07-20 Thread Marcus Meissner
Hi, For Wine 1.6 we have the following Coverity stats: - 3,648,322 Lines of Code scanned - Defect Density 0.51 - 8321 total defects - 1852 outstanding (unresolved) defects - 1964 dismissed defects - 4505 fixed defects git shortlog wine-1.4..wine-1.6|grep -i Coverity|wc -l 225 Thanks to AmineKh

Re: Need help with debugging a directx9 game crashing

2013-07-19 Thread Marcus Meissner
On Fri, Jul 19, 2013 at 04:06:56PM +0200, Henri Verbeet wrote: > On 19 July 2013 15:34, Qian Hong wrote: > > Further tests show that the simplest hack to avoid crashing is > > replacing line 71 to: > > FIXME("anything %x\n", 0xdeadbeef); > > > > I have no idea what the real fix is, any suggestion

Re: Another major milestone

2013-07-19 Thread Marcus Meissner
On Fri, Jul 19, 2013 at 06:32:32PM +0100, Ken Sharp wrote: > > > On 19/07/13 15:00, Rosanne DiMesio wrote: > >On Thu, 18 Jul 2013 16:55:42 -0500 > >Jeremy White wrote: > > > >>Alright folks, I have to confess that the 1.6 release came and I didn't > >>immediately get up and dance. > >> > >>In fa

Re: Another major milestone

2013-07-19 Thread Marcus Meissner
On Fri, Jul 19, 2013 at 09:00:30AM -0500, Rosanne DiMesio wrote: > On Thu, 18 Jul 2013 16:55:42 -0500 > Jeremy White wrote: > > > Alright folks, I have to confess that the 1.6 release came and I didn't > > immediately get up and dance. > > > > In fact, a new Wine release was almost...boring. > >

Re: Another major milestone

2013-07-19 Thread Marcus Meissner
On Thu, Jul 18, 2013 at 04:55:42PM -0500, Jeremy White wrote: > Alright folks, I have to confess that the 1.6 release came and I didn't > immediately get up and dance. > > In fact, a new Wine release was almost...boring. > > I think we have to consider that a major milestone in of itself. New, >

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)

2013-06-25 Thread Marcus Meissner
On Sun, Jun 23, 2013 at 08:43:18PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > > > --- a/dlls/ole32/ifs.c > > > > +++ b/dlls/ole32/ifs.c > > > > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(

Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)

2013-06-23 Thread Marcus Meissner
On Sun, Jun 23, 2013 at 07:15:43PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > --- a/dlls/ole32/ifs.c > > +++ b/dlls/ole32/ifs.c > > @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC > > iface,LPVOID pv,DWORD cb) { > >

Re: [PATCH] ole32: fixed 3 handle leaks (Coverity)

2013-06-09 Thread Marcus Meissner
On Mon, Jun 10, 2013 at 08:25:42AM +0200, Marcus Meissner wrote: > On Mon, Jun 10, 2013 at 10:43:58AM +0900, Dmitry Timoshkov wrote: > > Marcus Meissner wrote: > > > > > 1030106 Resource leak > > > 1030105 Resource leak > > > 1030104 Resource leak >

Re: [PATCH] ole32: fixed 3 handle leaks (Coverity)

2013-06-09 Thread Marcus Meissner
On Mon, Jun 10, 2013 at 10:43:58AM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > 1030106 Resource leak > > 1030105 Resource leak > > 1030104 Resource leak > > These cases are of the kind 'freeing resources at process exit is not useful'

Re: msvcrt: remove hack

2013-05-30 Thread Marcus Meissner
On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasin

Re: wine-patches

2013-05-01 Thread Marcus Meissner
On Thu, May 02, 2013 at 08:12:53AM +0200, Daniel Jeliński wrote: > Hello, > I sent a ~200KB patch to wine-patches last night and it disappeared without > a trace. I'm wondering if it got lost or just went to moderation. > Regards, > Daniel > > PS.I just resent it, still no luck. If you are subscr

Re: Fun with GCC 4.8

2013-04-15 Thread Marcus Meissner
On Mon, Apr 15, 2013 at 02:37:27PM -0600, James Eder wrote: > As many of you no doubt know, GCC recently released 4.8.0. This new > version introduces a new optimization level enabled by -Og with the > following description (from the man page): > > "Optimize debugging experience. -Og enables opt

Re: 64bit winelib test app fails on AMD CPU, but works on Intel - need help to identify possible problem, please :)

2013-04-07 Thread Marcus Meissner
Hi, Well, your testcase had a trivial mistake which i now see. This line: typedef struct AEffect * (*main_entry_t)(audioMasterCallback); must read: typedef struct WINAPI AEffect * (*main_entry_t)(audioMasterCallback); WINAPI is critical here, as it changes the call from the SysV AMD64 calling

Re: 64bit winelib test app fails on AMD CPU, but works on Intel - need help to identify possible problem, please :)

2013-04-04 Thread Marcus Meissner
On Thu, Apr 04, 2013 at 07:39:16PM -0400, jordan wrote: > Hey List, > > A few days ago, i posted to the list about possibly porting a winelib > app to support x86_64. (currently supports x86). > > the original post is here (for those interested, but not entirely > relevant to this post): > http:/

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.

2013-04-03 Thread Marcus Meissner
On Wed, Apr 03, 2013 at 02:33:06PM +0200, Marcus Meissner wrote: > Hi, > > I have one concern ... > > Licensing. > > GNUTLS is (L)GPLv3+ these days. > Wine will now turn into a LPGLv3+ licensed binary (not the sources, just > the binaries will turn into it implicitly

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.

2013-04-03 Thread Marcus Meissner
Hi, I have one concern ... Licensing. GNUTLS is (L)GPLv3+ these days. Wine will now turn into a LPGLv3+ licensed binary (not the sources, just the binaries will turn into it implicitly by linking against gnutls 3). Ciao, Marcus On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote: > ---

Re: Crash confuses me

2013-03-08 Thread Marcus Meissner
On Sat, Mar 09, 2013 at 01:40:00AM +, Graham wrote: > On 08/03/13 22:40, Francois Gouget wrote: > > On Fri, 8 Mar 2013, Marcus Meissner wrote: > > [...] > >> "real NOVICE" and using LD_PRELOAD or "hotpatching" does not fit together > >> for

Re: Crash confuses me

2013-03-08 Thread Marcus Meissner
On Thu, Mar 07, 2013 at 07:53:57PM +, Graham wrote: > I use a LD_PRELOAD before running wine so that i can debug my application. > > The library which is preloaded is able to replace system dlsym and from > that, other consequence library call. > > There is no problem until, i put some Detour

Re: [PATCH] cryptui: use add_oid_to_usage correctly (Coverity)

2013-02-02 Thread Marcus Meissner
On Fri, Feb 01, 2013 at 03:48:27PM -0800, Juan Lang wrote: > On Fri, Feb 1, 2013 at 3:45 PM, Juan Lang wrote: > > > Hi Marcus, > > > > -add_oid_to_usage(usage, ptr); > > +usage = add_oid_to_usage(usage, ptr); > > > > This looks fine, but would you mind making the same chan

Re: [PATCH 2/2] jscript: Fixed a leak in regexp_match function

2013-01-25 Thread Marcus Meissner
On Fri, Jan 25, 2013 at 04:26:59PM +0100, Piotr Caban wrote: > --- > dlls/jscript/regexp.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > > diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c > index 0d66551..fa2668c 100644 > --- a/dlls/jscript/regexp.c > +++ b/d

Re: Reload a DLL and _getptd returns zero

2013-01-13 Thread Marcus Meissner
On Fri, Jan 11, 2013 at 11:24:55AM -0800, Michael Ost wrote: > Hi list, > > Does anyone know why _getptd() calls would return zero on a DLL that > has been reloaded? Does something happen to the TLS used by _getptd? > > At Muse Research we have been struggling with a deep bug for years > where th

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread Marcus Meissner
On Thu, Jan 03, 2013 at 05:22:14PM -0500, jordan wrote: > Hi, > > I have been experimenting with some patchsets for Wine -> based on an > implementation of Wine originally developed By Muse Research. It has > improved support for a bunch of stuff, fixes (most) bottlenecks for > Linux proaudio fol

Re: [PATCH 2/2] kernel32: conditional variable support

2012-12-29 Thread Marcus Meissner
On Sun, Dec 30, 2012 at 12:02:34AM +0400, Nikolay Sivov wrote: > On 12/29/2012 23:04, Marcus Meissner wrote: > >From: Marcus Meissner > > > >Modeled pretty much after the implementation described > >in glibc/nptl/DESIGN-condvar.txt with its futex usage > &g

Re: Small patch to make Adobe Lightroom 4.x work with wine 1.5.17

2012-12-02 Thread Marcus Meissner
functions > related to Condition Variables. I found an original patch by Marcus > Meissner and I fixed it because it led to a 100% CPU load. I tried > to contact Marcus to discuss my changes with him, but he didn't > answer and so I submit my changes to this list, otherwise my

Re: [PATCH 20/25] mciseq: Check stop condition after sleeping. (Try 5)

2012-10-17 Thread Marcus Meissner
On Wed, Oct 17, 2012 at 10:36:44AM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Please note that the patch queue failed to detect some superseded patches: > > 90588: I should not have named that 17/25 in the first place. > 90672 + 90674: the original 20-21/25 were never marked superseded by l

Re: ntdll: Don't use strncasecmp for _strnicmp implementation

2012-10-16 Thread Marcus Meissner
On Tue, Oct 16, 2012 at 01:12:50PM +0200, Jacek Caban wrote: > On 10/16/12 13:08, Marcus Meissner wrote: > > On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote: > >> --- > >> dlls/ntdll/string.c | 12 +++- > >&g

Re: ntdll: Don't use strncasecmp for _strnicmp implementation

2012-10-16 Thread Marcus Meissner
On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote: > --- > dlls/ntdll/string.c | 12 +++- > dlls/ntdll/tests/string.c | 33 + > 2 files changed, 44 insertions(+), 1 deletions(-) > > > diff --git a/dlls/ntdll/string.c b/dlls/ntdll/strin

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

2012-10-03 Thread Marcus Meissner
On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote: > Hi Marcus, > > On 10/01/12 23:00, Marcus Meissner wrote: > > Hi, > > > > Various coverity issues complain about user-after-free scenarios, > > all involving this code path. > > > > I stro

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default

2012-09-10 Thread Marcus Meissner
On Mon, Sep 10, 2012 at 12:14:51AM +0900, Hiroshi Miura wrote: >-Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > > See registry entry for schannel and control > enable/disable tls versions. > > It also see grbitEnabledProtocols defined in > creden

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-02 Thread Marcus Meissner
On Sun, Sep 02, 2012 at 11:40:52PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > +if (!pInitializeConditionVariable) { > > +skip("no condition variable support.\n"); > > +return; > > +} > > Probably this sho

Re: winhttp: disable TLSv1.1/1.2 by default

2012-08-26 Thread Marcus Meissner
On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: > > Windows 7 disables TLSv1.1/1.2 by default. > This patch intend to behave same as Windows. Please do not... The newer TLSv1.x fix some shortcomings of the older TLS versions. Is there a specific problem you see? Otherwis

Re: wine/server: removed obsolete one-iteration loop from request forming macro (try 2)

2012-08-23 Thread Marcus Meissner
On Thu, Aug 23, 2012 at 11:14:23AM +0400, Oleg Yarigin wrote: > An original message was sent with wrong author`s name by mistake, so > I resend this patch with hope it was the only reason to reject it. It was not the only reason. A single loop is a common pattern in C to allow safe encapsulation

Re: GSoC mentor summit 2012

2012-08-04 Thread Marcus Meissner
On Fri, Jul 27, 2012 at 01:20:20PM +0200, Stefan Dösinger wrote: > Am Donnerstag, 26. Juli 2012, 16:07:52 schrieb Owen Rudge: > > It looks like the GSoC mentor summit for 2012 has been announced. Are > > any of the mentors this year interested in attending? It's happening on > > the 20th/21st Octob

Re: Have there been any problems with Wine on GCC 4.7?

2012-07-23 Thread Marcus Meissner
On Mon, Jul 23, 2012 at 07:06:21PM -0700, Scott Ritchie wrote: > Wine is the last remaining package still depending on GCC 4.5 in the > current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port > Wine, however 4.6 is known to not work too well. > > But now we have 4.7 -- have there b

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-16 Thread Marcus Meissner
On Mon, Jul 16, 2012 at 07:12:59AM +0200, Eduard Hasenleithner wrote: > Am 2012-07-15 22:04, schrieb GOUJON Alexandre: > >On 07/14/2012 09:14 PM, Eduard Hasenleithner wrote: > >>[...] > >>This means that the drive letter assigned for the sd card will not be > >>returned in GetLogicalDrives(). When

Re: Debugging wine/windows applications

2012-07-07 Thread Marcus Meissner
On Sat, Jul 07, 2012 at 01:25:12PM +0300, John Yani wrote: > I tried "WINELOADER=./wine winedbg --gdb notepad" > > And its output is the same as "./wine winedbg --gdb notepad" Well, i have a installed wine... but doing this there: wine winedbg.exe --gdb notepad.exe 0042:0043: create process 'C

Re: Debugging wine/windows applications

2012-07-07 Thread Marcus Meissner
On Sat, Jul 07, 2012 at 01:11:42PM +0300, John Yani wrote: > Did you mean './wine winedbg --gdb notepad'? Because I can't find winedbg > binary. This would be the same. There usually is a "winedbg" wrapper installed that does the same, but for all purposes its the same thing. Ciao, Marcus

Re: Debugging wine/windows applications

2012-07-06 Thread Marcus Meissner
On Sat, Jul 07, 2012 at 12:17:00AM +0300, John Yani wrote: > I tried to run wine under gdb and failed. Using multiprocess gdb I > endup with weird trace: > > 0xf7ffd430 > 0x7bc846f9 > 0x7bc8480f > 0x7bc84855 > 0x7bc42a94 > 0x7bc433b1 > 0x7b8772f7 > 0x7ebab89b > 0x7b

Re: Building WoW64 packages

2012-06-25 Thread Marcus Meissner
On Mon, Jun 25, 2012 at 11:21:33PM +0200, Hilko Bengen wrote: > Hi, > > after the effort on the Debian wine packages has progressed to a point > where it's likely that we'll release wheezy with a stable wine version > that is not completely out of date, I'd like to take things a step > further. >

Re: DllMain() seems unused in ntoskrnl.exe

2012-06-14 Thread Marcus Meissner
On Wed, Jun 13, 2012 at 07:46:47PM +0200, Francois Gouget wrote: > > The DllMain() function in ntoskrnl.exe appears to be unused: making > it static causes a compiler warning to that effect and removing it > entirely does not cause a compilation failure. Should it be removed or > is there a bui

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"

2012-06-06 Thread Marcus Meissner
On Wed, Jun 06, 2012 at 11:56:06AM +0200, Jacek Caban wrote: > On 06/06/12 11:52, Alexandre Julliard wrote: > > Jacek Caban writes: > > > >> This usage of list is broken here as well. list_init should be called > >> before list_add_head (so calling it early in initialization code will > >> fix bot

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"

2012-06-06 Thread Marcus Meissner
On Wed, Jun 06, 2012 at 11:31:52AM +0200, Jacek Caban wrote: > Hi Marcus, > > On 06/06/12 10:17, Marcus Meissner wrote: > > Hi, > > > > wine control.exe joy crashed in this line, as it should be wine > > control.exe joy.cpl. > > > > The list is

size of wine packages

2012-06-01 Thread Marcus Meissner
Hi, As we have crossed the 100MB installed size (stripped) for the Wine RPM packages (stripped), this makes a Wow64 capable installation taking around 200MB these days. Can we reduce this size? eg. kernel32.dll.so has 1.6MB of static data inside itself, which is puzzling me a bit. (winerror.re

Re: running 16bit code

2012-05-08 Thread Marcus Meissner
On Tue, May 08, 2012 at 12:06:23PM +0100, David Laight wrote: > On Tue, May 08, 2012 at 12:03:52PM +0200, Damjan Jovanovic wrote: > > On Tue, May 8, 2012 at 11:40 AM, David Laight wrote: > > > Does wine support running of 16bit windows apps? > > > If so does it rely on the underlying OS having sup

Re: Patch 85420

2012-04-17 Thread Marcus Meissner
On Tue, Apr 17, 2012 at 09:10:45PM +0200, Christian Costa wrote: > Hi, > > Patch http://source.winehq.org/patches/data/85420 is marked as > pending. I've taken a look but I still don't understand what's > wrong. > Is there anything I've missed ? I stopped reading at this line: +*frame =

Re: [PATCH] winealsa.drv: Init *num to 0 (Coverity)

2012-04-16 Thread Marcus Meissner
On Mon, Apr 16, 2012 at 11:53:00AM -0500, Andrew Eikum wrote: > On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote: > > Also initialize a "may be uninitialized" value the compiler sees. > > > > Not sure what this means. *num is initialized at the b

Re: Regression testing

2012-04-12 Thread Marcus Meissner
On Thu, Apr 12, 2012 at 10:23:07AM +0200, Daniel Jeliński wrote: > Hello all, > I am trying to get Microsoft SQL Server Management Studio to work > flawlessly under Wine. For the most part I create and triage related > bug reports, but recently I also started tinkering with code, > specifically wit

Re: 'Pending' patches state

2012-04-10 Thread Marcus Meissner
On Tue, Apr 10, 2012 at 04:52:42PM +0900, Dmitry Timoshkov wrote: > Jeff Latimer wrote: > > > I agree a lot of developers would benefit from feedback, however that > > does not appear to be the Wine way of doing business. Maybe a halfway > > measure would be to automatically notify the developer

Re: Wine and Window Management

2012-03-25 Thread Marcus Meissner
On Sat, Mar 24, 2012 at 07:12:14PM -0700, Roger Cruz wrote: >   > Could someone tell me if Wine has a built-in Window Manager of its own or > does it count on the host's window manager for such things as window > hierarchy (parent-child relationships), clipping, move, resize, iconify, > etc?  I

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-03-21 Thread Marcus Meissner
On Tue, Mar 20, 2012 at 06:40:37PM -0700, Joey Yandle wrote: > Hi everybody, > > As originally discovered by Carsten Juttner, Star Wars: The Old Republic > uses the time values in KUSER_SHARED_DATA to trigger network send > buffers. wine does not currently update these values, so TOR does not > m

Re: NtDelayExecution: reduce multiple stack allocation

2012-03-10 Thread Marcus Meissner
On Sat, Mar 10, 2012 at 04:20:20PM +0100, Ferdinand Nölscher wrote: > In ntdll/sync.c, line 1232 the struct "timeval" is being allocated in a > for-loop. > Would'nt it be faster if tv was created before entering the loop? > I have not tested doing so but I think that it would increase > performance

Re: [PATCH] README: updated Linux and FreeBSD kernels

2012-02-29 Thread Marcus Meissner
On Wed, Feb 22, 2012 at 10:44:31AM +0100, Francois Gouget wrote: > On Wed, 22 Feb 2012, Marcus Meissner wrote: > > > --- > > README | 13 ++--- > > 1 files changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/README b/README > > inde

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-15 Thread Marcus Meissner
On Thu, Feb 16, 2012 at 01:55:44AM +0300, Nikolay Sivov wrote: > The problem is that vsnprintf() was called multiple times with same > va_list. Ti fix that it was necessary to get rid of some tracing > bits like macro-defined callback calls and a single function for all > kinds of error types. > >

Re: Fwd: Google Summer of Code 2012 DEADLINE: 2012-02-27

2012-02-12 Thread Marcus Meissner
On Sat, Feb 11, 2012 at 03:56:43PM +, Jerome Leclanche wrote: > On Sat, Feb 11, 2012 at 2:50 PM, Maarten Lankhorst > wrote: > > > Hey Jeremy, > > > > Op 10-02-12 20:23, Jeremy White schreef: > > > > Hi Folks, > >> > >> It's that time of year again - summer of code is going to start up soon. >

Re: libgcrypt thread safety

2012-02-08 Thread Marcus Meissner
On Wed, Feb 08, 2012 at 02:48:06PM -0600, Adam Martinson wrote: > I've been looking into bug 27036 > , and it's due to the > lack of thread safety by default in libgcrypt (in this case via > libgnutls in secur32.dll). To be thread safe, libgcrypt requ

Re: SourceForge forbids download

2012-02-07 Thread Marcus Meissner
On Mon, Feb 06, 2012 at 10:31:01PM +0330, Aidin Gharibnavaz wrote: > Dear Wine developers, > > SourceForge blocked download for some countries by default, such as Iran. > (More detail can be found > here > ) > > So

Re: ntdll: Remove dead code

2012-02-05 Thread Marcus Meissner
On Sun, Feb 05, 2012 at 03:59:44PM +0100, André Hentschel wrote: > --- > dlls/ntdll/signal_x86_64.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 0fc53c7..e9cefb8 100644 > --- a/dlls/ntdll/signal_x8

Re: Rethinking WineConf

2012-01-17 Thread Marcus Meissner
On Tue, Jan 17, 2012 at 04:21:47PM -0600, Vincent Povirk wrote: > > Well, sure.  I was replying to a suggestion that we tack > > wineconf onto the side of, say, http://monospace.us/ > > by saying that I didn't think they'd be interested. > > Do you think they would be? > > Well, most of them are n

Re: What other conferences do Wine people attend?

2012-01-11 Thread Marcus Meissner
On Tue, Jan 10, 2012 at 02:55:33PM -0800, Dan Kegel wrote: > In the wineconf thread, the question came up: > What other conferences people do wine developers/users attend, if any? > > If you send me the names of the conference(s) you attended in the last > two years, > I'll summarize for the list.

Re: Rethinking WineConf

2012-01-10 Thread Marcus Meissner
On Mon, Jan 09, 2012 at 12:31:11PM -0600, Jeremy White wrote: > Hi All, > > This past Wine conference, while great fun as always, was not as well > attended as Wine conferences in the past. > > So I would like to stir up trouble by suggesting we rethink WineConf. > > For those that have not atte

Re: DIB crash with gdb

2011-12-25 Thread Marcus Meissner
On Fri, Dec 23, 2011 at 11:56:35PM -0600, Ken Thomases wrote: > > On Dec 23, 2011, at 3:10 PM, Michael Ost wrote: > > > This all makes sense, and pulls the code together for me. Thanks! > > You're welcome. > > > I assume this is a recent development, because I was successfully using gdb > > wi

Re: Regression testing breakthrough

2011-10-19 Thread Marcus Meissner
On Wed, Oct 19, 2011 at 04:18:50PM +0200, Frédéric Delanoy wrote: > On Wed, Oct 19, 2011 at 15:50, Marcus Meissner wrote: > > On Wed, Oct 19, 2011 at 02:42:29PM +0100, Ken Sharp wrote: > >> > >> > >> On 19/10/11 13:43, Frédéric Delanoy wrote: > >> &g

Re: Regression testing breakthrough

2011-10-19 Thread Marcus Meissner
On Wed, Oct 19, 2011 at 02:42:29PM +0100, Ken Sharp wrote: > > > On 19/10/11 13:43, Frédéric Delanoy wrote: > >On Wed, Oct 19, 2011 at 14:08, Joel Holdsworth > >wrote: > >>Alternatively, have you considered doing a .tar.gz of every build snapshot, > >>and placing that on a server somewhere? > >

Re: [Wine] WineHQ database compromise

2011-10-13 Thread Marcus Meissner
On Thu, Oct 13, 2011 at 10:23:58AM +0200, Maarten Lankhorst wrote: > Hey, > > On 10/12/2011 12:46 AM, Josh Juran wrote: > > On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > > > >> On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: > >> > >>> Since bugzilla passwords were sent in clearte

Re: [PATCH] ntdll: deal with images which override the section table during mapping

2011-10-10 Thread Marcus Meissner
On Mon, Oct 10, 2011 at 11:36:33AM +0200, Bernhard Loos wrote: > --- > dlls/ntdll/virtual.c | 38 ++ > 1 files changed, 34 insertions(+), 4 deletions(-) I think this needs tests, the algorithms are very fragile. Ciao, Marcus > diff --git a/dlls/ntdll/virtua

Re: [PATCH] server: if a debugger is attached to a process, child processes shouldn't get debugged (resend)

2011-10-07 Thread Marcus Meissner
On Fri, Oct 07, 2011 at 11:44:24AM +0900, Dmitry Timoshkov wrote: > Bernhard Loos wrote: > > > +int debug_childs:1; /* also debug all child > > processes */ > > 'debug_children' would be a better name. also unsigned intfoo:1; please. (int foo:1 works, but is s

Re: Problems with drawing text in 1.3.29

2011-10-05 Thread Marcus Meissner
On Wed, Oct 05, 2011 at 04:53:18PM +0100, Damian Dixon wrote: > Hi, > > I was attempting to use Wine 1.3.29 (in OpenSUSE 11.4 x86) and because of > issues pulled the source from git last night and still have problems. > > I am having performance issues with DrawText (5 odd seconds to draw a simpl

Re: ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets (try 2)

2011-10-04 Thread Marcus Meissner
On Tue, Oct 04, 2011 at 10:51:26AM -0600, Erich Hoover wrote: > Real Name: >     Erich Hoover > > Description: >     I know it's been quite a while, but I'm back with another solution > for Bug #7929. This patch uses SO_BINDTODEVICE in order to bind a > socket to a specific interface while still

Re: Alexandre's keynote

2011-10-03 Thread Marcus Meissner
On Sat, Oct 01, 2011 at 05:10:31PM -0500, Jeremy White wrote: > Thanks to Jon Parshall's hard work, we have Alexandre's keynote > available here: > > http://www.youtube.com/watch?v=2rdDvMonTnQ > > Remember to have your libation at hand so you can play the game... Thanks for doing that :) Int

Re: winscard

2011-09-30 Thread Marcus Meissner
On Fri, Sep 30, 2011 at 11:42:26AM +0200, Vincent Hardy wrote: > Hi all, > > Here are four patches that are a partial but functional > implementation of winscard. > > I installed "Belgian Electronic Identity Card MiddleWare" > (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) > > I tested w

Re: Ole16 to Ole32 mapping

2011-09-19 Thread Marcus Meissner
On Mon, Sep 19, 2011 at 10:00:48AM -0300, Bruno Jesus wrote: > Hi, I would like some advice about Ole function redirection. The > winsock16 dll maps some operations to ws2_32 dll, I thought I could do > the same with Ole16disp to Oleaut32. For example the function > SAFEARRAYALLOCDESCRIPTOR in Ole1

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length

2011-09-15 Thread Marcus Meissner
On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote: > --- > dlls/oleaut32/olepicture.c | 148 > +- > dlls/oleaut32/tests/olepicture.c | 16 ++--- > 2 files changed, 54 insertions(+), 110 deletions(-) Did make check work for you even? Marvin

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog

2011-09-01 Thread Marcus Meissner
On Tue, Aug 30, 2011 at 09:11:33PM -0300, Lucas Zawacki wrote: > > It doesn't make sense to pass the info as WM_INITDIALG parameter if it's > > going to be stored in global variables anyway. A better way would be to > > store this in the window info. > > > > Any pointers on what's the set of winap

Re: [4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval

2011-08-06 Thread Marcus Meissner
On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote: > --- > dlls/shlwapi/tests/string.c | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > > diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tests/string.c > index 68028d7..ecc58cc 100644 > --- a/dll

GSoC: dinput8 Action Mapping - dialog testing

2011-08-05 Thread Marcus Meissner
On Tue, Aug 02, 2011 at 06:25:49PM -0300, Lucas Zawacki wrote: > Hello. I need some help here. > > Before commiting the ConfigureDevices patches tried to add a couple > simple tests for the function, the problem is that I now have to test > a dialog. What is the best way to do it? I'm thinking of

Re: GSoC: dinput8 Action Mapping

2011-08-01 Thread Marcus Meissner
On Fri, Jul 29, 2011 at 05:48:43PM -0300, Lucas Zawacki wrote: > Hello! > > Here's a lot of patches with a ConfigureDevices implementation. These > patches can be tested with this app I built that uses ConfigureDevices > to set up a joystick action mapping > (https://github.com/downloads/lfzawacki

Re: comctl32: Remove dead increments (clang)

2011-07-26 Thread Marcus Meissner
On Tue, Jul 26, 2011 at 09:15:57PM +0200, André Hentschel wrote: > --- > dlls/comctl32/propsheet.c |1 - > dlls/comctl32/rebar.c |2 -- > 2 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/propsheet.c b/dlls/comctl32/propsheet.c > index f711399..3dd0713 10

Re: GSoC: dinput8 Action Mapping

2011-07-21 Thread Marcus Meissner
On Tue, Jul 19, 2011 at 09:40:37PM -0300, Lucas Zawacki wrote: > Hey, I've got a couple patches implementing build and setactionmap for > joysticks and I'd like you guys to give them a look. The patches look good to my eyes. This part: > +if ((lpdiaf->rgoAction[i].dwSemantic & genre) ==

build error in dlls/d3dx9_36/tests/math.c

2011-07-09 Thread Marcus Meissner
Hi, I get on dlls/d3dx9_36/tests/math.c: (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev ) gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-af

Re: ws2_32: Remove dead assignment (Clang)

2011-07-06 Thread Marcus Meissner
On Wed, Jul 06, 2011 at 10:57:12AM +0200, Marcus Meissner wrote: > On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > > --- > > dlls/ws2_32/socket.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/dlls/ws2_3

Re: ws2_32: Remove dead assignment (Clang)

2011-07-06 Thread Marcus Meissner
On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_3

Re: Random crashes while running (cmd) test runner

2011-07-04 Thread Marcus Meissner
On Mon, Jul 04, 2011 at 02:01:31PM +0200, Frédéric Delanoy wrote: > On Mon, Jul 4, 2011 at 13:37, Marcus Meissner wrote: > > On Mon, Jul 04, 2011 at 12:32:47PM +0200, Frédéric Delanoy wrote: > >> 2011/7/4 Stefan Dösinger : > >> > Am 04.07.2011 um 10:28 schrieb M

Re: Random crashes while running (cmd) test runner

2011-07-04 Thread Marcus Meissner
On Mon, Jul 04, 2011 at 12:32:47PM +0200, Frédéric Delanoy wrote: > 2011/7/4 Stefan Dösinger : > > Am 04.07.2011 um 10:28 schrieb Marcus Meissner: > >> export WINEDEBUG=+heap > > WINEDEBUG=warn+heap adds the corruption checking but not the debug output > > I ge

Re: Random crashes while running (cmd) test runner

2011-07-04 Thread Marcus Meissner
On Sat, Jul 02, 2011 at 09:31:52PM +0200, Frédéric Delanoy wrote: > Hi folks, > > I'm in the process of writing a couple of cmd tests (on top of master, > not of my currently pending patches), and I at times have problems > where none of the tests is actually performed, but the test suite > still

Re: [PATCH] advapi32: Set *lpSize properly in GetUserNameA (try2)

2011-07-04 Thread Marcus Meissner
On Sat, Jul 02, 2011 at 11:49:44AM +0300, Alex Stanev wrote: > > --- > dlls/advapi32/advapi.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c > index e135fa5..7025a21 100644 > --- a/dlls/advapi32/advapi.c > +++ b/dll

Re: GSoC: dinput8 Action Mapping

2011-06-30 Thread Marcus Meissner
On Thu, Jun 30, 2011 at 02:56:08AM -0300, Lucas Zawacki wrote: > Hey guys, how are you doing? I've got some patches for you. > > The first is a refactoring of the BuildActionMap implementations for > keyboard and mouse. I think with 'semantic_to_obj_id' the mapping is > pretty much correct for ke

Re: GSoC: dinput8 Action Mapping

2011-06-25 Thread Marcus Meissner
On Fri, Jun 24, 2011 at 01:37:41PM -0300, Lucas Zawacki wrote: > Is there any problem with the latest patches I sent? They're sitting > there with the 'New' status but I have no feedback (good or bad) about > them. I think there are still in the backlog. If there are not in Mondays commit round, r

Disablin xinput2 for now?

2011-06-20 Thread Marcus Meissner
Hi, There seem to be regressions in xinput2 support, http://bugs.winehq.org/show_bug.cgi?id=27028 As this might be a X.org issue, should we packagers turn off xinput2 support for the time being? Ciao, Marcus

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Marcus Meissner
On Tue, Jun 14, 2011 at 02:07:32PM -0300, Lucas Zawacki wrote: > > Also please implement unicode method and call it from ascii. > > (IDirectInput8AImpl_EnumDevicesBySemantics -> > > IDirectInput8WImpl_EnumDevicesBySemantics) > Sorry if that's a stupid question, but what should I do with the > str

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Marcus Meissner
On Mon, Jun 13, 2011 at 07:17:04PM -0300, Lucas Zawacki wrote: > OK, so here is my second try at some patches. These mostly implement > keyboard action mapping and there's plenty of tests to go together > with it. I believe the keyboard part is pretty much done, as is > SetActionMap. Of course I'm

Re: GSoC: dinput8 Action Mapping

2011-06-13 Thread Marcus Meissner
On Sun, Jun 12, 2011 at 10:45:38PM -0300, Lucas Zawacki wrote: > I'm having some issues with test that inject input. For instance this > code ( http://pastebin.com/gan0Niqj ) works as expected under wine and > wine with dinput8.dll , but fails in every windows version... I tried > a version with Se

Re: cmd: ensure create_full_path returns FALSE for all errors

2011-06-04 Thread Marcus Meissner
On Sat, Jun 04, 2011 at 04:37:05PM +0200, Frédéric Delanoy wrote: > This resolves the issue from bug #27383 > --- > programs/cmd/builtins.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c > index 0352e59..18e16fe 1006

Re: GSoC: dinput8 Action Mapping

2011-05-30 Thread Marcus Meissner
On Sun, May 29, 2011 at 07:18:03PM -0300, Lucas Zawacki wrote: > Hey guys. So last week I finally got a good understanding of dinput as > a whole and nailed some trivial cases of action mapping, the ones with > the keyboard. I'm sending a series of patches so everyone can take a > look before I try

  1   2   3   4   5   6   7   8   9   >