RY, len);
> +}
> +
> +static inline void *urlmon_realloc(void *mem, size_t len)
> +{
> +return HeapReAlloc(GetProcessHeap(), 0, mem, len);
> +}
> +
> +static inline BOOL urlmon_free(void *mem)
> +{
> +return HeapFree(GetProcessHeap(), 0, mem);
> +}
> +
>
he best approach.
-W is the old name for the gcc argument; the new name for it is -Wextra
which describes the warnings better: extra warnings; might be legit but
can be bogus.
> }
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer
when building wasn't part of the default make target.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Reg. Adresse: Red Hat GmbH, Haupt
tead
>> of terminating the app.
>>
>>
> Can you give an example? The Start utility already uses ExitProcess()
> if you means this...
>
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-
gh, but changelog doesn't
> provide enough information to distinguish them.
>
>> +Brouard Nicolas
>
> Again a duplicate due to the reversed last/first names.
>
>> +Tom Spear
>
> Not sure if have him already under an old name (can't remember which one).
>
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
//temporary buffer was created
> + HeapFree(GetProcessHeap(), 0, lpReorderBuffer);
> +}
> +
> return TRUE;
> }
thanks
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Alexandre Julliard wrote:
> Michael Stefaniuc <[EMAIL PROTECTED]> writes:
>
>> Actually it's not a cast. It's a heuristic that the compiler has to make
>> to detect a NULL pointer. The best heuristic for this is (char *) 0.
Duh ... that should have been (
ry. It compiled without warning here,
> even with -Wall. Doesn't the C standard says that 0 casts to a
Actually it's not a cast. It's a heuristic that the compiler has to make
to detect a NULL pointer. The best heuristic for this is (char *) 0.
This is a limitation of the
Dan Hipschman wrote:
> On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote:
>> Dan Hipschman wrote:
>>> This is just a minor cleanup patch. Even if we're definitely sure a
>>> string doesn't contain any % signs, it's still better not to use
ntf(stderr, usage);
> + fprintf(stderr, "%s", usage);
>return 1;
> }
>}
> @@ -458,7 +458,7 @@ int main(int argc,char *argv[])
>input_name = xstrdup(argv[optind]);
>}
>else {
> -fprintf(stderr, usage);
> +fprintf(stderr, &q
al build process.
That's why the right way to keep the source tree clean is to use a
separate build dir. That way a "make reallyclean" is a simple "rm -r
$wine_build_dir".
bye
michael
--
Michael Stefaniuc
ady a couple too many sound drivers in Wine and none of
which are great. Alexandre won't accept yet another sound driver in
Wine. He would like to have one sound driver working perfect (probably
winealsa).
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr.
ProcessHeap(), 0, pDstStrW);
>> return hr;
>> }
>
> This is a bikeshed issue really, but I wonder what Wine's policy on
> gotos like this is. Imo, it's better to add the HeapFree call to the if
> block and let the compiler work it out.
It really dep
TANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved)
> +{
> +TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved);
> +
> +switch (fdwReason)
> +{
> +case DLL_PROCESS_ATTACH:
> +DisableThreadLibraryCalls(hinstDLL);
> +
es from Microsoft can't contribute to wine.
That referred to the stolen ones or those you can look at when you sign
a NDA. ATL, MFC and msvc are different; you just cannot work on those
DLLs in Wine.
bye
michael
--
Michael Stefaniuc Tel
uot;can't notify client !\n");
> - return MMSYSERR_INVALPARAM;
> +if (lpNewData)
> + HeapFree(GetProcessHeap(), 0, lpNewData);
> + return MMSYSERR_INVALPARAM;
> }
> +if (lpNewData)
> +HeapFree(GetProcessHeap(), 0, lpNewData);
> return MMSYSERR_NOERROR;
> }
>
>
&g
by the tag; that one has the right date. E.g "tag wine-0.0.2" references
"commit 2c25c3e9442c69bd2402f94f264f0aafa58b00e0" which has as
"CommitDate: Tue Jun 29 16:33:12 1993 +".
> (I've changed the necessary perl-script to only include the
m running the test.
>
> If there are no objections, I'll sent the necessary patches in a few days.
>
> Bit off topic:
> One thing that struck me was the difference in test results for the Wine
> runs. This has most likely to do with old Wine installations running new
> te
obals.hfont = CreateFontIndirect(&logfont);
> return opts;
> }
>
> @@ -1624,11 +1686,13 @@ static void save_registry_settings(void)
> WINDOWINFO wi;
> HKEY hKey;
> INT width, height;
> + LOGFONT logfont;
>
> wi.cbSize = sizeof( WINDOWINFO );
> GetWindowInfo(Globals.hMainWnd, &wi);
> width = wi.rcWindow.right - wi.rcWindow.left;
> height = wi.rcWindow.bottom - wi.rcWindow.top;
> + GetObject(Globals.hfont, sizeof(logfont), &logfont);
>
> if ( RegOpenKeyEx( HKEY_CURRENT_USER, registry_key,
> 0, KEY_SET_VALUE, &hKey ) != ERROR_SUCCESS )
> @@ -1651,6 +1715,34 @@ static void save_registry_settings(void)
> (LPBYTE) &width, sizeof(DWORD) );
> RegSetValueEx( hKey, reg_height, 0, REG_DWORD,
> (LPBYTE) &height, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_height, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfHeight, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_width, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfWidth, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_escapement, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfEscapement, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_orientation, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfOrientation, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_weight, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfWeight, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_italic, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfItalic, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_underline, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfUnderline, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_strikeout, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfStrikeOut, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_charset, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfCharSet, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_outprecision, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfOutPrecision, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_clipprecision, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfClipPrecision, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_quality, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfQuality, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_pitchandfamily, 0, REG_DWORD,
> +(LPBYTE) &logfont.lfPitchAndFamily, sizeof(DWORD) );
> + RegSetValueEx( hKey, reg_font_facename, 0, REG_SZ,
> +(LPBYTE)
> &logfont.lfFaceName,(strlenW(&logfont.lfFaceName) + 1)*sizeof(WCHAR));
>
> /* TODO: Save more settings here (List vs. Detailed View, etc.) */
> RegCloseKey( hKey );
>
>
>
>
>
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
etAppCompatFlags2
> @ stdcall GetAppCompatFlags(long)
> +@ stdcall GetAppCompatFlags2(long)
> @ stdcall GetAsyncKeyState(long)
> @ stdcall GetCapture()
> @ stdcall GetCaretBlinkTime()
>
>
>
>
>
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
11bb71d3d6a34d301291b2d15c849a1381bd7789
>> URL:
>> http://source.winehq.org/git/wine.git/?a=commit;h=11bb71d3d6a34d301291b2d15c8
>>
>> 49a1381bd7789
>
>> Author: Michael Stefaniuc <[EMAIL PROTECTED]>
>> Date: Mon Jul 23 22:25:20 2007 +0200
t;
> from winehq.org and be shure that your application will work.
> This maintained snapshot could be released every 6 month with a good
> regretion tests.
Something like that is the plan for Wine-1.0.
> Of course you will say that Codeweavers already do that, but due to the
> pr
own the copyright to relicense
their work.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
comctl32.dll -T
../../.. -p comctl32_test.exe.so
/home/michi/work/wine/dlls/comctl32/tests/monthcal.c && touch monthcal.ok
monthcal.c:773: Test succeeded inside todo block: Expected 65536, got 65536
make[2]: *** [monthcal.ok] Error 1
bye
michael
--
Michael Stefaniuc
Tom Wickline wrote:
I was wondering if there are any plans in place for Wine to move to
the newly revised LGPL 3 licence before the release of 1.0?
http://www.gnu.org/licenses/lgpl.html
Why should Wine move?
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr
plaining about dead code
after the return.
> +{
> +skip("GetPrivateProfileSectionNamesW is not implemented\n");
> +DeleteFileA( testfile3 );
> +return;
> +}
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
msg 0x0202 instead
msg.c:5878: Test failed: Alt+MouseButton press/release: the msg 0x0105 was
expected, but got msg 0x0202 instead
msg.c:5878: Test failed: Alt+MouseButton press/release: the msg sequence is not
complete: expected - actual 0105
make[2]: *** [msg.ok] Error 9
bye
micha
OpenGL application in that case and not only wine.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D
pso, though. It will be interesting to see how the
two checkers do at finding NULL dereferences.
The problem with NULL pointer dereferences is that those may be valid.
If a function crashes in Windows on a NULL pointer dereference Wine
should/has do the same.
bye
michael
--
Michae
-fonts rpm is already in Fedora Extras for FC6
and in Fedora 7.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www
that dlls/uxtheme/draw.c uses this definition so must also be patched.
Please merge those 2 changes into one patch as one without the other
make the Wine source to not compile anymore. And please use unified diff
format; the draw.c.patch isn't a unified diff.
bye
michael
--
Michael St
*, LPVOID *);
+
+
+#endif /* __WINE_HNETCFG_DLL_H */
--------
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
ing is already present in the enviroment.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
> occupying Wine versions delta >= 1, usually I do:
>
> $ rm -rf dlls/; git checkout -f
>
> after every
>
> $ git bisect [bad|good]
>
> and before running ./configure .
Cleaner would be to use a separate build directory which you can remove
before each $SOURCE_
Michael Stefaniuc wrote:
> Misha Koshelev wrote:
>
>>Hi, thank you very much for your help.
>>
>>I am implementing Installer::RegistryValue for MSI OLE automation and I need
>>a way to tell apart
>>a VT_EMPTY and a VT_I4 type variant with a value of 0 as these
gt; am using DispGetParam for everything else.
Dumb question: if you already have the variant why don't you use the
V_VT() macro on it to its type?
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
o dlls/winex11.drv/ makes more sense.
> +++
> 1 files changed, 154 insertions(+), 0 deletions(-)
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-71
an origin Wine checkout and then on my
modified tree and see if i get any additional failures/successes.
> 2. How to fix the VarBstrFromDate?
>
> VarBstrFromDate(-657434.0 (DATE_MIN), 0x409, 0x8000, wherever)
> fails because VariantTimeToSystemTime successfully converts that to
> 1
00644
index 000..47056cd
--- /dev/null
+++ b/dlls/sxs/sxs.spec
@@ -0,0 +1,2 @@
+@ stub CreateAssemblyNameObject
+@ stub CreateAsseblyCache
^^^ Typo?
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.:
HTMLBodyElement_put_background(IHTMLBodyElement
> *iface, BSTR v)
> {
> HTMLBodyElement *This = HTMLBODY_THIS(iface);
> -TRACE("(%p)->(%s)\n", This, debugstr_w(v));
> +FIXME("(%p)->(%s)\n", This, debugstr_w(v));
It should then include "Stub"
now that. I'll use
LANG_NEUTRAL as long as somebody more knowledgeable dosn't change it.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECT
Alexandre Julliard wrote:
> Michael Stefaniuc <[EMAIL PROTECTED]> writes:
>
>> Ok, as there are no false positives i have improved the script a little;
>> documented it on my Smatch page and added it to my daily Smatch run.
>> If you know more functions that return
Michael Stefaniuc wrote:
> Francois Gouget wrote:
>
>>On Wed, 7 Mar 2007, Michael Stefaniuc wrote:
>>[...]
>>Sending patches...
>
> Send a patch too for the additional occurence that the improved script
> has found.
Duh ... I mean I have sent a patch already fo
Francois Gouget wrote:
> On Wed, 7 Mar 2007, Michael Stefaniuc wrote:
> [...]
>
>>You mean something like
>>http://people.redhat.com/mstefani/wine/smatch/scripts/file_handles.pl ?
>
>
> Cool, thanks.
>
>
> [...]
>
>>Most are fa
. In fact they may
>>possibly be removed altogether.
>
>
> Note that a valid file handle will never be NULL, so while these
> checks are wrong in theory, in practice it makes no difference.
Well, in one of the found cases (one of the RPCRT) the code was setting
the file handle
7;hFile' with 0.
dlls/dbghelp/pe_module.c 145 pe_load_dbg_file(52) Comparision of the
file handle 'hFile' with 0.
programs/rpcss/np_server.c 393 RPCSS_NPConnect(57) Comparision of the
file handle 'the_pipe' with 0.
Most are false positives (non NULL check before CloseHandle()).
Lei Zhang wrote:
> On 2/12/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> Lei Zhang wrote:
>> > Also, the patch from 2007/04/17 only removed -DWINE_NO_DEBUG_MSGS /
>> > -DWINE_NO_TRACE_MSGS from configure, but not from
>> > include/wine/debug.h.
>&
gging messages? According to
>> http://winehq.org/site/docs/winedev-guide/dbg-compiling, I can pass
>> --disable-debug, but the Changelog says that option was removed about
>> 10 month ago.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network En
se such change must not be performed, I'll just
> add a local variable which is a casted version.
> I thought this needs asking; adding in unnecessary
> variables doesn't seem the best fix to me.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr
. And
Pierre is working to move code out of winex11.drv and into the GDI and
User dlls to not have to duplicate it again in winequartz.drv.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbH
7;s safe in our implementation) - and I'm
> wondering if we really want to internally use undocumented functions
> with unclear semantics when there is an easy (documented) way.
>
> And besides - the comctl32 code is full of "if(p) Free(p);"...
Looks like i need to
pleHandles(long long long ptr ptr)
> @ stdcall CreateAntiMoniker(ptr)
> @ stdcall CreateBindCtx(long ptr)
> @ stdcall CreateClassMoniker(ptr ptr)
>
>
>
>
>
--
Michael Stefaniuc
C"
> +#define RASDT_Serial "SERIAL"
> +#define RASDT_FrameRelay "FRAMERELAY"
> +#define RASDT_Atm"ATM"
> +#define RASDT_Sonet "SONET"
> +#define RASDT_SW56 "SW56"
> +#define RASDT_Irda "IRDA"
> +#define RASD
the system, and it's not a standard macro anyway.
> The best way (other than just naming all the structs/unions) is to test
> for __STDC__, but GCC includes that one even when not using -ansi mode.
>
> Thoughts?
See above.
bye
michael
--
Michael Stefaniuc Tel.
size vartest.o with -O2
before 9s 38s 60s 870s750s1352256
after 3s 23s 35s 41s 42s 474300
I would say impressive, especially the -O3 and -Os changes.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engi
4, ULONG64, VarI8FromUI8, I8_MAX);
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
LS(36)
> +DEFINE_SMapLS(40)
Are you sure this compiles? You removed the semicolon in the macro
definition and when it is used. And even if it compiles the code needs
to look like C code.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
Paul Vriens wrote:
> Michael Stefaniuc wrote:
>> Alexandre Julliard wrote:
>>> Module: wine
>>> Branch: master
>>> Commit: 6338caa9eda8eda98dad9a89a8e71c6ea37bd168
>>> URL:
>>> http://source.winehq.org/git/wine.git/?a=commit;h=6338caa9eda
BindCtx_RegisterObjectParam(bind, sz_html_clientsite_objectparam,
> (IUnknown*)&ClientSite);
>
> SET_EXPECT(GetDisplayName);
>
>
>
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer
NameW;
> -keyProvInfo.pwszProvName = (LPWSTR)MS_DEF_PROV_W;
> +keyProvInfo.pwszContainerName = cspNameW;
> +keyProvInfo.pwszProvName = ms_def_prov_w;
> keyProvInfo.dwProvType = PROV_RSA_FULL;
> keyProvInfo.dwFlags = 0;
> keyProvInfo.cProvParam = 0;
bye
michael
that 'static const WCHAR ms_def_prov_w[]' fixes the compilation
error but renders the exercise moot.
>
> static void testCertProperties(void)
> {
>
>
> ---
>
> dlls/crypt32/tests/cert.c | 113
> ++---
> 1 files chang
05 por Andreas Mohr,
> Hannu Valtonen e Jonathan Ernst."
> + IDS_ABOUTTITLE, "Acerca do Desinstalador"
> + IDS_REGISTRYKEYNOTAVAILABLE, "Chave de registo de desinstalação não
> disponível (ainda), nada a fazer !"
> + IDS_UNINSTALLFAILED, "Ex
to cope with
#pragma code_page(65001) /* UTF-8 */
and use that once and for all. UTF-8 is now the default on more and more
distributions and "errors" like above will keep creeping in.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network En
> Any idea's?
If this is such a common operation why not create a macro for that too.
Something like
#define ARRAY_ZERO_LAST(x) ((x)[ARRAY_SIZE(x)-1] = '\0')
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer
t;composition_start;
> es->selection_end = es->selection_start + es->composition_len;
>
> -HeapFree(GetProcessHeap(),0,lpCompStrAttr);
> +if (lpCompStrAttr)
> +HeapFree(GetProcessHeap(),0,lpCompStrAttr);
This change is not needed as HeapFree'ing
'.','n','t','a','m','d','6','4',0};
There was also a Windows for IA64 aka Itanium CPUs. Not sure if the
.ntia64 needs to stay in.
bye
michael
> #else /* FIXME: other platforms */
> static
e ^
> +TRACE("mah.dwStreams=%d\n", infoPtr->mah.dwStreams);
> +TRACE("mah.dwSuggestedBufferSize=%d\n",
> infoPtr->mah.dwSuggestedBufferSize);
> +TRACE("mah.dwWidth=%d\n",infoPtr->mah.dwWidth);
> +TRACE("mah.dwHeight=%d\n", infoPtr->mah.dwHeight);
>
> mmioAscend(infoPtr->hMMio, &mmckInfo, 0);
>
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
t; GetLastError returns a DWORD, so these formats need to be %d, not %ld.
> There is already a big effort to clean these up, so we don't need to
> introduce more.
Yes, but lz32 isn't converted yet so he is correct. I didn't do lz32 as
he was working on it and I didn't want t
f we have problems due to new
> definitions in e.g. d3d10. For now we are safe as we filter out flags which
> are invalid in d3d8 / d3d9.
>
>
>
>
>
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
h git it should
> be MUCH easier.
Can this be done by anybody or does one need to be a Wine D3D guru for
that? If the task is easy it would be a good addition to
http://wiki.winehq.org/JanitorialProjects .
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
n't like
VT_ERROR as input. Well except VarCmp when both input variants where
VT_ERROR it would return "equal".
> the only app that gets further with this patch. See also bug 6166.
>
> I guess a test case is the only answer.
Definitely.
bye
michael
--
Michael Ste
Michael Stefaniuc wrote:
> For all the people wanting to help out with this janitorial task please
> wait until Alexandre commits this patch series. After that i'll create a
> page for this task on the Wine wiki and link it from
> http://wiki.winehq.org/JanitorialProjects
Ok, thi
ata;
> -test->default_data = &transform_default_data;
> -test->initial_data = &transform_default_data;
> -test->poison_data = &transform_poison_data;
> + test->test_data_in = (void*) &transform_test_data;
> +test->test_data_out = (void*) &tra
gt; > tab.c:184: Test failed: no icon, set size: Expected [54,20] got
>> [56,20]
>> >> > make[2]: *** [tab.ok] Error 6
>> >> >
>> >> Succeeds over here.
>> >>
>> >
>> > I know, it succeeds on a lot of machines,
; V_VT(Headers) != VT_EMPTY) {
> +if(Headers && V_VT(Headers) != VT_EMPTY && V_VT(Headers) != VT_ERROR) {
> if(V_VT(Headers) != VT_BSTR)
> return E_INVALIDARG;
>
>
>
>
] got [56,20]
>>tab.c:208: Test failed: no icon, set size: Expected [42,20] got [54,20]
>>tab.c:184: Test failed: no icon, set size: Expected [44,20] got [56,20]
>>tab.c:184: Test failed: no icon, set size: Expected [54,20] got [56,20]
>>make[2]: *** [tab.ok] Error
pcMgmtSetServerStackSize(unsigned int ThreadStackSize)
> +RPC_STATUS WINAPI RpcMgmtSetServerStackSize(unsigned long ThreadStackSize)
> {
>FIXME("(0x%x): stub\n", ThreadStackSize);
>return RPC_S_OK;
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engine
Elie Morisse wrote:
> A new version of my refcounting patch, lighter and honoring Stefan Dösinger
> proposal.
You forgot to attach the patch.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Ha
,"FIXME: i cheated and changed reserved IP
address 240.*/4 to 255.*.\n");
+ *target |= 0x00FF;
+ //printf("%x\n",*target);
+ }
+
n = sendmsg(fd, &hdr, dwFlags);
out:
-------
s I should invest time in the imap send stuff ;)
You can add custom email headers in the git config for git-format-patch.
There's where i add the "To: [EMAIL PROTECTED]". Then i just do a
mutt -H 0001-.
and send the email normally (not bounce it).
bye
michael
-
eturn value of setsockopt() first.*/
>> +SetLastError(0);
>> +
>
>
> 0 is ERROR_SUCCESS, and you need to use that define.
find -name '*.[ch]' | xargs grep 'SetLastError( *0 *)' | wc -l
117
Time for a new Janitorial mini task?
bye
michael
--
Mi
uoted from "The C Programming Language" second edition by Kernighan and
Ritchie with the subtitle "ANSI C".
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbH
ase (handles at
least 50% of the real life cases). As the old MSIMAXHANDLES was good
enough for a whole lot of programs i would define that as common case to
save me work of finding what the common case is.
> +msihandletable = msi_alloc_zero(1*sizeof(msi_handle_info));
> +}
&g
migrate
to git ;)
> My changes to the website reflect that support for CVS may not last
> forever...
Are there any plans to get rid of CVS? I would guess keeping the CVS
tree sync from the git tree is low maintanance so it can be kept around
"forewever".
bye
michael
--
Mic
that we have git
and everybody is happy with it.
Also everybody knows that vim is better than emacs ;)
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
the memory areas do overlap.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
you end up having to replace a lot of the infrastructure at the
beginning of the file (macros, defines and that like) than it's not
worth the effort.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbH
I guess Wine needs a patch to make it stop working
as uid 0 ...
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
Windows and 32bits in Win32.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
une, at least not after
you did a disruptive change to your repository.
>
> I'll let you know if that's right if I ever grok the
> structure... :-/
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711
t.
I like how it's done for git in fedora extras: git is a meta package
which requires all subpackages making it very easy and intuitive to get
it. So having something like wine being the meta package and the actual
wine subpackage being renamed to wine-core would give the user
friendliness an
Please disregard this patch as a false positive crept in.
Michael Stefaniuc wrote:
> hopefully this should be the last round of redundand NULL checks before
> HeapFree removals. I know, famous last words. But this time i have
> extended the redundant_null_check.pl Smatch script to fin
Ivan Gyurdiev wrote:
>
>> >From nobody Mon Sep 17 00:00:00 2001
>>
>
> Please delete this line in case the patch is corrupt.. missed it
The patch is not corrupted as it starts only with the '---' line.
bye
michael
--
Michael Stefaniuc
Michael Stefaniuc wrote:
> can somebody more familiar with this code confirm that on the error
> paths the CriticalSection should be released? I'm not sure about it as
> the function is supposed to keep the lock held when exiting without
> error; there is a d3ddevice_unlock_updat
el
P.S.: Let the flame war begin. ;)
>
>> A number of people said:
>> "The code is too hard to read because it's
>> completely unmovitated and uncommented."
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer
nd the time of the
> commit, so you could use that to build a top-10 of the developers with
> the best patch-to-commit times ;-)
Wont work quite well as the time of the change can be way older than the
time the developer submitted his patch.
bye
michael
--
Michael Stefaniuc
le" is not in git, so you need to run ./configure anyway?
>
>
> Well, yes, but what is changed in the tree after I checkout master branch
> back? If nothing changes, why make is complaining?
Does configure change between your two branches? That would explain it.
bye
mic
on my
> x86_64 system. However, wine resists.
> What am I doing wrong ? What's the correct way ?
>With regards, Pavel Trolle
>
>
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
uot; warning?
Where have you seen the wHite-string? I see only wRite-string in his email.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart
501 - 600 of 713 matches
Mail list logo
