I don't think this is going to work correctly when replacing hotkeys
(by passing an already-registered hwnd and id to RegisterHotKey with a
different key combination). Since the user driver's RegisterHotKey
function will be called with the new id/vkey/flags before
UnregisterHotKey is called for
On 09/18/2013 09:47 AM, Alistair Leslie-Hughes wrote:
+LIST_FOR_EACH_ENTRY(cursor,This-errors, struct ErrorEntry, entry)
+{
+if(nCnt == ulRecordNum)
+{
+*pErrorInfo = cursor-info;
+break;
+}
+}
+
This looks wrong, cause you never update
On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote:
---
dlls/ntdll/tests/file.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index 120fdac..5ae605b 100644
--- a/dlls/ntdll/tests/file.c
+++
Nikolay Sivov nsi...@codeweavers.com wrote:
--- a/dlls/ntdll/tests/file.c
+++ b/dlls/ntdll/tests/file.c
@@ -1985,6 +1985,22 @@ static void test_read_write(void)
bytes = 0xdeadbeef;
SetLastError(0xdeadbeef);
+ret = ReadFile(INVALID_HANDLE_VALUE, buf, 0,bytes, NULL);
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2207
Your paranoid
On 17 September 2013 21:07, Stefan Dösinger ste...@codeweavers.com wrote:
I might have misunderstood what you meant with separate flags for
each GL resource type. Did you mean something like this
B8G8R8A8_UNORM.flags[texture2d] = RENDERTARGET | TEXTURE | ...;
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2209
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2210
Your paranoid
Hey Dmitry,
I noticed a couple of tests structured like this:
status = pNtWriteFile(hfile, 0, NULL, NULL, iob, contents,
sizeof(contents), offset, NULL);
ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see
below */, expected STATUS_PENDING, got %#x\n, status);
ok(iob.Status ==
Thomas Faber thfa...@gmx.de wrote:
I noticed a couple of tests structured like this:
status = pNtWriteFile(hfile, 0, NULL, NULL, iob, contents,
sizeof(contents), offset, NULL);
ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see
below */, expected STATUS_PENDING, got
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2211
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2212
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2215
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2214
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2217
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2221
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=
Your paranoid
On 2013-09-18 11:31, Dmitry Timoshkov wrote:
Thomas Faber thfa...@gmx.de wrote:
status = pNtWriteFile(hfile, 0, NULL, NULL, iob, contents,
sizeof(contents), offset, NULL);
ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below
*/, expected STATUS_PENDING, got %#x\n,
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2228
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2229
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2236
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2230
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2235
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2233
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2238
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2231
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2232
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2237
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2234
Your paranoid
On Sep 16, 2013, at 1:21 PM, Ken Thomases wrote:
On Sep 16, 2013, at 12:55 PM, Alexandre Julliard wrote:
It's better to avoid adding entry points that don't correspond to
Windows APIs. Instead you should request the info when you need it.
Cocoa makes use of the size limits spontaneously,
Jacek Caban ja...@codeweavers.com writes:
---
dlls/mshtml/navigate.c | 3 ---
1 file changed, 3 deletions(-)
It doesn't work here:
../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p
urlmon_test.exe.so url.c touch url.ok
url.c:3397: Test failed: mon should be destroyed here
On 09/14/2013 12:14 AM, Scott Ritchie wrote:
Over the past couple years I've been able to try out Wine games on many
different environments -- laptops, desktops, even cloud servers.
On many occasions, I've discovered that a game appears to run
functionally but slowly, however upon further
Am 10.09.2013 11:44, schrieb Ralf Habacker:
- remove misleading comment
Just for the record:
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365804%28v=vs.85%29.aspx
do not mention any error code, which could be tested
If the function succeeds, it returns ERROR_SUCCESS.
If the
On Fri, Sep 13, 2013 at 02:14:24PM -0700, Scott Ritchie wrote:
Over the past couple years I've been able to try out Wine games on many
different environments -- laptops, desktops, even cloud servers.
On many occasions, I've discovered that a game appears to run
functionally but slowly,
I'm testing support for GetConsoleScreenBufferInfoEx.
At the moment, I've extended the screen_buffer struct in server/console.c to
look like this:
struct screen_buffer
{
struct object obj; /* object header */
struct list entry; /* entry in list of all
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 09:22, schrieb Henri Verbeet:
Setting render target usage on a P8 surface for example would fail
surface creation, while such surfaces can't be used for actual
rendering anyway. Tests confirm that surface creation is supposed
to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 11:39, schrieb Stefan Dösinger:
--- dlls/d3d9/tests/device.c | 340
+++ 1 file changed, 340
insertions(+)
Fyi, I have equivalent tests for d3d8, the behavior is the same.
-BEGIN PGP
On 17 September 2013 11:48, Stefan Dösinger stefandoesin...@gmail.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 09:22, schrieb Henri Verbeet:
Setting render target usage on a P8 surface for example would fail
surface creation, while such surfaces can't be used for
Bruno Jesus 00cp...@gmail.com writes:
@@ -5884,20 +5884,20 @@ SOCKET WINAPI WSASocketW(int af, int type, int
protocol,
return ret;
}
-/* convert the socket family and type */
-af = convert_af_w2u(af);
-type = convert_socktype_w2u(type);
-
if
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2198
Your paranoid
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 11:55, schrieb Henri Verbeet:
CreateDevice() returns D3DERR_SURFACENOTINVIDMEM, provided the
surface would otherwise be suitable for rendering.
SetRenderTarget() has inconsistent behaviour between versions, but
returns
On 17 September 2013 11:39, Stefan Dösinger ste...@codeweavers.com wrote:
diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h
index 4928f92..eabf890 100644
--- a/dlls/wined3d/wined3d_private.h
+++ b/dlls/wined3d/wined3d_private.h
@@ -2927,6 +2927,7 @@ extern enum
On 17 September 2013 11:39, Stefan Dösinger ste...@codeweavers.com wrote:
---
dlls/wined3d/volume.c | 95
+++
1 file changed, 88 insertions(+), 7 deletions(-)
Can't most of this be done on the resource level instead?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 13:55, schrieb Henri Verbeet:
On 17 September 2013 11:39, Stefan Dösinger
ste...@codeweavers.com wrote:
--- dlls/wined3d/volume.c | 95
+++ 1 file
changed, 88 insertions(+), 7
On 17 September 2013 14:58, Stefan Dösinger ste...@codeweavers.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 13:55, schrieb Henri Verbeet:
On 17 September 2013 11:39, Stefan Dösinger
ste...@codeweavers.com wrote:
--- dlls/wined3d/volume.c | 95
On Tue, Sep 17, 2013 at 7:00 AM, Alexandre Julliard julli...@winehq.org wrote:
Bruno Jesus 00cp...@gmail.com writes:
@@ -5884,20 +5884,20 @@ SOCKET WINAPI WSASocketW(int af, int type, int
protocol,
return ret;
}
-/* convert the socket family and type */
-af =
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 15:05, schrieb Henri Verbeet:
I was mostly thinking of merging e.g. wined3d_surface_get_pitch()
and wined3d_volume_get_pitch() into wined3d_resource_get_pitch(). I
don't feel strongly about doing that first though, so if you're
On Mon, 16 Sep 2013 11:33:34 -0500, Vincent Povirk wrote:
Typically, native GetGlyphOutlineW(hdc, ' ', GGO_BITMAP, gm, 0, NULL, ...)
returns gm.gmBlackBoxX = 1 instead of 0. Unfortunately, Wine's didn't,
and existing source codes (winex11, gdiplus, gdi32) expect 0 in this
case.
I don't
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 13:55, schrieb Henri Verbeet:
I don't like this approach much. I think we should either do the
right thing right away and have separate flags for each GL resource
type (i.e., vertex/index buffers, renderbuffers,
1D/2D/3D/CUBE/RECT
On 17 September 2013 16:52, Stefan Dösinger ste...@codeweavers.com wrote:
Am 2013-09-17 13:55, schrieb Henri Verbeet:
I don't like this approach much. I think we should either do the
right thing right away and have separate flags for each GL resource
type (i.e., vertex/index buffers,
On Tue, Sep 17, 2013 at 3:01 PM, Andrew Eikum aei...@codeweavers.com wrote:
This fixes a crash in PowerPoint when a shape is made
semi-transparent.
May also fix bug http://bugs.winehq.org/show_bug.cgi?id=34463 and
http://bugs.winehq.org/show_bug.cgi?id=30485
Typically, native GetGlyphOutlineW(hdc, ' ', GGO_BITMAP, gm, 0, NULL, ...)
returns gm.gmBlackBoxX = 1 instead of 0. Unfortunately, Wine's didn't,
and existing source codes (winex11, gdiplus, gdi32) expect 0 in this
case.
I don't think the existing code for finding the mask size would
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-17 17:12, schrieb Henri Verbeet:
The point is that the distinction you're making here between
volumes and everything else is a bit arbitrary, and I think this
patch as it is will make it more work rather than less to move
towards having
Over the past couple years I've been able to try out Wine games on many
different environments -- laptops, desktops, even cloud servers.
On many occasions, I've discovered that a game appears to run
functionally but slowly, however upon further investigation I find that
forcing the CPU to run at
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2187
Your paranoid
André Hentschel n...@dawncrow.de writes:
---
dlls/kernel32/tests/file.c | 84
++
1 file changed, 84 insertions(+)
It doesn't work here:
../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p
kernel32_test.exe.so file.c touch file.ok
Thanks for you comments. The answer is yes, as you guessed.
Typically, native GetGlyphOutlineW(hdc, ' ', GGO_BITMAP, gm, 0, NULL, ...)
returns gm.gmBlackBoxX = 1 instead of 0. Unfortunately, Wine's didn't,
and existing source codes (winex11, gdiplus, gdi32) expect 0 in this
case.
I don't
On Sep 16, 2013, at 12:55 PM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
---
dlls/user32/driver.c | 12
dlls/user32/user_private.h |1 +
dlls/user32/winpos.c |2 ++
3 files changed, 15 insertions(+), 0 deletions(-)
It's better to
Ken Thomases k...@codeweavers.com writes:
---
dlls/user32/driver.c | 12
dlls/user32/user_private.h |1 +
dlls/user32/winpos.c |2 ++
3 files changed, 15 insertions(+), 0 deletions(-)
It's better to avoid adding entry points that don't correspond to
Windows
Maybe the format for 32-bit bitmaps should be determined by the alpha
channel options?
On Monday, September 16, 2013, Dmitry Timoshkov dmi...@baikal.ru wrote:
Based on a gdiplus implementation.
---
dlls/windowscodecs/imgfactory.c | 149
+-
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2195
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2196
Your paranoid
Hi Scott,
On Linux power management decisions are made by cpufreq governors. Most
distributions I have used recently use the 'ondemand' scheduler, which
makes decisions as you would guess based on cpu load. This scheduler has
various parameters you can tweak in
Vincent Povirk madewokh...@gmail.com wrote:
Maybe the format for 32-bit bitmaps should be determined by the alpha
channel options?
Probably, but as the patch comment says the code is based on gdiplus
implementation, and there is no such an option flag in the corresponding
gdiplus API params.
Probably, but as the patch comment says the code is based on gdiplus
implementation, and there is no such an option flag in the corresponding
gdiplus API params. I'd suggest to accept the patch as as, and make further
improvements based on it.
Fair enough, the patch looks good otherwise.
On 15 September 2013 14:25, Akihiro Sagawa sagawa@gmail.com wrote:
diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 83cdaf9..9f9e12a 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -1308,7 +1308,7 @@ static void test_reset(void)
On 15 September 2013 17:50, matyapiro31 matyapir...@gmail.com wrote:
+ * wine is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at
In the past months I have been working on a command stream / worker
thread for wined3d. It moves most OpenGL calls into a separate thread
to improve performance (bug 11674) and fix some bugs that are
otherwise hard to fix (24684).
Thank you, Stefan!
I applied your patches to the Ubuntu PPA that
On 15 September 2013 21:47, Forest win...@tibit.com wrote:
I wonder if the 80%+ gains reported in other games are not to be seen in
Guild Wars 2, or if they're heavily dependent on CPU, GPU, graphics driver,
and screen resolution.
For the record, I'm using an Intel i5-3570K (stock speeds),
In general, this patchset helps more for mostly CPU limited
applications than for mostly GPU limited applications. That roughly
means that in general you'll see a larger difference on lower
resolutions or with less demanding applications / graphics settings,
and that you'll see a larger difference
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-09-15 21:47, schrieb Forest:
In the past months I have been working on a command stream /
worker thread for wined3d. It moves most OpenGL calls into a
separate thread to improve performance (bug 11674) and fix some
bugs that are otherwise
On 09/15/2013 04:25 PM, Akihiro Sagawa wrote:
hr = IUnknown_QueryInterface(reader_input,IID_IStream, (void**)stream2);
-ok(hr == E_NOINTERFACE, Expected S_OK, got %08x\n, hr);
+ok(hr == E_NOINTERFACE, Expected E_NOINTERFACE, got %08x\n, hr);
As Henri said, it's not that useful
2013/9/15 Nikolay Sivov nsi...@codeweavers.com
You could add CopyFile2 style callback function in our code, pass
everything you need as 'pvCallbackContext', that could be CopyFileEx
callback pointer or pointer to a structure that contains
pointer to user callback (and anything else you might
This seems suspicious to me. Why can't we use those values in
glyphmetrics if GetGlyphOutlineW returns 0? Does Windows provide bad
values in this case, or is our GetGlyphOutlineW broken? When does the
call to GetGlyphOutlineW in the second loop fail, and why ignore those
failures?
BTW, we should probably quit early if max_glyphsize is 0 at the end of
the first loop, rather than fail with OutOfMemory.
On Sun, 15 Sep 2013 16:32:25 -0500, Vincent Povirk wrote:
This seems suspicious to me. Why can't we use those values in
glyphmetrics if GetGlyphOutlineW returns 0? Does Windows provide bad
values in this case, or is our GetGlyphOutlineW broken?
Thanks for you comments. The answer is yes, as
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2185
Your paranoid
Hi Nikolay,
2013/9/13 Nikolay Sivov bungleh...@gmail.com
Does it actually accept any other value besides CP_ACP or 1200?
Documentation is unclear here, and makes impression that only two these
values are valid.
Did you mean EM_SETTEXTEX?
I had some tests today. And I found native EM_SETTEXTEX
On 09/14/2013 03:25 AM, Daniel Jeliński wrote:
Could you implement necessary part of CopyFile2 instead, and use it in
CopyFileEx? I think CopyFile2 has everything to do that.
2013/9/14 Nikolay Sivov nsi...@codeweavers.com
Could you implement necessary part of CopyFile2 instead, and use it in
CopyFileEx? I think CopyFile2 has everything to do that.
I suppose I could, but then, CopyFile2 uses a different callback than
CopyFileEx:
CopyFile2:
On 09/14/2013 11:46 PM, Daniel Jeliński wrote:
2013/9/14 Nikolay Sivov nsi...@codeweavers.com
mailto:nsi...@codeweavers.com
Could you implement necessary part of CopyFile2 instead, and use
it in CopyFileEx? I think CopyFile2 has everything to do that.
I suppose I could, but then,
On 9/13/2013 11:20, Dmitry Timoshkov wrote:
This test passes under Wine and shows that ReadFile after
CreateFile(GENERIC_WRITE)
is really supposed to fail.
---
dlls/ntdll/tests/file.c | 82 +
1 file changed, 82 insertions(+)
It looks like it
Nikolay Sivov bungleh...@gmail.com wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
functionality.
--
Dmitry.
On 9/13/2013 12:16, Dmitry Timoshkov wrote:
Nikolay Sivov bungleh...@gmail.com wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
Dmitry Timoshkov dmi...@baikal.ru writes:
This matches what NtWriteFile does.
I assume that this patch is in 'pending' state because of a test failure
caused
by 2/2, if the reason is different - please let me know.
It would need some test cases for other file types.
--
Alexandre Julliard
Nikolay Sivov bungleh...@gmail.com wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
functionality.
It doesn't matter what it uses
Francois Gouget fgou...@free.fr wrote:
That tree was a bit out of date causing the patch to fail to apply. I
updated it and rediffed.
I'd appreciate if you could postpone sending this sort of patches
when they could conflict with other pending patches in that area.
Thanks.
--
Dmitry.
Dmitry Timoshkov dmi...@baikal.ru writes:
Nikolay Sivov bungleh...@gmail.com wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that
ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the
tested
Jactry Zeng jactr...@gmail.com writes:
@@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT
msg, WPARAM wParam,
len = lParam ? strlen((char *)lParam) : 0;
}
} else {
+ if(bUTF8) {
+lParam = lParam + 3;
+pStruct-codepage =
On Fri, Sep 13, 2013 at 11:07:19AM +0100, Huw Davies wrote:
---
fonts/wingding.sfd | 86 +
Please ignore this one and use 'try 2'.
I had the points of one glyph selected in the outline editor which
apparently gets saved to the .sfd .
Huw.
2013/9/13 Alexandre Julliard julli...@winehq.org
@@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor,
UINT msg, WPARAM wParam,
len = lParam ? strlen((char *)lParam) : 0;
}
} else {
+ if(bUTF8) {
+lParam = lParam + 3;
+
On 9/13/2013 13:27, Jactry Zeng wrote:
Re-based to latest git.
Does it actually accept any other value besides CP_ACP or 1200?
Documentation is unclear here, and makes impression that only two these
values are valid.
On 9/13/2013 15:05, Jactry Zeng wrote:
bUnicode = !bRtf pStruct-codepage == CP_UNICODE;
+bUTF8 = (lParam (!strncmp((char *)lParam, utf8_bom, 3)));
What will happen if both of these are true? This needs a test with BOM
and 'codepage' set to 1200.
Hi Nikolay,
2013/9/13 Nikolay Sivov bungleh...@gmail.com
On 9/13/2013 15:05, Jactry Zeng wrote:
bUnicode = !bRtf pStruct-codepage == CP_UNICODE;
+bUTF8 = (lParam (!strncmp((char *)lParam, utf8_bom, 3)));
What will happen if both of these are true? This needs a test with BOM
and
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2155
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2158
Your paranoid
On 9/13/2013 22:26, André Hentschel wrote:
Sorry, ignore my comment. I missed that we actually have this call
already in wine.
On 9/13/2013 22:26, André Hentschel wrote:
+if (!pCreateFile2)
+{
+win_skip(CreateFile2 is missing\n);
+return;
+}
Should be skip() so it'll show up when running with wine. Not sure how
important it is though.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2127
Your paranoid
Marvin test...@winehq.org wrote:
=== wxppro (32 bit comm) ===
comm.c:863: Test failed: WaitCommEvent failed with a timeout
comm.c:875: recovering after WAIT_TIMEOUT...
comm.c:886: Test failed: WaitCommEvent error 0
comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
301 - 400 of 74996 matches
Mail list logo
