Re: wine-bugs change?

2013-08-13 Thread Thomas Spear
Austin, I think you put me on the right track. I had that disabled. I enabled it and disabled it again, which caused unintended interface changes. That forced me into the main settings for the priority inbox (not gmail settings). There, I found a radio button that was enabled by default apparently

Re: gdiplus: Only clip strings if rectangle width and height are positive.

2013-08-13 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: if (!(format_flags StringFormatFlagsNoClip) -scaled_rect.Width != 1 23 scaled_rect.Height != 1 23) +scaled_rect.Width != 1 23 scaled_rect.Height != 1 23 +rect-Width 0.0 rect-Height 0.0) { /*

Re: gdiplus: Only clip strings if rectangle width and height are positive.

2013-08-13 Thread Vincent Povirk
if (!(format_flags StringFormatFlagsNoClip) -scaled_rect.Width != 1 23 scaled_rect.Height != 1 23) +scaled_rect.Width != 1 23 scaled_rect.Height != 1 23 +rect-Width 0.0 rect-Height 0.0) { /* FIXME: If only the width or only the height is

Process for reporting security bugs?

2013-08-12 Thread Andrew Church
[Please cc: me on any replies since I'm not subscribed to the list.] Hi, Is there a specific process for reporting security-related bugs in Wine? I've looked through winehq.org but haven't found any mention of such; I just wanted to make sure I haven't overlooked anything before posting the bug

Re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-12 Thread Álvaro Nieto
Thank you for your feedback. I'll adjust the tests with your comments and I'll try to use testbot. 2013/8/8 Dan Kegel d...@kegel.com Minor problem: +static void test_strncpy(void) +{ +size_t len = 10; +char *ret; +char dst[len + 1]; Hmm. That last line is a VLA, and might

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events

2013-08-12 Thread Ruslan Kabatsayev
Hi, On Sun, Aug 11, 2013 at 12:33 PM, Hugh McMaster hugh.mcmas...@masterindexing.com wrote: Jason Edmeades and I have developed a patch that handles Ctrl-C and Ctrl-Break events in wineconsole's cmd.exe. The patch supports interactive mode, batch contexts and both the cmd /c and cmd /k

Re: ntdll/tests: test FileDispositionInformation file class

2013-08-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26661 Your paranoid

Re: Process for reporting security bugs?

2013-08-12 Thread Marcus Meissner
Hi, On Sat, Aug 10, 2013 at 01:12:24PM +0900, Andrew Church wrote: [Please cc: me on any replies since I'm not subscribed to the list.] Hi, Is there a specific process for reporting security-related bugs in Wine? I've looked through winehq.org but haven't found any mention of such; I

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events

2013-08-12 Thread Hugh McMaster
On Monday, 12 August 2013, Ruslan Kabatsayev wrote: I've tried applying your both patches, and it appears that Ctrl+C at cmd prompt still closes cmd, although pressing it while dir /s /w is running works as expected. Hi Ruslan, I've just tested the Ctrl-C patches on the most recent version of

Re: Process for reporting security bugs?

2013-08-12 Thread Marcus Meissner
On Mon, Aug 12, 2013 at 10:40:48PM +0900, Andrew Church wrote: Hi Marcus, If it is not a high severe issue you can also just mail this mailinglist here (wine-devel). Thanks for the info. As it turns out, it's an already-known issue (unixfs allows full host filesystem access through

Re: Question about implementing application compatibility

2013-08-12 Thread Vincent Povirk
This is awfully overcomplicated (plus I do not know how to make such a global variable in wine) so I was wondering is it OK to implement this differently than windows does it. If the implementation does not have to be the same to preserve compatibility, then you should ignore those details

Compiler warnings on Debian Sid kfreebsd-i386

2013-08-12 Thread Ken Sharp
Following my previous e-mail (http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html) I have since moved from Wheezy to Sid to work around a Debian bug. libxml2 has been updated (2.8.0+dfsg1-7+nmu1 -- 2.9.1+dfsg1-3) as a result and introduced some new compiler warnings:

Re: Compiler warnings on Debian Sid kfreebsd-i386

2013-08-12 Thread Mislav Blazevic
It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. On Mon, Aug 12, 2013 at 9:15 PM, Mislav Blazevic krofnica...@gmail.comwrote: It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. On Mon, Aug 12, 2013 at 9:11 PM, Ken Sharp kennyb...@o2.co.uk wrote:

Re: Compiler warnings on Debian Sid kfreebsd-i386

2013-08-12 Thread Ken Sharp
On 12/08/13 20:15, Mislav Blazevic wrote: It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. It does seem that way. :-) Or maybe :-(

RE: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events

2013-08-12 Thread Hugh McMaster
On Monday, 12 August 2013 at 10:57 PM, Ruslan Kabatsayev wrote: You're right, I had to run cmd via wineconsole, and I tried it before with plain wine. OK, this way your patches do indeed work. Thanks. No problems, Ruslan. I'm not sure Ctrl-C can be intercepted when running 'wine cmd.exe' but

Question about implementing application compatibility

2013-08-11 Thread Mislav Blazevic
For past two weeks I've been implementing apphelp.dll. I got that one working and moved onto kernel32 part of magic. According to various papers and blogs it seems that windows logs all exes and dlls ever executed in registry[1] and uses it as cache to lookup if binary needs to be shimmed or

Is it a little bug in wbemprox?

2013-08-10 Thread Jing Li
Hi, When I ran a simple win32 program just via WMI with query of SELECT * from Win32_Directory, wine1.6 crashed. And when I checked the related code I found that the function of static UINT seed_dirs( struct dirstack *dirstack, const struct expr *cond, WCHAR root, UINT *count ), in

Re: Is it a little bug in wbemprox?

2013-08-10 Thread Hans Leidekker
On Sat, 2013-08-10 at 15:55 +0800, Jing Li wrote: Hi, When I ran a simple win32 program just via WMI with query of SELECT * from Win32_Directory, wine1.6 crashed. And when I checked the related code I found that the function of static UINT seed_dirs( struct dirstack *dirstack, const struct

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-10 Thread Ken Sharp
On 08/08/13 21:28, Charles Davis wrote: On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning:

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-09 Thread Jacek Caban
On 08/08/13 19:56, Kai Tietz wrote: 2013/8/8 André Hentschel n...@dawncrow.de: Am 08.08.2013 17:51, schrieb Kai Tietz: Hi, this patch adds new --rt option to widl. By it you can control, if RT's IDL-language-extension(?s) getting active. This initial patch just adds the option-scanning and

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-09 Thread Ken Sharp
On 08/08/13 21:28, Charles Davis wrote: On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning:

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-09 Thread Charles Davis
On Aug 9, 2013, at 11:01 AM, Ken Sharp wrote: On 08/08/13 21:28, Charles Davis wrote: On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function]

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-09 Thread Ken Sharp
On 10/08/13 00:01, Charles Davis wrote: Did you run autoreconf like I said? No! I'm useless! I'll get back to you tomorrow. Sorry. :(

Compiler warnings on Debian kfreebsd-i386

2013-08-08 Thread Ken Sharp
Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function]

Re: [PATCH 1/1] msvcrt: Set ?: environment variable in _(w)chdir functions.

2013-08-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26639 Your paranoid

Re: winetestbot question

2013-08-08 Thread Francois Gouget
On Wed, 7 Aug 2013, Stefan Leichter wrote: Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. That VM is Windows XP SP1 and apparently that runtime only gets installed with SP3. The real

Re: Synchronization-patches of widl

2013-08-08 Thread André Hentschel
Am 08.08.2013 10:56, schrieb Kai Tietz: All these changes were necessary to support the VLC-people to begin with their WinRT port. By this we began on mingw-w64 to improve - thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT,

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-08 Thread André Hentschel
Am 08.08.2013 17:51, schrieb Kai Tietz: Hi, this patch adds new --rt option to widl. By it you can control, if RT's IDL-language-extension(?s) getting active. This initial patch just adds the option-scanning and the global flag-variable to widl. Ok for apply? I'd say no, you are adding

Re: [PATCH 09/11] widl: Handle LLP64 target same as LP64 one.

2013-08-08 Thread André Hentschel
Am 08.08.2013 18:07, schrieb Kai Tietz: Hi, this thing here puzzles me most. I reject this patch, but would like to get here some discussion to find the actual intended meaning of this xstrtoul function. Then you should remove it from the patchset and send it as RFC to wine-devel

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.

2013-08-08 Thread André Hentschel
Am 08.08.2013 17:57, schrieb Kai Tietz: -if (! is_attr(attrs, ATTR_PUBLIC)) +if (! is_attr(attrs, ATTR_PUBLIC) ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after !

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.

2013-08-08 Thread Kai Tietz
2013/8/8 André Hentschel n...@dawncrow.de: Am 08.08.2013 17:57, schrieb Kai Tietz: -if (! is_attr(attrs, ATTR_PUBLIC)) +if (! is_attr(attrs, ATTR_PUBLIC) ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after ! Well, agreed. But I don't want to change by my patch style issues.

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

2013-08-08 Thread Kai Tietz
2013/8/8 André Hentschel n...@dawncrow.de: Am 08.08.2013 17:51, schrieb Kai Tietz: Hi, this patch adds new --rt option to widl. By it you can control, if RT's IDL-language-extension(?s) getting active. This initial patch just adds the option-scanning and the global flag-variable to widl.

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-08 Thread Charles Davis
On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not

Re: configure.ac: allow disabling winemac.drv

2013-08-08 Thread Ken Thomases
On Aug 8, 2013, at 5:56 PM, Austin English wrote: +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver]), +[if test x$withval = xno; then ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi]) A switch to disable the Mac

Re: [2/2] wineserver: perform access check when creating event objects (try 2)

2013-08-08 Thread Andrew Cook
Actually ignore this patch, the problem was introduced by 92db6d2c back in 2007, server: Don't do access checks on the security descriptors of newly created objects which fixes sync.c:363 CreateEventW with blank sd failed i'll need to take another look at this, calling CreateEventEx with

Re: msvcrt: strncpy doesn't compliant C standard (try 2)

2013-08-07 Thread Frédéric Delanoy
On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto alvaro.ni...@gmail.com wrote: Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy

Re: [PATCH] typo fixes (https://github.com/vlajos/misspell_fixer)

2013-08-07 Thread Frédéric Delanoy
On Mon, Aug 5, 2013 at 9:41 PM, Veres Lajos vla...@gmail.com wrote: Signed-off-by: Veres Lajos vla...@gmail.com --- dlls/comctl32/tests/trackbar.c |2 +- documentation/ChangeLog.ALPHA | 80 documentation/ChangeLog.BETA | 44

Re: msvcp90/tests: Skip tests on missing functions

2013-08-07 Thread Piotr Caban
On 08/06/13 23:00, André Hentschel wrote: @@ -749,6 +749,13 @@ static BOOL init(void) SET(p_basic_istream_char_read_uint64, ??5?$basic_istream@DU?$char_traits@D@std@@@std@@QAEAAV01@AA_K@Z); + +if (!p_basic_istream_char_read_uint64) +{ +

Request to add wow64 keyword to bugzilla

2013-08-07 Thread Rosanne DiMesio
Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing numbers of users. -- Rosanne DiMesio

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Ken Sharp
On 07/08/13 13:59, Rosanne DiMesio wrote: Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Ken Sharp
+1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: On Wed, 07 Aug 2013 14:23:53 +0100 Ken Sharp kennyb...@o2.co.uk wrote: Would I be right in assuming you would like to see bugs in 32-bit applications that are only present in a wow64 WINEPREFIX? Are there many? Yes. As to how many there

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Frédéric Delanoy
On Wed, Aug 7, 2013 at 4:30 PM, Ken Sharp kennyb...@o2.co.uk wrote: +1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: As to keyword usage, some of those bugs were tagged with the win64 keyword, some weren't. I know there is also a win32 keyword, and perhaps that is meant to be used for

Re: msvcp90/tests: Skip tests on missing functions

2013-08-07 Thread André Hentschel
Am 07.08.2013 10:27, schrieb Piotr Caban: On 08/06/13 23:00, André Hentschel wrote: @@ -749,6 +749,13 @@ static BOOL init(void) SET(p_basic_istream_char_read_uint64, ??5?$basic_istream@DU?$char_traits@D@std@@@std@@QAEAAV01@AA_K@Z); + +if

Re: Request to add wow64 keyword to bugzilla

2013-08-07 Thread Rosanne DiMesio
On Wed, 7 Aug 2013 21:07:29 +0200 Frédéric Delanoy frederic.dela...@gmail.com wrote: There's no win32 keyword ; only win16 and win64 There wouldn't be any use anyway since it would be the default I know; Ken pointed that out. I think I misread win16. Clearly I should not post before

Re: msvcp90/tests: Add dynamically loaded functions for ARM

2013-08-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26637 Your paranoid

Re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid

winetestbot question

2013-08-07 Thread Stefan Leichter
Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. Because of the missing runtime each patch for the unit tests of the dlls msvcr90 and msvcp90 is marked as Failed at http://source.winehq.org/patches

re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Dan Kegel
Minor problem: +static void test_strncpy(void) +{ +size_t len = 10; +char *ret; +char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems

Re: msvcrt: strncpy doesn't compliant C standard

2013-08-06 Thread Nikolay Sivov
On 8/6/2013 11:09, Álvaro Nieto wrote: This patch solves [Bug 34211]. The implementation of strncpy function doesn't compliant with C standard [1]. Also Microsoft Visual Studio C/C++ compiler is ok with the standard [2]. Extract from msdn; The strncpy function copies the initial count

Re: ws2_32/tests: Fix a comment

2013-08-06 Thread Juan Lang
Hi Andre, -/* this is a io heavy test, do it at the end so the kernel doesn't start dropping packets */ +/* this is a heavy io test, do it at the end so the kernel doesn't start dropping packets */ To my eyes, this isn't an improvement. A slight improvement might be this is a io-heavy

Re: msvcr90/tests: Skip when _type_info_name_internal_method is not found

2013-08-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26627 Your paranoid

Re: msvcp90/tests: Skip tests on missing functions

2013-08-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26628 Your paranoid

Re: po: Add English (Philippines) resource

2013-08-05 Thread Francois Gouget
On Sun, 4 Aug 2013, Ken Sharp wrote: Hi everyone, Would anyone mind looking at the attached patch? I wonder if this is something that could be handled at the NLS level instead. Maybe in dlls/kernel32/nls/enp.nls. Would LOCALE_SNAME en-PH be relevant here? Or would it make sense to add a

Re: po: Add English (Philippines) resource

2013-08-05 Thread Ken Sharp
On 05/08/13 10:41, Francois Gouget wrote: On Sun, 4 Aug 2013, Ken Sharp wrote: Hi everyone, Would anyone mind looking at the attached patch? I wonder if this is something that could be handled at the NLS level instead. Maybe in dlls/kernel32/nls/enp.nls. Would LOCALE_SNAME en-PH be

Re: po: Add English (Philippines) resource

2013-08-05 Thread Ken Sharp
On 05/08/13 12:00, Ken Sharp wrote: As an aside: #define SUBLANG_SINDHI_PAKISTANSUBLANG_SINDHI_AFGHANISTAN This may cause problems if these languages are ever implemented. Not sure if Wine handles these differently. And then, of course, I realise that these are probably the

Re: msvcrt: invoke invalid_handler in _wcscpy_s

2013-08-05 Thread Piotr Caban
On 08/02/13 20:08, Daniel Lehman wrote: +if(!MSVCRT_CHECK_PMT(wcDest)) +{ +*MSVCRT__errno() = MSVCRT_EINVAL; return MSVCRT_EINVAL; +} The MSVCRT_CHECK_PMT macro sets the errno value. There's also MSVCRT_CHECK_PMT_ERR macro if you need to set different error.

Re: inputscope.idl: Imported from mingw-w64.

2013-08-05 Thread Ken Sharp
On 05/08/13 12:14, Jacek Caban wrote: + * No warranty is given; refer to the file DISCLAIMER.PD within this package. It's a minor point but this may be a bit confusing given the file doesn't exist.

wine mannual is wrong?

2013-08-05 Thread 中川祥
I'm interpretering wine.man. I found it saysthis requires X11 to run. But the newest ver. does not require X11,does it?

Draft: improve IMC/IMCC related functions

2013-08-05 Thread Qian Hong
Hello, This is a follow up of http://www.winehq.org/pipermail/wine-devel/2013-July/100459.html ( [PATCH] imm32: Fixed crashing in ImmGetIMCCSize. ) I believe the attached patchset is the correct fix for the Office crashing bug, how ever, I'm looking for a more graceful way to improve

Re: wine mannual is wrong?

2013-08-05 Thread Austin English
On Mon, Aug 5, 2013 at 7:49 AM, 中川祥 matyapir...@gmail.com wrote: I'm interpretering wine.man. I found it saysthis requires X11 to run. But the newest ver. does not require X11,does it? Yes. Unless you're on Mac and use the Mac driver instead. -- -Austin

Re: wine mannual is wrong?

2013-08-05 Thread Vincent Povirk
You can also run console apps without a graphics driver (if they don't do anything that requires one).

Fwd: [AppDB] Submitted test data deleted

2013-08-05 Thread Ken Sharp
Deleting test results because the Wine version is old? What the Hell is the plan there? Original Message Subject: [AppDB] Submitted test data deleted Date: Mon, 05 Aug 2013 15:48:43 -0500 From: AppDB appdb-nore...@winehq.org Reply-To: AppDB appdb-nore...@winehq.org To:

help [Abount Sql2005 and WMI]

2013-08-04 Thread Jing Li
Hi, all: I have met a problem when installing sql2005, and it seems related to some WMI problems. As WMI has just been implemented in wine-1.6 ( right? ), I want to know in what degree it has been implemented.By the way is there anyone succeed in install of it? Thanks. Appreciate your kind

Re: help [Abount Sql2005 and WMI]

2013-08-04 Thread Frédéric Delanoy
On Sun, Aug 4, 2013 at 10:39 AM, Jing Li slvm.f...@gmail.com wrote: Hi, all: I have met a problem when installing sql2005, and it seems related to some WMI problems. As WMI has just been implemented in wine-1.6 ( right? ), I want to know in what degree it has been implemented.By the way is

po: Add English (Philippines) resource

2013-08-04 Thread Ken Sharp
Hi everyone, Would anyone mind looking at the attached patch? It adds the English (Philippines) resource by linking (or copying) the English (US) resource. See http://bugs.winehq.org/show_bug.cgi?id=23124 Actually, the attached version links to fr.po (French) to make testing much easier.

Re: Wiki RFC: Redirects, swarm tactics, etc.

2013-08-04 Thread Kyle Auble
Thanks everyone, I've created a table of all of the pages that seemed relevant at http://wiki.winehq.org/WebContentTasks/WikiParty. I put down details on that page and its parent instead of cluttering up this email. On 08/02/2013 06:49 AM, Rosanne DiMesio wrote: By any chance do any of those

Wiki RFC: Redirects, swarm tactics, etc.

2013-08-02 Thread Kyle Auble
So I've finished with pretty much all of the edits I had in mind for the wiki, but before I ride off into the sunset for a while, I wanted to toss out a few ideas. 1. Do we want some kind of guideline on redirects for the wiki? Some stable interface pages to the main site might be good, but

Re: gdi32: Don't let the gdi32 driver allocate memory in the dplayx region.

2013-08-02 Thread Alexei Svitkine
On Fri, Jul 26, 2013 at 2:04 AM, Nikolay Sivov bungleh...@gmail.com wrote: Looks like dplay should be fixed to not depend on that reserved address area. I agree, that's the ideal solution. However, I'm not sufficiently familiar with what dplay is doing to need that block of memory at that

Re: Wiki RFC: Redirects, swarm tactics, etc.

2013-08-02 Thread Austin English
On Thu, Aug 1, 2013 at 11:03 PM, Kyle Auble kau...@lavabit.com wrote: So I've finished with pretty much all of the edits I had in mind for the wiki, but before I ride off into the sunset for a while, I wanted to toss out a few ideas. .. 2. There's still a lot of old/missing content on the

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-02 Thread Rico Schüller
On 31.07.2013 00:14, Matteo Bruni wrote: 2013/7/30 Rico Schüller kgbric...@web.de: Hi Matteo, please see the attached patch. On 25.07.2013 16:13, Matteo Bruni wrote: 2013/7/24 Rico Schüller kgbric...@web.de: --- dlls/d3dx9_36/tests/shader.c | 308

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-02 Thread Rico Schüller
On 01.08.2013 17:25, Matteo Bruni wrote: Instead of generating an entry for the struct with the correct members, the compiler generates TWO entries for sbnf, one with all its fields in D3DXRS_FLOAT4 and the other with D3DXRS_BOOL. Which, if I'm reading this correctly, makes 0 sense. Calling

Re: [PATCH] d3dx9_36: Implement ID3DXEffect_FindNextValidTechnique + add tests.

2013-08-02 Thread Rico Schüller
On 02.08.2013 00:03, Christian Costa wrote: +technique = (D3DXHANDLE)0xdeadbeef; +hr = effect-lpVtbl-FindNextValidTechnique(effect, technique1, technique); +ok(hr == D3D_OK, FindNextValidTechnique failed, got %#x, expected %#x\n, hr, D3D_OK); +ok(technique == technique2,

Re: Clang warns on wrong header guard in config.h

2013-08-02 Thread Alexandre Julliard
Charles Davis cdavi...@gmail.com writes: These lines generate what Clang thinks is the header guard for the config.h header, but we know that it isn't--that header AFAICT has never had an include guard, and __WINE_CONFIG_H is just there to indicate that it's been included. Should we change

RE: reg.exe: Add query function

2013-08-02 Thread Hugh McMaster
On Thursday, 1 August 2013 11:55 PM, Nikolay Sivov wrote: +p = strchrW(key_name,'\\'); +if (!p) +{ +p = 0; +} +else p++; I'm not sure what this is supposed to do. It is equivalent to the following code; p = strchrW(key_name, '\\'); if (p != NULL) p++;

Re: reg.exe: Add query function

2013-08-02 Thread Nikolay Sivov
On 8/2/2013 12:52, Hugh McMaster wrote: +case REG_BINARY: +case REG_NONE: +pValue = value; +for (i=0; ivalueSize; i++, pValue++) +reg_printfW(formatXW, *pValue); +break; There's no need for separate variable here nor for

RE: reg.exe: Add query function

2013-08-02 Thread Hugh McMaster
On Friday, 2 August 2013 6:58 PM, Nikolay Sivov wrote: There's no need for separate variable here nor for incrementing pointer. The incrementing pointer is needed because the 'value' is a Byte array. But the separate variable is not needed. Yes, so value[i] will do the same. Yes, you're

Re: gdi32: Avoid a crash by loading AppKit before using Core Text if might use the Mac driver.

2013-08-02 Thread Alexandre Julliard
Ken Thomases k...@codeweavers.com writes: +/* If the Mac driver might be used, then load AppKit now before using the Core Text API. + Otherwise, AppKit crashes on Mac OS X 10.7+ because CTFontDescriptor isn't toll-free + bridged to NSCTFontDescriptor. That bridging is only

Re: ntdll: Implement compatible FindActCtxSectionString() for window class section (try3)

2013-08-02 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: @@ -1031,6 +1105,17 @@ static BOOL parse_window_class_elem(xmlbuf_t* xmlbuf, struct dll_redirect* dll) if (!(entity-u.class.name = xmlstrdupW(content))) return FALSE; +/* each class entry needs index, data and string data */ +

Re: Wiki RFC: Redirects, swarm tactics, etc.

2013-08-02 Thread Ken Sharp
I've just started looking at the Wiki myself. There's a lot of outdated stuff on there and it needs a lot of attention. There's little hope of me helping with anything related to the actual programming but I'm willing to help with other stuff. On 02/08/13 07:03, Kyle Auble wrote: So I've

Re: po: Add English (Canada) resource [Take 2]

2013-08-02 Thread Ken Sharp
With all the corrections in-place for Canadian English, the British English it defaults to is identical (as far as Wine is concerned). This patch has a couple of errors now so it can be disregarded. If a separate entry to en_CA is necessary then let me know and I'll resubmit with the changes,

appwiz: Correct Wine Mono installer title in several languages

2013-08-02 Thread Ken Sharp
Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would rather have the changes made along with the next string for each language?

Re: ntdll: Implement compatible FindActCtxSectionString() for window class section (try3)

2013-08-02 Thread Nikolay Sivov
On 8/2/2013 13:33, Alexandre Julliard wrote: Nikolay Sivov nsi...@codeweavers.com writes: @@ -1031,6 +1105,17 @@ static BOOL parse_window_class_elem(xmlbuf_t* xmlbuf, struct dll_redirect* dll) if (!(entity-u.class.name = xmlstrdupW(content))) return FALSE; +/* each class entry

Re: ntdll: Implement compatible FindActCtxSectionString() for window class section (try3)

2013-08-02 Thread Alexandre Julliard
Nikolay Sivov bungleh...@gmail.com writes: On 8/2/2013 13:33, Alexandre Julliard wrote: Nikolay Sivov nsi...@codeweavers.com writes: @@ -1031,6 +1105,17 @@ static BOOL parse_window_class_elem(xmlbuf_t* xmlbuf, struct dll_redirect* dll) if (!(entity-u.class.name =

jscript FTBFS in Cygwin 1.7.22

2013-08-02 Thread Ken Sharp
Probably better to post this here rather than the forums: http://forum.winehq.org/viewtopic.php?f=2t=19501 Not sure if this is a Wine bug (as usual) so I'd rather put this here than to open a new bug. On Cygwin 1.7.22 the compilation stops at jscript, apparently a conflict in the declaration

Re: [1/2] ntdll: Implement NtQueryEvent

2013-08-02 Thread Alexandre Julliard
Andrew Cook aris...@gmail.com writes: diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in index 10d6674..a44b880 100644 --- a/dlls/ntdll/tests/Makefile.in +++ b/dlls/ntdll/tests/Makefile.in @@ -7,6 +7,7 @@ C_SRCS = \ directory.c \ env.c \ error.c \

Re: riched20: Make ITextDocument stub reusable for ITextServices (try 4)

2013-08-02 Thread Alexandre Julliard
Caibin Chen tigerso...@gmail.com writes: diff --git a/dlls/riched20/tomimpl.h b/dlls/riched20/tomimpl.h new file mode 100644 index 000..886c3a8 --- /dev/null +++ b/dlls/riched20/tomimpl.h @@ -0,0 +1,59 @@ +/* + * RichEdit - TOM interfaces implementations + * + * Copyright 2013 by

Re: appwiz: Correct Wine Mono installer title in several languages

2013-08-02 Thread Alexandre Julliard
Ken Sharp kennyb...@o2.co.uk writes: Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would rather have the changes made along with the next string for each language? You say you want to catch the translators attention, but you

Re: appwiz: Correct Wine Mono installer title in several languages

2013-08-02 Thread Ken Sharp
On 02/08/13 10:57, Alexandre Julliard wrote: Ken Sharp kennyb...@o2.co.uk writes: Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would rather have the changes made along with the next string for each language? You say you

Re: appwiz: Correct Wine Mono installer title in several languages

2013-08-02 Thread Alexandre Julliard
Ken Sharp kennyb...@o2.co.uk writes: On 02/08/13 10:57, Alexandre Julliard wrote: Ken Sharp kennyb...@o2.co.uk writes: Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would rather have the changes made along with the next

Re: Wiki RFC: Redirects, swarm tactics, etc.

2013-08-02 Thread Rosanne DiMesio
On Fri, 02 Aug 2013 01:03:34 -0500 Kyle Auble kau...@lavabit.com wrote: 3. There are actually a few more fixes to the theme code at the head of my bitbucket repo (and also branches for 2 different Moinmoin upgrade paths). By any chance do any of those fixes/branches take care of

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-02 Thread Matteo Bruni
2013/8/1 Matteo Bruni matteo.myst...@gmail.com: Instead of generating an entry for the struct with the correct members, the compiler generates TWO entries for sbnf, one with all its fields in D3DXRS_FLOAT4 and the other with D3DXRS_BOOL. Which, if I'm reading this correctly, makes 0 sense.

Re: [docs] wineusr: Assorted formatting tagging fixes (try 2)

2013-08-02 Thread Alexandre Julliard
Frédéric Delanoy frederic.dela...@gmail.com writes: @@ -710,17 +714,18 @@ Path=c:\windows;c:\windows\system;e:\;e:\test;f:\ choose between several edition modes: itemizedlist listitem - para -

Re: appwiz: Correct Wine Mono installer title in several languages

2013-08-02 Thread Ken Sharp
On 02/08/13 12:05, Alexandre Julliard wrote: Ken Sharp kennyb...@o2.co.uk writes: On 02/08/13 10:57, Alexandre Julliard wrote: Ken Sharp kennyb...@o2.co.uk writes: Hi Alexandre, http://source.winehq.org/patches/data/97460 should be correct but would I be right in assuming you would

Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon

2013-08-02 Thread Nozomi Kodama
De : Matteo Bruni matteo.myst...@gmail.com À : Nozomi Kodama nozomi.kod...@yahoo.com Cc : Wine Devel wine-devel@winehq.org Envoyé le : Jeudi 1 août 2013 9h46 Objet : Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon 2013/8/1 Nozomi Kodama

Re: gdi32: Avoid a crash by loading AppKit before using Core Text if might use the Mac driver.

2013-08-02 Thread Ken Thomases
On Aug 2, 2013, at 4:22 AM, Alexandre Julliard wrote: Ken Thomases k...@codeweavers.com writes: +/* If the Mac driver might be used, then load AppKit now before using the Core Text API. + Otherwise, AppKit crashes on Mac OS X 10.7+ because CTFontDescriptor isn't toll-free +

Re: gdi32: Avoid a crash by loading AppKit before using Core Text if might use the Mac driver.

2013-08-02 Thread Alexandre Julliard
Ken Thomases k...@codeweavers.com writes: On Aug 2, 2013, at 4:22 AM, Alexandre Julliard wrote: That's ugly. freetype.c has no business knowing about the details of the graphics driver. Is it acceptable to load the graphics driver at that point, by calling DRIVER_load_driver(display, …)?

Re: [PATCH] oleaut32: ERR on 32bit typelibs on 64bit

2013-08-02 Thread Alexandre Julliard
Marcus Meissner meiss...@suse.de writes: Triggered by the Novell Groupwise installer currently, from the ISBE64W.exe Installshield Helper program. The typelib is contained directly in ISBE64W.exe itself :/ Basically if we encounter this case the program will crash anyway (but with random

Re: [PATCH] oleaut32: ERR on 32bit typelibs on 64bit

2013-08-02 Thread Marcus Meissner
On Fri, Aug 02, 2013 at 04:29:07PM +0200, Alexandre Julliard wrote: Marcus Meissner meiss...@suse.de writes: Triggered by the Novell Groupwise installer currently, from the ISBE64W.exe Installshield Helper program. The typelib is contained directly in ISBE64W.exe itself :/ Basically

Re: xmllite: Improve attribute value parsing

2013-08-02 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: +static void reader_normalize_space(xmlreader *reader, WCHAR *ptr) +{ +encoded_buffer *buffer = reader-input-buffer-utf16; + +if (!is_wchar_space(*ptr)) return; + +if (*ptr == '\r' *ptr == '\n') That's not going to happen very

Re: gdi32: Avoid a crash by loading AppKit before using Core Text if might use the Mac driver.

2013-08-02 Thread Ken Thomases
On Aug 2, 2013, at 9:19 AM, Alexandre Julliard wrote: Ken Thomases k...@codeweavers.com writes: On Aug 2, 2013, at 4:22 AM, Alexandre Julliard wrote: That's ugly. freetype.c has no business knowing about the details of the graphics driver. Is it acceptable to load the graphics driver at

<    5   6   7   8   9   10   11   12   13   14   >