Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Henri Verbeet
I think tests would be appropriate.

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Christian Costa
. That said, if it is really a problem, I can add some basic ones. But I don't think so. Message du 22/02/10 13:06 De : Henri Verbeet A : wine-devel@winehq.org Copie à : Objet : Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets) I think tests

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Henri Verbeet
On 22 February 2010 13:43, Christian Costa titan.co...@wanadoo.fr wrote: Sure. Having tests is better but in this case there is no chance for regression. I usually write tests for my personnal pursose or to compare behaviour against real windows or native dll. You write tests to prove your

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Christian Costa
@winehq.org Objet : Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets) On 22 February 2010 13:43, Christian Costa wrote: Sure. Having tests is better but in this case there is no chance for regression. I usually write tests for my personnal

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Henri Verbeet
On 22 February 2010 15:15, Christian Costa titan.co...@wanadoo.fr wrote: More generally I would say that over-reviewing is not a good thing. It does not bring much in term of quality and slow down development. Thrust is the base of a community. Sure, but that trust has to be justified. I can

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

2010-02-22 Thread Christian Costa
Henri Verbeet a écrit : On 22 February 2010 15:15, Christian Costa titan.co...@wanadoo.fr wrote: More generally I would say that over-reviewing is not a good thing. It does not bring much in term of quality and slow down development. Thrust is the base of a community. Sure, but that