Am Dienstag 28 November 2006 22:05 schrieb Markus Amsler:
Stefan Dösinger wrote:
I proposed getting rid of COM some time ago, but I didn't consider that
we need some features like inheritance.
I think we should keep COM, but get rid of the D3D-Specific Addrefs
because they are different
Stefan Dösinger [EMAIL PROTECTED] writes:
Well, GetParent isn't part of IUnknown(its a wined3d invention), so from the
COM point of view we're fine to do whatever we want with it. (Just
QueryInterface has the rule that it addrefs the returned interface)
The COM rules are not limited to
On 28/11/06, Markus Amsler [EMAIL PROTECTED] wrote:
One problem is, half of the AddRef patches were commited. Before
reverting them, I thought I send the rest again. The other problem is
the AddRef in GetParent is ugly, because it AddRefs on a d3dx object. We
should do d3dx refcounting only in
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably be best if
they were reverted.
That was my impression too,
On 28/11/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably
Alexandre Julliard wrote:
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably be best if
they were reverted.
Markus Amsler [EMAIL PROTECTED] writes:
I wasn't fully aware of the importance of the COM refcount rules, just
saw the opportunity for simplification. For removing COM it would be
probably better to start with removing the lpVtbl's. I agree it's
probably best to revert them for consistency.
Am Dienstag 28 November 2006 16:55 schrieb Alexandre Julliard:
Markus Amsler [EMAIL PROTECTED] writes:
I wasn't fully aware of the importance of the COM refcount rules, just
saw the opportunity for simplification. For removing COM it would be
probably better to start with removing the
Stefan Dösinger wrote:
I proposed getting rid of COM some time ago, but I didn't consider that we
need some features like inheritance.
I think we should keep COM, but get rid of the D3D-Specific Addrefs because
they are different between the various versions d3d versions. So keep the
AddRef
H. Verbeet wrote:
On 28/11/06, Markus Amsler [EMAIL PROTECTED] wrote:
The following patches remove refcounting in wined3d Getters. The
Setters/Creaters refcounting can't be removed right now, because of the
way implicit surfaces are currently handled.
The idea is to simplify the d3dx-wined3d
Markus Amsler wrote:
@@ -4704,7 +4704,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl
TRACE((%p) : ppDecl=%p\n, This, ppDecl);
*ppDecl = This-stateBlock-vertexDecl;
-if (NULL != *ppDecl) IWineD3DVertexDeclaration_AddRef(*ppDecl);
return WINED3D_OK;
These patches violate
On 22/11/06, Robert Shearman [EMAIL PROTECTED] wrote:
Markus Amsler wrote:
@@ -4704,7 +4704,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl
TRACE((%p) : ppDecl=%p\n, This, ppDecl);
*ppDecl = This-stateBlock-vertexDecl;
-if (NULL != *ppDecl)
H. Verbeet wrote:
On 22/11/06, Robert Shearman [EMAIL PROTECTED] wrote:
These patches violate COM rules. Is this for performance or other
reasons?
The plan seems to be to not use COM for wined3d anymore, mainly
because the layering of d3d87/8/9 on top of wined3d is causing some
problems
On 22/11/06, Markus Amsler [EMAIL PROTECTED] wrote:
It's about simplifying code, with the side effect of perhaps small
performance gains. It's also the first step to drop COM in wined3d, but
that's not my intention (it seems Stefan likes the idea).
Well, you can't half-remove COM. If you start
H. Verbeet wrote:
On 22/11/06, Markus Amsler [EMAIL PROTECTED] wrote:
It's about simplifying code, with the side effect of perhaps small
performance gains. It's also the first step to drop COM in wined3d, but
that's not my intention (it seems Stefan likes the idea).
Well, you can't half-remove
15 matches
Mail list logo
