Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.

2013-10-02 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > diff --git a/server/file.c b/server/file.c > index 2ecf97c..94d3060 100644 > --- a/server/file.c > +++ b/server/file.c > @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) > > access = generic_file_map_access( access ); > if (access

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > The tests show that this is how fully up to date Windows versions starting > from XP behave, isn't that convincing enough? If not, what else do you need > to see? An application that breaks because of this. -- Alexandre Julliard julli...@winehq.org

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Do you propose to leave NtWriteFile/NtReadFile in the state when they > > return STATUS_SUCCESS for overlapped writes and reads? But that's clearly > > not how Windows implements this accordingto the tests, and that would > > require changing all the tests to accept

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Do you propose to leave NtWriteFile/NtReadFile in the state when they > return STATUS_SUCCESS for overlapped writes and reads? But that's clearly > not how Windows implements this accordingto the tests, and that would > require changing all the tests to accept both valu

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
> The tests also show that returning success is allowed for other file > types, so I don't see a need to add complexity to treat files > differently, unless there's a demonstrated need. Do you propose to leave NtWriteFile/NtReadFile in the state when they return STATUS_SUCCESS

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
ts also show that returning success is allowed for other file types, so I don't see a need to add complexity to treat files differently, unless there's a demonstrated need. -- Alexandre Julliard julli...@winehq.org

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > I don't see the point. Do you actually have an app that depends on this? When I started to work on this I had an app that has one of the reasons to require running under Vista+ was the difference in overlapped IO behavior. On the other hand the tests clearly show that

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 3 ++- > dlls/ntdll/tests/file.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) I don't see the point. Do you actually have an app that depends on this? -- Alexandre Julliard julli...@winehq.org

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your paranoid andr

Re: [2/2] shlwapi: Write file access also assumes read access.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2215 Your paranoid andr

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Dmitry Timoshkov
(INVALID_HANDLE_VALUE, buf, 0,&bytes, NULL); > > +todo_wine > > +ok(!ret, "ReadFile should fail\n"); > > +todo_wine > > +ok(GetLastError() == ERROR_INVALID_HANDLE, "expected > > ERROR_INVALID_HANDLE, got %d\n", GetLastError()); > > + ok(

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Nikolay Sivov
On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote: --- dlls/ntdll/tests/file.c | 41 + 1 file changed, 41 insertions(+) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 120fdac..5ae605b 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls

Re: ntdll: Add a file access test.

2013-09-13 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Nikolay Sivov wrote: > >> >> It looks like it belongs to kernel32/tests. >> > Since actual access checks are done by ntdll APIs I believe that >> > ntdll/tests >> > is appropriate place, kernel32 file APIs are just wrappe

Re: ntdll: Add a file access test.

2013-09-13 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > >> It looks like it belongs to kernel32/tests. > > Since actual access checks are done by ntdll APIs I believe that ntdll/tests > > is appropriate place, kernel32 file APIs are just wrappers around the tested > > functionality. > >

Re: ntdll: Add a file access test.

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 12:16, Dmitry Timoshkov wrote: Nikolay Sivov wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. It doesn&#

Re: ntdll: Add a file access test.

2013-09-13 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. -- Dmitry.

Re: ntdll: Add a file access test.

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 11:20, Dmitry Timoshkov wrote: This test passes under Wine and shows that ReadFile after CreateFile(GENERIC_WRITE) is really supposed to fail. --- dlls/ntdll/tests/file.c | 82 + 1 file changed, 82 insertions(+) It looks like it

Re: Sort the AUTHORS file by their last names.

2013-09-02 Thread Tae Wong
Hentschel said: you would need to fix the generation and wanted to change the order of the AUTHORS file. The message you posted in Mon, Sep 2, 2013 at 3:24 PM has a text file (AUTHORS) containing all authors sorted alphabetically by their last names. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-09-02 Thread André Hentschel
Am 02.09.2013 08:24, schrieb Tae Wong: > Add more authors from the GIT log. > > Commit this patch. > > > It seems you have some need to change the order of the AUTHORS file, but it's autogenerated, so you would need to fix the generation. And Michael already pointed ou

Re: Sort the AUTHORS file by their last names.

2013-08-20 Thread Tae Wong
Non-Dutch names like Van Buggenhaut can be placed under V instead. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Non-Dutch names starting with a last name of van can be placed under v and d can be placed under d. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Ken Sharp
This is clearly going nowhere.

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Particles "van" and "de" can be parts of last name for non-Dutch persons. On 8/17/13, Michael Stefaniuc wrote: > On 08/16/2013 09:33 PM, Tae Wong wrote: >> You have to manually update it by adding all authors from the GIT log. >> >> The attachment is here at first message. > That one you did is n

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 09:33 PM, Tae Wong wrote: > You have to manually update it by adding all authors from the GIT log. > > The attachment is here at first message. That one you did is not correct either: - I see some Spanish "double" last names sorted by the 2nd one instead of the first. - In Dutch th

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
You have to manually update it by adding all authors from the GIT log. The attachment is here at first message. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Frédéric Delanoy
On Fri, Aug 16, 2013 at 6:51 PM, Tae Wong wrote: > Older revisions sort them by last name instead of text line. > > Your file contains all of the names sorted on last name. > > The current revision contains all names sorted in first name, not last name. The old revisions were u

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Older revisions sort them by last name instead of text line. Your file contains all of the names sorted on last name. The current revision contains all names sorted in first name, not last name. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 05:40 PM, Tae Wong wrote: > In the GIT tree, the AUTHORS file is sorted on first names. Wrong. It is sorted by the text line. The first word on the line can be the first or lastname, depending what the author used. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
In the GIT tree, the AUTHORS file is sorted on first names. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 04:42 PM, Tae Wong wrote: > Julliard said that it should feel free to provide a script that sorts > by last name. > > You want to do this. Careful. It is a trap. He is fine with it if it is done *right*. Figuring out what the last name is is a hard problem. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Julliard said that it should feel free to provide a script that sorts by last name. You want to do this. -- Tae Wong

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Alexandre Julliard
Tae Wong writes: > Wow! It is sorted on the first names, not on the last names... > > You want to apply the patch. When you sort developers in alphabetical > order, you must choose first names or last names. It's autogenerated, so it's simply sorted textually. Feel free to provide a script that

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Tae Wong
Wow! It is sorted on the first names, not on the last names... You want to apply the patch. When you sort developers in alphabetical order, you must choose first names or last names. You want to sort it by last names. This patch contains several names with particles (de Saedeleer, Van Assche...)

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Ken Sharp
On 16/08/13 14:46, Tae Wong wrote:> The AUTHORS file have all developers from the GIT log which were > sorted on their first names. > > This patch will switch the sort order from first to last names. This isn't how the AUTHORS file is generated. http://source.winehq.org/gi

Re: ntdll/tests: test FileDispositionInformation file class

2013-08-12 Thread Marvin
anoid android. === WXPX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c002) === WVISTAX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.

2013-06-28 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch fixes the problem reported in the bug 2770, hopefully it's still > > acceptable during code freeze. > > Is there an application that's fixed by this? According to bug 2770, > that app only crashes a little further on (which is of course an > improvement,

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.

2013-06-28 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch fixes the problem reported in the bug 2770, hopefully it's still > acceptable during code freeze. Is there an application that's fixed by this? According to bug 2770, that app only crashes a little further on (which is of course an improvement, but not wort

Re: [PATCH] [cmd, try2] move filename . deletes file

2013-06-13 Thread Bruno Jesus
On Thu, Jun 13, 2013 at 12:23 PM, Alexandre Julliard wrote: > > Jason Edmeades writes: > > > move is not tollerent of the source and destination being the same > > and happily removes the destination (after prompting) ready to > > move the file, only to appear shocked

Re: [PATCH] [cmd, try2] move filename . deletes file

2013-06-13 Thread Alexandre Julliard
Jason Edmeades writes: > move is not tollerent of the source and destination being the same > and happily removes the destination (after prompting) ready to > move the file, only to appear shocked that the file is no longer > there... > > This was sent originally where I compa

Adding names to the authors file.

2013-05-24 Thread Tae Wong
The only Croatian person is Marko Nikolić, but with no accented letter. Could you also add Joško Nikolić (the Croatian translator) and Volkan Gezer (the Turkish translator) to the authors file as well? The file name (in all capitals) is AUTHORS. It is very great so that you have to accentuate

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.

2013-04-26 Thread Tae Wong
You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)

2013-04-23 Thread Christian Costa
y used structs, I think > we shouldn't use a typedef. Also the struct is only used to determine the > size and for nothing else? There may be a better way to do that... Maybe > something like in dlls/windowscodecs/icoformat.c ? > > I think you got inspired by dlls/windowscode

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)

2013-04-23 Thread Rico Schüller
u got inspired by dlls/windowscodecs/bmpdecode.c, there is the same issue. Why do we need a typedef, if we only use it in one file to calculate the size? +BITMAPFILEHEADER *header; +if ((header_size == sizeof(BITMAPINFOHEADER)) || +(header_size == sizeof(BITMAPV4H

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.

2013-04-22 Thread Christian Costa
Wich DIB types ? Are you referring to BI_BITFIELDS compression ? I just looked at windows codecs code and there this code to handle color masks: /* if this is a BITMAPINFOHEADER with BI_BITFIELDS compression, we need to read the extra fields */ if (This->bih.bV5Size == sizeof(BITM

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.

2013-04-22 Thread Alexandre Julliard
Christian Costa writes: > +if (header_size == sizeof(BITMAPINFOHEADER)) > +{ > +BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; > +ULONG count = header->biClrUsed; > + > +if (!count && header->biBitCount <= 8) > +count = 1 << header->biBitCount; >

Re: spec file and -arch

2013-03-08 Thread André Hentschel
Am 05.03.2013 22:57, schrieb Stefan Leichter: > Hi, > > when i look into msvcr100.spec file i find lots of different parameters for > the > switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . > > To me it is not clear what is the difference bet

spec file and -arch

2013-03-05 Thread Stefan Leichter
Hi, when i look into msvcr100.spec file i find lots of different parameters for the switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . To me it is not clear what is the difference between win64 and x86_64. The same for i386 and win32. What are is the criteria to

Fix name order in the authors file.

2013-02-27 Thread Tae Wong
You’ve found Kazuyuki Sato in inverted name order. Apostrophes on the O-section are not ignored. O'Callahan, Robert O'Neill, Damien O'Regan, Mike Oberhumer, Stefan Oberndorfer, Peter Ogburn, Walt Ognyanoff, Damyan Olsen, Henrik Olsen, Magnus Olson, Roger Olver, Neil Ortiz, Jose Manuel Ferrer Osmun

Re: [PATCH] ieframe/tests: Don't convert to long path name until the file exists

2013-01-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24128 Your paranoid android

Re: [PATCH (try3)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23822 Your paranoid android

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-09 Thread Vincent Povirk
Series looks fine to me. And yes, testbot has been broken for a while now..

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Jacek Caban
/tests/webbrowser.c | 56 > ++--- > 2 files changed, 59 insertions(+), 4 deletions(-) > > > 0001-ieframe-Strip-file-from-file-URLs-in-BEFORENAVIGATE2.patch > > > diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c > index dd4a976..2601ba8 100644 &

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android

Re: [PATCH] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-08 Thread Dmitry Timoshkov
Marvin wrote: > === WINEBUILD (build) === > Patch failed to apply Looks like testbot is broken. -- Dmitry.

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23802 Your paranoid android

Re: [PATCH 4/6] server: Store and return security attributes with extended file attributes (try 5).

2012-12-09 Thread Anssi Hannula
03.12.2012 23:13, Erich E. Hoover kirjoitti: > On Sun, Dec 2, 2012 at 5:28 PM, Anssi Hannula wrote: >> ... >> I don't see the need for an uppercase "WINEACL" in the attribute name, >> especially since all the examples in e.g. attr(5) are lowercase. >> Moreover, [1] recommends using application spe

Re: [PATCH 4/6] server: Store and return security attributes with extended file attributes (try 5).

2012-12-03 Thread Erich E. Hoover
On Sun, Dec 2, 2012 at 5:28 PM, Anssi Hannula wrote: > ... > I don't see the need for an uppercase "WINEACL" in the attribute name, > especially since all the examples in e.g. attr(5) are lowercase. > Moreover, [1] recommends using application specific namespaces in the > attribute name, so IMHO a

Re: [PATCH 4/6] server: Store and return security attributes with extended file attributes (try 5).

2012-12-02 Thread Anssi Hannula
Hi, 27.11.2012 00:45, Erich E. Hoover kirjoitti: > This patch adds the ability to store and retrieve the security > attributes of a file by turning them into extended file attributes (if > available). These attributes are stored in the attribute > "user.WINEACL" in the

Re: [PATCH 2/2] winmm: Fix handling of mmio file buffers.

2012-11-20 Thread Alexandre Julliard
Akihiro Sagawa writes: > This fix bug 19566 and 32013. > --- > dlls/winmm/mmio.c | 31 +-- > dlls/winmm/tests/mmio.c | 16 > 2 files changed, 21 insertions(+), 26 deletions(-) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P

Re: [PATCH 5/7] server: Store and return security attributes with extended file attributes (try 2).

2012-11-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22726 Your paranoid android

Re: [PATCH 5/7] server: Store and return security attributes with extended file attributes.

2012-11-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22707 Your paranoid android

Re: [PATCH 5/7] server: Store and return security attributes with extended file attributes.

2012-11-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22706 Your paranoid android

Re: [PATCH 1/3] ntdll: Implement nanosecond precision file time storage (try 2).

2012-10-23 Thread Alexandre Julliard
"Erich E. Hoover" writes: > @@ -2048,17 +2048,26 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, > PIO_STATUS_BLOCK io, > > if (info->LastAccessTime.QuadPart || > info->LastWriteTime.QuadPart) > { > +#ifdef HAVE_FUTIMENS > +struct timespec tv[2

Re: [PATCH 1/3] ntdll: Implement nanosecond precision file time storage.

2012-10-19 Thread Alexandre Julliard
"Erich E. Hoover" writes: > This series of patches provides a fix for Bug #31858 (Netflix Internet > Connection Problem). With this particular patch the POSIX.1-2008 > futimens() function is used to replace the BSD futimes() function, > allowing for nanosecond precision

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-17 Thread Christian Costa
that? > > > I'm not against improving the testbot, it was just a suggestion. > > > > > It's a good one.I will file a bug in bugzilla for the test bot and try > > your suggestion. > > Do you know any simple tool that enables to do that? > >

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-17 Thread Dmitry Timoshkov
: > > be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. > > That way the tests don't depend on any external files, or abilities in > > the tested environment to download them. > > > It seems a bit complicated for a test I will run only once and n

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-16 Thread Francois Gouget
the testbot, it was just a suggestion. > > > It's a good one.I will file a bug in bugzilla for the test bot and try > your suggestion. > Do you know any simple tool that enables to do that? If the sfx approach can be made to work without changes to WineTestBot then it may be wort

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Austin English
gt; Indeed that would be great to be able to download some files along >>>>>>> with >>>>>>> the >>>>>>> test. >>>>>>> Typically for me avi files and dlls (or .drv) would be great ! :D >>>>>> >>>

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Christian Costa
that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Austin English
stian Costa wrote: >>>> >>>>> Indeed that would be great to be able to download some files along with >>>>> the >>>>> test. >>>>> Typically for me avi files and dlls (or .drv) would be great ! :D >>>> >>>

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Christian Costa
dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them. It

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Austin English
lly for me avi files and dlls (or .drv) would be great ! :D >> >> Just do what other tests do: embed all the required data into the test: >> be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. >> That way the tests don't depend on any external fil

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Christian Costa
: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them. It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Dmitry Timoshkov
etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them. -- Dmitry.

Re: testbot/lib: If we cannot open the log file, then log to stderr.

2012-10-15 Thread Christian Costa
estBot/Log.pm | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/testbot/lib/WineTestBot/Log.pm > b/testbot/lib/WineTestBot/Log.pm > index 6883968..7de6dcb 100644 > --- a/testbot/lib/WineTestBot/Log.pm > +++ b/testbot/lib/WineTestBo

Re: [1/3] cmd/tests: Show name of current test file on standard output

2012-10-11 Thread Alexandre Julliard
Frédéric Delanoy writes: > When there are several test files, indicates which file error line numbers > relate to, making > "debugging" easier. That's what trace() is for. -- Alexandre Julliard julli...@winehq.org

Re: shell32: Fix ShellExecute()'s handling of file URLs.

2012-10-10 Thread Marvin
anoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "

Re: [2/4] winemaker: Generate def file from spec file with winebuild (try 2)

2012-10-10 Thread Alexandre Julliard
André Hentschel writes: > @@ -2569,6 +2570,7 @@ sub generate_project_files($) > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) > \$(${canon}_MODULE:.dll=.def)\n"; >} elsif (@$target[$T_TYPE] == $TT_DLL) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS)

Re: [3/3] winemaker: Generate def file from spec file with winebuild

2012-10-09 Thread Alexandre Julliard
André Hentschel writes: > @@ -2576,7 +2577,9 @@ sub generate_project_files($) >if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & > $TF_HASDEF)) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) > \$(${canon}_MODULE:.dll=.def)\n"; >} elsif (@$t

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-25 Thread Per Johansson
> The alternative would be to write a new program. The advantage to that > is: > > Start.exe already has a /unix option so adding a /AppleEvent one may > make sense. > > I have two questions though (I apologize if careful reading the patch > would answer them). > > H

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-25 Thread Francois Gouget
On Tue, 25 Sep 2012, Per Johansson wrote: > Hi, > > I should probably add a note that when I wrote this I had some doubts it it > belongs in start.exe, and I still somewhat do. > > The alternative would be to write a new program. The advantage to that is: Start.exe already has a /unix option so

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-24 Thread Per Johansson
action with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson > 0006-start-Support-getting-the-file-to-open-by-AppleEvent.patch Description: Binary data

Re: shell32: Add tests for ShellExecute()'s handling of file URLs. (try2)

2012-09-19 Thread Marvin
anoid android. === WNT4WSSP6 (32 bit shlexec) === Timeout === W2KPROSP4 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test faile

Re: [7/8] winemenubuilder: Use a dispatch table to access XDG specific parts, extracted to different file.

2012-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21662 Your paranoid android

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.

2012-09-19 Thread Juan Lang
Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif +test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_ex

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.

2012-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android

Re: shell32: Make ShellExecute use native file association databases as fallback path (resend)

2012-08-28 Thread Alexandre Julliard
; + > +if (stat(openCmd, &st) == -1) > +{ > +TRACE("stat() %s failed: %s\n", openCmd, strerror(errno)); > +return retval; > +} > + > +cpid = fork(); > +if (!cpid) > +{ > +/* Prevent the situation where the n

Re: mountmgr.sys: For loop-mounted devices, use the backing file

2012-08-21 Thread Damjan Jovanovic
On Tue, Aug 21, 2012 at 4:25 PM, GOUJON Alexandre wrote: > I thought mounting the ISO should be the same thing than inserting the disc > in the drive. > But you seem to think that the current behaviour is the right one so in this > case, simply ignore my patch. > > Try using cdemu to load that I

Re: mountmgr.sys: For loop-mounted devices, use the backing file

2012-08-21 Thread GOUJON Alexandre
evice. The game was calling GetVolumeInformation to check its serial and to do so, GetVolumeInformation has to look at some blocks at specific offsets. But seeking (SetFilePointer) and reading (ReadFile) is not the same with the handle of the loop device and the ISO file. So I had to manually chang

Re: mountmgr.sys: For loop-mounted devices, use the backing file

2012-08-21 Thread Alexandre Julliard
Alexandre Goujon writes: > As part of their copy protection, some games use some ioctl's to check some > physical attributes. > Unfortunately, when using the loop device, some ioctl fail (like > IOCTL_SCSI_GET_ADDRESS). > A simple fix is to use /path/to/the/file.ISO instead of /dev/loopX. Seve

Re: start: Support getting the file to open by AppleEvent.

2012-07-26 Thread Per Johansson
24 jul 2012 kl. 17:49 skrev Per Johansson: > I've also managed to write a function which fetches the AppleEvent using > Objective-C, which can be seen here: > <https://github.com/morth/molae/blob/master/molae.m>. > > I suppose if there's no way to get this file

Re: start: Support getting the file to open by AppleEvent.

2012-07-24 Thread Per Johansson
-C, which can be seen here: <https://github.com/morth/molae/blob/master/molae.m>. I suppose if there's no way to get this file into wine I could make it into a library and check for it in configure. Would that be the most proper approach? Regrads, -- Per Johansson

Re: start: Support getting the file to open by AppleEvent.

2012-07-19 Thread Per Johansson
19 jul 2012 kl. 18:11 skrev Alexandre Julliard : > Per Johansson writes: > >> Uses a private API. > > You really don't want to do that. Alright, but like I said earlier there's really no other good way to support associations without using Objective-C. I'll send a new version without associ

Re: start: Support getting the file to open by AppleEvent.

2012-07-19 Thread Alexandre Julliard
Per Johansson writes: > Series goal: Implement app bundle start menu / file type associations on OS X. > > > From 681ea02fb9e3df819f812e359d3fe76c77423e32 Mon Sep 17 00:00:00 2001 > From: Per Johansson > Date: Tue, 17 Apr 2012 21:29:13 +0200 > Subject: start: Support gettin

Re: Suppressing My Computer in File Open dialog box?

2012-07-14 Thread Dan Kegel
On Sat, Jul 14, 2012 at 2:03 AM, GOUJON Alexandre wrote: >> Does anyone know how to keep the Save File dialog box from >> listing My Computer in the LookIn pulldown? > > Have you read > http://msdn.microsoft.com/en-us/library/windows/desktop/ms646

Re: Suppressing My Computer in File Open dialog box?

2012-07-14 Thread GOUJON Alexandre
I've been meaning to do ever since I helped port Picasa. Picasa was an easy case, since it didn't use any standard widgets. So now I'm wondering how to coax standard widgets into not leaking Windows paths or naming conventions visually. Does anyone know how to keep the Save File dia

Suppressing My Computer in File Open dialog box?

2012-07-13 Thread Dan Kegel
elped port Picasa. Picasa was an easy case, since it didn't use any standard widgets. So now I'm wondering how to coax standard widgets into not leaking Windows paths or naming conventions visually. Does anyone know how to keep the Save File dialog box from listing My Computer in the LookI

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.

2012-06-21 Thread Eric Pouech
one tricky question... could it be that on windows this test behaves differently on ntfs vs FAT filesystem ? or what would give re-opening the file after the deletefile call ? A+ 2012/6/21, Dmitry Timoshkov : > Previous version had a typo in file name. > --- > dlls/kernel32/tests/fi

Re: kernel32: Add a test for deleting an opened for reading file.

2012-06-21 Thread Marvin
anoid android. === WNT4WSSP6 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2KPROSP4 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === WXPPROSP3 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2K3R2SESP2 (32 bit file) === file.c:3255: Test f

  1   2   3   4   5   6   7   8   9   10   >