Re: winscard stub dll

2007-05-16 Thread Mounir IDRASSI
Hi Francois, Thanks for your modifications. I'll review your patch and submit it if I have no comments, ِCheers, Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Francois Gouget wrote: > Hi, > > Here's a new version of the patch that removes the casts as suggested >

Re: winscard stub dll

2007-05-15 Thread Francois Gouget
Hi, Mounir IDRASSI wrote: Hi, Apart from Alexandre comment, I don't see any other possible changes. Here's a new version of the patch that removes the casts as suggested by Alexandre. -- Francois Gouget [EMAIL PROTECTED] commit 86fd1bdb35906c5601ff9b44ac2cbd6c35cdfbd9 Author: Francois Goug

Re: winscard stub dll

2007-05-15 Thread Mounir IDRASSI
Hi, Apart from Alexandre comment, I don't see any other possible changes. So, if the first patch containing the API headers is OK, I can submit the winscard stub patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Francois Gouget <[EM

Re: winscard stub dll

2007-05-15 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > But then on a 64bit system an __int64 should be the same as a long so > maybe it's ok anyway. Yes, __int64 is a long on Win64. > The only issue that could happen is if we try to compile Wine's dlls > on a 64bit Windows system using Visual C++. Isn't

Re: winscard stub dll

2007-05-15 Thread Francois Gouget
Alexandre Julliard wrote: Francois Gouget <[EMAIL PROTECTED]> writes: * I would really have liked to get rid of the (unsigneg int) casts, but as the handle types are ULONG_PTRs it seems like it won't be possible. That's quite annoying. If anyone has suggestions... ULONG_PTRs are longs, they

Re: winscard stub dll

2007-05-15 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > * I would really have liked to get rid of the (unsigneg int) casts, but > as the handle types are ULONG_PTRs it seems like it won't be possible. > That's quite annoying. If anyone has suggestions... ULONG_PTRs are longs, they should be printed with

winscard stub dll

2007-05-15 Thread Francois Gouget
As I was working on the winscard headers, I also did small tweaks on the winscard stub implementation. I admit it's mostly whitespace changes: * removed unneeded #includes. They should be added back when the implementation actually requires them. * use LPCBYTE like in the headers instead of 'c