Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-27 Thread Simon Barber
On Mon, Jun 27, 2016 at 1:59 AM, Alexis La Goutte wrote: > Hi Joerg, > > > On Mon, Jun 27, 2016 at 12:07 AM, Joerg Mayer wrote: > >> Hello, >> >> I plan to do some cleanups to >> - somewhat improve the readability of the code >> 1) Get rid of reduntant author entries and code comments, see >>

Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-27 Thread Bill Meier
On 6/26/2016 6:07 PM, Joerg Mayer wrote: Hello, I plan to do some cleanups to - somewhat improve the readability of the code 1) Get rid of reduntant author entries and code comments, see https://code.wireshark.org/review/16154 2) Get rid of those fixed field functions that only add o

Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-27 Thread Alexis La Goutte
Hi Joerg, On Mon, Jun 27, 2016 at 12:07 AM, Joerg Mayer wrote: > Hello, > > I plan to do some cleanups to > - somewhat improve the readability of the code > 1) Get rid of reduntant author entries and code comments, see > https://code.wireshark.org/review/16154 Mixed opinion about this c

Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-26 Thread Simon Barber
great idea. I'll wait for your changes before adding a feature - I'd like to be able to filter out beacons by writing wlan.beacon, probes by wlan.probe_request, etc. Simon On Sun, Jun 26, 2016 at 3:07 PM, Joerg Mayer wrote: > Hello, > > I plan to do some cleanups to > - somewhat improve the rea

[Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-26 Thread Joerg Mayer
Hello, I plan to do some cleanups to - somewhat improve the readability of the code 1) Get rid of reduntant author entries and code comments, see https://code.wireshark.org/review/16154 2) Get rid of those fixed field functions that only add one of two items. Call the remaining funct