Signed-off-by: Amadeusz Sławiński
---
WINGs/wbrowser.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/WINGs/wbrowser.c b/WINGs/wbrowser.c
index d390407..03b75ad 100644
--- a/WINGs/wbrowser.c
+++ b/WINGs/wbrowser.c
@@ -375,8 +375,6 @@ void WMSetBrowserTitled(WMBrowser * bPtr, Bool flag)
Hey,
so seeing as various utilities report different stuff, here are patches
for dead assignments reported by clang.
Amadeusz
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Signed-off-by: Amadeusz Sławiński
---
wrlib/load_jpeg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/wrlib/load_jpeg.c b/wrlib/load_jpeg.c
index 178d5d9..ded519e 100644
--- a/wrlib/load_jpeg.c
+++ b/wrlib/load_jpeg.c
@@ -136,7 +136,8 @@ RImage *RLoadJPEG(const char *file_
Signed-off-by: Amadeusz Sławiński
---
util/wmsetbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/wmsetbg.c b/util/wmsetbg.c
index b52f950..775cc19 100644
--- a/util/wmsetbg.c
+++ b/util/wmsetbg.c
@@ -868,7 +868,6 @@ static int readmsg(int fd, char *buffer, int size)
{
int cou
Signed-off-by: Amadeusz Sławiński
---
wrlib/save_xpm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/wrlib/save_xpm.c b/wrlib/save_xpm.c
index 3e6c976..08cb52e 100644
--- a/wrlib/save_xpm.c
+++ b/wrlib/save_xpm.c
@@ -87,7 +87,6 @@ static Bool addcolor(XPMColor ** list, unsigned r, unsigned
Signed-off-by: Amadeusz Sławiński
---
util/wmmenugen_parse_xdg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/wmmenugen_parse_xdg.c b/util/wmmenugen_parse_xdg.c
index f5cdb58..384f9ee 100644
--- a/util/wmmenugen_parse_xdg.c
+++ b/util/wmmenugen_parse_xdg.c
@@ -363,7 +363,6 @@ static Bo
Signed-off-by: Amadeusz Sławiński
---
WINGs/wframe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/WINGs/wframe.c b/WINGs/wframe.c
index 38547e7..336f839 100644
--- a/WINGs/wframe.c
+++ b/WINGs/wframe.c
@@ -82,9 +82,6 @@ static void paintFrame(Frame * fPtr)
tlen = 0;
Signed-off-by: Amadeusz Sławiński
---
src/misc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/misc.c b/src/misc.c
index 4d008a3..63e7158 100644
--- a/src/misc.c
+++ b/src/misc.c
@@ -279,7 +279,6 @@ char *ShrinkString(WMFont *font, const char *string, int
width)
p = strl
Signed-off-by: Amadeusz Sławiński
---
wrlib/rotate.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/wrlib/rotate.c b/wrlib/rotate.c
index f04b95e..fead8ae 100644
--- a/wrlib/rotate.c
+++ b/wrlib/rotate.c
@@ -77,7 +77,6 @@ RImage *RRotateImage(RImage * image, float angle)
Signed-off-by: Amadeusz Sławiński
---
WINGs/wfilepanel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/WINGs/wfilepanel.c b/WINGs/wfilepanel.c
index 0f12819..968dcc4 100644
--- a/WINGs/wfilepanel.c
+++ b/WINGs/wfilepanel.c
@@ -664,7 +664,6 @@ static void normalizePath(char *s)
{
int
Signed-off-by: Amadeusz Sławiński
---
WINGs/wpanel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/WINGs/wpanel.c b/WINGs/wpanel.c
index 1c1d04f..6e2f9f4 100644
--- a/WINGs/wpanel.c
+++ b/WINGs/wpanel.c
@@ -545,13 +545,11 @@ WMGenericPanel *WMCreateGenericPanel(WMScreen * scrPtr,
WMWindow
Signed-off-by: Amadeusz Sławiński
---
WINGs/wfontpanel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/WINGs/wfontpanel.c b/WINGs/wfontpanel.c
index 0c1d3fd..aede6dd 100644
--- a/WINGs/wfontpanel.c
+++ b/WINGs/wfontpanel.c
@@ -812,7 +812,6 @@ static void setFontPanelFontName(FontPanel * pane
On Sun, 18 May 2014 at 13:32:48 +0200, Amadeusz Sławiński wrote:
> Signed-off-by: Amadeusz Sławiński
> ---
> WINGs/wfilepanel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/WINGs/wfilepanel.c b/WINGs/wfilepanel.c
> index 0f12819..968dcc4 100644
> --- a/WINGs/wfilepanel.c
> +++ b/WINGs
On Sun, 18 May 2014 14:54:22 +0100
"Carlos R. Mafra" wrote:
> On Sun, 18 May 2014 at 13:32:48 +0200, Amadeusz Sławiński wrote:
> > Signed-off-by: Amadeusz Sławiński
> > ---
> > WINGs/wfilepanel.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/WINGs/wfilepanel.c b/WINGs/wfilepane
From: Christophe CURIS
Hello,
This serie of patch fixes the code in WINGs toolkit that are related
to 17 bugs reported by Coverity. 5 bugs should have been fixed from
WUtil fixes (commit 515fb74c0c). It does not fix everything, there
are 5 more
bugs which will probably be ignored (Time of check
From: Christophe CURIS
As pointed by Coverity, there is a small check for NULL pointer when
handling triple-click selection in a WMText, however this check is only
partially implemented so the code would crash later anyway.
This patch implement an appropriate skip to avoid crash, and includes a
l
From: Christophe CURIS
As pointed by Coverity, despite apparent checks the function would fail if
trying to set a NULL title. Instead of trying to do over-complicated things
we just ignore (with a warning if NDEBUG is not set) the case. If user
wants an empty title, the correct way is to provide
From: Christophe CURIS
As pointed by coverity, the case 'index < 0' cannot be true because it was
already earlier and handled with an early return.
Signed-off-by: Christophe CURIS
---
WINGs/wpopupbutton.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/WINGs/wpopupbutton.c b/WINGs/wpopupb
From: Christophe CURIS
As reported by Coverity, in the (rare) case where the wstrlcat would fail
the array for the result would not be freed before returning.
Signed-off-by: Christophe CURIS
---
WINGs/wbrowser.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/WINGs/wbrowser.c b/WINGs/wbrow
From: Christophe CURIS
As pointed by Coverity, a temporary WMArray was not freed after use.
Signed-off-by: Christophe CURIS
---
WINGs/wtext.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/WINGs/wtext.c b/WINGs/wtext.c
index 8641840..b57b6b3 100644
--- a/WINGs/wtext.c
+++ b/WINGs/wtext.c
From: Christophe CURIS
As pointed by Coverity, the data returned by WMGetTextSelectedStream are
actually a newly allocated buffer, so we need to release it when we're done
with it.
Signed-off-by: Christophe CURIS
---
WINGs/wtext.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/WINGs/wtext
From: Christophe CURIS
As pointed by Coverity, the variable 'dir' is passed by reference because
the function may update it; as it is never NULL (the function is local)
checking for that does not make sense. From the actual usage, it seems
logical that the check should have been on the value, not
From: Christophe CURIS
As pointed by Coverity, the allocated temporary storage was not freed. As
an allocation is not needed here, replaced by a local storage.
---
WINGs/wtextfield.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/WINGs/wtextfield.c b/WINGs/wtex
From: Christophe CURIS
As reported by Coverity, the function 'WMGetTextFieldText' allocates memory
to generate the result string, so it has to be freed.
Signed-off-by: Christophe CURIS
---
WINGs/wcolorpanel.c | 43 ---
1 file changed, 32 insertions(+), 1
From: Christophe CURIS
As pointed by Coverity, the array used to build the result for the
function 'getStreamObjects' could leak in case of early return.
Signed-off-by: Christophe CURIS
---
WINGs/wtext.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/WINGs/wtext.c b/WIN
From: Christophe CURIS
As pointed by Coverity, there is a NULL pointer check at the end of the
function 'deleteFile' (which happens to not be necessary because wfree was
made to accept NULL pointers), however there are many things done before
that assumes the pointer is not NULL. The check is mov
From: Christophe CURIS
As pointed by Coverity, the 'paintItem' function in the WMBrowser widget
is checking for nullity of its text argument, but before that it called the
strlen function which crashes on NULL pointer. This patch moves the strlen
call to the right place and reduce the lifespan of
From: Christophe CURIS
As reported by Coverity, the structure containing the callback functions
to handle the drag-and-drop actions could be freed but later re-used.
The correct behaviour is to keep the allocated memory for the structure.
Signed-off-by: Christophe CURIS
---
WINGs/dragdestinati
From: Christophe CURIS
When the condition can be simply checked in an if, it is better to do that
than to use a flow breaking goto.
Signed-off-by: Christophe CURIS
---
WINGs/wtext.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/WINGs/wtext.c b/WINGs/wtext.c
ind
From: Christophe CURIS
As pointed by Coverity, the code was checking for NULL pointer to avoid
misbehaviour, but it actually dereferenced the pointer beforehand so the
crash would still happen.
Signed-off-by: Christophe CURIS
---
WINGs/wcolorpanel.c | 9 +
1 file changed, 5 insertions(
Somehow I missed that my original patch did exactly the opposite of what it
should have. Carlos, could you patch this over the original?
Thanks!
---
WPrefs.app/Appearance.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c
On Sun, 18 May 2014 at 14:41:14 -0500, Doug Torrance wrote:
> Somehow I missed that my original patch did exactly the opposite of
> what it should have. Carlos, could you patch this over the original?
Done.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
On 05/17/2014 09:43 AM, Christophe wrote:
From: Christophe CURIS
It makes code simpler and less prone to errors.
---
WPrefs.app/Appearance.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c
index 21dad63..ce54e
On Sun, 18 May 2014 at 15:45:35 -0500, Doug Torrance wrote:
> On 05/17/2014 09:43 AM, Christophe wrote:
> >From: Christophe CURIS
> >
> >It makes code simpler and less prone to errors.
> >---
> > WPrefs.app/Appearance.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
>
In response to Amadeusz's comments regarding my patch "WPrefs: Add ability to
edit FrameBorderColor/FrameSelectedBorderColor", this new patch attempts to
reduce the confusion between focused and selected windows. In particular,
only the frame border color for non-selected windows appears in the pr
35 matches
Mail list logo