[PATCH] Fixed xinerama detection

This patch fixes xinerama configure script auto detection when the libs are setup but the headers are missing. Without it, configure script is stopping on my system with the msg: "found no but cannot compile with the header". 0001-Fixed-xinerama-detection.patch Description: Binary data

[PATCH] Removed refs to connect and server examples

This patch is used to remove references to missing code files. 0001-Removed-refs-to-connect-and-server-examples.patch Description: Binary data

Re: [PATCH] Removed refs to connect and server examples

sure, thanks. On Wed, Feb 12, 2014 at 10:20 PM, Carlos R. Mafra wrote: > On Wed, 12 Feb 2014 at 22:04:36 +0800, David Maciejak wrote: >> This patch is used to remove references to missing code files. > > Thanks for the patches! > > In the future please consider inlining t

[PATCH] Fixed label display truncated for 'delays in ms for autocollapsing clips'

This patch is fixing some label truncated in WPrefs.app --- WPrefs.app/Docks.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/WPrefs.app/Docks.c b/WPrefs.app/Docks.c index 91fa338..e85f5df 100644 --- a/WPrefs.app/Docks.c +++ b/WPrefs.app/Docks.c @@ -169,7 +169,7

Re: [PATCH] Fixed label display truncated for 'delays in ms for autocollapsing clips'

please find enclosed the patch regards, david On Thu, Feb 13, 2014 at 12:12 AM, Carlos R. Mafra wrote: > Thanks for the inlined patch, but it seems your mail client > screwed up the patch (it does not apply). > >> WMMoveWidget(panel->autoDelayF[k], 15, 10 + k * 110); >> if (k == 0) >> WMSe

Re: [PATCH] Fixed xinerama detection

On Thursday, February 13, 2014, Christophe wrote: > From: Christophe CURIS > > > The proper behaviour that was expected is to accept silently that > libXinerama may not be missing, and only stop compilation when the lib > is present but not its header. Yes, in fact I did want to change that beh

[PATCH] WINGs: Added support for syslog msg

This patch is used to add support for syslog messaging implemented in WINGs lib directly, so available from the lib itself and wmaker too. I believe it will in a first time help to get some logging info centralized in one point, and in a second time maybe add some info level messages like wmaker is

[REQUEST] info/legal panel not closing using shortcut

Hi, I will need some help on updating some code in src/dialog.c I am trying to modify the infoPanel and legalPanel to let them handle close window event shortcut i configured from WPrefs.app. Seems at least both of them do not handle correctly the destroy event that is sent, even if i add a call

Re: [PATCH] WINGs: Added support for syslog msg

nlog(prog_name, options, LOG_DAEMON); so syslog log will contain "wmaker[pid]:" followed by the msg from the original log regards, david On Thu, Feb 13, 2014 at 8:19 PM, Carlos R. Mafra wrote: > On Thu, 13 Feb 2014 at 19:04:41 +0800, David Maciejak wrote: >> This patc

[PATCH] WINGs: Removed warning msgs from compiler

This patch contains some cleanup for compiler warnings and a comment typo fix --- WINGs/error.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/WINGs/error.c b/WINGs/error.c index e129eee..61c3cc0 100644 --- a/WINGs/error.c +++ b/WINGs/error.c @@ -46,6 +46,8 @@ void sys

[PATCH] wrlib: Improved NETPBM support, file format detection and fixed test compilation

Hi, I know some of you will say that patch is not sexy :) It's my first look into wrlib. I will provide more. The patch is working on that: 1) the tests examples were not compiling cause of a missing X11 lib call 2) load.c is used to identify the file format, i rebased the checks on what is prov

[PATCH] wrlib: Added support for webp image

Hi, this patch is adding support for google webp image format, if you don't know it a quick recap is to say that according to their tests it's better than png and jpeg. Follow the link below for some more details: https://developers.google.com/speed/webp/ patch inlined and enclosed. ps: next ta

Re: Re : [PATCH] wrlib: Improved NETPBM support, file format detection and fixed test compilation

On Sun, Feb 23, 2014 at 12:24 PM, Christophe wrote: > > - David Maciejak a écrit : >> Hi, >> >> I know some of you will say that patch is not sexy :) >> It's my first look into wrlib. I will provide more. >> >> The patch is working on that:

Re: Re : [PATCH] WINGs: Added support for syslog msg

> Hi, > > Sorry to bring those suggestions below a bit late... > > > - David Maciejak a écrit : >> [...] >> >> diff --git a/WINGs/WINGs/WUtil.h b/WINGs/WINGs/WUtil.h >> index 246ef2d..b2e76ab 100644 >> --- a/WINGs/WINGs/WUtil.h >> +++ b/WI

[PATCH] Added webp return error code

Based on the feedback from Christophe, this patch is adding some error code report for webp module. Patch is inlined and enclosed. regards, david --- wrlib/load_webp.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/wrlib/load_webp.c b/wrlib/load_webp.c

Re: [PATCH] Added webp return error code

oops sorry, please see the one enclosed On Mon, Feb 24, 2014 at 10:03 PM, Carlos R. Mafra wrote: > On Mon, 24 Feb 2014 at 20:37:09 +0800, David Maciejak wrote: >> Based on the feedback from Christophe, this patch is adding some error >> code report for webp module. >> &g

[PATCH] Added ppm return error code

This patch is adding some more error code return value for ppm module. --- wrlib/load_ppm.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/wrlib/load_ppm.c b/wrlib/load_ppm.c index b45d0f0..e8e1ab3 100644 --- a/wrlib/load_ppm.

[PATCH] Fixed WEBP image detection

This patch is used to fix the return statement which is not at the good place and add the function synopsis in the header. --- wrlib/imgformat.h | 4 wrlib/load.c | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/wrlib/imgformat.h b/wrlib/imgformat.h index 29ad41

Re: [PATCH] Fixed WEBP image detection

Sure, do at your convenience. thanks, david On Thu, Feb 27, 2014 at 5:05 PM, Carlos R. Mafra wrote: > On Thu, 27 Feb 2014 at 13:24:29 +0800, David Maciejak wrote: >> This patch is used to fix the return statement which is not at the >> good place and add the function synopsi

[PATCH] Updated copyright date

This patch is just updating the year in the copyright. --- src/dialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dialog.c b/src/dialog.c index 43f12fc..69fd31d 100644 --- a/src/dialog.c +++ b/src/dialog.c @@ -1106,7 +1106,7 @@ typedef struct { #define COPYRIGHT_TEX

[PATCH] Fixed compiler warnings in WPrefs

This patch is used to catch some return function value, to make the compiler happy. --- WPrefs.app/Appearance.c| 15 +++ WPrefs.app/MouseSettings.c | 4 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c index 3b

[PATCH] wrlib: WEBP header fixes

Again, a patch to clean-up webp code. --- wrlib/imgformat.h | 2 +- wrlib/load.c | 2 +- wrlib/load_webp.c | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/wrlib/imgformat.h b/wrlib/imgformat.h index 9e739d8..43df3ec 100644 --- a/wrlib/imgformat.h +++ b/wrlib/imgforma

[PATCH] Scale image to fit in preview panel

This patch is used to scale image to fit in the icon preview panel. Moreover, i encountered a bug in the preview icon list that I am currently trying to resolve. Hopefully i will send another patch for that. --- WINGs/WINGs/WINGs.h|2 +- WINGs/wpixmap.c| 16 +++

Re: [PATCH] Scale image to fit in preview panel

On Fri, Mar 7, 2014 at 7:13 PM, Carlos R. Mafra wrote: > On Fri, 7 Mar 2014 at 8:46:33 +0800, David Maciejak wrote: >> This patch is used to scale image to fit in the icon preview panel. >> > > Thanks for the patch, I think I once noticed this problem when setting > a

[PATCH] Fixed unknown image format detection in Icon Chooser preview mode

When pressing the Preview button from Icon chooser, a list of preview icons is displayed. When a unknown image format is encountered the list is showing duplicated entries. That patch is correcting that issue and adding rescale feature to that preview show. --- src/dialog.c | 12 ++-- 1

[PATCH] wrlib: added support for imagemagick third-party lib

This patch is providing support for some common image format like SVG, BMP, PICT, ... Please test ! --- configure.ac | 27 +++ m4/wm_imgfmt_check.m4 | 20 +++ src/dialog.c |8 +++-- src/main.c|1 + wrlib/Makefile.am |4 +++ wr

[PATCH] Better ImageMagick lib detection

On some systems the library name is not common, now we use the config program to find the right libs to use. --- configure.ac | 16 m4/wm_imgfmt_check.m4 |2 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index edc4b7

[PATCH] RandR misc.

This patch is replacing XRandR naming to RandR, as XRandR is the name of the tool (and the lib) used in X11 and RandR is the technology WMaker wants to support and to show to the end user. I had to update the info panel too, when many features are activated not all of them can be displayed properly

[PATCH] Cleaned releasing application

When an application is created with WMInitializeApplication, it's never destroyed properly. The patch is adding some functions to free the memory and taking as example 'wmsetbg'. Moreover, in wmsetbg.c I also corrected 2 compiler warnings and a possible buffer overflow. Next step is to track down

Re: [PATCH] Cleaned releasing application

tch. > > On Sat, 22 Mar 2014 at 20:25:42 +0800, David Maciejak wrote: >> When an application is created with WMInitializeApplication, >> it's never destroyed properly. >> The patch is adding some functions to free the memory and taking as >> example 'wmsetbg&#

Re: Xinerama related bugs

Hi Josip, it's more or less a known *issue* as xinerama had been deprecated since years and randr support has never been fully implemented in wmaker. regards, david On Thu, Mar 27, 2014 at 9:19 PM, Josip Deanovic wrote: > On Thursday 2014-03-27, Josip Deanovic wrote: >> Greetings! >> >> There

[PATCH 0/3] Added some clean function

When an application is created with WMInitializeApplication, it's never destroyed properly. The 3 patches are adding some functions to free the memory and taking as example 'wmsetbg'. Moreover, in wmsetbg.c I also corrected 2 compiler warnings and a possible buffer overflow. -- To unsubscribe,

[PATCH 1/3] Added cleaned function in wings

--- WINGs/WINGs/WINGs.h | 3 ++- WINGs/notification.c | 12 WINGs/wapplication.c | 11 +++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h index aa95844..6597504 100644 --- a/WINGs/WINGs/WINGs.h +++ b/WINGs/WINGs/WINGs

[PATCH 2/3] Modified commented code to call clean fcts

--- WPrefs.app/TexturePanel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/WPrefs.app/TexturePanel.c b/WPrefs.app/TexturePanel.c index 9f2b86a..530c124 100644 --- a/WPrefs.app/TexturePanel.c +++ b/WPrefs.app/TexturePanel.c @@ -1527,6 +1527,7 @@ int main(int argc, char **argv) ShowTextureP

[PATCH 3/3] Cleaned and fixed sprintf call

--- util/wmsetbg.c | 54 -- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/util/wmsetbg.c b/util/wmsetbg.c index 644c85d..d85eb43 100644 --- a/util/wmsetbg.c +++ b/util/wmsetbg.c @@ -100,6 +100,12 @@ typedef struct BackgroundText

[PATCH] Added clean functions to wrlib

Same as previous patches but this time to add some functions to wrlib to release all memory allocated. The apps using wrlib have to call the cleaning functions before leaving. --- wrlib/context.c | 11 +++ wrlib/convert.c | 27 ++- wrlib/libwraster.map |

Re: [PATCH 0/3] Changes in NetPBM support

Great Christophe, quite a bunch of changes, don't know how you tested your modifications for non regression, from my side i used the files at https://git.gnome.org/browse/gdk-pixbuf/tree/tests/test-images even if i remember well not all the file types are provided. regards, david On Sun, Apr 6,

[PATCH] Removed unused second switch panel background

Still don't know why the switch panel background has to be blue, but anyway i believe we don't need to have the second background file in the repo which is not used and btw can be tweaked from the config file. -- diff --git a/Window

Re: wmaker-dev emails landing of SPAM folder (was Re: [PATCH 0/2] wrlib: changes in MagickWand implementation)

hum Carlos, not sure you saw that email: Subject: [PATCH] Added clean functions to wrlib Newsgroups: gmane.compw.window-managers.windowmaker.devel Date: 2014-03-31 15:43:17 GMT (2 weeks, 1 day, 18 hours and 22 minutes ago) see: http://news.gmane.org/gmane.compw.window-managers.windowmaker.devel

Re: [PATCH] Added clean functions to wrlib

As far as I can see with the image viewer (wmiv) I am working on and which is using wrlib, without that patch some memory are lost. Thx, David On Wednesday, April 16, 2014, Carlos R. Mafra wrote: > On Mon, 31 Mar 2014 at 23:43:17 +0800, David Maciejak wrote: > > Same as previous pa

[PATCH] wrlib: added missing call to deallocate magick pixelwand

add the missing call to deallocate the image background --- wrlib/load_magick.c | 1 + 1 file changed, 1 insertion(+) diff --git a/wrlib/load_magick.c b/wrlib/load_magick.c index d9ecb2d..b08e591 100644 --- a/wrlib/load_magick.c +++ b/wrlib/load_magick.c @@ -80,6 +80,7 @@ RImage * RLoadMagick(co

Re: Major surgery on #next (was Re: [PATCH 0/7] Improvements to NetPBM support commit)

> So a lot of things have been done. I still have patches I think were not > addressed and still need to be added again: > > 0003-wrlib-WEBP-header-fixes.patch > 0005-Fixed-unknown-image-format-detection-in-Icon-Chooser.patch > 0006-wrlib-added-support-for-imagemagick-third-party-lib.patch > 0007-w

Re: Major surgery on #next (was Re: [PATCH 0/7] Improvements to NetPBM support commit)

On Monday, April 28, 2014, Carlos R. Mafra wrote: > On Sun, 27 Apr 2014 at 19:19:14 +0200, Christophe wrote: > > > > The patch '0007-wrlib-Added-clean-functions-to-wrlib' would deserve > > some feedback too (that means: expect a diff patch if you import it in > > #next, or ask for an alternate ve

Re: [PATCH 4/4] Removed unused second switch panel background

On Friday, May 9, 2014, Carlos R. Mafra wrote: > On Thu, 8 May 2014 at 23:57:04 +0200, Christophe wrote: > > From: David Maciejak > > > > > the second one is not used, so i removed it. > > btw, user can change it from the config file > > So I don't thi

[PATCH] wrlib: add a function to draw rectangles

It appears that such kind of function was missing from the lib. It will be required for upcoming wmiv image viewer tool. diff --git a/wrlib/draw.c b/wrlib/draw.c index 350837c..aa8588d 100644 --- a/wrlib/draw.c +++ b/wrlib/draw.c @@ -463,6 +463,13 @@ void ROperateLines(RImage * image, int operatio

Re: [PATCH] wrlib: add a function to draw rectangles

enclosed the updated version On Sat, May 10, 2014 at 8:28 PM, Carlos R. Mafra wrote: > On Sat, 10 May 2014 at 19:43:42 +0800, David Maciejak wrote: >> It appears that such kind of function was missing from the lib. >> It will be required for upcoming wmiv image viewer tool. &

Re: [PATCH] util/wmiv: an image viewer using wrlib

On Sat, May 10, 2014 at 10:10 PM, Carlos R. Mafra wrote: > On Sat, 10 May 2014 at 21:37:51 +0800, David Maciejak wrote: >> I am enclosing here a patch that brings wmiv, a fast image viewer >> which uses wrlib. I tested it over the last weeks, i can just say it >> working

Re: [PATCH] util/wmiv: an image viewer using wrlib

On Sunday, May 11, 2014, Carlos R. Mafra wrote: > On Sun, 11 May 2014 at 1:09:23 +0800, David Maciejak wrote: > > On Sat, May 10, 2014 at 10:10 PM, Carlos R. Mafra > > > > wrote: > > > On Sat, 10 May 2014 at 21:37:51 +0800, David Maciejak wrote: > > >&g

Re: [PATCH] util/wmiv: an image viewer using wrlib

On Tuesday, May 13, 2014, Carlos R. Mafra wrote: > On Mon, 12 May 2014 at 13:13:02 +0800, David Maciejak wrote: > > ok got it, pthread cmd line was added only with magickwand support > compilation. > > I added posix thread checks in configure file and recreate the patch I >

[PATCH] clean wDockFindFreeSlot function

it appears that a sx var is set but not used --- a/src/dock.c +++ b/src/dock.c @@ -2719,7 +2719,7 @@ Bool wDockFindFreeSlot(WDock *dock, int *x_pos, int *y_pos) int x, y; int i, done = False; int corner; - int sx = 0, ex = scr->scr_width, ey = scr->scr_height; + int ex = scr->scr_width, ey

Re: Re : [PATCH] clang analyzer fixes

great ! i did run cppcheck on my side too some days ago, i was about to report some patches in the coming minutes/hours to correct some of the problems reported. regards, david On Sat, May 17, 2014 at 10:43 PM, Christophe wrote: > > - Amadeusz Sławiński a écrit : >> Hey, >> I've decided to

[PATCH 1/6] src/appicon.c: updated paint_app_icon

moving scr initialization after WApplication existing test to prevent crashing in case wapp is null --- src/appicon.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/appicon.c b/src/appicon.c index f61ae0e..bbf1455 100644 --- a/src/appicon.c +++ b/src/appicon.c @@ -19

[PATCH 2/6] src/defaults.c: updated readGlobalDomain

set default path init value to remove some cppcheck warning --- src/defaults.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/defaults.c b/src/defaults.c index 7d66372..c6748d5 100644 --- a/src/defaults.c +++ b/src/defaults.c @@ -798,7 +798,7 @@ static void initDefaults(v

[PATCH 4/6] src/misc.c: updated GetShortcutString

remove unused var and remove some commented code too --- src/misc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/misc.c b/src/misc.c index 92c1534..4d008a3 100644 --- a/src/misc.c +++ b/src/misc.c @@ -736,7 +736,6 @@ char *GetShortcutString(const char *shortcut) { char *b

[PATCH 3/6] src/dialog.c: updated keyPressHandler

wmalloc is already taking care of the memory allocation return value, and i replace strcpy to strncpy --- src/dialog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dialog.c b/src/dialog.c index da126ae..d0d9179 100644 --- a/src/dialog.c +++ b/src/dialog.c @@ -899,

[PATCH 5/6] src/usermenu.c: updated wUserMenuRefreshInstances

remove unused var and move wwin check --- src/usermenu.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/usermenu.c b/src/usermenu.c index 4a669c9..c349810 100644 --- a/src/usermenu.c +++ b/src/usermenu.c @@ -279,7 +279,6 @@ static WMenu *configureUserMenu(WScreen *

[PATCH 6/6] src/winmenu.c: updated prepare_menu_position

did some change as prepare_menu_position never updated x and y values --- src/winmenu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/winmenu.c b/src/winmenu.c index 5fa4886..d8b3f4f 100644 --- a/src/winmenu.c +++ b/src/winmenu.c @@ -729,16 +729,16 @@ stat

Re: [PATCH 2/6] src/defaults.c: updated readGlobalDomain

the correct way to fix the > problem reported by cppcheck. > > > - David Maciejak a écrit : >> set default path init value to remove some cppcheck warning >> >> --- >> src/defaults.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >&g

Re: [PATCH 3/6] src/dialog.c: updated keyPressHandler

On Sun, May 18, 2014 at 1:03 AM, Christophe wrote: > May I vote against this patch? > Comments below... > > > - David Maciejak a écrit : >> [...] >> >> diff --git a/src/dialog.c b/src/dialog.c >> index da126ae..d0d9179 100644 >> --- a/src/dialo

Re: [PATCH 6/6] src/winmenu.c: updated prepare_menu_position

On Sunday, May 18, 2014, Christophe wrote: > Signed-off-by: Christophe CURIS > > > Not pointed by Coverity either. (that's a funny one) > > Yes quite funny .. So the good thing when using multiple tools is that we were able to find more issues ! > - David Macieja

Re: [PATCH 2/6] src/defaults.c: updated readGlobalDomain

is when sizeof(path) <= 0 (then the behaviour of > snprintf is undefined), which I believe is a bit unlikely. > > Did I miss something? > > > - David Maciejak a écrit : >> Sure, as you may come with a better idea i am ok with that. >> btw i believe coverity report

Re: [PATCH] WMaker: rewrote generation of title for the Icon Chooser to avoid problems

NULL but not both > > Now the appropriate length is calculated (not counting on a margin) and the > string is generated with the available elements. > > As a side note, the variable was renamed from 'tmp' to 'title' for clarity. > > This was highlighted by

[PATCH] wrlib: RRotateImage function not fully implemented

when the rotation angle value passed to RRotateImage is a modulo of 90, the function is working well but in other cases the rotateImage() function is called. That last function is half implemented but the half already implemented part is also segfaulting (use the testrot.c to replay the crash). So

[PATCH] wrlib: add image flip functions

This patch adds RVerticalFlipImage and RHorizontalFlipImage functions. 0001-wrlib-add-image-flip-functions.patch Description: Binary data

Re: [PATCH] wrlib: add image flip functions

> 0001-wrlib-add-image-flip-functions.patch has style problems, please review. you mean the braces ? > and it would be better to remove the braces (even though that's just a > warning, it's a style I've been trying to enforce and many parts of > the code follow it). ok, feel free to remove them

Re: [PATCH] wrlib: add image flip functions

yeah i understand. Thank you Carlos ! On Wed, May 21, 2014 at 5:25 PM, Carlos R. Mafra wrote: > On Wed, 21 May 2014 at 17:09:19 +0800, David Maciejak wrote: >> > 0001-wrlib-add-image-flip-functions.patch has style problems, please >> > review. >> >> you mean th

Re: [PATCH] wrlib: RRotateImage function not fully implemented

right, i will resubmit it. On Wed, May 21, 2014 at 5:29 PM, Carlos R. Mafra wrote: > On Wed, 21 May 2014 at 12:49:44 +0800, David Maciejak wrote: >> when the rotation angle value passed to RRotateImage is a modulo of 90, >> the function is working well but in other cases

[PATCH] util/wmiv: correct errors and warnings

This patch is correcting all errors and almost all warnings reported by checkpatch against wmiv.c. I also added a check to test if _GNU_SOURCE is set already to remove a compiler warning. diff --git a/util/wmiv.c b/util/wmiv.c index 8c382c9..2eab5d3 100755 --- a/util/wmiv.c +++ b/util/wmiv.c @@

Re: [PATCH] wrlib: RRotateImage function not fully implemented

(dy << 1); p = dpr - dy; @@ -396,4 +400,5 @@ static RImage *rotateImage(RImage * image, float angle) } return img; +#endif } -- 1.8.3.2 On Wed, May 21, 2014 at 5:43 PM, David Maciejak wrote: > right, i will resubmit it. > > On Wed, May 21, 2014 at 5:29 PM, Carlos R. Mafra

Re: [PATCH] wrlib: add image flip functions

background image. regards, david On Wed, May 21, 2014 at 8:10 PM, Carlos R. Mafra wrote: > On Wed, 21 May 2014 at 13:05:02 +0800, David Maciejak wrote: >> This patch adds RVerticalFlipImage and RHorizontalFlipImage functions. > > Do you have some application in mind? Otherwise we are just

Re: [PATCH] wrlib: add image flip functions

, May 21, 2014 at 10:02 PM, David Maciejak wrote: > i am working on some new feature that will autorotate the img (at > least jpeg) based on the exif orientation tag. The code is almost done > on my side. For example i added a RLoadOrientedImage fct. > i will add it for wmiv and need f

Re: [PATCH] Fix issues with alt-tab

> > Most of the people probably don't even know how to turn off the > switchpanel. I have always wondered why there is no option in the > WPrefs for disable/enable switchpanel. > i would like to see that feature too ;) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org

[PATCH] wrlib: fixed transformation functions

Here the patch i was talking about some days ago. With a valid set of exif images available at https://github.com/recurser/exif-orientation-examples i was able to detect that the flip functions was shifting the image by 1px. The 90 and 270 degrees rotation were not working as expected as the fun

[PATCH] WINGs: fix duplicate if/else branch in W_LookupString

cppcheck is reporting the msg below: [../WINGs/winputmethod.c:215] -> [../WINGs/winputmethod.c:209]: (style) Found duplicate branches for 'if' and 'else'. The patch is fixing it by setting a default return call. diff --git a/WINGs/winputmethod.c b/WINGs/winputmethod.c index 7d3aae0..26bc4a1 10

[PATCH 0/2] EXIF orientation feature

These patches (one for the lib, one for the viewer tool) are bringing EXIF orientation support in wrlib. Most popular display libs and tools are providing such kind of features these days (eog, gimp, ...). I ported the code from jpegexiforient to be able to extract the tag value, and as said in som

[PATCH 2/2] util/wmiv: add image auto orientation detection

Based on wrlib EXIF orientation feature, this patch is adding orientation detection and provides 2 more shortcuts for live right/left rotation. Internal version was increased to 0.7. --- util/wmiv.c | 103 +++- 1 file changed, 89 insertions

[PATCH 1/2] wrlib: add EXIF orientation feature

This patch is adding a RLoadOrientedImage that can be used to extract the EXIF orientation field of a given image (only JPEG for now), the resulting image is automatically flipped/rotated. --- wrlib/libwraster.map | 2 + wrlib/load.c | 60 +- wrlib/misc.c | 227 +++

Re: [PATCH 1/2] wrlib: add EXIF orientation feature

Seems the link I provided is already dead... You can find the original code here: http://sylvana.net/jpegcrop/jpegexiforient.c length is initialised from reading 2 bytes. regards, david On Fri, May 30, 2014 at 6:00 AM, BALATON Zoltan wrote: > On Thu, 29 May 2014, David Maciejak wr

Re: [PATCH 0/2] EXIF orientation feature

On Fri, May 30, 2014 at 6:29 AM, Carlos R. Mafra wrote: > On Thu, 29 May 2014 at 20:45:42 +0800, David Maciejak wrote: >> These patches (one for the lib, one for the viewer tool) are bringing >> EXIF orientation support in wrlib. >> Most popular display libs and tools are p

Re: [PATCH 0/2] EXIF orientation feature

On Sunday, June 1, 2014, Christophe wrote: > > - Carlos R. Mafra > a écrit : > > On Fri, 30 May 2014 at 16:27:44 +0800, David Maciejak wrote: > > > On Fri, May 30, 2014 at 6:29 AM, Carlos R. Mafra > wrote: > > > > On Thu, 29 May 2014

Re: [PATCH 00/11] WPrefs: fixes for stuff reported by Coverity

Thanks Christophe for all these patches! On a side note, i saw yesterday that WPrefs is using some fcts from WINGs/userdefaults.c, at least these 2: WMSetUDIntegerForKey and WMSetUDFloatForkey The code looks the same for both fcts and are defining a buffer[128] and then use sprintf. It would be c

[PATCH] util/wmiv: add image auto orientation detection

This patch is less intrusive than the previous one, almost all is done in wmiv, the exif metadata handling is based on libexif. Based on libexif feature, this patch is adding orientation detection and provides 2 more shortcuts for live right/left rotation. Internal version was bumped to 0.7. ---

[PATCH] WPrefs: add expert option to disable switch panel

This patch is adding a checkbox option in the expert panel to be able to disable the Alt-Tab window switching panel from the pref GUI. Please test, i experienced some weird things with the inotify stuff, sometime a wmaker hot restart is needed to force reload the conf. thanks, david --- WPrefs.

Re: [PATCH] WPrefs: add expert option to disable switch panel

On Tuesday, June 3, 2014, Carlos R. Mafra wrote: > On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote: > > This patch is adding a checkbox option in the expert panel > > to be able to disable the Alt-Tab window switching panel from the pref > GUI. > > > > P

Re: [PATCH] WPrefs: add expert option to disable switch panel

On Tuesday, June 3, 2014, Josip Deanovic wrote: > Quoting message written on Tuesday 2014-06-03 22:43:22 by David Maciejak: > > That option is effectively disabling *all* the switch panel, not only > > the icons. > > In fact it can be used either to disable the panel or to s

Re: [PATCH] WPrefs: add expert option to disable switch panel

Enclosed the patch with lain text proposal ""Show switch panel when cycling windows."" and with logic changed, to amend commit c994b65f14ad2ab872f5c1b91119d78885743cfc. On Thu, Jun 5, 2014 at 1:41 AM, Yury Tarasievich wrote: > Alt-Tab is "cycling" only in one specific scenario (holding the Alt).

[PATCH] wmaker: increase logo size

Increase the size to default 64x64, please test. --- WindowMaker/Icons/GNUstep.tiff | Bin 906 -> 3014 bytes WindowMaker/Icons/GNUstep.xpm | 326 ++--- 2 files changed, 271 insertions(+), 55 deletions(-) 0001-wmaker-increase-logo-size.patch Description: Bina

Re: [PATCH 00/11] WPrefs: fixes for stuff reported by Coverity

On Sunday, June 8, 2014, Christophe wrote: > > > The only detail I'd see there being that using %f for float is likely to > loose accuracy in the value stored if the number is more than a basic > number, but as this function is not used anywhere it does not really > matter... > > Yes that's what

[PATCH] WMaker: src/misc.c remove obsolete code

This patch is removing the call to get_dnd_selection function which was removed long time ago. --- src/misc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/misc.c b/src/misc.c index 63e7158..572fbe4 100644 --- a/src/misc.c +++ b/src/misc.c @@ -627,9 +627,6 @@ char *ExpandOptions(WScre

[PATCH] wrlib: load.c clean coding style

just some code cleaning stuff. --- wrlib/load.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/wrlib/load.c b/wrlib/load.c index 7c2e6af..9430854 100644 --- a/wrlib/load.c +++ b/wrlib/load.c @@ -108,16 +108,15 @@ static void init_cache(void) char *tmp; t

[PATCH 1/2] WINGs: add function to set the color of the frame title

This patch adds a function used to set the color of the frame title. --- WINGs/WINGs/WINGs.h | 2 ++ WINGs/wframe.c | 15 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h index 51252f5..6333750 100644 --- a/WINGs/WINGs/

[PATCH 2/2] wmaker: darken labels from docked application settings

This patch darkens DnD labels in docked app settings when support is not compiled in. --- src/dockedapp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dockedapp.c b/src/dockedapp.c index a7bca3b..6a84afc 100644 --- a/src/dockedapp.c +++ b/src/dockedapp.c @@ -316,6 +316,9 @@ void Sho

Re: [PATCH] wmaker: increase logo size

>> On 06/04/2014 10:47 PM, David Maciejak wrote: >> > Increase the size to default 64x64, please test. >> > >> > --- >> > WindowMaker/Icons/GNUstep.tiff | Bin 906 -> 3014 bytes >> > WindowMaker/Icons/GNUstep.xpm | 326 >> &g

Re: [PATCH] wmaker: increase logo size

On Thu, Jun 12, 2014 at 9:33 PM, David Maciejak wrote: > Sorry for the delay, > > normally the dock icons are autoresized so it should still be > displayed within the tile, even if i agree that the icon is bigger > than before. > btw Doug, feel free to modify & share

Re: [PATCH] wmaker: increase logo size

522 - 2 files changed, 253 insertions(+), 269 deletions(-) Thanks, david On Sat, Jun 14, 2014 at 8:43 AM, Carlos R. Mafra wrote: > On Fri, 13 Jun 2014 at 8:37:08 +0800, David Maciejak wrote: >> On Thu, Jun 12, 2014 at 9:33 PM, David Maciejak >> wrote: >&g

Re: [PATCH] wmaker: increase logo size

The definition of this one is better. See comparison enclosed. On Sun, Jun 15, 2014 at 5:10 PM, Carlos R. Mafra wrote: > On Sun, 15 Jun 2014 at 12:41:31 +0800, David Maciejak wrote: >> Found some time to redo the patch and move back to 48x48 icons. >> Carlos, could you ple

Re: [PATCH] wmaker: increase logo size

Carlos, plz find the patch enclosed with the comment updated: [PATCH] wmaker: redo logo This patch is providing the logo still in 48x48 size but with a better definition. On Sun, Jun 15, 2014 at 6:47 PM, Carlos R. Mafra wrote: > On Sun, 15 Jun 2014 at 18:24:25 +0800, David Maciejak wr

[PATCH] wrlib: fix RCreateImageFromDrawable error log msg

This patch is fixing the name of the function from the log message. --- wrlib/xpixmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wrlib/xpixmap.c b/wrlib/xpixmap.c index 14bed08..b3d3853 100644 --- a/wrlib/xpixmap.c +++ b/wrlib/xpixmap.c @@ -155,7 +155,7 @@ RImage *RCrea

[PATCH 0/4] cppcheck patches

Hi, i am sending some patch suggestions to correct some more issues reported by cppcheck. regards, david -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

[PATCH 1/4] WINGs: correct possible null pointer dereference

As reported by cppcheck: [WINGs/array.c:129] -> [WINGs/array.c:131]: (warning) Possible null pointer dereference: array - otherwise it is redundant to check it against null. [WINGs/array.c:151] -> [WINGs/array.c:153]: (warning) Possible null pointer dereference: array - otherwise it is redundant t

  1   2   >