Re: Docks and AppIcons

2013-03-21 Thread BALATON Zoltan
Hello, I don't know this part of the code and I haven't looked at it so my comment is only conceptual but maybe it can help you to understand it better so I comment on this anyway. On Wed, 20 Mar 2013, "Rodolfo García Peñas (kix)" wrote: Now, the Dock and the Clip are WDock structs, but the i

Re: Docks and AppIcons

2013-03-21 Thread Haroldo Santos
2 considerations on this subject: - a code which appears to be stable is not necessarily correct (Heisenbugs are uncomfortably common :/) - besides reviewing the code many people can use the next branch and test new versions cheers, Harodo On Thu, Mar 21, 2013 at 7:16 AM, Carlos R. Mafra wrote

Re: Docks and AppIcons

2013-03-21 Thread SJS
begin quoting "Rodolfo Garc??a Pe??as (kix)" as of Thu, Mar 21, 2013 at 01:52:50AM +0100: > On 20/03/2013 22:59, Carlos R. Mafra wrote: [snip] > > Massive cleanups in core objects smells like trouble and should have > > a very compelling reason to be accepted at this (very stable) point. Stabili

Re: Docks and AppIcons

2013-03-21 Thread Rodolfo García Peñas (kix)
"Carlos R. Mafra" escribió: On Thu, 21 Mar 2013 at 9:33:25 +, Rodolfo García Peñas (kix) wrote: If Carlos thinks that we should work only in bugs, not in big/deep changes what will happend? Perhaps is not bad idea stop here for a while with deep changes. I should say I'm a bit nervous

Re: Docks and AppIcons

2013-03-21 Thread Carlos R. Mafra
On Thu, 21 Mar 2013 at 9:33:25 +, Rodolfo García Peñas (kix) wrote: > > If Carlos thinks that we should work only in bugs, not in big/deep > changes what will happend? Perhaps is not bad idea stop here for a > while with deep changes. I should say I'm a bit nervous about deep changes at this

Re: Docks and AppIcons

2013-03-21 Thread Rodolfo García Peñas (kix)
Andreas Tscharner escribió: On 20.03.2013 20:37, "Rodolfo García Peñas (kix)" wrote: [snip] Comments? Hi Andreas, You are using git. Make a branch and make the changes if you feel Yes, and no. I have a lot of branches here (Really, A LOT). When I send patches, is only a part of my bran

Re: Docks and AppIcons

2013-03-20 Thread Andreas Tscharner
On 20.03.2013 20:37, "Rodolfo García Peñas (kix)" wrote: [snip] Comments? You are using git. Make a branch and make the changes if you feel like. If it does not work, you learned something. If it works we can review it here... Best regards Andreas -- ("`-''-/").___..--''"`-._

Re: Docks and AppIcons

2013-03-20 Thread Rodolfo García Peñas (kix)
On 20/03/2013 22:59, Carlos R. Mafra wrote: > On Wed, 20 Mar 2013 at 20:37:39 +0100, "Rodolfo García Peñas (kix)" wrote: >> >> But, anyway, I think return WAppIcon when we are trying to create a >> WDock struct is wrong and all functions about Dock/Clip should work >> with WDock structs. >> >> Comm

Re: Docks and AppIcons

2013-03-20 Thread Carlos R. Mafra
On Wed, 20 Mar 2013 at 20:37:39 +0100, "Rodolfo García Peñas (kix)" wrote: > > But, anyway, I think return WAppIcon when we are trying to create a > WDock struct is wrong and all functions about Dock/Clip should work > with WDock structs. > > Comments? Unless you find bugs I'd recomend to not to

Docks and AppIcons

2013-03-20 Thread Rodolfo García Peñas (kix)
Hi, I was thinking about the docks and appicons in wmaker, and probably we should work in this code. Now, the Dock and the Clip are WDock structs, but the icons attached to the Clip or the Dock are WAppIcons. When we create the Dock/Clip we do something like: - Create the Dock (WDock