Re: [Xen-devel] arch arm qemu compile erro

2014-12-09 Thread Mao Mingya
From the the arch arm, since the stubdom is not supported now. Does the device to be shared between doms have to be pv front/backend structure. To run the Linux on Dom0 and DomU. Could the qemu and pv backend run in the Dom0 at the same time? For example: for network, block device, serial c

Re: [Xen-devel] [PATCH] x86/hvm: Extend HVM cpuid leaf with vcpu id

2014-12-09 Thread Matt Wilson
On Thu, Nov 06, 2014 at 09:27:59PM +, Andrew Cooper wrote: > On 06/11/2014 19:32, Konrad Rzeszutek Wilk wrote: > > On Thu, Nov 06, 2014 at 03:07:10PM +, Paul Durrant wrote: > >> To perform certain hypercalls HVM guests need to use Xen's idea of > > What are those 'certain'? > > Some HVM hy

Re: [Xen-devel] [PATCH v2] VMX: don't allow PVH to reach handle_mmio()

2014-12-09 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, December 08, 2014 5:13 PM > > PVH guests accessing I/O ports via string ops is not supported yet. > > Reported-by: Roger Pau Monné > Signed-off-by: Jan Beulich Acked-by: Kevin Tian > --- > v2: handle_pio() is already safe (pointed

[Xen-devel] [linux-linus test] 32171: regressions - FAIL

2014-12-09 Thread xen . org
flight 32171 linux-linus real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32171/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 8 guest-start fail REGR. vs. 31241 test-amd64-i386-qemut

Re: [Xen-devel] Steps to run XenServer on ARM Platform

2014-12-09 Thread manish jaggi
On 8 December 2014 at 05:46, Stefano Stabellini wrote: > On Mon, 8 Dec 2014, Ian Campbell wrote: >> On Fri, 2014-12-05 at 15:15 -0800, manish jaggi wrote: >> > Hi, >> > >> > I am trying to find a tutorial to jumpstart installing XenServer / XCP >> > on an ARM 64bit platform. >> > Could the mailing

[Xen-devel] [linux-3.10 test] 32172: regressions - FAIL

2014-12-09 Thread xen . org
flight 32172 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32172/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 5 kernel-build fail REGR. vs. 26303 test-amd64-amd64-xl-qe

Re: [Xen-devel] Konrad R Wilk's Xen Project Committer Status confirmed (+ some governance policy concerns)

2014-12-09 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 11:51:27AM +, Lars Kurth wrote: > Hi all, > > I wanted to to summarize the outcome of the vote for Konrad's committer > status. We had 4 votes in favor and one abstained. Which means Konrad is > confirmed. Thank you! I wished I had an acceptance speech prepared!! But

Re: [Xen-devel] [RFC V8 2/3] libxl domain snapshot API design

2014-12-09 Thread Chun Yan Liu
>>> On 12/9/2014 at 07:11 PM, in message <1418123518.14361.20.ca...@citrix.com>, Ian Campbell wrote: > On Mon, 2014-12-08 at 22:04 -0700, Chun Yan Liu wrote: > > Partly. At least for domain disk snapshot create/delete, I prefer using > > qmp commands instead of calling qemu-img one by one. Us

Re: [Xen-devel] [v8][PATCH 04/17] update the existing hypercall to support XEN_DOMCTL_set_rdm

2014-12-09 Thread Tian, Kevin
> From: Tim Deegan [mailto:t...@xen.org] > Sent: Tuesday, December 09, 2014 6:11 PM > > At 08:19 + on 09 Dec (1418109561), Jan Beulich wrote: > > Why do you always pick other than the simplest possible solution? > > Jan, please don't make personal comments like this in code review. It > can

[Xen-devel] [xen-4.3-testing test] 32163: regressions - trouble: blocked/broken/fail/pass

2014-12-09 Thread xen . org
flight 32163 xen-4.3-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32163/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 3 host-install(3) broken REGR. vs. 32110 test-amd64-i386-x

Re: [Xen-devel] [PATCHv1 net] xen-netfront: use correct linear area after linearizing an skb

2014-12-09 Thread David Miller
From: David Vrabel Date: Tue, 9 Dec 2014 18:43:28 + > Commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d (xen-netfront: Fix > handling packets on compound pages with skb_linearize) attempted to > fix a problem where an skb that would have required too many slots > would be dropped causing TCP co

Re: [Xen-devel] [v8][PATCH 04/17] update the existing hypercall to support XEN_DOMCTL_set_rdm

2014-12-09 Thread Chen, Tiejun
On 2014/12/9 18:22, Jan Beulich wrote: On 09.12.14 at 11:11, wrote: At 08:19 + on 09 Dec (1418109561), Jan Beulich wrote: Why do you always pick other than the simplest possible solution? Jan, please don't make personal comments like this in code review. It can only offend and demoraliz

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Tuesday, December 09, 2014 7:44 PM > > > -Original Message- > > From: Ian Campbell > > Sent: 09 December 2014 11:29 > > To: Paul Durrant > > Cc: Tim (Xen.org); Yu, Zhang; Kevin Tian; Keir (Xen.org); jbeul...@suse.com; > > Xen-de

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Tian, Kevin
> From: Malcolm Crossley > Sent: Tuesday, December 09, 2014 6:52 PM > > On 09/12/14 10:37, Yu, Zhang wrote: > > > > > > On 12/9/2014 6:19 PM, Paul Durrant wrote: > >> I think use of an raw mfn value currently works only because dom0 is > >> using a 1:1 IOMMU mapping scheme. Is my understanding cor

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Tian, Kevin
> From: Tim Deegan [mailto:t...@xen.org] > Sent: Tuesday, December 09, 2014 6:47 PM > > At 18:10 +0800 on 09 Dec (1418145055), Yu, Zhang wrote: > > Hi all, > > > >As you can see, we are pushing our XenGT patches to the upstream. One > > feature we need in xen is to translate guests' gfn to mfn

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, December 09, 2014 6:50 PM > > >>> On 09.12.14 at 11:37, wrote: > > On 12/9/2014 6:19 PM, Paul Durrant wrote: > >> I think use of an raw mfn value currently works only because dom0 is using > a > > 1:1 IOMMU mapping scheme. Is my unde

Re: [Xen-devel] [PATCH v2 1/2] x86, platform, xen, kconfig: clarify kvmconfig is for kvm

2014-12-09 Thread Josh Triplett
On Tue, Dec 09, 2014 at 03:35:37PM -0800, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We'll be adding options for xen as well. > > Cc: Josh Triplett > Cc: Borislav Petkov > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Michal Marek > Cc: Randy Dunlap > Cc: penb...@kernel.org > C

[Xen-devel] [rumpuserxen test] 32181: all pass - PUSHED

2014-12-09 Thread xen . org
flight 32181 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32181/ Perfect :-) All tests in this flight passed version targeted for testing: rumpuserxen b0b7b13cadc971e8c5745880dcbb92bc2185765b baseline version: rumpuserxen fbf232c42ae2dea512a2c34b154e

[Xen-devel] [PATCH v2 1/2] x86, platform, xen, kconfig: clarify kvmconfig is for kvm

2014-12-09 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We'll be adding options for xen as well. Cc: Josh Triplett Cc: Borislav Petkov Cc: Pekka Enberg Cc: David Rientjes Cc: Michal Marek Cc: Randy Dunlap Cc: penb...@kernel.org Cc: levinsasha...@gmail.com Cc: mtosa...@redhat.com Cc: fengguang...@intel.com Cc: David Vra

[Xen-devel] [PATCH v2 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This lets you build a kernel which can support xen dom0 or xen guests by just using: make xenconfig on both x86 and arm64 kernels. This also splits out the options which are available currently to be built with x86 and 'make ARCH=arm64' under a shared config. Techn

[Xen-devel] [PATCH v2 0/2] x86/arm64: add xenconfig

2014-12-09 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This v2 addreses some minor feedback on patch 2, and just mends in the review tags. Luis R. Rodriguez (2): x86, platform, xen, kconfig: clarify kvmconfig is for kvm x86, arm, platform, xen, kconfig: add xen defconfig helper arch/x86/configs/xen.config | 7 +++

Re: [Xen-devel] [PATCH] netback: don't store invalid vif pointer

2014-12-09 Thread David Miller
From: "Jan Beulich" Date: Tue, 09 Dec 2014 11:47:04 + > When xenvif_alloc() fails, it returns a non-NULL error indicator. To > avoid eventual races, we shouldn't store that into struct backend_info > as readers of it only check for NULL. > > Signed-off-by: Jan Beulich Applied, thanks. ___

Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Luis R. Rodriguez
On Tue, Dec 9, 2014 at 12:37 PM, Julien Grall wrote: > On 09/12/14 20:22, Luis R. Rodriguez wrote: >> On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall wrote: >>> Hello Luis, >>> >>> On 08/12/2014 23:05, Luis R. Rodriguez wrote: diff --git a/kernel/configs/xen.config b/kernel/configs/xen.con

Re: [Xen-devel] PV DomU running linux 3.17.3 causing xen-netback fatal error in Dom0

2014-12-09 Thread Anthony Wright
On 09/12/2014 22:30, Siegmann Joseph wrote: > > Would you mind sharing what it would take to correct this issue… is > there a file I could just replace until a patch is released? > We simply applied David Vrabel's patch from 8/12/14 to a stock 3.17.3 kernel we were running in the DomU and it fixed

[Xen-devel] [libvirt test] 32180: regressions - FAIL

2014-12-09 Thread xen . org
flight 32180 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 32137 build-amd64-libvirt

Re: [Xen-devel] [PATCH v2] xen/blkfront: remove redundant flush_op

2014-12-09 Thread Boris Ostrovsky
On 12/09/2014 09:25 AM, Vitaly Kuznetsov wrote: flush_op is unambiguously defined by feature_flush: REQ_FUA | REQ_FLUSH -> BLKIF_OP_WRITE_BARRIER REQ_FLUSH -> BLKIF_OP_FLUSH_DISKCACHE 0 -> 0 and thus can be removed. This is just a cleanup. The patch was suggested by Boris Ostrovsk

Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Julien Grall
On 09/12/14 20:22, Luis R. Rodriguez wrote: > On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall wrote: >> Hello Luis, >> >> On 08/12/2014 23:05, Luis R. Rodriguez wrote: >>> >>> diff --git a/kernel/configs/xen.config b/kernel/configs/xen.config >>> new file mode 100644 >>> index 000..0d0eb6d >>> --

Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Luis R. Rodriguez
On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall wrote: > Hello Luis, > > On 08/12/2014 23:05, Luis R. Rodriguez wrote: >> >> diff --git a/kernel/configs/xen.config b/kernel/configs/xen.config >> new file mode 100644 >> index 000..0d0eb6d >> --- /dev/null >> +++ b/kernel/configs/xen.config >> +CON

Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Luis R. Rodriguez
On Tue, Dec 9, 2014 at 12:22 PM, Luis R. Rodriguez wrote: > If you are sure then yes. Likewise here. Luis ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Xen-unstable: irq.c:xxxx: dom1: forcing unbind of pirq 40

2014-12-09 Thread Sander Eikelenboom
Tuesday, December 9, 2014, 7:05:32 PM, you wrote: > Tuesday, December 9, 2014, 6:29:08 PM, you wrote: > On 09.12.14 at 17:24, wrote: >>> Currently i'm running Xen-unstable with Stefano's libxl fixup patches (not >>> doing >>> reset due to qmp race, switching order of xc_domain_irq_permis

[Xen-devel] [PATCHv1 net] xen-netfront: use correct linear area after linearizing an skb

2014-12-09 Thread David Vrabel
Commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d (xen-netfront: Fix handling packets on compound pages with skb_linearize) attempted to fix a problem where an skb that would have required too many slots would be dropped causing TCP connections to stall. However, it filled in the first slot using th

Re: [Xen-devel] [PATCH v2 14/19] hvmloader: construct SLIT

2014-12-09 Thread Wei Liu
On Tue, Dec 09, 2014 at 04:57:14PM +, Jan Beulich wrote: > >>> On 01.12.14 at 16:33, wrote: > > --- a/tools/firmware/hvmloader/acpi/build.c > > +++ b/tools/firmware/hvmloader/acpi/build.c > > @@ -263,6 +263,38 @@ static struct acpi_20_srat *construct_srat(void) > > return srat; > > } > >

Re: [Xen-devel] [PATCH v2 13/19] hvmloader: construct SRAT

2014-12-09 Thread Wei Liu
On Tue, Dec 09, 2014 at 04:53:40PM +, Jan Beulich wrote: > >>> On 01.12.14 at 16:33, wrote: > > @@ -203,6 +204,65 @@ static struct acpi_20_waet *construct_waet(void) > > return waet; > > } > > > > +static struct acpi_20_srat *construct_srat(void) > > +{ > > +struct acpi_20_srat *sr

Re: [Xen-devel] Xen-unstable: irq.c:xxxx: dom1: forcing unbind of pirq 40

2014-12-09 Thread Sander Eikelenboom
Tuesday, December 9, 2014, 6:29:08 PM, you wrote: On 09.12.14 at 17:24, wrote: >> Currently i'm running Xen-unstable with Stefano's libxl fixup patches (not >> doing >> reset due to qmp race, switching order of xc_domain_irq_permission and >> xc_physdev_unmap_pirq) >> and with a kernel w

Re: [Xen-devel] [PATCH v2 12/19] hvmloader: retrieve vNUMA information from hypervisor

2014-12-09 Thread Wei Liu
On Tue, Dec 09, 2014 at 04:46:22PM +, Jan Beulich wrote: > >>> On 01.12.14 at 16:33, wrote: > > @@ -261,6 +262,8 @@ int main(void) > > > > init_hypercalls(); > > > > +init_vnuma_info(); > > This is very early, and I don't think it needs to be - I guess it could be > done right be

Re: [Xen-devel] [PATCH] console: const-ify the arguments for __warn() and __bug()

2014-12-09 Thread Mihai Donțu
On Monday 08 December 2014 10:28:41 Andrew Cooper wrote: > On 08/12/14 00:19, Mihai Donțu wrote: > > Both __warn() and __bug() take as first parameter the file name of the > > current compilation unit (__FILE__). Mark that parameter as constant to > > better reflect that. > > > > Signed-off-by: Mih

Re: [Xen-devel] [PATCH v2] VMX: don't allow PVH to reach handle_mmio()

2014-12-09 Thread Roger Pau Monné
El 09/12/14 a les 18.19, Jan Beulich ha escrit: On 09.12.14 at 18:01, wrote: >> For 4.6 I think we need to start using a different hvm_io_bitmap for PVH >> Dom0 that allows direct access to the IO ports, bypassing the vmexit and >> simplifying the code in Xen (this would also fix INS/OUTS). S

[Xen-devel] [PATCH v2] console: allocate ring buffer earlier

2014-12-09 Thread Jan Beulich
... when "conring_size=" was specified on the command line. We can't really do this as early as we would want to when the option was not specified, as the default depends on knowing the system CPU count. Yet the parsing of the ACPI tables is one of the things that generates a lot of output especial

Re: [Xen-devel] Xen-unstable: irq.c:xxxx: dom1: forcing unbind of pirq 40

2014-12-09 Thread Jan Beulich
>>> On 09.12.14 at 17:24, wrote: > Currently i'm running Xen-unstable with Stefano's libxl fixup patches (not > doing > reset due to qmp race, switching order of xc_domain_irq_permission and > xc_physdev_unmap_pirq) > and with a kernel with Konrad's 3.19 patch series. > > Although i have seen

Re: [Xen-devel] [PATCH v3 1/2] x86, platform, kconfig: clarify kvmconfig is for kvm

2014-12-09 Thread Borislav Petkov
On Mon, Dec 08, 2014 at 03:04:59PM -0800, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We'll be adding options for xen as well. > > Cc: Josh Triplett > Cc: Borislav Petkov > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Michal Marek > Cc: Randy Dunlap > Cc: penb...@kernel.org > C

Re: [Xen-devel] [PATCH v2] VMX: don't allow PVH to reach handle_mmio()

2014-12-09 Thread Jan Beulich
>>> On 09.12.14 at 18:01, wrote: > For 4.6 I think we need to start using a different hvm_io_bitmap for PVH > Dom0 that allows direct access to the IO ports, bypassing the vmexit and > simplifying the code in Xen (this would also fix INS/OUTS). Still not > sure what should be done for PVH DomUs, s

Re: [Xen-devel] [PATCH v2] VMX: don't allow PVH to reach handle_mmio()

2014-12-09 Thread Roger Pau Monné
El 08/12/14 a les 10.12, Jan Beulich ha escrit: > PVH guests accessing I/O ports via string ops is not supported yet. > > Reported-by: Roger Pau Monné > Signed-off-by: Jan Beulich This looks fine to me (at least it doesn't break the existing IN/OUT users), and seems the best solution 4.5 wise:

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-09 Thread Ian Jackson
Olaf Hering writes ("Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd"): > On Tue, Dec 09, Ian Jackson wrote: > > But: I think the script is rather over-engineered, and that it ought > > to be in /etc. > > Why should the wrapper be in /etc?! Because it is the last chance the adm

[Xen-devel] [PATCH v2 for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid()

2014-12-09 Thread Andrew Cooper
The error handling from a failed memory allocation should return PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and continuing to the memcpy() below, with the dest pointer being NULL. Coverity also complains about passing a non-NUL terminated string to xc_flask_context_to_sid().

Re: [Xen-devel] [PATCH v2 14/19] hvmloader: construct SLIT

2014-12-09 Thread Jan Beulich
>>> On 01.12.14 at 16:33, wrote: > --- a/tools/firmware/hvmloader/acpi/build.c > +++ b/tools/firmware/hvmloader/acpi/build.c > @@ -263,6 +263,38 @@ static struct acpi_20_srat *construct_srat(void) > return srat; > } > > +static struct acpi_20_slit *construct_slit(void) > +{ > +struct a

Re: [Xen-devel] [PATCH v2 13/19] hvmloader: construct SRAT

2014-12-09 Thread Jan Beulich
>>> On 01.12.14 at 16:33, wrote: > @@ -203,6 +204,65 @@ static struct acpi_20_waet *construct_waet(void) > return waet; > } > > +static struct acpi_20_srat *construct_srat(void) > +{ > +struct acpi_20_srat *srat; > +struct acpi_20_srat_processor *processor; > +struct acpi_20_sr

Re: [Xen-devel] [PATCH v2 12/19] hvmloader: retrieve vNUMA information from hypervisor

2014-12-09 Thread Jan Beulich
>>> On 01.12.14 at 16:33, wrote: > @@ -261,6 +262,8 @@ int main(void) > > init_hypercalls(); > > +init_vnuma_info(); This is very early, and I don't think it needs to be - I guess it could be done right before doing ACPI stuff? > --- /dev/null > +++ b/tools/firmware/hvmloader/vnuma.

Re: [Xen-devel] PV DomU running linux 3.17.3 causing xen-netback fatal error in Dom0

2014-12-09 Thread Anthony Wright
On 08/12/2014 12:03, David Vrabel wrote: > Does this patch to netfront fix it? > > 8<- > xen-netfront: use correct linear area after linearizing an skb > > Commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d (xen-netfront: Fix > handling packets on compound p

Re: [Xen-devel] [v8][PATCH 02/17] introduce XEN_DOMCTL_set_rdm

2014-12-09 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 08:33:56AM +, Jan Beulich wrote: > >>> On 09.12.14 at 02:06, wrote: > Also how does this work with 32-bit dom0s? Is there a need to use the > compat layer? > >>> > >>> Are you saying in xsm case? Others? > >>> > >>> Actually this new DOMCTL is similar with XEN

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-09 Thread Olaf Hering
On Tue, Dec 09, Ian Jackson wrote: > Olaf Hering writes ("Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE > in systemd"): > > On Fri, Dec 05, Ian Jackson wrote: > > > I think the only way to make this work properly is to factor the > > > necessary parts out of init.d/xencommons into a new

Re: [Xen-devel] [PATCH v2] xen/serial: setup UART idle mode for OMAP

2014-12-09 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 05:25:08PM +0200, Oleksandr Dmytryshyn wrote: > On Tue, Dec 9, 2014 at 4:47 PM, Ian Campbell wrote: > > On Mon, 2014-12-08 at 15:51 +0200, Oleksandr Dmytryshyn wrote: > >> UART is not able to receive bytes when idle mode is not > >> configured properly. When we use Xen with

Re: [Xen-devel] [PATCH for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid()

2014-12-09 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 02:30:24PM +, Andrew Cooper wrote: > On 09/12/14 14:27, Ian Campbell wrote: > > On Fri, 2014-11-28 at 11:37 +, Ian Campbell wrote: > >> On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: > >>> The error handling from a failed memory allocation should return > >>

Re: [Xen-devel] [PATCH 2/6] libxl: events: Deregister xenstore watch fd when not needed

2014-12-09 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 2/6] libxl: events: Deregister xenstore watch fd when not needed"): > On Tue, 2014-12-09 at 15:54 +, Ian Jackson wrote: > > We want to have no fd events registered when we are idle. > > In this patch, deal with the xenstore watch fd: ... > > Signed-off-by: Ian

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-09 Thread Ian Jackson
Olaf Hering writes ("Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS"): > Perhaps a crashed or otherwise unavailable xenstored isnt such a problem > because its like that since a very long time. Without xenstored, the system is basically hosed. And it's not r

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-09 Thread Ian Jackson
Olaf Hering writes ("Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd"): > On Fri, Dec 05, Ian Jackson wrote: > > I think the only way to make this work properly is to factor the > > necessary parts out of init.d/xencommons into a new script which can > > be used by both xencommon

Re: [Xen-devel] [PATCH 2/6] libxl: events: Deregister xenstore watch fd when not needed

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 15:54 +, Ian Jackson wrote: > We want to have no fd events registered when we are idle. > In this patch, deal with the xenstore watch fd: > > * Track the total number of active watches. > * When deregistering a watch, or when watch registration fails, check > whether th

[Xen-devel] [PATCH 4/6] libxl: events: Tear down SIGCHLD machinery on ctx destruction

2014-12-09 Thread Ian Jackson
We want to have no fd events registered when we are idle. Also, we should put back the default SIGCHLD handler. So: * In libxl_ctx_free, use libxl_childproc_setmode to set the mode to the default, which is libxl_sigchld_owner_libxl (ie `libxl owns SIGCHLD only when it has active children')

[Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed

2014-12-09 Thread Ian Jackson
We want to have no fd events registered when we are idle. In this patch, deal with the evtchn fd: * Defer setup of the evtchn handle to the first use. * Defer registration of the evtchn fd; register as needed on use. * When cancelling an evtchn wait, or when wait setup fails, check whether t

[Xen-devel] [PATCH for-4.5 v2 0/6] libxl: events: Tear down fd interests when idle

2014-12-09 Thread Ian Jackson
If libxl_event_register_callbacks is called with nonzero hooks while any part of libxl has any fd interests registered internally, then: * There is no way for libxl to notify the application that it wants to be told about these fds, because the spec in the doc comment says that the new hook

[Xen-devel] [PATCH 1/6] libxl: events: Assert that libxl_ctx_free is not called from a hook

2014-12-09 Thread Ian Jackson
No-one in their right mind would do this, and if they did everything would definitely collapse. Arrange that if this happens, we crash ASAP. Signed-off-by: Ian Jackson Acked-by: Ian Campbell Tested-by: Ian Campbell Release-Acked-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl.c |2 ++ 1

[Xen-devel] [PATCH 2/6] libxl: events: Deregister xenstore watch fd when not needed

2014-12-09 Thread Ian Jackson
We want to have no fd events registered when we are idle. In this patch, deal with the xenstore watch fd: * Track the total number of active watches. * When deregistering a watch, or when watch registration fails, check whether there are now no watches and if so deregister the fd. * On libxl tea

[Xen-devel] [PATCH 6/6] libxl: events: Document and enforce actual callbacks restriction

2014-12-09 Thread Ian Jackson
libxl_event_register_callbacks cannot reasonably be called while libxl is busy (has outstanding operations and/or enabled events). This is because the previous spec implied (although not entirely clearly) that event hooks would not be called for existing fd and timeout interests. There is thus no

Re: [Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 15:54 +, Ian Jackson wrote: > We want to have no fd events registered when we are idle. > In this patch, deal with the evtchn fd: > > * Defer setup of the evtchn handle to the first use. > * Defer registration of the evtchn fd; register as needed on use. > * When cance

Re: [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 15:39 +, Anthony PERARD wrote: > The path to the pty of a Xen PV console is set only in > virDomainOpenConsole. But this is done too late. A call to > virDomainGetXMLDesc done before OpenConsole will not have the path to > the pty, but a call after OpenConsole will. > > e

Re: [Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed [and 1 more messages]

2014-12-09 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed"): > There were other comments further down my original review which you > haven't answered. I don't think they were (all) predicated on a > particular answer to the first question (although some were). Sorr

[Xen-devel] [PATCH 3/6] libxl: events: Deregister, don't just modify, sigchld pipe fd

2014-12-09 Thread Ian Jackson
We want to have no fd events registered when we are idle. This implies that we must be able to deregister our interest in the sigchld self-pipe fd, not just modify to request no events. Signed-off-by: Ian Jackson Acked-by: Ian Campbell Tested-by: Ian Campbell Release-Acked-by: Konrad Rzeszutek

[Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

2014-12-09 Thread Anthony PERARD
The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call to virDomainGetXMLDesc done before OpenConsole will not have the path to the pty, but a call after OpenConsole will. e.g. of the current issue. Starting a domain with '' Then: virDomainGe

Re: [Xen-devel] [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0

2014-12-09 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0"): > There was a point in time where the prevailing version of bison (or > maybe flex) in stable distro releases had a bug which meant these files > could not be regenerated easily on common distros. I

Re: [Xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure

2014-12-09 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 02:35:37PM +, Ian Campbell wrote: > On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote: > > > +distclean: > > + rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons > > NetBSD/rc.d/xencommons > > Configure generates a boatload more things than this, se

Re: [Xen-devel] [PATCH 1/4] dma: add dma_get_required_mask_from_max_pfn()

2014-12-09 Thread Greg Kroah-Hartman
On Mon, Dec 08, 2014 at 10:36:14AM +, David Vrabel wrote: > On 05/12/14 21:31, Greg Kroah-Hartman wrote: > > On Fri, Dec 05, 2014 at 02:08:00PM +, David Vrabel wrote: > >> A generic dma_get_required_mask() is useful even for architectures (such > >> as ia64) that define ARCH_HAS_GET_REQUIRE

Re: [Xen-devel] [PATCH v2] xen/serial: setup UART idle mode for OMAP

2014-12-09 Thread Oleksandr Dmytryshyn
On Tue, Dec 9, 2014 at 4:47 PM, Ian Campbell wrote: > On Mon, 2014-12-08 at 15:51 +0200, Oleksandr Dmytryshyn wrote: >> UART is not able to receive bytes when idle mode is not >> configured properly. When we use Xen with old Linux >> Kernel (for example 3.8) this kernel configures hwmods >> for al

Re: [Xen-devel] [PATCH for-4.5] flask/policy: Example policy updates for migration

2014-12-09 Thread Ian Campbell
On Mon, 2014-12-08 at 11:07 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 08, 2014 at 03:54:06PM +, Ian Campbell wrote: > > On Mon, 2014-12-08 at 10:52 -0500, Konrad Rzeszutek Wilk wrote: > > > On Mon, Dec 08, 2014 at 09:48:07AM +, Ian Campbell wrote: > > > > On Fri, 2014-12-05 at 12:03

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Correct the opcode for BUG_INSTR on arm32

2014-12-09 Thread Ian Campbell
On Fri, 2014-12-05 at 10:54 +, Ian Campbell wrote: > > > Not sure, why I dropped the 0 when I implemented the patch... > > > This is a bug fixed for Xen 4.5. This is only affected ARM32 where the > > > BUG opcode was malformed. > > > > > > With the malformed opcode, the ASSERT/BUG_ON is skippe

Re: [Xen-devel] [PATCH] tools/xenstore: fix link error with libsystemd

2014-12-09 Thread Ian Campbell
On Fri, 2014-12-05 at 12:19 -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 05, 2014 at 10:53:03AM +, Ian Campbell wrote: > > On Fri, 2014-12-05 at 11:49 +0100, Olaf Hering wrote: > > > Linking fails with undefined reference to the used systemd functions. > > > Move LDFLAGS after the object f

[Xen-devel] [xen-unstable test] 32153: tolerable trouble: broken/fail/pass - PUSHED

2014-12-09 Thread xen . org
flight 32153 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/32153/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt 3 host-install(3) broken pass in 32139 test-armhf-armhf-xl 4 xe

Re: [Xen-devel] [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 14:04 +, George Dunlap wrote: > At the moment libxl unconditinally passes the underlying file format > to qemu in the device string. However, when tapdisk is in use, > tapdisk handles the underlying format and presents qemu with > effectively a raw disk. When qemu looks

Re: [Xen-devel] [PATCH v2] xen/serial: setup UART idle mode for OMAP

2014-12-09 Thread Ian Campbell
On Mon, 2014-12-08 at 15:51 +0200, Oleksandr Dmytryshyn wrote: > UART is not able to receive bytes when idle mode is not > configured properly. When we use Xen with old Linux > Kernel (for example 3.8) this kernel configures hwmods > for all devices even if the device tree nodes for those > devices

Re: [Xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote: > +distclean: > + rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons > NetBSD/rc.d/xencommons Configure generates a boatload more things than this, see e.g. $ grep hotplug/ tools/configure.ac Perhaps the answer would be

Re: [Xen-devel] [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk

2014-12-09 Thread George Dunlap
On 12/09/2014 02:32 PM, Wei Liu wrote: > On Tue, Dec 09, 2014 at 02:04:19PM +, George Dunlap wrote: >> At the moment libxl unconditinally passes the underlying file format >> to qemu in the device string. However, when tapdisk is in use, >> tapdisk handles the underlying format and presents qe

Re: [Xen-devel] error of VM Migration (xl toolstack) failed when migrating Webserver VM with 100 connecitons using httperf

2014-12-09 Thread George Dunlap
On Mon, Dec 8, 2014 at 4:36 AM, Minalkumar Patel wrote: > > > error of Migration failed when migrating Webserver VM with 100 connecitons > using httperf Thanks for the bug report. Can you please include more information about your setup? At very least the output of "xl info", your domain config

Re: [Xen-devel] [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk

2014-12-09 Thread Wei Liu
On Tue, Dec 09, 2014 at 02:04:19PM +, George Dunlap wrote: > At the moment libxl unconditinally passes the underlying file format > to qemu in the device string. However, when tapdisk is in use, > tapdisk handles the underlying format and presents qemu with > effectively a raw disk. When qemu

Re: [Xen-devel] [PATCH for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid()

2014-12-09 Thread Andrew Cooper
On 09/12/14 14:27, Ian Campbell wrote: > On Fri, 2014-11-28 at 11:37 +, Ian Campbell wrote: >> On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: >>> The error handling from a failed memory allocation should return >>> PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and >>

Re: [Xen-devel] [PATCH for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid()

2014-12-09 Thread Ian Campbell
On Fri, 2014-11-28 at 11:37 +, Ian Campbell wrote: > On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: > > The error handling from a failed memory allocation should return > > PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and > > continuing > > to the memcpy() below, wi

[Xen-devel] [PATCH v2] xen/blkfront: remove redundant flush_op

2014-12-09 Thread Vitaly Kuznetsov
flush_op is unambiguously defined by feature_flush: REQ_FUA | REQ_FLUSH -> BLKIF_OP_WRITE_BARRIER REQ_FLUSH -> BLKIF_OP_FLUSH_DISKCACHE 0 -> 0 and thus can be removed. This is just a cleanup. The patch was suggested by Boris Ostrovsky. Signed-off-by: Vitaly Kuznetsov --- Changes from

Re: [Xen-devel] [PATCH] tools/hotplug: xendomains.service depends on network

2014-12-09 Thread Wei Liu
On Tue, Dec 09, 2014 at 01:06:55PM +0100, Olaf Hering wrote: > Starting domains during boot will most likely require network for the > local bridge and it may need access to remote filesystems. Add ordering > tags to systemd service file. > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: St

[Xen-devel] [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk

2014-12-09 Thread George Dunlap
At the moment libxl unconditinally passes the underlying file format to qemu in the device string. However, when tapdisk is in use, tapdisk handles the underlying format and presents qemu with effectively a raw disk. When qemu looks at the tapdisk block device and doesn't find the image format it

Re: [Xen-devel] [COVERITY ACCESS] Request for access to Coverity

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-02 at 15:12 +, Ian Campbell wrote: > On Tue, 2014-12-02 at 15:10 +, George Dunlap wrote: > > On Thu, Nov 27, 2014 at 3:11 PM, Konrad Rzeszutek Wilk > > wrote: > > > > > > On Nov 27, 2014 6:59 AM, Tim Deegan wrote: > > >> > > >> At 11:39 + on 27 Nov (1417084797), George

Re: [Xen-devel] [PATCH v2] introduce grant copy for user land

2014-12-09 Thread Thanos Makatos
> -Original Message- > From: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > Sent: 05 December 2014 6:06 PM > To: Thanos Makatos; xen-de...@lists.xenproject.org > Cc: David Vrabel > Subject: Re: [Xen-devel] [PATCH v2] introduce grant copy for user land > > On 12/02/2014 11:13 AM, Tha

Re: [Xen-devel] [PATCH] netback: don't store invalid vif pointer

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 11:47 +, Jan Beulich wrote: > When xenvif_alloc() fails, it returns a non-NULL error indicator. To > avoid eventual races, we shouldn't store that into struct backend_info > as readers of it only check for NULL. > > Signed-off-by: Jan Beulich Acked-by: Ian Campbell Th

[Xen-devel] [PATCH] tools/hotplug: xendomains.service depends on network

2014-12-09 Thread Olaf Hering
Starting domains during boot will most likely require network for the local bridge and it may need access to remote filesystems. Add ordering tags to systemd service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- This should go into 4

[Xen-devel] Konrad R Wilk's Xen Project Committer Status confirmed (+ some governance policy concerns)

2014-12-09 Thread Lars Kurth
Hi all, I wanted to to summarize the outcome of the vote for Konrad's committer status. We had 4 votes in favor and one abstained. Which means Konrad is confirmed. A number of concerns were raised, e.g. shouldn't other maintainers (e.g. George Dunlap as past release manager, or Stefano Stabellini

Re: [Xen-devel] [libvirt] [PATCH] libxl: Set path to console on domain startup.

2014-12-09 Thread Anthony PERARD
On Mon, Dec 08, 2014 at 12:03:36PM -0700, Jim Fehlig wrote: > Anthony PERARD wrote: > > The path to the pty of a Xen PV console is set only in > > virDomainOpenConsole. But this is done too late. A call to > > virDomainGetXMLDesc done before OpenConsole will not have the path to > > the pty, but a

[Xen-devel] [PATCH] netback: don't store invalid vif pointer

2014-12-09 Thread Jan Beulich
When xenvif_alloc() fails, it returns a non-NULL error indicator. To avoid eventual races, we shouldn't store that into struct backend_info as readers of it only check for NULL. Signed-off-by: Jan Beulich --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -404,6 +40

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 09 December 2014 11:29 > To: Paul Durrant > Cc: Tim (Xen.org); Yu, Zhang; Kevin Tian; Keir (Xen.org); jbeul...@suse.com; > Xen-devel@lists.xen.org > Subject: Re: [Xen-devel] One question about the hypercall to translate gfn to > mfn. > > On

Re: [Xen-devel] [PATCH v2 01/19] xen: dump vNUMA information with debug key "u"

2014-12-09 Thread Jan Beulich
>>> On 09.12.14 at 12:22, wrote: > Is this what you want? > > +if ( vnuma->vmemrange[j].nid == i ) > +{ > +printk(" %016"PRIx64" - %016"PRIx64"\n", > + vnuma->vmemrange[j].start, > + vn

Re: [Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 11:22 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 5/6] libxl: events: Deregister evtchn fd > when not needed"): > > On Fri, 2014-11-28 at 14:47 +, Ian Jackson wrote: > > > libxl__ev_evtchn_* is always called with the ctx lock held. > > > > For the most p

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Ian Campbell
On Tue, 2014-12-09 at 11:17 +, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 09 December 2014 11:11 > > To: Paul Durrant > > Cc: Tim (Xen.org); Yu, Zhang; Kevin Tian; Keir (Xen.org); jbeul...@suse.com; > > Xen-devel@lists.xen.org > > Subject: Re: [Xen-devel

Re: [Xen-devel] One question about the hypercall to translate gfn to mfn.

2014-12-09 Thread Malcolm Crossley
On 09/12/14 11:23, Jan Beulich wrote: On 09.12.14 at 12:17, wrote: >> I think we want be able to avoid setting up a PTE in the MMU since it's not >> needed in most (or perhaps all?) cases. > > With shared page tables, there's no way to do one without the other. > Interestingly the IOMMU in

Re: [Xen-devel] [PATCH v2 01/19] xen: dump vNUMA information with debug key "u"

2014-12-09 Thread Wei Liu
On Mon, Dec 08, 2014 at 05:01:29PM +, Jan Beulich wrote: [...] > > +for ( i = 0; i < vnuma->nr_vnodes; i++ ) > > +{ > > +err = snprintf(keyhandler_scratch, 12, "%3u", > > +vnuma->vnode_to_pnode[i]); > > +if ( err < 0 || vnuma->vnode_to

Re: [Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed

2014-12-09 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed"): > On Fri, 2014-11-28 at 14:47 +, Ian Jackson wrote: > > libxl__ev_evtchn_* is always called with the ctx lock held. > > For the most part this is implicit due to the caller being in an ao > callback,

  1   2   >