On 16/06/15 16:04, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> Libxl has now been fully adjusted not to need them.
>>
>> Signed-off-by: Andrew Cooper
> Acked-by: Ian Campbell
>
> /me looks mournfully at the #28 shaped hole in this series which would
> nuke all
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Libxl has now been fully adjusted not to need it.
>
> Signed-off-by: Andrew Cooper
Acked-by: Ian Campbell
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Libxl has now been fully adjusted not to need them.
>
> Signed-off-by: Andrew Cooper
Acked-by: Ian Campbell
/me looks mournfully at the #28 shaped hole in this series which would
nuke all the migration v1 code from libxc :-)
Ian.
___
On Tue, 2015-06-16 at 20:20 +0530, Vijay Kilari wrote:
> On Thu, Jun 11, 2015 at 3:10 PM, Ian Campbell wrote:
> > Draft F follows. Also at:
> > http://xenbits.xen.org/people/ianc/vits/draftF.{pdf,html}
> >
> >
> > ## Per-domain `struct pending_irq` for `vLPI`s
> >
> > Internally Xen uses a `struct
>>> On 16.06.15 at 12:50, wrote:
> How XenServer currently does levelling
> ==
>
> The _Heterogeneous Pool Levelling_ support in XenServer appears to
> predate the
> libxc CPUID policy API, so does not currently use it. The toolstack has a
> table of CPU model
On 16/06/15 14:50, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> With libxl migration v2, there will be other moving parts which might fail,
>> requiring the helper to be stopped for reasons which are not its fault.
>>
>> Signed-off-by: Andrew Cooper
>> CC: Ian C
On 16/06/15 15:31, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> From: Ross Lagerwall
>>
>> Signed-off-by: Ross Lagerwall
>> Signed-off-by: Andrew Cooper
>> CC: Ian Campbell
>> CC: Ian Jackson
>> CC: Wei Liu
> Overall looks good, I've got some comments below
On Tue, 16 Jun 2015, Jan Beulich wrote:
> >>> On 16.06.15 at 16:03, wrote:
> > On Fri, 5 Jun 2015, Jan Beulich wrote:
> >> +} else if (s->msix->enabled) {
> >> +if (!(value & PCI_MSIX_FLAGS_ENABLE)) {
> >> +xen_pt_msix_disable(s);
> >> +s->msix->enabled = false;
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> From: Ross Lagerwall
>
> Signed-off-by: Ross Lagerwall
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
> ---
> tools/libxl/Makefile |2 +-
> tools/libxl/libxl_internal.h | 33 ++
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> In a remus senario, libxc will write a CHECKPOINT record, then hand ownership
"scenario"
> of the fd to libxl. Libxl then writes any records required and finishes with
> a CHECKPOINT_END record, then hands ownership of the fd back to libx
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> This is a complicated set of changes which must be done together for
> bisectability.
>
> * libxl-save-helper is updated to unconditionally use libxc migration v2.
> * libxl compatibility workarounds in libxc are disabled for save operati
On Wed, Jun 10, 2015 at 11:09:50AM +0100, Stefano Stabellini wrote:
> When QEMU restricts its xenstore connection, it cannot provide PV
> backends. A separate QEMU instance is required to provide PV backends in
> userspace, such as qdisk. With two separate instances, it is not
> possible to take ad
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> @@ -377,6 +384,28 @@ static void record_body_done(libxl__egc *egc,
> stream_failed(egc, stream, ret);
> }
>
> +void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void,
> + int ret, int ret
On 06/16/15 06:32, Wei Liu wrote:
> On Mon, Jun 15, 2015 at 01:45:26PM -0400, Don Slutz wrote:
>> On 06/15/15 11:54, Wei Liu wrote:
>>> On Mon, Jun 15, 2015 at 10:15:51AM -0400, Don Slutz wrote:
This allows more then 32 nics.
>>>
>>> How does this patch help? What prevents you from having
On Wed, Jun 10, 2015 at 11:09:49AM +0100, Stefano Stabellini wrote:
> The device model is going to restrict its xenstore connection to $DOMID
> level. Let qemu-xen access
> /local/domain/$LIBXL_TOOLSTACK_DOMID/device-model/$DOMID, as it is
> required by QEMU to read/write the physmap. It doesn't co
On Tue, Jun 16, 2015 at 04:56:35PM +0200, Juergen Gross wrote:
> Hmm, I'm beginning to question the value of that file. May be I should
> just throw it away.
Given that you are going to have to justify every one of them, and
ensure that you are creating them in a race-free manner (I didn't look
to
On Tue, 16 Jun 2015, Jan Beulich wrote:
> >>> On 16.06.15 at 15:35, wrote:
> > On Fri, 5 Jun 2015, Jan Beulich wrote:
> >> @@ -322,6 +323,13 @@ static int xen_pt_msix_update_one(XenPCI
> >>
> >> pirq = entry->pirq;
> >>
> >> +if (pirq == XEN_PT_UNASSIGNED_PIRQ || s->msix->maskall ||
>
On 16/06/15 14:19, Jan Beulich wrote:
On 12.06.15 at 18:43, wrote:
>> IOMMUOP_query_caps
>> --
>>
>> This subop queries the runtime capabilities of the PV-IOMMU interface for
>> the
>> specific called domain. This subop uses `struct pv_iommu_op` directly.
>
> "calling domain
On Tue, 16 Jun 2015, Juergen Gross wrote:
> AFAIK there are no outstanding questions for more than one month now.
> I'd appreciate some feedback or accepting these patches.
They are against dead code, which will be gone soon. We switched over
to queued locks.
Thanks,
tglx
flight 58604 xen-4.2-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/58604/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-libvirt 3 host-install(3) broken in 58584 REGR. vs. 584
On Tue, 16 Jun 2015, Jan Beulich wrote:
> >>> On 16.06.15 at 16:27, wrote:
> > On Fri, 5 Jun 2015, Jan Beulich wrote:
> >> This is done indirectly by adjusting two typedefs and helps emphasizing
> >> that the respective tables aren't supposed to be modified at runtime
> >> (as they may be shared b
On 06/16/2015 02:37 PM, Ian Jackson wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
>> Remember that the path you gave in your previous e-mail isn't the path
>> for the *usb device*, it's the path for the *block device*. It
>> contains a PCI address, but it l
flight 58597 linux-3.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/58597/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl 9 debian-install fail REGR. vs. 52209-bisect
test-amd64-amd64-pair
Hi Ian,
On 06/16/2015 07:05 PM, Ian Jackson wrote:
Yang Hongyang writes ("[Xen-devel] [PATCH v2 COLOPre 09/13] tools/libxl: Update
libxl_save_msgs_gen.pl to support return data from xl to xc"):
From: Wen Congyang
Currently, all callbacks return an integer value or void. We cannot
return
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> When a legacy stream is found, it needs to be converted to a v2 stream for the
> reading logic. This is done by exec()ing the python conversion utility.
>
> One complication is that the caller of this interface needs to assume
> ownership
On 06/16/2015 04:45 PM, Greg KH wrote:
On Tue, Jun 16, 2015 at 04:32:34PM +0200, Juergen Gross wrote:
Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
domU to communicate with a USB device assigned to that domU. The
communication is all done via the pvUSB backend in a drive
On 06/16/2015 03:20 PM, Juergen Gross wrote:
> On 06/16/2015 04:06 PM, George Dunlap wrote:
>> On 06/16/2015 02:49 PM, Juergen Gross wrote:
>>> On 06/16/2015 03:29 PM, George Dunlap wrote:
On 06/16/2015 02:23 PM, Juergen Gross wrote:
> Hmm, I'd rather have it all in one place. Putting it i
On Thu, Jun 11, 2015 at 3:10 PM, Ian Campbell wrote:
> Draft F follows. Also at:
> http://xenbits.xen.org/people/ianc/vits/draftF.{pdf,html}
>
>
> ## Per-domain `struct pending_irq` for `vLPI`s
>
> Internally Xen uses a `struct pending_irq` to track the status of any
> pending virtual IRQ, includi
On 16/06/15 14:26, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v2 6/6] libxl/save: Refactor
> libxl__domain_suspend_state"):
>> Currently struct libxl__domain_suspend_state contains 2 type of states,
>> one is save state, another is suspend state. This patch separate it out.
>> The motivati
On Tue, Jun 16, 2015 at 04:32:34PM +0200, Juergen Gross wrote:
> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
> domU to communicate with a USB device assigned to that domU. The
> communication is all done via the pvUSB backend in a driver domain
> (usually Dom0) which is o
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> From: Ross Lagerwall
>
> Signed-off-by: Ross Lagerwall
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
Overall looks good, I've got some comments below and I think it almost
certainly wants eyes from
>>> On 16.06.15 at 16:27, wrote:
> On Fri, 5 Jun 2015, Jan Beulich wrote:
>> This is done indirectly by adjusting two typedefs and helps emphasizing
>> that the respective tables aren't supposed to be modified at runtime
>> (as they may be shared between devices).
>>
>> Signed-off-by: Jan Beulich
This series adds XEN guest pvUSB support. With pvUSB it is possible to
use physical USB devices from a XEN domain.
The support consists of a frontend in form of a virtual hcd driver in
the unprivileged domU passing I/O-requests to the backend in a driver
domain (usually Dom0). The backend is not p
>>> On 16.06.15 at 16:19, wrote:
> On Fri, 5 Jun 2015, Jan Beulich wrote:
>> @@ -1016,11 +1002,12 @@ static XenPTRegInfo xen_pt_emu_reg_pm[]
>> .size = 2,
>> .init_val = 0x0008,
>> .res_mask = 0x00F0,
>> -.ro_mask= 0xE10C,
>> +.ro_mask=
AFAIK there are no outstanding questions for more than one month now.
I'd appreciate some feedback or accepting these patches.
Juergen
On 04/30/2015 12:53 PM, Juergen Gross wrote:
Paravirtualized spinlocks produce some overhead even if the kernel is
running on bare metal. The main reason are t
On 16/06/15 15:19, Boris Ostrovsky wrote:
> On 06/16/2015 10:15 AM, David Vrabel wrote:
>> On 15/06/15 21:35, Ingo Molnar wrote:
>>> * David Vrabel wrote:
>>>
On 15/06/15 10:05, Ian Campbell wrote:
> On Sat, 2015-06-13 at 11:49 +0200, Ingo Molnar wrote:
>> xen_mm_pin_all()/unpin_all()
Add myself as maintainer for the Xen pvUSB stuff.
Signed-off-by: Juergen Gross
Acked-by: Konrad Rzeszutek Wilk
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d8afd29..8ef4e83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10965,6 +109
Add the definition of pvUSB protocol used between the pvUSB frontend in
a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
This header was originally provided by Fujitsu for Xen based on Linux
2.6.18.
Changes are:
- adapt to Linux style guide
Signed-off-by: Juergen Gross
--
Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
domU to communicate with a USB device assigned to that domU. The
communication is all done via the pvUSB backend in a driver domain
(usually Dom0) which is owner of the physical device.
The pvUSB frontend is a USB hcd for a vir
On Fri, 5 Jun 2015, Jan Beulich wrote:
> This is done indirectly by adjusting two typedefs and helps emphasizing
> that the respective tables aren't supposed to be modified at runtime
> (as they may be shared between devices).
>
> Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
> -
On Fri, 5 Jun 2015, Jan Beulich wrote:
> Functions setting errno commonly return just -1, which is of no
> particular use in the log file.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
> --- a/qemu/upstream/hw/xen/xen_pt.c
> +++ b/qemu/upstream/hw/xen/xen_pt.c
> @@ -609,8 +60
On 06/16/2015 10:15 AM, David Vrabel wrote:
On 15/06/15 21:35, Ingo Molnar wrote:
* David Vrabel wrote:
On 15/06/15 10:05, Ian Campbell wrote:
On Sat, 2015-06-13 at 11:49 +0200, Ingo Molnar wrote:
xen_mm_pin_all()/unpin_all() are used to implement full guest instance
suspend/restore. It's a
On Fri, 5 Jun 2015, Jan Beulich wrote:
> Introduce yet another mask for them, so that the generic routine can
> handle them, at once rendering xen_pt_pmcsr_reg_write() superfluous.
>
> Signed-off-by: Jan Beulich
>
> --- a/qemu/upstream/hw/xen/xen_pt.h
> +++ b/qemu/upstream/hw/xen/xen_pt.h
> @@ -
On 06/16/2015 04:06 PM, George Dunlap wrote:
On 06/16/2015 02:49 PM, Juergen Gross wrote:
On 06/16/2015 03:29 PM, George Dunlap wrote:
On 06/16/2015 02:23 PM, Juergen Gross wrote:
Hmm, I'd rather have it all in one place. Putting it in qemu would
enable us to handle hotplug as well. A USB devi
>>> On 16.06.15 at 16:03, wrote:
> On Fri, 5 Jun 2015, Jan Beulich wrote:
>> +} else if (s->msix->enabled) {
>> +if (!(value & PCI_MSIX_FLAGS_ENABLE)) {
>> +xen_pt_msix_disable(s);
>> +s->msix->enabled = false;
>> +} else if (!s->msix->maskall) {
>
> Wh
On 15/06/15 21:35, Ingo Molnar wrote:
>
> * David Vrabel wrote:
>
>> On 15/06/15 10:05, Ian Campbell wrote:
>>> On Sat, 2015-06-13 at 11:49 +0200, Ingo Molnar wrote:
>
xen_mm_pin_all()/unpin_all() are used to implement full guest instance
suspend/restore. It's a stop-all method that
On 06/16/2015 03:45 AM, Jan Beulich wrote:
On 15.06.15 at 19:17, wrote:
+for ( i = 0; i < num_counters; i++ )
+{
+if ( (ctrl_regs[i] & CTRL_RSVD_MASK) != ctrl_rsvd[i] )
+{
+/*
+ * Not necessary to re-init context since we s
On 16/06/15 14:39, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> Introduced at this point so the python stream conversion code has a concrete
>> ABI to use.
> Please could you also explicitly mention that it isn't added to FLAG_ALL
> yet because we don't actually
On Fri, 5 Jun 2015, Jan Beulich wrote:
> The way the generic infrastructure works the intention of not allowing
> unaligned accesses can't be achieved by simply setting .unaligned to
> false. The benefit is that we can now replace the conditionals in
> {get,set}_entry_value() by assert()-s.
>
> Si
On 16/06/15 14:37, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> Shortly more parameters will appear, and this saves unboxing each one.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper
>> CC: Ian Campbell
>> CC: Ian Jackson
>> CC: Wei Liu
>> ---
On 06/16/2015 02:49 PM, Juergen Gross wrote:
> On 06/16/2015 03:29 PM, George Dunlap wrote:
>> On 06/16/2015 02:23 PM, Juergen Gross wrote:
>>> Hmm, I'd rather have it all in one place. Putting it in qemu would
>>> enable us to handle hotplug as well. A USB device assigned via it's
>>> serial to a
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> This utility will take a legacy stream as in input, and produce a v2 stream as
> an output. It is exec()'d by libxl to provide backwards compatibility.
>
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
On 16/06/15 14:47, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH 01/27] tools/libxl: Fix
> libxl__ev_child_inuse() check for not-yet-initialised children"):
>> It is possible that one bit fails before it can be calculated whether
>> the second bit needs to start or not.
>>
>> At the momen
On Mon, Jun 15, 2015 at 05:34:08PM +0100, Lars Kurth wrote:
>
> > On 15 Jun 2015, at 15:51, George Dunlap wrote:
> >
> >> A more practical requirement for a feature with "Supported" status is
> >> that _either_:
> >>
> >> * The feature is tested automatically.
> >>
> >> * At least once during
On Fri, 5 Jun 2015, Jan Beulich wrote:
> Particularly the maskall bit has to be under exclusive hypervisor
> control (and since they live in the same config space field, the
> enable bit has to follow suit). Use the replacement hypercall
> interfaces.
>From this commit message, I expect a patch th
>>> On 16.06.15 at 15:35, wrote:
> On Fri, 5 Jun 2015, Jan Beulich wrote:
>> @@ -322,6 +323,13 @@ static int xen_pt_msix_update_one(XenPCI
>>
>> pirq = entry->pirq;
>>
>> +if (pirq == XEN_PT_UNASSIGNED_PIRQ || s->msix->maskall ||
>> +(entry->latch(VECTOR_CTRL) & PCI_MSIX_ENTRY
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> From: Ross Lagerwall
>
> C structures describing the Libxl migration v2 stream format
Do we think these should be internal or are they part of the library
API? I suppose it's a bit of a grey area, obviously the file format is
"ABI", but i
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Contains:
> * Python implementation of the libxc migration v2 records
> * Verification code for spec compliance
> * Unit tests
>
> Signed-off-by: Andrew Cooper
For this, and the following lobxl and verification patches:
Acked-by: Ian
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper
> +EMULATOR\_CONTEXT
> +
> +
> +A context blob for a specific emulator associated with the domain.
> +
> + 0 1 2 3 4 5 6 7 octet
> +++
On 06/16/2015 09:09 PM, Ian Campbell wrote:
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
move save/restore code into libxl_dom_save.c.
If this (unlike other patches in the series) is purely code motion
please indicate that this is the case.
You might also like to consider refacto
Andrew Cooper writes ("Re: [PATCH 01/27] tools/libxl: Fix
libxl__ev_child_inuse() check for not-yet-initialised children"):
> It is possible that one bit fails before it can be calculated whether
> the second bit needs to start or not.
>
> At the moment, all bits in libxl in this area do initiali
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> If a conversion of a legacy stream is needed, libxl__xc_domain_restore() will
> need to use an fd other to the one found in the domain_create_state.
>
> No functional change.
It could be argued that the one in domain_create_state should al
On 06/16/2015 09:08 PM, Ian Campbell wrote:
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
move remus code into libxl_remus.c.
Please say something like "... by refactoring bits of
libxl_domain_remus_start and domain_save_done into X and Y and moving
the remaining functionality unch
On 06/16/2015 09:00 PM, Ian Campbell wrote:
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
Move domain suspend code into a separate file libxl_dom_suspend.c.
export an API libxl__domain_suspend() which wrappers the static
just "..which wraps the..."
will fix, thank you !
funct
On 06/16/2015 09:04 PM, Ian Campbell wrote:
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
move domain resume code into libxl_dom_suspend.c.
Even though it has "resume" in the name, I'm not sure that
libxl__domain_s3_resume is a good candidate for moving to the suspend
code, it's ca
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> With libxl migration v2, there will be other moving parts which might fail,
> requiring the helper to be stopped for reasons which are not its fault.
>
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
>
On 06/16/2015 03:29 PM, George Dunlap wrote:
On 06/16/2015 02:23 PM, Juergen Gross wrote:
On 06/16/2015 03:09 PM, George Dunlap wrote:
On 06/16/2015 02:06 PM, Juergen Gross wrote:
On 06/16/2015 01:45 PM, Ian Jackson wrote:
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb
Ian Campbell writes ("Re: [PATCH 01/27] tools/libxl: Fix
libxl__ev_child_inuse() check for not-yet-initialised children"):
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> > Shortly, libxl will be juggling multiple parallel operations, and will
> > possibly have to take error decisions
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> This is the same as is used by libxc.
>
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
Acked-by: Ian Campbell
___
Xen-devel mailing list
Xen-devel@lists
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Introduced at this point so the python stream conversion code has a concrete
> ABI to use.
Please could you also explicitly mention that it isn't added to FLAG_ALL
yet because we don't actually implement it yet and that it will be added
the
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
> Remember that the path you gave in your previous e-mail isn't the path
> for the *usb device*, it's the path for the *block device*. It
> contains a PCI address, but it looks like it also contains part of the
> USB top
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Shortly more parameters will appear, and this saves unboxing each one.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper
> CC: Ian Campbell
> CC: Ian Jackson
> CC: Wei Liu
> ---
> tools/libxl/libxl_create.c | 12 +
On 16/06/15 14:21, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> Shortly, libxl will be juggling multiple parallel operations, and will
>> possibly have to take error decisions before some tasks have been set up.
> It would be preferable, I think, to arrange to ca
On Fri, 5 Jun 2015, Jan Beulich wrote:
> The remaining log message in pci_msix_write() is wrong, as there guest
> behavior may only appear to be wrong: For one, the old logic didn't
> take the mask-all bit into account. And then this shouldn't depend on
> host device state (i.e. the host may have m
On 06/16/2015 03:19 PM, George Dunlap wrote:
On Tue, Jun 16, 2015 at 1:02 PM, Ian Jackson wrote:
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
So it sounds like we're converging on "Allow multiple ways to specify
the interface", with at least the following field
On 06/16/2015 02:23 PM, Juergen Gross wrote:
> On 06/16/2015 03:09 PM, George Dunlap wrote:
>> On 06/16/2015 02:06 PM, Juergen Gross wrote:
>>> On 06/16/2015 01:45 PM, Ian Jackson wrote:
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb
API"):
> On 06/16/2015 01:1
On 16/06/15 14:13, David Vrabel wrote:
> On 16/06/15 13:57, Julien Grall wrote:
>> On 16/06/15 12:59, Jan Beulich wrote:
>> On 16.06.15 at 13:14, wrote:
On 15/06/2015 16:48, David Vrabel wrote:
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 44ea92d..a0ff9
Yang Hongyang writes ("[PATCH v2 6/6] libxl/save: Refactor
libxl__domain_suspend_state"):
> Currently struct libxl__domain_suspend_state contains 2 type of states,
> one is save state, another is suspend state. This patch separate it out.
> The motivation of this is that COLO will need to do suspe
On 06/16/2015 03:09 PM, George Dunlap wrote:
On 06/16/2015 02:06 PM, Juergen Gross wrote:
On 06/16/2015 01:45 PM, Ian Jackson wrote:
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb
API"):
On 06/16/2015 01:10 PM, Ian Jackson wrote:
AIUI some devices have serial numbers,
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> This is safe (as the variable will simply be unused), and is required for
> correct compilation when midway through untangling the libxc/libxl
> interaction.
>
> The #define is left in place to highlight that the variables can be removed
>
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Shortly, libxl will be juggling multiple parallel operations, and will
> possibly have to take error decisions before some tasks have been set up.
It would be preferable, I think, to arrange to call libxl__ev_child_init
on all such libxl__e
>>> On 12.06.15 at 18:43, wrote:
> IOMMUOP_query_caps
> --
>
> This subop queries the runtime capabilities of the PV-IOMMU interface for
> the
> specific called domain. This subop uses `struct pv_iommu_op` directly.
"calling domain" perhaps?
> --
On Tue, Jun 16, 2015 at 1:02 PM, Ian Jackson wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
>> So it sounds like we're converging on "Allow multiple ways to specify
>> the interface", with at least the following fields:
>> - bus (int - 1,2,3, &c)
>> - port (
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> Currently struct libxl__domain_suspend_state contains 2 type of states,
> one is save state, another is suspend state. This patch separate it out.
"This patch separates those two out".
> The motivation of this is that COLO will need to do
On 16/06/15 13:57, Julien Grall wrote:
> On 16/06/15 12:59, Jan Beulich wrote:
> On 16.06.15 at 13:14, wrote:
>>> On 15/06/2015 16:48, David Vrabel wrote:
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 44ea92d..a0ff9d2 100644
--- a/xen/include/xen/sched.h
>
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> move save/restore code into libxl_dom_save.c.
If this (unlike other patches in the series) is purely code motion
please indicate that this is the case.
You might also like to consider refactoring things such that all patches
are pure motio
On 06/16/2015 02:06 PM, Juergen Gross wrote:
> On 06/16/2015 01:45 PM, Ian Jackson wrote:
>> Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb
>> API"):
>>> On 06/16/2015 01:10 PM, Ian Jackson wrote:
AIUI some devices have serial numbers, which means you can distinguish
>>
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> move remus code into libxl_remus.c.
Please say something like "... by refactoring bits of
libxl_domain_remus_start and domain_save_done into X and Y and moving
the remaining functionality unchanged into the new file".
I gave two examples o
On 06/16/2015 08:59 PM, Ian Campbell wrote:
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
Rename libxl__domain_suspend() to libxl__domain_save() since it
actually do the save domain work.
This results in some strangeness in that some functions called *save*
are now passed a struct
On 06/16/2015 01:45 PM, Ian Jackson wrote:
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
On 06/16/2015 01:10 PM, Ian Jackson wrote:
AIUI some devices have serial numbers, which means you can distinguish
them ?
Yes, they have. The question is whether those are d
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> move domain resume code into libxl_dom_suspend.c.
Even though it has "resume" in the name, I'm not sure that
libxl__domain_s3_resume is a good candidate for moving to the suspend
code, it's called only from libxl_send_trigger and IIRC we do
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> Move domain suspend code into a separate file libxl_dom_suspend.c.
> export an API libxl__domain_suspend() which wrappers the static
just "..which wraps the..."
> function domain_suspend_callback_common() for internal use.
>
> Note that t
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> Rename libxl__domain_suspend() to libxl__domain_save() since it
> actually do the save domain work.
This results in some strangeness in that some functions called *save*
are now passed a struct called *suspend*. I think this is probably
tem
On 16/06/15 12:59, Jan Beulich wrote:
On 16.06.15 at 13:14, wrote:
>> On 15/06/2015 16:48, David Vrabel wrote:
>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>> index 44ea92d..a0ff9d2 100644
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -129,7
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
> So it sounds like we're converging on "Allow multiple ways to specify
> the interface", with at least the following fields:
> - bus (int - 1,2,3, &c)
> - port (string - 2.1.3, &c)
> - address/devnum (int)
> - vendorid (
>>> On 16.06.15 at 13:14, wrote:
> On 15/06/2015 16:48, David Vrabel wrote:
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index 44ea92d..a0ff9d2 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -129,7 +129,7 @@ struct evtchn
>> #endif
>>
Juergen Gross writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
> On 06/16/2015 01:10 PM, Ian Jackson wrote:
> > AIUI some devices have serial numbers, which means you can distinguish
> > them ?
>
> Yes, they have. The question is whether those are different on multiple
> instances?
George Dunlap writes ("Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"):
> On Tue, Jun 16, 2015 at 12:19 PM, Juergen Gross wrote:
> > I'm pretty sure this is just a matter of timing during boot: the busses
> > are all (or at least some of them) queried at the same time and the
> > first answe
On Tue, Jun 16, 2015 at 12:25 PM, Juergen Gross wrote:
>>> qemu does support specifying a USB device via :,
>>> which is stable even across reboots, but unfortunately it isn't
>>> guaranteed to be unique (you can have plugged in two devices of the
>>> same type).
>>
>>
>> Indeed. That would also
Yang Hongyang writes ("Re: [Xen-devel] [PATCH v6 COLO 02/15] secondary vm
suspend/resume/checkpoint code"):
> > On Mon, Jun 08, 2015 at 11:45:46AM +0800, Yang Hongyang wrote:
...
> >> 3. Suspend secondary vm
> >> a. Suspend secondary vm.
> >> b. Call libxl__checkpoint_devices_postsuspend()
101 - 200 of 313 matches
Mail list logo
