[Xen-devel] [PATCH RFC 00/04] xen: arm64: Support VM save/restore on arm64

2016-08-04 Thread Chenxiao Zhao
Hi all, This patch added support VM save/restore for arm64. It is based on previous work done by Ian Campbell [1] with some bug fixes to make it work on stable-4.7. You should apply Ian's patch first. There still some known issues that have not fixed yet. * GIC v2 not support * No live migra

[Xen-devel] [PATCH RFC 01/04] xen: arm64: save/restore VCPU state for arm64

2016-08-04 Thread Chenxiao Zhao
added support to save/restore arm64 registers Signed-off-by: Chenxiao Zhao diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index aee3353..3073b17 100644 --- a/xen/arch/arm/hvm.c +++ b/xen/arch/arm/hvm.c @@ -120,7 +120,8 @@ static int cpu_save(struct domain *d, hvm_domain_context_t *h)

[Xen-devel] [PATCH RFC 03/04] tools/libxc: arm: Implement save ops arm_setup

2016-08-04 Thread Chenxiao Zhao
arm_setup need to return number of pages that vm is allocated. Code is copied from x64 save ops. Signed-off-by: Chenxiao Zhao diff --git a/tools/libxc/xc_sr_save_arm.c b/tools/libxc/xc_sr_save_arm.c index 611f99a..a2ef2db 100644 --- a/tools/libxc/xc_sr_save_arm.c +++ b/tools/libxc/xc_sr_save_a

[Xen-devel] [PATCH RFC 04/04] xen: arm64: save/restore domain type

2016-08-04 Thread Chenxiao Zhao
On arm64 VM uses d->arch.type to indicate if the domain is 32-bit or 64-bit. This value is set while parsing kernel image. while restoring VCPU state, it will use this value to decide the VCPU type. I can not find a proper place to save/restore this value in state file, this is surely not a goo

[Xen-devel] [PATCH RFC 02/04] tools/libxc: arm: Add missing save ops

2016-08-04 Thread Chenxiao Zhao
Add arm_check_vm_state function, .check_vm_state can not be NULL in arch specific ops. Signed-off-by: Chenxiao Zhao diff --git a/tools/libxc/xc_sr_save_arm.c b/tools/libxc/xc_sr_save_arm.c index 1442679..611f99a 100644 --- a/tools/libxc/xc_sr_save_arm.c +++ b/tools/libxc/xc_sr_save_arm.c @@ -1

Re: [Xen-devel] unable start xen in hikey

2016-08-04 Thread Chenxiao Zhao
The xen.cfg file seems fine to me. I suggest you try to use the dtb file compiled from the kernel source and update UEFI bootloader on hikey board to the latest version. hope this could help. On 8/4/2016 11:02 PM, Kamenee Arumugam wrote: I have already pass hi6220-key.dtb in my xen.cfg: opti

Re: [Xen-devel] [PATCH v5 0/4] x86/ioreq server: Introduce HVMMEM_ioreq_server mem type.

2016-08-04 Thread Jan Beulich
>>> On 05.08.16 at 04:44, wrote: > On 7/12/2016 5:02 PM, Yu Zhang wrote: >> XenGT leverages ioreq server to track and forward the accesses to GPU >> I/O resources, e.g. the PPGTT(per-process graphic translation tables). >> Currently, ioreq server uses rangeset to track the BDF/ PIO/MMIO ranges >>

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

2016-08-04 Thread Haozhong Zhang
On 08/04/16 10:51, Konrad Rzeszutek Wilk wrote: > > > > Such a pmem namespace can be created via a userspace tool ndctl and > > > > then recognized by Linux NVDIMM driver. However, they currently only > > > > reserve space for Linux kernel's page structs. Therefore, our design > > > > need to e

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 18:31, wrote: > Jan Beulich writes ("[PATCH] domctl: relax getdomaininfo permissions"): >> Qemu needs access to this for the domain it controls, both due to it >> being used by xc_domain_memory_mapping() (which qemu calls) and the >> explicit use in hw/xenpv/xen_domainbuild.c:xe

Re: [Xen-devel] [PATCH v2 1/2] xen/x86: Move irq allocation from Xen smp_op.cpu_up()

2016-08-04 Thread Juergen Gross
On 03/08/16 19:22, Boris Ostrovsky wrote: > Commit ce0d3c0a6fb1 ("genirq: Revert sparse irq locking around > __cpu_up() and move it to x86 for now") reverted irq locking > introduced by commit a89941816726 ("hotplug: Prevent alloc/free > of irq descriptors during cpu up/down") because of Xen alloca

Re: [Xen-devel] [PATCH v2 2/2] hotplug: Prevent alloc/free of irq descriptors during cpu up/down (again)

2016-08-04 Thread Juergen Gross
On 03/08/16 19:22, Boris Ostrovsky wrote: > Now that Xen no longer allocates irqs in _cpu_up() we can restore > commit a89941816726 ("hotplug: Prevent alloc/free of irq descriptors > during cpu up/down") > > Signed-off-by: Boris Ostrovsky > Acked-by: Thomas Gleixner Reviewed-by: Juergen Gross

Re: [Xen-devel] [PATCH v2 07/25] arm/altp2m: Add altp2m init/teardown routines.

2016-08-04 Thread Sergej Proskurin
Hi Julien, On 08/03/2016 08:12 PM, Julien Grall wrote: > Hello Sergej, > > On 01/08/16 18:10, Sergej Proskurin wrote: >> The p2m initialization now invokes initialization routines responsible >> for the allocation and initialization of altp2m structures. The same >> applies to teardown routines.

Re: [Xen-devel] [PATCH v2 01/25] arm/altp2m: Add first altp2m HVMOP stubs.

2016-08-04 Thread Sergej Proskurin
Hi Julien, On 08/04/2016 06:51 PM, Julien Grall wrote: > > > On 04/08/16 17:22, Sergej Proskurin wrote: >> >> On 08/04/2016 06:04 PM, Julien Grall wrote: >>> >>> >>> On 04/08/16 17:01, Sergej Proskurin wrote: Hi Julien, On 08/03/2016 06:54 PM, Julien Grall wrote: > Hello S

Re: [Xen-devel] [PATCH] x86/debug: Avoid crashing in early boot because of debugger_trap_entry()

2016-08-04 Thread Jan Beulich
>>> On 03.08.16 at 19:08, wrote: > debugger_trap_entry() is not safe to use during early boot, as it follows > current before it is necesserily safe to do so. Futhermore it does this > unconditionally, despite most callsites turning into no-ops because of the > vector test. > > Inline debugger_t

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Jan Beulich
>>> On 03.08.16 at 22:44, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs) > switch ( mode ) > { > case 8: > +if ( eax == __HYPERVISOR_hvm_op && > + regs->rdi ==

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Jan Beulich
>>> On 03.08.16 at 23:00, wrote: > On 08/03/16 23:44, Andrew Cooper wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs) >> switch ( mode ) >> { >> case 8: >> +if ( eax == __H

Re: [Xen-devel] unable start xen in hikey

2016-08-04 Thread Chenxiao Zhao
you have to pass hi6220-key.dtb to xen. On Thu, Aug 4, 2016 at 2:15 AM Kamenee Arumugam wrote: > Hi all, > > I am unable to start xen in hikey successfully but getting to this prompt > message: > > > >* Xen 4.7.0 (c/s Mon Jun 20 11:38:15 2016 +0100 git:9a6cc4f) EFI loader* > >* Using configurati

Re: [Xen-devel] [PATCH] x86/hvm: Drop the info level HVM save/restore messages

2016-08-04 Thread Jan Beulich
>>> On 03.08.16 at 20:26, wrote: > These are not very useful at all, and overly voluminous since the domain > builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM > domains. I have to admit that I like to have them for restore, but I'm with you that they're quite useless for

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 08:36, wrote: > On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: > On 03.08.16 at 20:41, wrote: >>> @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned >>> long gla, >>> } >>> } >>> >>> -if ( p2m_mem_acc

Re: [Xen-devel] [PATCH v2] libxl: return any serial tty path in libxl_console_get_tty

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 09:07:56AM +0800, Bob Liu wrote: > When specifying a serial list in domain config, users of > libxl_console_get_tty cannot get the tty path of a second specified pty > serial, > since right now it always returns the tty path of serial 0. > > Signed-off-by: Bob Liu Acked-

Re: [Xen-devel] [PATCH] x86: support newer Intel CPU models

2016-08-04 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, August 03, 2016 4:38 PM > > ... as per the June 2016 edition of the SDM. > > Also remove a couple of dead break statements as well as unused > *MSR_PM_LASTBRANCH* #define-s. > > Signed-off-by: Jan Beulich Acked-by: Kevin Tian

[Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Razvan Cojocaru
Hello, Looking at xen/common/domctl.c, it appears that during handling of XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: 465 if ( ret == 0 ) 466 { 467 domain_pause(d); 468 ret = arch_set_info_guest(v, c); 469 domain_un

[Xen-devel] [PATCH] libelf: drop struct elf_dom_parms' virt_offset member

2016-08-04 Thread Jan Beulich
It's being used solely by elf_xen_addr_calc_check(), and hence can be a local variable there. Signed-off-by: Jan Beulich --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -404,6 +404,8 @@ static elf_errorstatus elf_xen_note_chec static elf_errorstatus elf_xen_

[Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
Qemu needs access to this for the domain it controls, both due to it being used by xc_domain_memory_mapping() (which qemu calls) and the explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). This at once avoids a for_each_domain() loop when the ID of an existing domain gets passed in. Rep

[Xen-devel] [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree

2016-08-04 Thread Wei Liu
Signed-off-by: Wei Liu --- ap-common | 4 1 file changed, 4 insertions(+) diff --git a/ap-common b/ap-common index 19c7580..46523f3 100644 --- a/ap-common +++ b/ap-common @@ -33,6 +33,10 @@ : ${TREEVCS_LINUX:=git} +: ${TREE_XTF:=git://xenbits.xen.org/xtf.git} +: ${PUSH_TREE_XTF:=$XENBI

[Xen-devel] [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build

2016-08-04 Thread Wei Liu
Clone, build and package XTF for later use. Signed-off-by: Wei Liu --- ts-xtf-build | 66 1 file changed, 66 insertions(+) create mode 100755 ts-xtf-build diff --git a/ts-xtf-build b/ts-xtf-build new file mode 100755 index 000..5

[Xen-devel] [OSSTEST PATCH RFC 07/14] sg-run-job: create xtf build recipe

2016-08-04 Thread Wei Liu
Signed-off-by: Wei Liu --- sg-run-job | 5 + 1 file changed, 5 insertions(+) diff --git a/sg-run-job b/sg-run-job index 259fc3b..240b265 100755 --- a/sg-run-job +++ b/sg-run-job @@ -480,6 +480,7 @@ proc need-hosts/build {} { return BUILD } proc need-hosts/build-kern {} { return BUILD } pro

[Xen-devel] [OSSTEST PATCH RFC 09/14] mfi-common: create xtf build job for 4.8 onwards

2016-08-04 Thread Wei Liu
Signed-off-by: Wei Liu --- mfi-common | 29 + 1 file changed, 29 insertions(+) diff --git a/mfi-common b/mfi-common index 971ded3..b1e8dab 100644 --- a/mfi-common +++ b/mfi-common @@ -67,6 +67,21 @@ xenbranch_xsm_variants () { esac } +xenbranch_wants_xtf_tests

[Xen-devel] [OSSTEST PATCH RFC 13/14] make-flight: create 5 xtf jobs

2016-08-04 Thread Wei Liu
Create jobs only for x86 and set host flag diverse-xtf-x86. Signed-off-by: Wei Liu --- make-flight | 22 ++ 1 file changed, 22 insertions(+) diff --git a/make-flight b/make-flight index 18e5bc3..613b3d0 100755 --- a/make-flight +++ b/make-flight @@ -422,6 +422,26 @@ do_rtds_

[Xen-devel] [OSSTEST PATCH RFC 14/14] Create XTF branch

2016-08-04 Thread Wei Liu
This branch contains Xen and Linux build jobs and all jobs which contain xtf in their name. Signed-off-by: Wei Liu --- I'm not sure if everything is ok because I can't test all changes. --- ap-fetch-version | 4 ap-print-url | 3 +++ ap-push | 5 + cr-daily-branch | 8

[Xen-devel] [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support

2016-08-04 Thread Wei Liu
By default FEP depends on debug flag. When we are near release the debug flag will be turned off. In order to test a release build, we explicitly enable FEP in build configuration. Since we target Xen versions that already have Kconfig support, only a Kconfig option is created for now. We can eas

[Xen-devel] [OSSTEST PATCH RFC 03/14] DO NOT APPLY ts-leak-check: sleep 5 seconds before collecting stuff

2016-08-04 Thread Wei Liu
The system could be in the process of freeing up resources. Give it some time to finish. Signed-off-by: Wei Liu --- This won't be necessary once we fix all synchronisation issues in xtf-runner. --- ts-leak-check | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ts-leak-check b/ts-leak-check

[Xen-devel] [OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install

2016-08-04 Thread Wei Liu
Extract XTF to the desire location. Signed-off-by: Wei Liu --- ts-xtf-install | 41 + 1 file changed, 41 insertions(+) create mode 100755 ts-xtf-install diff --git a/ts-xtf-install b/ts-xtf-install new file mode 100755 index 000..81e5864 --- /dev/nul

[Xen-devel] [OSSTEST PATCH RFC 00/14] Integrate XTF into OSSTest

2016-08-04 Thread Wei Liu
Hi all This patch series integrates XTF into OSSTest. It still depends on quite a few things (listed below) but I think it has gotten to point that it can be posted for review. It depends on having a canonical location for xtf.git. Currently this series contains a patch to point to my own xtf.git

[Xen-devel] [OSSTEST PATCH RFC 05/14] DO NOT APPLY point xtf to my personal tree

2016-08-04 Thread Wei Liu
--- ap-common | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ap-common b/ap-common index 46523f3..e544605 100644 --- a/ap-common +++ b/ap-common @@ -33,9 +33,9 @@ : ${TREEVCS_LINUX:=git} -: ${TREE_XTF:=git://xenbits.xen.org/xtf.git} -: ${PUSH_TREE_XTF:=$XENBITS:/hom

[Xen-devel] [OSSTEST PATCH RFC 11/14] Introduce ts-xtf-run

2016-08-04 Thread Wei Liu
This is the main script for running XTF. It will first perform selftest, and then run each XTF test case as a substep. It does the following things: 1. Run self tests for individual environment and record the result. 2. Collect tests according to available environments. 3. Run the collected test

[Xen-devel] [OSSTEST PATCH RFC 02/14] TestSupport: factor out target_jobdir_subdir

2016-08-04 Thread Wei Liu
Returns a path inside job-specific directory with leafname subdir. It will be used to return the distribution location of xtf. No functional change. Signed-off-by: Wei Liu --- Osstest/TestSupport.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Osstest/TestSu

[Xen-devel] [OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep

2016-08-04 Thread Wei Liu
Test the availability of FEP during runtime. Signed-off-by: Wei Liu --- ts-xtf-fep | 39 +++ 1 file changed, 39 insertions(+) create mode 100755 ts-xtf-fep diff --git a/ts-xtf-fep b/ts-xtf-fep new file mode 100755 index 000..e3884ac --- /dev/null +++ b/t

[Xen-devel] [OSSTEST PATCH RFC 12/14] sg-run-job: test-xtf recipe

2016-08-04 Thread Wei Liu
Install XTF, run FEP test and then run all available tests. Signed-off-by: Wei Liu --- sg-run-job | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sg-run-job b/sg-run-job index 240b265..960fce4 100755 --- a/sg-run-job +++ b/sg-run-job @@ -411,6 +411,13 @@ proc run-job/test-nested {} {

[Xen-devel] [distros-debian-wheezy test] 66914: all pass

2016-08-04 Thread Platform Team regression test user
flight 66914 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66914/ Perfect :-) All tests in this flight passed as required baseline version: flight 66850 jobs: build-amd64 pass build-armh

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 10:21, wrote: > Looking at xen/common/domctl.c, it appears that during handling of > XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: > > 465 if ( ret == 0 ) > 466 { > 467 domain_pause(d); > 468 ret = arch_set_info

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

2016-08-04 Thread Haozhong Zhang
Hi Konrad, On 08/03/16 17:25, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 18, 2016 at 08:29:12AM +0800, Haozhong Zhang wrote: > > Hi, > > > > Hey! > > Thanks for posting! Sorry for the late review. Below are some of my > comment. > Thank you for the review! [..] > And is there any need for the

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Razvan Cojocaru
On 08/04/2016 11:51 AM, Jan Beulich wrote: On 04.08.16 at 10:21, wrote: >> Looking at xen/common/domctl.c, it appears that during handling of >> XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: >> >> 465 if ( ret == 0 ) >> 466 { >> 467 domain

[Xen-devel] [PATCH] tools: xenalyze: kill spurious sched_switch output in non dump mode.

2016-08-04 Thread Dario Faggioli
In fact, 52cf096df7 ("xenalyze: handle scheduling event"), when dealing with TRC_SCHED_SWITCH, forgot to check whether we actually are in dump mode, causing the printf() in dump_sched_switch() to always produce its output, which is not what we want. Signed-off-by: Dario Faggioli --- Cc: George Du

Re: [Xen-devel] [PATCH] libelf: drop struct elf_dom_parms' virt_offset member

2016-08-04 Thread Andrew Cooper
On 04/08/16 09:32, Jan Beulich wrote: > It's being used solely by elf_xen_addr_calc_check(), and hence can be > a local variable there. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https:/

Re: [Xen-devel] [PATCH] x86/debug: Avoid crashing in early boot because of debugger_trap_entry()

2016-08-04 Thread Andrew Cooper
On 04/08/16 08:05, Jan Beulich wrote: On 03.08.16 at 19:08, wrote: >> debugger_trap_entry() is not safe to use during early boot, as it follows >> current before it is necesserily safe to do so. Futhermore it does this >> unconditionally, despite most callsites turning into no-ops because of

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Andrew Cooper
On 04/08/16 08:13, Jan Beulich wrote: On 03.08.16 at 22:44, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs) >> switch ( mode ) >> { >> case 8: >> +if ( eax == __HYPE

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 10:52, wrote: > On 08/03/16 17:25, Konrad Rzeszutek Wilk wrote: >> Anyhow, wouldn't this 'sizeof(struct page_info)' depend on the ndctl >> tool and what version was used to create this? What if one version >> used 32-bytes for a PAGE, while another used 64-bytes for a PAGE too?

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread George Dunlap
On 04/08/16 08:51, Jan Beulich wrote: On 04.08.16 at 08:36, wrote: >> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >> On 03.08.16 at 20:41, wrote: @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, }

Re: [Xen-devel] [PATCH] x86/debug: Avoid crashing in early boot because of debugger_trap_entry()

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:20, wrote: > On 04/08/16 08:05, Jan Beulich wrote: > On 03.08.16 at 19:08, wrote: >>> debugger_trap_entry() is not safe to use during early boot, as it follows >>> current before it is necesserily safe to do so. Futhermore it does this >>> unconditionally, despite most

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Andrew Cooper
On 04/08/16 08:23, Jan Beulich wrote: On 03.08.16 at 23:00, wrote: >> On 08/03/16 23:44, Andrew Cooper wrote: >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs) >>> switch ( mode ) >>> { >>>

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:24, wrote: > On 04/08/16 08:13, Jan Beulich wrote: > On 03.08.16 at 22:44, wrote: >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs) >>> switch ( mode ) >>> { >>> ca

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

2016-08-04 Thread Haozhong Zhang
On 08/04/16 03:25, Jan Beulich wrote: > >>> On 04.08.16 at 10:52, wrote: > > On 08/03/16 17:25, Konrad Rzeszutek Wilk wrote: > >> Anyhow, wouldn't this 'sizeof(struct page_info)' depend on the ndctl > >> tool and what version was used to create this? What if one version > >> used 32-bytes for a PA

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:25, wrote: > On 04/08/16 08:51, Jan Beulich wrote: > On 04.08.16 at 08:36, wrote: >>> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >>> On 03.08.16 at 20:41, wrote: > @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, > unsigned > lo

[Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread George Dunlap
One of the common ways in which contributors trip up over the CODING_STYLE guides is by not putting a full stop at the end of a comment when there is only a single sentence. Calling these out is a waste of everybody's time: The full stop at the end of a comment with a single sentence (or a single

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Wei Liu
The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread David Vrabel
On 03/08/16 15:36, David Vrabel wrote: > On 02/08/16 15:06, Paulina Szubarczyk wrote: >> >> +/** >> + * Copy memory from or to grant references. The information of each >> operations >> + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value >> indicate >> + * the direction of an o

[Xen-devel] [PATCH v2] libs/gnttab: introduce XENGNTTAB_BUILD_BUG_ON

2016-08-04 Thread Wei Liu
The implementation is taken from libxc. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Paulina Szubarczyk I could have put it in a header file accessible to all libraries under libs but this construct is only relevant to xengnttab library at the moment so it's put under gnttab/private.h. It ca

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread George Dunlap
On 04/08/16 10:36, Jan Beulich wrote: On 04.08.16 at 11:25, wrote: >> On 04/08/16 08:51, Jan Beulich wrote: >> On 04.08.16 at 08:36, wrote: On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: On 03.08.16 at 20:41, wrote: >> @@ -1846,11 +1846,15 @@ int hvm_hap_nested_p

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread George Dunlap
On 04/08/16 10:37, George Dunlap wrote: > One of the common ways in which contributors trip up over the > CODING_STYLE guides is by not putting a full stop at the end of a > comment when there is only a single sentence. Calling these out is a > waste of everybody's time: The full stop at the end o

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread George Dunlap
On 04/08/16 10:46, George Dunlap wrote: > On 04/08/16 10:37, George Dunlap wrote: >> One of the common ways in which contributors trip up over the >> CODING_STYLE guides is by not putting a full stop at the end of a >> comment when there is only a single sentence. Calling these out is a >> waste o

[Xen-devel] [ovmf baseline-only test] 66913: all pass

2016-08-04 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 66913 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66913/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 365a3aab857a2820d36d2ae9b3b62f06230b295a baseline v

Re: [Xen-devel] HVMOP_guest_request_vm_event only works from guest in ring0

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:32, wrote: > On 04/08/16 08:23, Jan Beulich wrote: > On 03.08.16 at 23:00, wrote: >>> On 08/03/16 23:44, Andrew Cooper wrote: --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -5194,8 +5194,14 @@ int hvm_do_hypercall(struct cpu_user_regs *regs)

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread David Vrabel
On 04/08/16 10:37, George Dunlap wrote: > One of the common ways in which contributors trip up over the > CODING_STYLE guides is by not putting a full stop at the end of a > comment when there is only a single sentence. Calling these out is a > waste of everybody's time: The full stop at the end o

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:37, wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -93,7 +93,9 @@ Comments > > Only C style /* ... */ comments are to be used. C++ style // comments > should not be used. Multi-word comments should begin with a capital > -letter and end with a full stop. > +lette

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread George Dunlap
On 04/08/16 11:09, Jan Beulich wrote: On 04.08.16 at 11:37, wrote: >> --- a/CODING_STYLE >> +++ b/CODING_STYLE >> @@ -93,7 +93,9 @@ Comments >> >> Only C style /* ... */ comments are to be used. C++ style // comments >> should not be used. Multi-word comments should begin with a capital

[Xen-devel] [libvirt test] 99936: tolerable FAIL - PUSHED

2016-08-04 Thread osstest service owner
flight 99936 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/99936/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-sup

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-08-04 Thread Wei Liu
On Wed, Aug 03, 2016 at 08:20:18PM +0100, Julien Grall wrote: > Hi Wei, > > On 02/08/16 12:01, Wei Liu wrote: > >On Thu, Jul 28, 2016 at 08:42:05PM +0800, Shannon Zhao wrote: > >>On 2016年07月28日 19:06, Julien Grall wrote: > >>>On 26/07/16 02:17, Boris Ostrovsky wrote: > On 07/25/2016 07:40 PM,

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread Ian Jackson
George Dunlap writes ("[PATCH] CODING_STYLE: Allow single-sentence comments without full stops"): > One of the common ways in which contributors trip up over the > CODING_STYLE guides is by not putting a full stop at the end of a > comment when there is only a single sentence. Calling these out i

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Paulina Szubarczyk
On 08/04/2016 11:38 AM, Wei Liu wrote: The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: In a linux part an ioctl(gntdev, IOCTL

Re: [Xen-devel] [PATCH] CODING_STYLE: Allow single-sentence comments without full stops

2016-08-04 Thread George Dunlap
On 04/08/16 11:04, David Vrabel wrote: > On 04/08/16 10:37, George Dunlap wrote: >> One of the common ways in which contributors trip up over the >> CODING_STYLE guides is by not putting a full stop at the end of a >> comment when there is only a single sentence. Calling these out is a >> waste of

[Xen-devel] [xen-unstable-smoke test] 99940: tolerable all pass - PUSHED

2016-08-04 Thread osstest service owner
flight 99940 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/99940/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Julien Grall
On 04/08/16 09:21, Razvan Cojocaru wrote: Hello, Hello Razvan, Looking at xen/common/domctl.c, it appears that during handling of XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: 465 if ( ret == 0 ) 466 { 467 domain_pause(d); 468

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Julien Grall
Hello Razvan, On 04/08/16 10:00, Razvan Cojocaru wrote: On 08/04/2016 11:51 AM, Jan Beulich wrote: On 04.08.16 at 10:21, wrote: Looking at xen/common/domctl.c, it appears that during handling of XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: 465 if ( ret == 0 )

Re: [Xen-devel] [PATCH v2 00/25] arm/altp2m: Introducing altp2m to ARM.

2016-08-04 Thread George Dunlap
On 03/08/16 19:21, Tamas K Lengyel wrote: >> Although the behavior is very different compare to what x86 does. By default >> the guest will be able to play with altp2m. > > Personally my life would be a lot easier on x86 too if the default XSM > behavior was external-use only for altp2m. I'm a p

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-04 Thread Ian Jackson
Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu depriv)"): > On 03.08.16 at 18:10, wrote: > > George Dunlap writes ("Re: Device model operation hypercall (DMOP, re qemu > > depriv)"): > >> So before qemu devpriv can be usable, *all* the HVMCTL operations would > >> need

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-04 Thread Julien Grall
On 03/08/16 19:20, Stefano Stabellini wrote: On Wed, 3 Aug 2016, Julien Grall wrote: Hi Jan, On 03/08/16 09:53, Jan Beulich wrote: On 02.08.16 at 20:43, wrote: On Tue, 2 Aug 2016, Jan Beulich wrote: On 02.08.16 at 16:59, wrote: On 02/08/16 15:54, Jan Beulich wrote: On 02.08.16 at 16:26

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Razvan Cojocaru
On 08/04/2016 02:08 PM, Julien Grall wrote: > > > On 04/08/16 09:21, Razvan Cojocaru wrote: >> Hello, > > Hello Razvan, > >> Looking at xen/common/domctl.c, it appears that during handling of >> XEN_DOMCTL_setvcpucontext, a domain_pause() happens unconditionally: >> >> 465 if ( ret ==

Re: [Xen-devel] XEN_DOMCTL_setvcpucontext and domain_pause()

2016-08-04 Thread Razvan Cojocaru
On 08/04/2016 02:12 PM, Julien Grall wrote: > Hello Razvan, > > On 04/08/16 10:00, Razvan Cojocaru wrote: >> On 08/04/2016 11:51 AM, Jan Beulich wrote: >> On 04.08.16 at 10:21, wrote: Looking at xen/common/domctl.c, it appears that during handling of XEN_DOMCTL_setvcpucontext, a dom

Re: [Xen-devel] [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support"): > By default FEP depends on debug flag. When we are near release the debug > flag will be turned off. In order to test a release build, we explicitly > enable FEP in build configuration. > > Since we target

Re: [Xen-devel] [PATCH v2 11/25] arm/altp2m: Add HVMOP_altp2m_destroy_p2m.

2016-08-04 Thread Julien Grall
Hello Sergej, On 01/08/16 18:10, Sergej Proskurin wrote: Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v2: Substituted the call to tlb_flush for p2m_flush_table. Added comments. Cosmetic fixes. --- xen/arch/arm/altp2m.c| 50 ++

Re: [Xen-devel] [OSSTEST PATCH RFC 02/14] TestSupport: factor out target_jobdir_subdir

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 02/14] TestSupport: factor out target_jobdir_subdir"): > Returns a path inside job-specific directory with leafname subdir. > > It will be used to return the distribution location of xtf. Acked-by: Ian Jackson ___

Re: [Xen-devel] [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 12:46:30PM +0100, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in > FEP support"): > > By default FEP depends on debug flag. When we are near release the debug > > flag will be turned off. In order to test a release build, we

Re: [Xen-devel] [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 04/14] ap-common: add xtf tree"): > Signed-off-by: Wei Liu ... > +: ${TREE_XTF:=git://xenbits.xen.org/xtf.git} > +: ${PUSH_TREE_XTF:=$XENBITS:/home/xen/git/osstest/xtf.git} > +: ${BASE_TREE_XTF:=git://xenbits.xen.org/osstest/xtf.git} We should probably have the

Re: [Xen-devel] [PATCH v2 12/25] arm/altp2m: Add HVMOP_altp2m_switch_p2m.

2016-08-04 Thread Julien Grall
Hello Sergej, On 01/08/16 18:10, Sergej Proskurin wrote: Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/altp2m.c| 32 xen/arch/arm/hvm.c | 2 +- xen/include/asm-arm/altp2m.h | 4 3 files c

Re: [Xen-devel] [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build"): > Clone, build and package XTF for later use. ... > diff --git a/ts-xtf-build b/ts-xtf-build > new file mode 100755 > index 000..5c4c3ec > --- /dev/null > +++ b/ts-xtf-build ... > +selectbuildhost(\@ARGV); > +# remaining argum

Re: [Xen-devel] [OSSTEST PATCH RFC 07/14] sg-run-job: create xtf build recipe

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 07/14] sg-run-job: create xtf build recipe"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support

2016-08-04 Thread Andrew Cooper
On 04/08/16 12:46, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in > FEP support"): >> By default FEP depends on debug flag. When we are near release the debug >> flag will be turned off. In order to test a release build, we explicitly >> enable FEP

Re: [Xen-devel] [OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install"): > Extract XTF to the desire location. ... ^ > +$xtfdir = get_runvar('xtfdir', $r{xtfbuildjob}); > +die "xtfdir not set?" if !$xtfdir; I don't understand the purpose of this xtfdir variable. Su

Re: [Xen-devel] [PATCH v2 13/25] arm/altp2m: Make p2m_restore_state ready for altp2m.

2016-08-04 Thread Julien Grall
Hello, On 01/08/16 18:10, Sergej Proskurin wrote: This commit adapts the function "p2m_restore_state" in a way that the currently active altp2m table is considered during state restoration. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/p2m.c

Re: [Xen-devel] [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 12:52:26PM +0100, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build"): > > Clone, build and package XTF for later use. > ... > > diff --git a/ts-xtf-build b/ts-xtf-build > > new file mode 100755 > > index 000..5c4c3ec > > --- /dev/nul

[Xen-devel] [PATCH] x86/debug: Make debugger_trap_entry() safe during early boot

2016-08-04 Thread Andrew Cooper
debugger_trap_entry() is reachable during early boot where its unconditional use of current is unsafe. Add a warning to the function to this effect. Perform the vector check first, as this allows the compiler to elide the other content from most of its callsites. Check guest_mode(regs) before us

Re: [Xen-devel] [PATCH v2 14/25] arm/altp2m: Make get_page_from_gva ready for altp2m.

2016-08-04 Thread Julien Grall
Hello Sergej, On 01/08/16 18:10, Sergej Proskurin wrote: The function get_page_from_gva uses ARM's hardware support to translate gva's to machine addresses. This function is used, among others, for memory regulation purposes, e.g, within the context of memory ballooning. To ensure correct behavi

Re: [Xen-devel] [OSSTEST PATCH RFC 09/14] mfi-common: create xtf build job for 4.8 onwards

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 09/14] mfi-common: create xtf build job for 4.8 onwards"): > Signed-off-by: Wei Liu ... > +xenbranch_wants_xtf_tests () { > +case "$xenbranch" in > +xen-3.*-testing) return 1;; > +xen-4.0-testing) return 1;; > +xen-4.1-testing) return 1;; > +

Re: [Xen-devel] [OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 12:54:41PM +0100, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install"): > > Extract XTF to the desire location. > ... ^ > > +$xtfdir = get_runvar('xtfdir', $r{xtfbuildjob}); > > +die "xtfdir not set?" if

Re: [Xen-devel] [OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep

2016-08-04 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep"): > Test the availability of FEP during runtime. ... > +my $ret = target_cmd_root($ho, < +$xtfdir/xtf-runner fep > +END > +die "expecting $expect but fep test returned $ret" if $ret != $expect; target_cmd_root does not re

Re: [Xen-devel] [OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 01:00:13PM +0100, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep"): > > Test the availability of FEP during runtime. > ... > > +my $ret = target_cmd_root($ho, < > +$xtfdir/xtf-runner fep > > +END > > +die "expecting $expect b

Re: [Xen-devel] [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support

2016-08-04 Thread Wei Liu
On Thu, Aug 04, 2016 at 12:53:33PM +0100, Andrew Cooper wrote: > On 04/08/16 12:46, Ian Jackson wrote: > > Wei Liu writes ("[OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in > > FEP support"): > >> By default FEP depends on debug flag. When we are near release the debug > >> flag will be t

Re: [Xen-devel] [PATCH v2 15/25] arm/altp2m: Extend __p2m_lookup.

2016-08-04 Thread Julien Grall
Hello Sergej, On 01/08/16 18:10, Sergej Proskurin wrote: This commit extends the functionality of the function "__p2m_lookup". The function "__p2m_lookup" performs the necessary steps gathering information concerning memory attributes and the p2m table level a specific gfn is mapped to. Thus, we

Re: [Xen-devel] [PATCH v2 17/25] arm/altp2m: Cosmetic fixes - function prototypes.

2016-08-04 Thread Julien Grall
Hello Sergej, On 01/08/16 18:10, Sergej Proskurin wrote: This commit changes the prototype of the following functions: - apply_p2m_changes - apply_one_level - p2m_insert_mapping - p2m_remove_mapping These changes are required as our implementation reuses most of the existing ARM p2m implementat

<    1   2   3   >