[Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-16 Thread Alistair Francis
To avoid this build error with newer build systems: error: #warning redirecting incorrect #include to [-Werror=cpp] Rename sys/poll.h to poll.h Signed-off-by: Alistair Francis --- tools/libxl/libxl_internal.h | 2 +- tools/tests/xen-access/xen-access.c| 2 +-

[Xen-devel] [PATCH 7/7] tools/blktap2: Fix missing header file

2016-12-16 Thread Alistair Francis
To avoid build errors relating to missing delcarations of ssize_t add the appripriote header file to atomic.h. Signed-off-by: Alistair Francis --- tools/blktap2/include/atomicio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/blktap2/include/atomicio.h b/tools/blktap2/include/atomi

[Xen-devel] [PATCH 0/7] General Build Fixes

2016-12-16 Thread Alistair Francis
This patch series is a list of build issues that appeared when buildling Xen 4.8.0 in buildroot. Hopefully some of them can be accepted upstream to help others who are trying to build Xen in the future. Alistair Francis (6): Remove hardcoded strict -Werror checking tools/libxl: Remove hardcode

[Xen-devel] [PATCH 2/7] tools/libxl: Remove hardcoded strict -Werror checking

2016-12-16 Thread Alistair Francis
Signed-off-by: Alistair Francis --- tools/libxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 91e2f97..e8a37ef 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -11,7 +11,7 @@ MINOR = 0 XLUMAJOR = 4.9

[Xen-devel] [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment

2016-12-16 Thread Alistair Francis
From: "Yann E. MORIN" When CFLAGS are passed from the environment, the first-level make invocation will append -D__OBJECT_FILE__ to it, then call a second make invocation, that will have those new CFLAGS in its environment, but will also append -D__OBJECT_FILE__ to those. Then, the compiler fail

[Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-16 Thread Alistair Francis
Signed-off-by: Alistair Francis --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 3ec7367..e3cda81 100644 --- a/Config.mk +++ b/Config.mk @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y SHELL ?= /bin/sh # Tools to run on system hosting t

[Xen-devel] [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h

2016-12-16 Thread Alistair Francis
To avoid this build error with newer build systems: error: #warning redirecting incorrect #include to [-Werror=cpp] Rename sys/signal.h to signal.h Signed-off-by: Alistair Francis --- tools/blktap2/drivers/tapdisk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Xen-devel] [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats

2016-12-16 Thread Alistair Francis
The unsued variable 'struct stat stats' causes build errors in some situations. As it isn't used just remove it. Signed-off-by: Alistair Francis --- tools/blktap2/vhd/lib/libvhd-journal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c b/tools/blktap2/v

[Xen-devel] [xen-4.4-testing test] 103438: tolerable FAIL - PUSHED

2016-12-16 Thread osstest service owner
flight 103438 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103438/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 15 guest-localmigrate/x10 fail like 103058 test-xtf-amd64-amd

[Xen-devel] [xen-4.7-testing test] 103419: tolerable FAIL - PUSHED

2016-12-16 Thread osstest service owner
flight 103419 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103419/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 6 xen-boot fail in 103351 pass in 103419 test-armhf-armhf-xl-credit2 1

[Xen-devel] [linux-4.1 bisection] complete test-amd64-amd64-xl-multivcpu

2016-12-16 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-multivcpu testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional

[Xen-devel] [xen-unstable-smoke test] 103511: tolerable all pass - PUSHED

2016-12-16 Thread osstest service owner
flight 103511 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103511/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-16 Thread Dario Faggioli
On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > the function is only called from csched_tick, which already checks > that current is not the idle vcpu. The patch also adds an ASSERT to > the same effect, in order to m

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-libvirt-xsm

2016-12-16 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt-xsm testid xen-boot Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware gi

Re: [Xen-devel] [PATCH] xen/arm: fix rank/vgic locks inversion bug

2016-12-16 Thread Stefano Stabellini
On Fri, 16 Dec 2016, Stefano Stabellini wrote: > On Fri, 16 Dec 2016, Julien Grall wrote: > > Hi Stefano, > > > > On 16/12/16 00:08, Stefano Stabellini wrote: > > > On Thu, 15 Dec 2016, Julien Grall wrote: > > > > On 15/12/2016 01:04, Stefano Stabellini wrote: > > > > > The locking order is: first

Re: [Xen-devel] [PATCH] xen/arm: fix rank/vgic locks inversion bug

2016-12-16 Thread Stefano Stabellini
On Fri, 16 Dec 2016, Julien Grall wrote: > Hi Stefano, > > On 16/12/16 00:08, Stefano Stabellini wrote: > > On Thu, 15 Dec 2016, Julien Grall wrote: > > > On 15/12/2016 01:04, Stefano Stabellini wrote: > > > > The locking order is: first rank lock, then vgic lock. The order is > > > > respected ev

[Xen-devel] [xen-unstable-smoke test] 103503: regressions - FAIL

2016-12-16 Thread osstest service owner
flight 103503 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103503/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 4 host-ping-check-native fail REGR. vs. 103481 Tests which

[Xen-devel] [PATCH v5 10/13] tools: Call XEN_DOMCTL_acpi_access on PVH VCPU hotplug

2016-12-16 Thread Boris Ostrovsky
Provide libxc interface for accessing ACPI via XEN_DOMCTL_acpi_access. When a VCPU is hot-(un)plugged to/from a PVH guest update VCPU map by writing to ACPI's XEN_ACPI_CPU_MAP register and then set GPE0 status bit in GPE0.status. Signed-off-by: Boris Ostrovsky --- Changes in v5: * xc_acpi_access

[Xen-devel] [PATCH v5 11/13] pvh: Set online VCPU map to avail_vcpus

2016-12-16 Thread Boris Ostrovsky
ACPI builder marks VCPUS set in vcpu_online map as enabled in MADT. With ACPI-based CPU hotplug we only want VCPUs that are started by the guest to be marked as such. Remaining VCPUs will be set to "enable" by AML code during hotplug. Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek W

[Xen-devel] [PATCH v5 08/13] pvh: Send an SCI on VCPU hotplug event

2016-12-16 Thread Boris Ostrovsky
When GPE0 status register gets a bit set (currently XEN_GPE0_CPUHP_BIT only) send an SCI to the guest. Also update send_guest_global_virq() to handle cases when VCPU0 is offlined. Signed-off-by: Boris Ostrovsky --- Changes in v5: * Fixed SCI-triggering logic xen/arch/x86/hvm/acpi.c| 9

[Xen-devel] [PATCH v5 01/13] x86/pmtimer: Move ACPI registers from PMTState to hvm_domain

2016-12-16 Thread Boris Ostrovsky
These registers (pm1a specifically) are not all specific to pm timer and are accessed by non-pmtimer code (for example, sleep/power button emulation). The public name for save state structure is kept as 'pmtimer' to avoid code churn with the expected changes in migration code. hvm_hw_acpi name is

[Xen-devel] [PATCH v5 12/13] pvh/acpi: Save ACPI registers for PVH guests

2016-12-16 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/arch/x86/hvm/pmtimer.c | 8 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index b70c299..37acf11 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -257,7 +257,11 @@ st

[Xen-devel] [PATCH v5 03/13] domctl: Add XEN_DOMCTL_acpi_access

2016-12-16 Thread Boris Ostrovsky
This domctl will allow toolstack to read and write some ACPI registers. It will be available to both x86 and ARM but will be implemented first only for x86 Signed-off-by: Boris Ostrovsky --- CC: Daniel De Graaf --- Changes in v5: * Added forgotten in v4 xsm hooks * Replaces gas_t with a xen_acpi

[Xen-devel] [PATCH v5 09/13] libxl: Update xenstore on VCPU hotplug for all guest types

2016-12-16 Thread Boris Ostrovsky
Currently HVM guests that use upstream qemu do not update xenstore's availability entry for VCPUs. While it is not strictly necessary for hotplug to work, xenstore end up reflecting actual status of VCPUs. Signed-off-by: Boris Ostrovsky --- New in v5 tools/libxl/libxl.c | 6 -- 1 file chang

[Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-16 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v5: * Code movement due to changes in patch 4 xen/arch/x86/hvm/acpi.c | 64 ++--- 1 file changed, 55 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/hvm/acpi.c b/xen/arch/x86/hvm/acpi.c index b2299

[Xen-devel] [PATCH v5 02/13] acpi/x86: Define ACPI IO registers for PVH guests

2016-12-16 Thread Boris Ostrovsky
Define VCPU available map address (used by AML's PRSC method) and GPE0 CPU hotplug event number. Use these definitions in mk_dsdt instead hardcoded values. These definitions will later be used by both the hypervisor and the toolstack (initially for PVH guests only), thus they are placed in public

[Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-16 Thread Boris Ostrovsky
PVH guests will have ACPI accesses emulated by the hypervisor as opposed to QEMU (as is the case for HVM guests). This patch installs handler for accesses to PM1A, GPE0 (which is added to struct hvm_hw_acpi) and VCPU map. Logic for the handler will be provided by a later patch. Whether or not the

[Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-16 Thread Boris Ostrovsky
Subsequent domctl access to ACPI registers and VCPU map will use the same code. We create acpi_[cpumap_]access_common() routines in anticipation of these changes. Signed-off-by: Boris Ostrovsky --- Changes in v5: * Code movement due to changes in patch 4 * Added fallthough switch statemnt comment

[Xen-devel] [PATCH v5 07/13] events/x86: Define SCI virtual interrupt

2016-12-16 Thread Boris Ostrovsky
PVH guests do not have IOAPIC which typically generates an SCI. For those guests SCI will be provided as a virtual interrupt. Copy VIRQ_MCA definition from of xen-mca.h to xen.h to keep all x86-specific VIRQ_ARCH_* in one place. (However, because we don't want to require inclusion of xen.h in xen-

[Xen-devel] [PATCH v5 13/13] docs: Describe PVHv2's VCPU hotplug procedure

2016-12-16 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk --- CC: George Dunlap CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan --- docs/misc/hvmlite.markdown | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/misc/hvmlite.markdown b/docs/misc/hvm

[Xen-devel] [PATCH v5 00/13] PVH VCPU hotplug support

2016-12-16 Thread Boris Ostrovsky
This series adds support for ACPI-based VCPU hotplug for unprivileged PVH guests. Main changes in v5: * Split ACPI access routines into one accessing VCPU map and the other accessing ACPI registers * domctl interface changes * Initialize VCPU map during domain creation. * Set xenstore's CPU "ava

[Xen-devel] [xen-4.6-testing test] 103407: tolerable FAIL - PUSHED

2016-12-16 Thread osstest service owner
flight 103407 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103407/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-rumprun-i386 16 rumprun-demo-xenstorels/xenstorels.repeat fail like 103159 test-armhf-

Re: [Xen-devel] [XTF PATCH 00/16] Add test cases for nested vmxon

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > This patch series starts to add a test selection "test-hvm64-vvmx" for > nested VMX. This first series focuses mostly on nested vmxon. > > * Patch 01 - 03 test the basic environment (cpuid and MSR). > > * Patch 04 - 05 add functions to execute VMX instruct

[Xen-devel] [qemu-mainline baseline-only test] 68230: regressions - FAIL

2016-12-16 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68230 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68230/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 10 guest-start

Re: [Xen-devel] [XTF PATCH 14/16] vvmx: test vmxon in VMX root w/ CPL = 3 and w/o current VMCS

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > Fault #GP(0) is expected in this test. > > Signed-off-by: Haozhong Zhang > --- > tests/vvmx/vmxon.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c > index 0664a48..ec7ee7e 1

[Xen-devel] [xen-unstable-smoke test] 103481: tolerable all pass - PUSHED

2016-12-16 Thread osstest service owner
flight 103481 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103481/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [XTF PATCH 08/16] vvmx: test vmxon with invalidly wide VMXON region address

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > +static uint8_t get_cpu_paddr_bits(void) > +{ > +uint8_t paddr_bits = 36; > +uint32_t eax; > + > +eax = cpuid_eax(0x8000); > +if ( (eax >> 16) == 0x8000 && eax >= 0x8008 ) > +{ > +eax = cpuid_eax(0x8008); > +

Re: [Xen-devel] [XTF PATCH 07/16] vvmx: test vmxon in CPL=3 and out of VMX operation

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c > index 31f074c..ca33b3c 100644 > --- a/tests/vvmx/vmxon.c > +++ b/tests/vvmx/vmxon.c > @@ -28,11 +28,42 @@ static bool test_vmxon_novmxe(void) >VMXERR_FAULT, EXINFO_SYM(U

[Xen-devel] [ovmf test] 103411: regressions - FAIL

2016-12-16 Thread osstest service owner
flight 103411 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/103411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 103347 version target

[Xen-devel] [xen-4.5-testing test] 103398: tolerable FAIL - PUSHED

2016-12-16 Thread osstest service owner
flight 103398 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103398/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 6 xen-boot fail in 103316 pass in 103398 test-amd64-amd64-xl-qemuu-win

Re: [Xen-devel] [XTF PATCH 06/16] vvmx: test vmxon with CR4.VMXE cleared

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > diff --git a/tests/vvmx/util.c b/tests/vvmx/util.c > index 74b4d01..f30fc26 100644 > --- a/tests/vvmx/util.c > +++ b/tests/vvmx/util.c > @@ -1,7 +1,31 @@ > #include > +#include > #include > #include "util.h" > > +#define INVALID_VMCS_REVID (~(uint

Re: [Xen-devel] tool stack tool chain dependencies (again)

2016-12-16 Thread Doug Goldstein
On 12/16/16 6:52 AM, Jan Beulich wrote: > Hello, > > especially some of the changes late in the 4.8 cycle have caused me > to spend a good part of the morning trying to figure out how to build > the tool stack on an older system. Among other things I've run into > - ipxe all of the sudden not work

Re: [Xen-devel] [XTF PATCH 05/16] vvmx: add a general error handler for VMX instructions

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > handle_vmxinsn_err() is added to check and output the mismatch between > errors in the execution of a VMX instruction and the expected errors. > > Signed-off-by: Haozhong Zhang > --- > tests/vvmx/util.c | 104 > ++

Re: [Xen-devel] [XTF PATCH 04/16] vvmx: add C wrappers of vmxon/vmread/vmptrld

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: Review of the technical side of the patch, leaving the licensing to the other thread. Reordering for better logical clarity for my suggestion. > diff --git a/tests/vvmx/util.h b/tests/vvmx/util.h > new file mode 100644 > index 000..57d3398 > --- /dev/

[Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-16 Thread Praveen Kumar
The patch gets rid of a redundant check in csched_vcpu_acct. In fact, the function is only called from csched_tick, which already checks that current is not the idle vcpu. The patch also adds an ASSERT to the same effect, in order to make assumption ( i.e., no calling this on idle vcpus) even more

[Xen-devel] [licensing] was: [XTF PATCH 04/16] vvmx: add C wrappers of vmxon/vmread/vmptrld

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > diff --git a/include/arch/x86/hvm/vmx/vmcs.h b/include/arch/x86/hvm/vmx/vmcs.h > new file mode 100644 > index 000..e1a6ef8 > --- /dev/null > +++ b/include/arch/x86/hvm/vmx/vmcs.h > @@ -0,0 +1,179 @@ > +#ifndef XTF_X86_HVM_VMX_VMCS_H > +#define XTF_X86_

Re: [Xen-devel] [XEN VMID RESEND v5 1/2] xen/arm: Move p2m_vmid_allocator_init() inside setup_virt_paging()

2016-12-16 Thread Stefano Stabellini
Both patches applied. FYI most committers/reviewers prefer to have a [PATCH 0/NUM] email before the actual patches, so that patches are all properly threaded as replies (when using git-send-email --in-reply-to=). For example: https://lkml.org/lkml/2016/12/15/654 I don't particularly care about t

Re: [Xen-devel] [PATCH] libxl: fix coding style issues in init_acpi_config

2016-12-16 Thread Ian Jackson
Wei Liu writes ("[PATCH] libxl: fix coding style issues in init_acpi_config"): > 1. Use "r" to store return values from xc calls. > 2. Don't initialise "rc" at the beginning of the function. > > Signed-off-by: Wei Liu Right, that's what I meant., Acked-by: Ian Jackson Thanks, Ian. _

[Xen-devel] [PATCH] xen: sched: removal of redundant check in Credit

2016-12-16 Thread Praveen Kumar
The patch gets rid of a redundant check in csched_vcpu_acct. In fact, the function is only called from csched_tick, which already checks that current is not the idle vcpu. The patch also adds an ASSERT to the same effect, in order to make assumption ( i.e., no calling this on idle vcpus) even more

[Xen-devel] [linux-3.18 test] 103386: regressions - FAIL

2016-12-16 Thread osstest service owner
flight 103386 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103386/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 9 xen-boot/src_hostfail REGR. vs. 101675 test-amd64-i386-libv

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 16, 2016 at 09:17:01AM -0700, Jan Beulich wrote: > >>> On 16.12.16 at 15:45, wrote: > > On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: > >> On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: > >> > >>> On 30.11.16 at 17:49, wrote: > >> > > @@ -1655,6 +1653,

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 16, 2016 at 09:18:13AM -0700, Jan Beulich wrote: > >>> On 16.12.16 at 15:28, wrote: > > On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: > >> >>> On 30.11.16 at 17:49, wrote: > >> > --- a/docs/misc/xen-command-line.markdown > >> > +++ b/docs/misc/xen-command-line.markdown

[Xen-devel] [PATCH] libxl: fix coding style issues in init_acpi_config

2016-12-16 Thread Wei Liu
1. Use "r" to store return values from xc calls. 2. Don't initialise "rc" at the beginning of the function. Signed-off-by: Wei Liu --- tools/libxl/libxl_x86_acpi.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/tools/libxl/libxl_x86_acpi.c b

Re: [Xen-devel] [PATCH v4 10/14] xen/x86: populate PVHv2 Dom0 physical memory map

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 09, 2016 at 09:48:32AM -0700, Jan Beulich wrote: > >>> On 30.11.16 at 17:49, wrote: > > @@ -302,7 +307,8 @@ static unsigned long __init compute_dom0_nr_pages( > > avail -= max_pdx >> s; > > } > > > > -need_paging = opt_dom0_shadow || (is_pvh_domain(d) && > > !i

[Xen-devel] [xen-unstable-smoke test] 103470: regressions - FAIL

2016-12-16 Thread osstest service owner
flight 103470 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-buildfail REGR. vs. 103284 Tests which

[Xen-devel] [libvirt test] 103403: tolerable all pass - PUSHED

2016-12-16 Thread osstest service owner
flight 103403 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/103403/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 103329 test-armhf-armhf-libvirt-xsm 13

Re: [Xen-devel] [XTF PATCH 03/16] vvmx: test whether MSR_IA32_VMX_BASIC is set correctly

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > It tests whether bit 31 and bit 48 are 0, and VMCS size is in the > range (0, 4096]. > > Signed-off-by: Haozhong Zhang > --- > include/arch/x86/msr-index.h | 4 > tests/vvmx/msr.c | 47 > >

Re: [Xen-devel] [PATCH v1 1/1] xen/arm: Map mmio-sram nodes as cached memory

2016-12-16 Thread Edgar E. Iglesias
On Fri, Dec 16, 2016 at 04:12:00PM +, Julien Grall wrote: > Hi Edgar, > > On 15/12/16 11:26, Edgar E. Iglesias wrote: > >From: "Edgar E. Iglesias" > > > >Relax the mapping of mmio-sram nodes that do not set the > >no-memory-wc property to cached normal memory. > > > >Rationale: > >Allthough o

Re: [Xen-devel] Xen ARM - Exposing a PL011 to the guest

2016-12-16 Thread Julien Grall
(CC rest maintainers for event channel questions) On 16/12/16 10:06, Bhupinder Thakur wrote: Hi, Hi Bhupinder, The idea is for Xen to act as an intermediary as shown below: ring buffers rx/tx fifo dom0 <---> Xen HYP (running pl011 em

Re: [Xen-devel] megaraid_sas regression in linux-3.18 [and 1 more messages]

2016-12-16 Thread alexander . levin
On Wed, Dec 14, 2016 at 01:30:46PM +, Ian Jackson wrote: > alexander.le...@verizon.com writes ("RE: megaraid_sas regression in > linux-3.18 [and 1 more messages]"): > > Added 5e5ec1759dd6 to the 3.18 queue, thanks! > > How often does this queue get flushed ? Every couple of weeks, the LTS re

Re: [Xen-devel] [PATCH] x86/microcode: Use native_cpuid() in load_ucode_amd_bsp()

2016-12-16 Thread Borislav Petkov
On Fri, Dec 16, 2016 at 11:39:52AM -0500, Boris Ostrovsky wrote: > When CONFIG_PARAVIRT is selected, cpuid() becomes a call. Since > for 32-bit kernels load_ucode_amd_bsp() is executed before paging > is enabled the call cannot be completed (as kernel virtual addresses > are not reachable yet). >

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: init_acpi_config should return rc in exit path"): > > And please don't just apply this one patch because it is buggy. > > You would also need "libxl: set rc to 0 in init_acpi_config in success > path". Noted, thanks. Ian. ___

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Wei Liu
On Wed, Dec 14, 2016 at 11:44:36AM +, Wei Liu wrote: > ... otherwise it returns 0 even if the function fails. > > Signed-off-by: Wei Liu > --- > Cc: Ian Jackson > > This should be backported to 4.8. And please don't just apply this one patch because it is buggy. You would also need "libxl

[Xen-devel] [PATCH] x86/microcode: Use native_cpuid() in load_ucode_amd_bsp()

2016-12-16 Thread Boris Ostrovsky
When CONFIG_PARAVIRT is selected, cpuid() becomes a call. Since for 32-bit kernels load_ucode_amd_bsp() is executed before paging is enabled the call cannot be completed (as kernel virtual addresses are not reachable yet). Use native_cpuid() instead which is an asm wrapper for CPUID instruction.

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 15:28, wrote: > On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: >> >>> On 30.11.16 at 17:49, wrote: >> > --- a/docs/misc/xen-command-line.markdown >> > +++ b/docs/misc/xen-command-line.markdown >> > @@ -656,6 +656,23 @@ affinities to prefer but be not limited to th

Re: [Xen-devel] [XTF PATCH 02/16] vvmx: test whether MSR_IA32_FEATURE_CONTROL is set correctly

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > diff --git a/tests/vvmx/msr.c b/tests/vvmx/msr.c > new file mode 100644 > index 000..100491d > --- /dev/null > +++ b/tests/vvmx/msr.c > @@ -0,0 +1,67 @@ > +#include > + > +#include > + > +/* > + * NB. Guest MSR_IA32_FEATURE_CONTROL is set by Xen hype

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 15:45, wrote: > On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: >> On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: >> > >>> On 30.11.16 at 17:49, wrote: >> > > @@ -1655,6 +1653,28 @@ out: >> > > return rc; >> > > } >> > > >> > > +static int

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 16:28, wrote: > On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: >> On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: >> > >>> On 30.11.16 at 17:49, wrote: >> > > --- a/xen/arch/x86/setup.c >> > > +++ b/xen/arch/x86/setup.c >> > > @@ -187,6 +187,35 @@

Re: [Xen-devel] [PATCH v1 1/1] xen/arm: Map mmio-sram nodes as cached memory

2016-12-16 Thread Julien Grall
Hi Edgar, On 15/12/16 11:26, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Relax the mapping of mmio-sram nodes that do not set the no-memory-wc property to cached normal memory. Rationale: Allthough on chip memories are relatively fast compared to s/Allthough/Although/ off-chip memo

Re: [Xen-devel] [PATCH v11 00/13] x86: multiboot2 protocol support

2016-12-16 Thread Doug Goldstein
On 12/5/16 4:25 PM, Daniel Kiper wrote: > Hi, > > I am sending eleventh version of multiboot2 protocol support for > legacy BIOS and EFI platforms. This patch series release contains > fixes for all known issues. > > The final goal is xen.efi binary file which could be loaded by EFI > loader, mul

Re: [Xen-devel] [PATCH] libxl: set rc to 0 in init_acpi_config in success path

2016-12-16 Thread Boris Ostrovsky
On 12/16/2016 10:51 AM, Wei Liu wrote: > xc_doamin_getinfo returns >=0 in success path, and if there is no vnode > configured, that rc will be returned to caller, which indicates error. > > Fix that by setting rc to 0 in success path. > > Reported-by: Boris Ostrovsky > Signed-off-by: Wei Liu > --

[Xen-devel] [PATCH] libxl: set rc to 0 in init_acpi_config in success path

2016-12-16 Thread Wei Liu
xc_doamin_getinfo returns >=0 in success path, and if there is no vnode configured, that rc will be returned to caller, which indicates error. Fix that by setting rc to 0 in success path. Reported-by: Boris Ostrovsky Signed-off-by: Wei Liu --- Cc: Boris Ostrovsky Cc: Ian Jackson Please squas

Re: [Xen-devel] [HACKERS] [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation [and 2 more messages] [and 1 more messages]

2016-12-16 Thread Kevin Grittner
I guess the preceding posts leave us with these guarantees about read-only transactions which we might want to make explicit in the documentation: (1) A serialization failure cannot be initially thrown on a COMMIT attempt for a read-only transaction; however, if a subtransaction catches a seriali

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path"): > I don't think so, because there could be functions that only return >0 > values to indicate error. The problem here is the violation of the CODING_STYLE which forbids the use of `rc' to contain any

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: > On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: > > >>> On 30.11.16 at 17:49, wrote: > > > --- a/xen/arch/x86/setup.c > > > +++ b/xen/arch/x86/setup.c > > > @@ -187,6 +187,35 @@ static void __init parse_acpi_param(char

Re: [Xen-devel] Can't boot as Xen dom0 due to commit fe055896

2016-12-16 Thread Borislav Petkov
On Fri, Dec 16, 2016 at 09:40:59AM -0500, Boris Ostrovsky wrote: > It works Thanks. Added your Tested-by. > but I think both of the bugs we talked about yesterday still > need to be fixed, they are not related to Xen. For the one issue with the eq_id, I have the below cleanup for all the args pa

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Wei Liu
On Fri, Dec 16, 2016 at 10:21:07AM -0500, Boris Ostrovsky wrote: > On 12/16/2016 10:16 AM, Wei Liu wrote: > > > > I see, I think we also need to set rc=0 in the success path. > > Or 'return rc < 0 ? rc : 0;' > I don't think so, because there could be functions that only return >0 values to indic

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Boris Ostrovsky
On 12/16/2016 10:16 AM, Wei Liu wrote: > > I see, I think we also need to set rc=0 in the success path. Or 'return rc < 0 ? rc : 0;' -boris ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Wei Liu
On Fri, Dec 16, 2016 at 10:10:43AM -0500, Boris Ostrovsky wrote: > On 12/14/2016 06:49 AM, Andrew Cooper wrote: > > On 14/12/16 11:44, Wei Liu wrote: > >> ... otherwise it returns 0 even if the function fails. > > > > Coverity-ID: 1397121 > > > >> Signed-off-by: Wei Liu > > > > Reviewed-by: Andrew

Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

2016-12-16 Thread Boris Ostrovsky
On 12/14/2016 06:49 AM, Andrew Cooper wrote: > On 14/12/16 11:44, Wei Liu wrote: >> ... otherwise it returns 0 even if the function fails. > > Coverity-ID: 1397121 > >> Signed-off-by: Wei Liu > > Reviewed-by: Andrew Cooper > >> --- >> Cc: Ian Jackson >> >> This should be backported to 4.8. >> --

Re: [Xen-devel] [HACKERS] [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation [and 2 more messages] [and 1 more messages]

2016-12-16 Thread Robert Haas
On Fri, Dec 16, 2016 at 9:39 AM, Kevin Grittner wrote: > Good catch! Thanks! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] Xen: ARM: Support for mapping ECAM PCIe Config Space Specified In Static ACPI Table

2016-12-16 Thread Julien Grall
On 14/12/16 08:00, Jiandi An wrote: Hi Guys, Hello Jiandi, Xen currently doesn't map ECAM space specified in static ACPI table. > Seeking opinion on how this should be handled properly. > Each root complex ECAM region takes up 64K 4K pages (256MB). > For some platforms there might be multi

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 16, 2016 at 02:28:54PM +, Roger Pau Monne wrote: > On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: > > >>> On 30.11.16 at 17:49, wrote: > > > @@ -1655,6 +1653,28 @@ out: > > > return rc; > > > } > > > > > > +static int __init construct_dom0_hvm(struct domain *d

Re: [Xen-devel] [XTF PATCH 01/16] vvmx: test whether VMX feature is present in CPUID

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > diff --git a/tests/vvmx/cpuid.c b/tests/vvmx/cpuid.c > new file mode 100644 > index 000..9a4cdae > --- /dev/null > +++ b/tests/vvmx/cpuid.c > @@ -0,0 +1,24 @@ > +#include > + > +bool test_cpuid_vmx_feat(void) > +{ > +uint32_t ecx = cpuid_ecx(1); >

Re: [Xen-devel] [HACKERS] [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation [and 2 more messages] [and 1 more messages]

2016-12-16 Thread Kevin Grittner
On Fri, Dec 16, 2016 at 8:24 AM, Robert Haas wrote: > On Thu, Dec 15, 2016 at 9:01 AM, Kevin Grittner wrote: >> I also realized some other properties of read-only transactions >> that might interest you (and that I should probably document). >> Since the only way for a read-only transaction to be

Re: [Xen-devel] Can't boot as Xen dom0 due to commit fe055896

2016-12-16 Thread Boris Ostrovsky
On 12/16/2016 08:07 AM, Borislav Petkov wrote: > On Fri, Dec 16, 2016 at 01:19:03PM +0100, Borislav Petkov wrote: >>> Okay. Results: >>> >>> Xen HVM domain is working. >>> Xen dom0 is working. >>> Bare metal is working, microcode has been loaded. >>> >>> So you can add my: >>> >>> Tested-by: Juerge

[Xen-devel] [qemu-mainline test] 103397: tolerable FAIL - PUSHED

2016-12-16 Thread osstest service owner
flight 103397 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/103397/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 103164 test-armhf-armhf-libvirt-x

Re: [Xen-devel] [PATCH v4 09/14] xen/x86: split Dom0 build into PV and PVHv2

2016-12-16 Thread Roger Pau Monne
On Fri, Dec 09, 2016 at 09:07:16AM -0700, Jan Beulich wrote: > >>> On 30.11.16 at 17:49, wrote: > > --- a/docs/misc/xen-command-line.markdown > > +++ b/docs/misc/xen-command-line.markdown > > @@ -656,6 +656,23 @@ affinities to prefer but be not limited to the > > specified node(s). > > > > Pin

Re: [Xen-devel] [HACKERS] [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation [and 2 more messages] [and 1 more messages]

2016-12-16 Thread Robert Haas
On Thu, Dec 15, 2016 at 9:01 AM, Kevin Grittner wrote: > I also realized some other properties of read-only transactions > that might interest you (and that I should probably document). > Since the only way for a read-only transaction to be the on > experiencing a serialization failure is if Tout

[Xen-devel] [xen-unstable-smoke test] 103463: regressions - FAIL

2016-12-16 Thread osstest service owner
flight 103463 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103463/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-buildfail REGR. vs. 103284 Tests which

[Xen-devel] [distros-debian-jessie test] 68229: tolerable all pass

2016-12-16 Thread Platform Team regression test user
flight 68229 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68229/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-armhf-jessie-netboot-pygrub 11 migrate-support-check fail never pass test-armhf-armhf-

Re: [Xen-devel] [XTF PATCH 00/16] Add test cases for nested vmxon

2016-12-16 Thread Andrew Cooper
On 16/12/16 13:43, Haozhong Zhang wrote: > This patch series starts to add a test selection "test-hvm64-vvmx" for > nested VMX. This first series focuses mostly on nested vmxon. > > * Patch 01 - 03 test the basic environment (cpuid and MSR). > > * Patch 04 - 05 add functions to execute VMX instruct

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 14:57, wrote: > On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: >> Despite all attempts so far (ending in commit fecf584294 ["Config.mk: >> fix comment for debug option"] adjusting the respective comment), >> Config.mk's debug= setting still affects the hypervisor b

Re: [Xen-devel] [PATCH v4 07/14] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

2016-12-16 Thread Roger Pau Monne
On Thu, Dec 08, 2016 at 09:24:08AM -0700, Jan Beulich wrote: > >>> On 30.11.16 at 17:49, wrote: > > --- a/xen/include/asm-x86/p2m.h > > +++ b/xen/include/asm-x86/p2m.h > > @@ -834,6 +834,7 @@ static inline unsigned int > > p2m_get_iommu_flags(p2m_type_t p2mt) > > case p2m_grant_map_rw: > >

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Wei Liu
On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: > Despite all attempts so far (ending in commit fecf584294 ["Config.mk: > fix comment for debug option"] adjusting the respective comment), > Config.mk's debug= setting still affects the hypervisor build: CFLAGS > gets -g added there. >

Re: [Xen-devel] [PATCH v11 07/13] x86: add multiboot2 protocol support for EFI platforms

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 14:38, wrote: > On 05/12/16 22:25, Daniel Kiper wrote: >> diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub.c >> index 4158124..6ea6aa1 100644 >> --- a/xen/arch/x86/efi/stub.c >> +++ b/xen/arch/x86/efi/stub.c >> @@ -3,6 +3,44 @@ >> #include >> #include >> #includ

[Xen-devel] [XTF PATCH 11/16] vvmx: test vmxon with bit 31 of VMCS revision ID set

2016-12-16 Thread Haozhong Zhang
VMfailInvalid is expected in this test. Signed-off-by: Haozhong Zhang --- tests/vvmx/vmxon.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c index 75b6dcb..268baa8 100644 --- a/tests/vvmx/vmxon.c +++ b/tests/vvmx/vmxon.c @@ -118,6

[Xen-devel] [XTF PATCH 14/16] vvmx: test vmxon in VMX root w/ CPL = 3 and w/o current VMCS

2016-12-16 Thread Haozhong Zhang
Fault #GP(0) is expected in this test. Signed-off-by: Haozhong Zhang --- tests/vvmx/vmxon.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c index 0664a48..ec7ee7e 100644 --- a/tests/vvmx/vmxon.c +++ b/tests/vvmx/vmxon.c @

[Xen-devel] [XTF PATCH 13/16] vvmx: test vmxon in VMX root w/ CPL = 0 and w/o current VMCS

2016-12-16 Thread Haozhong Zhang
VMfailInvalid is expected in this test. Signed-off-by: Haozhong Zhang --- tests/vvmx/vmxon.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vvmx/vmxon.c b/tests/vvmx/vmxon.c index a41f101..0664a48 100644 --- a/tests/vvmx/vmxon.c +++ b/tests/vvmx/vmxon.c @@ -149,6

[Xen-devel] [XTF PATCH 05/16] vvmx: add a general error handler for VMX instructions

2016-12-16 Thread Haozhong Zhang
handle_vmxinsn_err() is added to check and output the mismatch between errors in the execution of a VMX instruction and the expected errors. Signed-off-by: Haozhong Zhang --- tests/vvmx/util.c | 104 ++ tests/vvmx/util.h | 17 + 2 file

  1   2   >