Re: [Xen-devel] [PATCH v2 02/13] iommu: Add extra order argument to the IOMMU APIs and platform callbacks

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 18:20, wrote: > Hi, all. > > Any comments? Excuse me, but comments on what? The quoted text below just has two "will add" comments of yours. I don't think you expect any further comments on those. As to the series as a whole - I still have it on my to-be-reviewed list, but the

Re: [Xen-devel] [PATCH v4 03/11] public: xen.h: add definitions for UUID handling

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 22:27, wrote: > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -930,6 +930,15 @@ __DEFINE_XEN_GUEST_HANDLE(uint16, uint16_t); > __DEFINE_XEN_GUEST_HANDLE(uint32, uint32_t); > __DEFINE_XEN_GUEST_HANDLE(uint64, uint64_t); > > +typedef uint8_t xen_uuid_t[1

Re: [Xen-devel] [PATCH v4 11/11] arm: enable XENFEAT_ARM_SMCCC_supported feature

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 22:27, wrote: > As Xen now supports SMCCC, we can enable this feature to tell > guests that it is safe to call generic SMCs and HVCs. I think this and patch 10 should be folded. > Signed-off-by: Volodymyr Babchuk > --- > xen/common/kernel.c | 3 +++ > 1 file changed, 3 inser

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

2017-08-22 Thread Roger Pau Monné
On Tue, Aug 22, 2017 at 05:52:04AM +0800, Chao Gao wrote: > When SR-IOV is enabled, 'Virtual Functions' of a 'Physical Function' are under > the scope of the same VT-d unit as the 'Physical Function'. A 'Physical > Function' can be a 'Traditional Function' or an ARI 'Extended Function'. > And furth

Re: [Xen-devel] [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

2017-08-22 Thread Roger Pau Monné
On Fri, Aug 18, 2017 at 06:24:06PM +0100, Roger Pau Monné wrote: > On Fri, Aug 18, 2017 at 10:29:15AM -0400, annie li wrote: > > > > On 8/18/2017 5:14 AM, Roger Pau Monné wrote: > > > On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > > > > If there is inflight I/O in any non-last queue,

[Xen-devel] [ovmf test] 112782: all pass - PUSHED

2017-08-22 Thread osstest service owner
flight 112782 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/112782/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bb3d1a6198cc5a8f2672927295c9f8d5ede9187c baseline version: ovmf fa74dd2217aebe6930890

[Xen-devel] [xen-4.6-testing bisection] complete test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm

2017-08-22 Thread osstest service owner
branch xen-4.6-testing xenbranch xen-4.6-testing job test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-tradi

Re: [Xen-devel] Regression PCI passthrough from 4.5.5 to 4.6.0-rc1

2017-08-22 Thread Roger Pau Monné
On Mon, Aug 21, 2017 at 04:18:56PM +0100, Roger Pau Monné wrote: > On Mon, Aug 21, 2017 at 09:14:45AM -0600, Jan Beulich wrote: > > >>> On 21.08.17 at 16:49, wrote: > > > Another option is to (ab)use the msi.gflags field to add another flag > > > in order to signal Xen whether the interrupt should

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月18日 18:13, Wei Liu wrote: >>> ASSERT(info->viommu[viommu_id]->ops); >>> > > >>> > > For extra safety. >> > >> > Or check ops in the previous if? >> > > That depends on if ops can be null or not. If ops isn't be set, it will be null. Because struct viommu is allocated via xzalloc().

Re: [Xen-devel] [PATCH v8 1/2] x86emul: New return code for unimplemented instruction

2017-08-22 Thread Jan Beulich
>>> On 08.08.17 at 20:06, wrote: > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c What about the use in a switch() statement in hvmemul_do_io() in this file? And the use in hvmemul_do_io_buffer()? > @@ -2044,6 +2044,8 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned

Re: [Xen-devel] [PATCH v8 2/2] x86/monitor: Notify monitor if an emulation fails.

2017-08-22 Thread Jan Beulich
>>> On 08.08.17 at 20:06, wrote: > If case of a vm_event with the emulate_flags set, if the instruction > is not implemented by the emulator, the monitor should be notified instead > of directly injecting a hw exception. > This behavior can be used to re-execute an instruction not supported by > t

Re: [Xen-devel] [PATCH V2 4/25] Xen/doc: Add Xen virtual IOMMU doc

2017-08-22 Thread Lan Tianyu
On 2017年08月18日 18:15, Wei Liu wrote: > On Fri, Aug 18, 2017 at 03:17:37PM +0800, Lan Tianyu wrote: >> On 2017年08月17日 19:19, Wei Liu wrote: >>> On Wed, Aug 09, 2017 at 04:34:05PM -0400, Lan Tianyu wrote: +Now just suppport single vIOMMU for one VM and introduced domctls are compatible >>>

Re: [Xen-devel] [PATCH v4] hvm: vmx/svm_cpu_up_prepare should be called only once

2017-08-22 Thread Jan Beulich
>>> On 22.08.17 at 04:08, wrote: > These routines are first called via CPU_UP_PREPARE notifier by > the BSP and then by the booting ASP from vmx_cpu_up()/_svm_cpu_up(). > > Avoid the unnecessary second call. Because BSP doesn't go through > CPU_UP_PREPARE it is a special case. We pass 'bsp' flag

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-22 Thread Jan Beulich
>>> On 18.08.17 at 23:55, wrote: > On 08/18/2017 05:02 PM, christopher.w.cl...@gmail.com wrote: >> From: Christopher Clark >> >> Isolation of devices passed through to domains usually requires an >> active IOMMU. The existing method of requiring an IOMMU is via a Xen >> boot parameter ("iommu=fo

Re: [Xen-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-22 Thread Ross Lagerwall
On 08/21/2017 11:30 PM, Stefano Stabellini wrote: On Mon, 21 Aug 2017, Ross Lagerwall wrote: When the guest writes to the RTC, Xen emulates it and broadcasts a TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens rather than ignoring it so that something useful can be done with the

Re: [Xen-devel] [PATCH 04/27] xen/mm: Move {G, M]FN <-> {G, M}ADDR helpers to common code

2017-08-22 Thread Jan Beulich
>>> On 14.08.17 at 16:23, wrote: > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -92,6 +92,9 @@ static inline bool_t mfn_eq(mfn_t x, mfn_t y) > return mfn_x(x) == mfn_x(y); > } > > +#define maddr_to_mfn(maddr) _mfn(paddr_to_pfn(maddr)) > +#define mfn_to_maddr(mfn) pfn_to_p

Re: [Xen-devel] [PATCH 06/27] xen/mm: Use __virt_to_mfn in map_domain_page instead of virt_to_mfn

2017-08-22 Thread Jan Beulich
>>> On 14.08.17 at 16:23, wrote: > virt_to_mfn may by overridden by the source files, for improving locally > typesafe. > > Therefore map_domain_page has to use __virt_to_mfn to prevent any > compilation issue in sources files that override the helper. > > Signed-off-by: Julien Grall Acked-by:

Re: [Xen-devel] [PATCH 05/27] xen/mm: Use typesafe MFN for alloc_boot_pages return

2017-08-22 Thread Jan Beulich
>>> On 14.08.17 at 16:23, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -200,7 +200,7 @@ static void __init init_frametable_chunk(void *start, > void *end) > */ > while ( step && s + (step << PAGE_SHIFT) > e + (4 << PAGE_SHIFT) ) > step >>= PAGETA

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: > On 2017年08月18日 18:13, Wei Liu wrote: > >>> ASSERT(info->viommu[viommu_id]->ops); > >>> > > > >>> > > For extra safety. > >> > > >> > Or check ops in the previous if? > >> > > > That depends on if ops can be null or not. > > If ops is

[Xen-devel] [linux-3.18 test] 112775: trouble: blocked/broken/fail/pass

2017-08-22 Thread osstest service owner
flight 112775 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/112775/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 3 capture-logs broken REGR. vs. 112102

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

2017-08-22 Thread Chao Gao
On Tue, Aug 22, 2017 at 08:29:58AM +0100, Roger Pau Monné wrote: >On Tue, Aug 22, 2017 at 05:52:04AM +0800, Chao Gao wrote: >> When SR-IOV is enabled, 'Virtual Functions' of a 'Physical Function' are >> under >> the scope of the same VT-d unit as the 'Physical Function'. A 'Physical >> Function' c

[Xen-devel] [PATCH 01/19] libxl/xl: move some HVM/PV specific fields of libxl_domain_build_info

2017-08-22 Thread Roger Pau Monne
Move the HVM/PV sub-structure fields of libxl_domain_build_info into the top-level structure. xl is also modified to start using those fields. This is required because those options will be used by the new PVH guest type. Defines are added in order to signal consumers that the fields are availabl

[Xen-devel] [PATCH 18/19] xl: add PVH as a guest type

2017-08-22 Thread Roger Pau Monne
And remove device model "none". Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/xl/xl_parse.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 84380efc72..29f52876cf 100644 --- a/tools/xl/xl_parse.

[Xen-devel] [PATCH 14/19] libxl: PVH guests use PV nics

2017-08-22 Thread Roger Pau Monne
Remove device model "none" support from the nic functions. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_nic.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c index 4b6e8c0cb1..7

[Xen-devel] [PATCH 06/19] libxl: set PVH guests to use the PV console

2017-08-22 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_console.c b/tools/libxl/libxl_console.c index 446e766911..5029365d2e 100644 --- a/tools/libxl/libxl_console.c +++ b/tools/libxl/li

[Xen-devel] [PATCH 00/19] libxl/xl: add PVH guest type

2017-08-22 Thread Roger Pau Monne
Hello, This series adds a new PVH guest type to libxl/xl, this supersedes the current PVHv2 implementation, that relies on using the "none" device model version. As part of this series a new xl option is also implemented, called "type" that supersedes the current "builder" option. A "firmware" op

[Xen-devel] [PATCH 02/19] xl: introduce a domain type option

2017-08-22 Thread Roger Pau Monne
Introduce a new type option to xl configuration files in order to specify the domain type. This supersedes the current builder option. The new option is documented in the xl.cfg man page, and the previous builder option is marked as deprecated. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson

[Xen-devel] [PATCH 16/19] libxl: add PVH support to USB

2017-08-22 Thread Roger Pau Monne
Add PVH support to usb related functions. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index d8948d5212..d6bdbb822b 100644 ---

[Xen-devel] [PATCH 03/19] xl: introduce a firmware option

2017-08-22 Thread Roger Pau Monne
The new firmware option aims to provide a coherent way to set the firmware for the different kind of guests Xen supports. For PV guests the available firmwares are pvgrub{32|64}, and for HVM the following are supported: bios, uefi, seabios, rombios and ovmf. Note that uefi maps to ovmf, and bios m

[Xen-devel] [PATCH 04/19] libxl: introduce a PVH guest type

2017-08-22 Thread Roger Pau Monne
The new guest type is introduced to the libxl IDL. libxl__domain_make is also modified to save the guest type, and libxl__domain_type is expanded to fetch that information when detecting guest type. This is required because the hypervisor only differentiates between PV and HVM guests, so libxl nee

[Xen-devel] [PATCH 08/19] libxl: remove device model "none" support from disk related functions

2017-08-22 Thread Roger Pau Monne
CD-ROM backend selection was partially based on the device model, this is no longer needed since the device model "none" is now removed, so HVM guests always have a device model. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_disk.c | 10 +- 1 file

[Xen-devel] [PATCH 10/19] libxl: add PVH support to domain building

2017-08-22 Thread Roger Pau Monne
And remove device model "none" support. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_dom.c | 148 ++-- 1 file changed, 94 insertions(+), 54 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl

[Xen-devel] [PATCH 12/19] libxl: add PVH support to vpcu hotplug, domain destruction/pause and domain configuration

2017-08-22 Thread Roger Pau Monne
And remove support for device model "none". Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_domain.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c index 08eccd

[Xen-devel] [PATCH 11/19] libxl: add PVH support to domain save/suspend

2017-08-22 Thread Roger Pau Monne
And remove the device model "none" support. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_dom_save.c| 9 ++--- tools/libxl/libxl_dom_suspend.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_dom_save.

[Xen-devel] [PATCH 13/19] libxl: add PVH support to memory functions

2017-08-22 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_mem.c b/tools/libxl/libxl_mem.c index f5d2530d8c..e551e09fed 100644 --- a/tools/libxl/libxl_mem.c +++ b/tools/libxl/libxl_mem.c @@ -46

[Xen-devel] [PATCH 19/19] libxl: remove device model "none" from IDL

2017-08-22 Thread Roger Pau Monne
And the xl.cfg man page documentation. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- docs/man/xl.cfg.pod.5.in| 5 - tools/libxl/libxl.h | 8 tools/libxl/libxl_types.idl | 1 - 3 files changed, 14 deletions(-) diff --git a/docs/man/xl.cfg.pod.5.in

[Xen-devel] [PATCH 05/19] libxl: allow PVH guests to use a bootloader

2017-08-22 Thread Roger Pau Monne
Allow PVH guests to boot using a bootloader. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_bootloader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_bootloader.c b/tools/libxl/libxl_bootloader.c index a47bd8c25

[Xen-devel] [PATCH 07/19] libxl: add PVH support to domain creation

2017-08-22 Thread Roger Pau Monne
Remove the device model "none" support from domain creation and introduce support for PVH. This requires changing some of the HVM checks to be applied for both HVM and PVH. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_create.c | 69 +

[Xen-devel] [PATCH 17/19] libxl: add PVH support to x86 functions

2017-08-22 Thread Roger Pau Monne
This also includes the x86 ACPI related functions. Remove support for device model "none" Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_x86.c | 33 + tools/libxl/libxl_x86_acpi.c | 3 +-- 2 files changed, 18 insertion

[Xen-devel] [PATCH 09/19] libxl: set device model for PVH guests

2017-08-22 Thread Roger Pau Monne
PVH guests use the same device model selection as PV guests, because PVH guests only use the device model for the PV backends. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_dm.c

[Xen-devel] [PATCH 15/19] libxl: remove device model "none" support from stream functions

2017-08-22 Thread Roger Pau Monne
Remove the usage of device model "none" in the migration stream related functions. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_stream_read.c | 6 ++ tools/libxl/libxl_stream_write.c | 11 ++- 2 files changed, 4 insertions(+), 13 deletions(

Re: [Xen-devel] [PATCH v3 18/52] xen/arch/x86/psr.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:51, wrote: > Modify the custom parameter parsing routines in: > > xen/arch/x86/psr.c > > to indicate whether the parameter value was parsed successfully. > > Cc: Jan Beulich > Cc: Andrew Cooper > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich ___

Re: [Xen-devel] [PATCH v3 20/52] xen/arch/x86/shutdown.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:51, wrote: > --- a/xen/arch/x86/shutdown.c > +++ b/xen/arch/x86/shutdown.c > @@ -51,8 +51,11 @@ static int reboot_mode; > * efiUse the EFI reboot (if running under EFI) > */ > static enum reboot_type reboot_type = BOOT_INVALID; > -static void __init set_reboot_type(c

Re: [Xen-devel] [PATCH v3 22/52] xen/arch/x86/x86_64/mmconfig-shared.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:51, wrote: > --- a/xen/arch/x86/x86_64/mmconfig-shared.c > +++ b/xen/arch/x86/x86_64/mmconfig-shared.c > @@ -28,22 +28,35 @@ > > unsigned int pci_probe = PCI_PROBE_CONF1 | PCI_PROBE_MMCONF; > > -static void __init parse_mmcfg(char *s) > +static int __init parse_mmcfg(con

Re: [Xen-devel] [PATCH v3 25/52] xen/common/efi/boot.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:51, wrote: > Modify the custom parameter parsing routines in: > > xen/common/efi/boot.c > > to indicate whether the parameter value was parsed successfully. > > Cc: Jan Beulich > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich _

[Xen-devel] [distros-debian-snapshot test] 72002: tolerable trouble: blocked/broken/fail/pass

2017-08-22 Thread Platform Team regression test user
flight 72002 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72002/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-armhf-daily-netboot-pygrub 1 build-check(1) blocked n/a build-arm64-pvops

Re: [Xen-devel] [PATCH v3 31/52] xen/drivers/cpufreq/cpufreq.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:51, wrote: > @@ -581,8 +585,12 @@ void __init cpufreq_cmdline_parse(char *str) > &cpufreq_gov_performance, > &cpufreq_gov_powersave > }; > +static char buf[128]; __initdata With that Reviewed-by: Jan Beulich Jan ___

Re: [Xen-devel] [PATCH v3 33/52] xen/drivers/passthrough/iommu.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > @@ -89,44 +89,50 @@ static void __init parse_iommu_param(char *s) > s += 3; > > ss = strchr(s, ','); > -if ( ss ) > -*ss = '\0'; > - > -if ( !parse_bool(s) ) > -iommu_enable = 0; > -else if (

Re: [Xen-devel] [PATCH v3 34/52] xen/drivers/passthrough/pci.c: let custom parameter parsing routines return errno

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -149,17 +149,18 @@ static struct phantom_dev { > } phantom_devs[8]; > static unsigned int nr_phantom_devs; > > -static void __init parse_phantom_dev(char *str) { > +static int __in

[Xen-devel] [ovmf baseline-only test] 72003: all pass

2017-08-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72003 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72003/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bb3d1a6198cc5a8f2672927295c9f8d5ede9187c baseline v

Re: [Xen-devel] [PATCH v2 02/13] iommu: Add extra order argument to the IOMMU APIs and platform callbacks

2017-08-22 Thread Oleksandr Tyshchenko
Hi, Jan On Tue, Aug 22, 2017 at 10:21 AM, Jan Beulich wrote: On 21.08.17 at 18:20, wrote: >> Hi, all. >> >> Any comments? > > Excuse me, but comments on what? The quoted text below just has > two "will add" comments of yours. I don't think you expect any > further comments on those. As to t

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月22日 16:42, Wei Liu wrote: > On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: >> On 2017年08月18日 18:13, Wei Liu wrote: > ASSERT(info->viommu[viommu_id]->ops); >>> >>> For extra safety. > > Or check ops in the previous if? > >>> That depends on if ops can

Re: [Xen-devel] Xen 4.10 Development Update

2017-08-22 Thread Yu Zhang
On 8/21/2017 6:15 PM, Julien Grall wrote: Hi Paul, On 21/08/17 11:11, Paul Durrant wrote: -Original Message- From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Julien Grall Sent: 21 August 2017 11:08 To: xen-de...@lists.xenproject.org Cc: julien.gr...@arm.com Subjec

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 06:39:32PM +0800, Lan Tianyu wrote: > On 2017年08月22日 16:42, Wei Liu wrote: > > On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: > >> On 2017年08月18日 18:13, Wei Liu wrote: > > ASSERT(info->viommu[viommu_id]->ops); > >>> > >>> For extra safety. > > >

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月22日 18:53, Wei Liu wrote: > On Tue, Aug 22, 2017 at 06:39:32PM +0800, Lan Tianyu wrote: >> On 2017年08月22日 16:42, Wei Liu wrote: >>> On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: On 2017年08月18日 18:13, Wei Liu wrote: >>> ASSERT(info->viommu[viommu_id]->ops);

Re: [Xen-devel] Is:livepatch-build-tools.git declare it supported? Was:Re: [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-08-22 Thread George Dunlap
On Tue, Aug 22, 2017 at 7:37 AM, Jan Beulich wrote: On 21.08.17 at 17:28, wrote: >> So your argument seems to be: >> >> 1. We can only provide security support in situations where we can test >> all possible combinations in the support matrix. >> >> 2. We cannot test the entire matrix of com

Re: [Xen-devel] [PATCH V2 4/25] Xen/doc: Add Xen virtual IOMMU doc

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 04:07:32PM +0800, Lan Tianyu wrote: > On 2017年08月18日 18:15, Wei Liu wrote: > > On Fri, Aug 18, 2017 at 03:17:37PM +0800, Lan Tianyu wrote: > >> On 2017年08月17日 19:19, Wei Liu wrote: > >>> On Wed, Aug 09, 2017 at 04:34:05PM -0400, Lan Tianyu wrote: > +Now just suppport si

Re: [Xen-devel] [PATCH v3] hvmloader: support system enclosure asset tag (SMBIOS type 3)

2017-08-22 Thread Roger Pau Monné
On Mon, Aug 21, 2017 at 12:49:38PM +0100, VIVEK KUMAR CHAUBEY wrote: > From: Vivek Kumar Chaubey > > Allow setting system enclosure asset tag for HVM guest. Guest OS can > check and perform desired operation like support installation. > Also added documentation of '~/bios-string/*' xenstore keys

[Xen-devel] [xen-4.9-testing test] 112780: regressions - trouble: blocked/broken/fail/pass

2017-08-22 Thread osstest service owner
flight 112780 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/112780/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 112647 test-amd64-i386

Re: [Xen-devel] [PATCH V2 5/25] tools/libxc: Add viommu operations in libxc

2017-08-22 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:06PM -0400, Lan Tianyu wrote: > From: Chao Gao > > This patch adds XEN_DOMCTL_viommu_op hypercall. This hypercall > comprises three sub-command: > - query capabilities of one specific type vIOMMU emulated by Xen > - create vIOMMU in Xen hypervisor, given viommu type,

[Xen-devel] [xen-unstable-smoke test] 112816: tolerable trouble: broken/pass - PUSHED

2017-08-22 Thread osstest service owner
flight 112816 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/112816/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64-pvops 2 hos

Re: [Xen-devel] Is:livepatch-build-tools.git declare it supported? Was:Re: [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-08-22 Thread Roger Pau Monné
On Tue, Aug 22, 2017 at 11:58:57AM +0100, George Dunlap wrote: > I think guest OS support is actually a pretty good analog. I can't > imagine not issuing XSAs for bugs in Linux, just as I can't imagine > not issuing XSAs for actual security issues that get found in the > livepatch tools. If you t

Re: [Xen-devel] [PATCH 01/27] xen/x86: numa: Don't check alloc_boot_pages return

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:23, Julien Grall wrote: > alloc_boot_pages will panic if it is not possible to allocate. So the > check in the caller is pointless. More than that I don't see why "0" couldn't be a valid MFN. At least the code in alloc_boot_pages() doesn't treat it specially, so it doesn't sign

Re: [Xen-devel] [PATCH 02/27] xen/x86: srat: Don't check alloc_boot_pages return

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:23, Julien Grall wrote: > alloc_boot_pages will panic if it is not possible to allocate. So the > check in the caller is pointless. > > Signed-off-by: Julien Grall Reviewed-by: Andre Przywara Thanks, Andre. > --- > > Cc: Jan Beulich > Cc: Andrew Cooper > --- > xen/arch

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > static void __init _cmdline_parse(const char *cmdline) > { > char opt[128], *optval, *optkey, *q; > -const char *p = cmdline; > +const char *p = cmdline, *s, *key; > const struct kernel_param *param; > -int bool_assert; > +int bool_ass

Re: [Xen-devel] [PATCH 00/19] libxl/xl: add PVH guest type

2017-08-22 Thread Andrew Cooper
On 22/08/17 10:49, Roger Pau Monne wrote: > Hello, > > This series adds a new PVH guest type to libxl/xl, this supersedes the > current PVHv2 implementation, that relies on using the "none" device > model version. > > As part of this series a new xl option is also implemented, called > "type" that

Re: [Xen-devel] [PATCH v5 01/11] x86/pci: introduce hvm_pci_decode_addr

2017-08-22 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 14 August 2017 15:29 > To: xen-de...@lists.xenproject.org > Cc: boris.ostrov...@oracle.com; konrad.w...@oracle.com; Roger Pau Monne > ; Paul Durrant ; Jan > Beulich ; Andrew Cooper > > Subject: [PATCH v5 01/

Re: [Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:23, Julien Grall wrote: > The only way alloc_boot_pages will return 0 is during the error case. This statement is not true. If alloc_boot_pages() returns, it has succeeded. Returning 0 is nothing special. > Although, Xen will panic in the error path. So the check in the caller

Re: [Xen-devel] [PATCH v3 47/52] xen: add basic support for runtime parameter changing

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > Add the needed infrastructure for runtime parameter changing similar > to that used at boot time via cmdline. We are using the same parsing > functions as for cmdline parsing, but with a different array of > parameter definitions. > > Cc: Andrew Cooper > Cc: Ge

Re: [Xen-devel] [PATCH 00/19] libxl/xl: add PVH guest type

2017-08-22 Thread Roger Pau Monne
On Tue, Aug 22, 2017 at 12:24:29PM +0100, Andrew Cooper wrote: > On 22/08/17 10:49, Roger Pau Monne wrote: > > Hello, > > > > This series adds a new PVH guest type to libxl/xl, this supersedes the > > current PVHv2 implementation, that relies on using the "none" device > > model version. > > > > As

Re: [Xen-devel] [PATCH v3 48/52] xen: add hypercall for setting parameters at runtime

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -467,6 +467,42 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > copyback = 1; > break; > > +case XEN_SYSCTL_set_parameter: > +{ > +#define XEN_SET_PARA

Re: [Xen-devel] [PATCH v3 52/52] xen: make some console related parameters settable at runtime

2017-08-22 Thread Jan Beulich
>>> On 16.08.17 at 14:52, wrote: > Support modifying conswitch, console_timestamps, loglvl and > guest_loglvl at runtime. > > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Wei Liu > Sig

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2017-08-22 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 14 August 2017 15:29 > To: xen-de...@lists.xenproject.org > Cc: boris.ostrov...@oracle.com; konrad.w...@oracle.com; Roger Pau Monne > ; Ian Jackson ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Paul Durrant

Re: [Xen-devel] [PATCH v5 03/11] x86/mmcfg: add handlers for the PVH Dom0 MMCFG areas

2017-08-22 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 14 August 2017 15:29 > To: xen-de...@lists.xenproject.org > Cc: boris.ostrov...@oracle.com; konrad.w...@oracle.com; Roger Pau Monne > ; Jan Beulich ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH v5 03/11

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-08-22 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 14 August 2017 15:29 > To: xen-de...@lists.xenproject.org > Cc: boris.ostrov...@oracle.com; konrad.w...@oracle.com; Roger Pau Monne > ; Jan Beulich ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH v5 09/11

Re: [Xen-devel] [PATCH v2 1/4] x86/dom0: prevent access to MMCFG areas for PVH Dom0

2017-08-22 Thread Jan Beulich
>>> On 11.08.17 at 18:43, wrote: > They are emulated by Xen, so they must not be mapped into Dom0 p2m. > Introduce a helper function to add the MMCFG areas to the list of > denied iomem regions for PVH Dom0. "They are" or "They are going to be"? > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch

Re: [Xen-devel] [PATCH v2 2/4] x86/dom0: prevent PVH Dom0 from mapping read-only the IO APIC area

2017-08-22 Thread Jan Beulich
>>> On 11.08.17 at 18:43, wrote: > This is emulated by Xen and must not be mapped into PVH Dom0 p2m. > > Signed-off-by: Roger Pau Monné If we stay with black listing MMIO ranges Acked-by: Jan Beulich Jan ___ Xen-devel mailing list Xen-devel@lists.x

Re: [Xen-devel] [PATCH v2 3/4] x86/vtd: introduce a PVH implementation of iommu_inclusive_mapping

2017-08-22 Thread Jan Beulich
>>> On 11.08.17 at 18:43, wrote: > On certain Intel systems, as far as I can tell almost all pre-Haswell ones, > trying to boot a PVH Dom0 will freeze the box completely, up to the point that > not even the watchdog works. The freeze happens exactly when enabling the DMA > remapping in the IOMMU,

Re: [Xen-devel] [PATCH 00/19] libxl/xl: add PVH guest type

2017-08-22 Thread Andrew Cooper
On 22/08/17 12:30, Roger Pau Monne wrote: > On Tue, Aug 22, 2017 at 12:24:29PM +0100, Andrew Cooper wrote: >> On 22/08/17 10:49, Roger Pau Monne wrote: >>> Hello, >>> >>> This series adds a new PVH guest type to libxl/xl, this supersedes the >>> current PVHv2 implementation, that relies on using th

[Xen-devel] [xen-4.5-testing bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64

2017-08-22 Thread osstest service owner
branch xen-4.5-testing xenbranch xen-4.5-testing job test-amd64-i386-xl-qemuu-debianhvm-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git T

Re: [Xen-devel] Xen 4.10 Development Update

2017-08-22 Thread Julien Grall
On 22/08/17 06:59, Oleksandr Andrushchenko wrote: Hi, Julien! Hi Oleksandr, On 08/21/2017 01:07 PM, Julien Grall wrote: This email only tracks big items for xen.git tree. Please reply for items you woulk like to see in 4.10 so that people have an idea what is going on and prioritise accord

Re: [Xen-devel] [PATCH v2 4/4] x86/dom0: re-order DMA remapping enabling for PVH Dom0

2017-08-22 Thread Jan Beulich
>>> On 11.08.17 at 18:43, wrote: > Make sure the reserved regions are setup before enabling the DMA > remapping in the IOMMU, by calling dom0_setup_permissions before > iommu_hwdom_init. I can't match up this part with ... > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 23:52, wrote: > --- a/xen/include/xen/pci.h > +++ b/xen/include/xen/pci.h > @@ -39,6 +39,10 @@ > #define PCI_SBDF3(s,b,df) s) & 0x) << 16) | PCI_BDF2(b, df)) > > struct pci_dev_info { > +/* > + * When 'is_virtfn' is set, 'is_extfn' is re-used to indicate whet

Re: [Xen-devel] Xen 4.10 Development Update

2017-08-22 Thread Julien Grall
Hi, On 22/08/17 11:22, Yu Zhang wrote: On 8/21/2017 6:15 PM, Julien Grall wrote: Hi Paul, On 21/08/17 11:11, Paul Durrant wrote: -Original Message- From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Julien Grall Sent: 21 August 2017 11:08 To: xen-de...@lists.xenpr

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 20:05, wrote: > Currently Linux has no support for grant v2 as this would reduce the > maximum number of active grants by a factor of 2 compared to v1, > because the number of possible grants are limited by the allowed number > of grant frames and grant entries of v2 need twice

[Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-22 Thread Roger Pau Monne
The version of SMBIOS set in the entry point is 2.4, however several structures are missing fields required by 2.4. Fix this by adding the missing fields, this is based on the documents found at the DMTF site [0]. Most fields are set to 0 (undefined/not specified), except for the cache related han

Re: [Xen-devel] [PATCH 1/3] xen: move hvm save code under common to x86

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 16:09, wrote: > The code is only used by x86 at this point. Merge common/hvm/save.c > into x86 hvm/save.c. Move the headers and fix up inclusions. Remove > the now empty common/hvm directory. > > Also fix some issues while moving: > 1. removing trailing spaces; > 2. fix multi-l

Re: [Xen-devel] [PATCH 2/3] xen: merge common hvm/irq.h into x86 hvm/irq.h

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 16:14, wrote: > On Mon, Aug 21, 2017 at 03:09:12PM +0100, Wei Liu wrote: >> That header file is only used by x86. Merge is into the x86 header. >> >> Signed-off-by: Wei Liu > [...] >> +#define HVM_IRQ_DPCI_MACH_PCI(1 << _HVM_IRQ_DPCI_MACH_PCI_SHIFT) >> +#define HVM_IRQ

Re: [Xen-devel] [PATCH 3/3] x86: switch to plain bool in passthrough code

2017-08-22 Thread Jan Beulich
>>> On 21.08.17 at 16:09, wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/19] libxl/xl: add PVH guest type

2017-08-22 Thread Roger Pau Monne
On Tue, Aug 22, 2017 at 01:33:55PM +0100, Andrew Cooper wrote: > On 22/08/17 12:30, Roger Pau Monne wrote: > > On Tue, Aug 22, 2017 at 12:24:29PM +0100, Andrew Cooper wrote: > >> On 22/08/17 10:49, Roger Pau Monne wrote: > >>> Hello, > >>> > >>> This series adds a new PVH guest type to libxl/xl, th

Re: [Xen-devel] [PATCH V2 6/25] tools/libacpi: Add DMA remapping reporting (DMAR) ACPI table structures

2017-08-22 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:07PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Add dmar table structure according Chapter 8 "BIOS Considerations" of > VTd spec Rev. 2.4. > > VTd > spec:http://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/vt-directed-io-spec.pdf >

Re: [Xen-devel] [PATCH v3 3/6] xen: RCU/x86/ARM: discount CPUs that were idle when grace period started.

2017-08-22 Thread Jan Beulich
>>> On 18.08.17 at 20:04, wrote: > Changes from v2: > * initialize idle_cpumask to "all clear", i.e., all the CPUs are busy; > they'll clear their bit out themselves as soon as the run the idle > loop (pretty soon anyway). Just to make sure I correctly understand this - you really mean "they'

Re: [Xen-devel] [PATCH v3 5/6] xen: RCU: avoid busy waiting until the end of grace period.

2017-08-22 Thread Jan Beulich
>>> On 18.08.17 at 20:04, wrote: > --- a/xen/arch/x86/cpu/mwait-idle.c > +++ b/xen/arch/x86/cpu/mwait-idle.c > @@ -741,9 +741,8 @@ static void mwait_idle(void) > } > > cpufreq_dbs_timer_suspend(); > - > sched_tick_suspend(); > - /* sched_tick_suspend() can raise TIMER_SOFTI

Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

2017-08-22 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:08PM -0400, Lan Tianyu wrote: > From: Chao Gao > > The BIOS reports the remapping hardware units in a platform to system software > through the DMA Remapping Reporting (DMAR) ACPI table. > New fields are introduces for DMAR table. These new fields are set by > toolst

Re: [Xen-devel] [PATCH V2 8/25] tools/libxl: Add a user configurable parameter to control vIOMMU attributes

2017-08-22 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:09PM -0400, Lan Tianyu wrote: > From: Chao Gao [...] > -=back > +=back > + > +=item B > + > +Specifies the vIOMMU which are to be provided to the guest. > + > +B has the form C where: > + > +=over 4 > + > +=item B > + > +Possible Bs are: > + > +=over 4 > + > +=item B

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-22 Thread Wei Liu
On Fri, Aug 18, 2017 at 07:56:36AM -0600, Jan Beulich wrote: > >>> On 18.08.17 at 15:45, wrote: > > On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: > >> > > >> >> > +} > >> >> > +} > >> >> > +} > >> >> > >> >> This still looks wrong to me. How do you know acpi_mo

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-22 Thread Wei Liu
On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: > On Thu, Aug 17, 2017 at 01:28:21PM +0100, Wei Liu wrote: > >On Thu, Aug 17, 2017 at 12:32:17PM +0100, Wei Liu wrote: > >> On Wed, Aug 09, 2017 at 04:34:10PM -0400, Lan Tianyu wrote: > >> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl

[Xen-devel] [linux-next test] 112778: regressions - trouble: blocked/broken/fail/pass

2017-08-22 Thread osstest service owner
flight 112778 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/112778/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 112673 test-amd64-i386-xl-q

Re: [Xen-devel] [PATCH v2 1/4] x86/dom0: prevent access to MMCFG areas for PVH Dom0

2017-08-22 Thread Roger Pau Monne
On Tue, Aug 22, 2017 at 06:26:23AM -0600, Jan Beulich wrote: > >>> On 11.08.17 at 18:43, wrote: > > They are emulated by Xen, so they must not be mapped into Dom0 p2m. > > Introduce a helper function to add the MMCFG areas to the list of > > denied iomem regions for PVH Dom0. > > "They are" or "T

Re: [Xen-devel] Xen 4.10 Development Update

2017-08-22 Thread Meng Xu
On Mon, Aug 21, 2017 at 6:07 AM, Julien Grall wrote: > This email only tracks big items for xen.git tree. Please reply for items you > woulk like to see in 4.10 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use cases of the

  1   2   >