Re: [PATCH v5 27/38] xen: gntdev: fix common struct sg_table related issues

2020-05-17 Thread Jürgen Groß
On 13.05.20 15:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the

Re: [PATCH] optee: immediately free buffers that are released by OP-TEE

2020-05-17 Thread Volodymyr Babchuk
Hi Julien, On Mon, 2020-05-11 at 10:34 +0100, Julien Grall wrote: > Hi Volodymyr, > > On 06/05/2020 02:44, Volodymyr Babchuk wrote: > > Normal World can share buffer with OP-TEE for two reasons: > > 1. Some client application wants to exchange data with TA > > 2. OP-TEE asks for shared buffer

[PATCH] xen/arm: optee: allow plain TMEM buffers with NULL address

2020-05-17 Thread Volodymyr Babchuk
Trusted Applications use popular approach to determine required size of buffer: client provides a memory reference with the NULL pointer to a buffer. This is so called "Null memory reference". TA updates the reference with the required size and returns it back to client. Then client allocates

[PATCH v6 15/18] libxl: ignore emulated IDE disks beyond the first 4

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Qemu supports only 4 emulated IDE disks, when given more (or with higher indexes), it will fail to start. Since the disks can still be accessible using PV interface, just ignore emulated path and log a warning, instead of rejecting the configuration altogether.

[PATCH v6 16/18] libxl: consider also qemu in stubdomain in libxl__dm_active check

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Since qemu-xen can now run in stubdomain too, handle this case when checking it's state too. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian

[PATCH v6 17/18] docs: Add device-model-domid to xenstore-paths

2020-05-17 Thread Jason Andryuk
Document device-model-domid for when using a device model stubdomain. Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/misc/xenstore-paths.pandoc | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/misc/xenstore-paths.pandoc

[PATCH v6 18/18] libxl: Check stubdomain kernel & ramdisk presence

2020-05-17 Thread Jason Andryuk
Just out of context is the following comment for libxl__domain_make: /* fixme: this function can leak the stubdom if it fails */ When the stubdomain kernel or ramdisk is not present, the domid and stubdomain name will indeed be leaked. Avoid the leak by checking the file presence and erroring

[PATCH v6 03/18] libxl: fix qemu-trad cmdline for no sdl/vnc case

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki When qemu is running in stubdomain, any attempt to initialize vnc/sdl there will crash it (on failed attempt to load a keymap from a file). If vfb is present, all those cases are skipped. But since b053f0c4c9e533f3d97837cf897eb920b8355ed3 "libxl: do not start

[PATCH v6 04/18] libxl: Allow running qemu-xen in stubdomain

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Do not prohibit anymore using stubdomain with qemu-xen. To help distingushing MiniOS and Linux stubdomain, add helper inline functions libxl__stubdomain_is_linux() and libxl__stubdomain_is_linux_running(). Those should be used where really the difference is about

[PATCH v6 13/18] libxl: use vchan for QMP access with Linux stubdomain

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Access to QMP of QEMU in Linux stubdomain is possible over vchan connection. Handle the actual vchan connection in a separate process (vchan-socket-proxy). This simplified integration with QMP (already quite complex), but also allows preliminary filtering of

[PATCH v6 14/18] libxl: require qemu in dom0 for multiple stubdomain consoles

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Device model stubdomains (both Mini-OS + qemu-trad and linux + qemu-xen) are always started with at least 3 consoles: log, save, and restore. Until xenconsoled learns how to handle multiple consoles, this is needed for save/restore support. For Mini-OS stubdoms,

[PATCH v6 10/18] tools: add missing libxenvchan cflags

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki libxenvchan.h include xenevtchn.h and xengnttab.h, so applications built with it needs applicable -I in CFLAGS too. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6 -

[PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki This allows using arguments with spaces, like -append, without nominating any special "separator" character. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Re-work to use libxl_xs_* functions in a loop. Also write arguments in dm-argv

[PATCH v6 00/18] Add support for qemu-xen runnning in a Linux-based stubdomain

2020-05-17 Thread Jason Andryuk
Hi, In coordination with Marek, I'm making a submission of his patches for Linux stubdomain device-model support. I made a few of my own additions, but Marek did the heavy lifting. Thank you, Marek. Below is mostly the v5 cover leter with a few additions. General idea is to allow freely set

[PATCH v6 05/18] libxl: Handle Linux stubdomain specific QEMU options.

2020-05-17 Thread Jason Andryuk
From: Eric Shelton This patch creates an appropriate command line for the QEMU instance running in a Linux-based stubdomain. NOTE: a number of items are not currently implemented for Linux-based stubdomains, such as: - save/restore - QMP socket - graphics output (e.g., VNC) Signed-off-by: Eric

[PATCH v6 01/18] Document ioemu MiniOS stubdomain protocol

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add documentation based on reverse-engineered toolstack-ioemu stubdomain protocol. Signed-off-by: Marek Marczykowski-Górecki Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/misc/stubdom.txt | 53

[PATCH v6 08/18] tools/libvchan: notify server when client is connected

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Let the server know when the client is connected. Otherwise server will notice only when client send some data. This change does not break existing clients, as libvchan user should handle spurious notifications anyway (for example acknowledge of remote side

[PATCH v6 12/18] libxl: Refactor kill_device_model to libxl__kill_xs_path

2020-05-17 Thread Jason Andryuk
Move kill_device_model to libxl__kill_xs_path so we have a helper to kill a process from a pid stored in xenstore. We'll be using it to kill vchan-qmp-proxy. libxl__kill_xs_path takes a "what" string for use in printing error messages. kill_device_model is retained in libxl_dm.c to provide the

[PATCH v6 11/18] tools: add simple vchan-socket-proxy

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add a simple proxy for tunneling socket connection over vchan. This is based on existing vchan-node* applications, but extended with socket support. vchan-socket-proxy serves both as a client and as a server, depending on parameters. It can be used to

[PATCH v6 02/18] Document ioemu Linux stubdomain protocol

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add documentation for upcoming Linux stubdomain for qemu-upstream. Signed-off-by: Marek Marczykowski-Górecki Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson - Replace dmargs with dm-argv for xenstore

[PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Rely on a wrapper script in stubdomain to attach relevant consoles to qemu. The save console (1) must be attached to fdset/1. When performing a restore, $STUBDOM_RESTORE_INCOMING_ARG must be replaced on the qemu command line by "fd:$FD", where $FD is an open

[PATCH v6 07/18] xl: add stubdomain related options to xl config parser

2020-05-17 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/man/xl.cfg.5.pod.in | 27 +++ tools/xl/xl_parse.c |

[linux-linus test] 150225: tolerable FAIL - PUSHED

2020-05-17 Thread osstest service owner
flight 150225 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150225/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail blocked in 150221 test-amd64-amd64-xl-qemut-win7-amd64

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-17 Thread Manuel Bouyer
On Sun, May 17, 2020 at 07:32:59PM +0200, Manuel Bouyer wrote: > I've been looking a bit deeper in the Xen kernel. > The mapping is failed in ./arch/x86/mm/p2m.c:p2m_get_page_from_gfn(), > /* Error path: not a suitable GFN at all */ > if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) &&

[xen-unstable test] 150223: tolerable FAIL - PUSHED

2020-05-17 Thread osstest service owner
flight 150223 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150223/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 150220 Tests which did not

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-17 Thread Manuel Bouyer
I've been looking a bit deeper in the Xen kernel. The mapping is failed in ./arch/x86/mm/p2m.c:p2m_get_page_from_gfn(), /* Error path: not a suitable GFN at all */ if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) && !p2m_is_pod(*t) ) { gdprintk(XENLOG_ERR,

Re: RoCE adapters and Xen.

2020-05-17 Thread Jason Long
Please see https://community.oracle.com/thread/4326908 Migration to a new hypervisor is more easy than adding hardware support !!! Sent from Yahoo Mail on Android On Sun, May 17, 2020 at 8:35 PM, Hongyan Xia wrote: On Sun, 2020-05-17 at 13:15 +, Jason Long wrote: > Hello, > The

Re: RoCE adapters and Xen.

2020-05-17 Thread Hongyan Xia
On Sun, 2020-05-17 at 13:15 +, Jason Long wrote: > Hello, > The Xen hypervisor doesn't support the RoCE adapters? The Oracle > migrates to the KVM because of it. > Why not add this feature? I am curious. Aren't RoCE adapters just PCIe devices? If things are set up correctly and drivers are

Re: [PATCH v5 06/21] libxl: write qemu arguments into separate xenstore keys

2020-05-17 Thread Jason Andryuk
On Thu, May 14, 2020 at 12:25 PM Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v5 06/21] libxl: write qemu arguments into > separate xenstore keys"): > > +xs_set_permissions(ctx->xsh, t, GCSPRINTF("%s/rtc/timeoffset", > > vm_path), roperm, ARRAY_SIZE(roperm)); > > This line seems

Re: [PATCH v5 05/21] libxl: Handle Linux stubdomain specific QEMU options.

2020-05-17 Thread Jason Andryuk
On Thu, May 14, 2020 at 12:19 PM Ian Jackson wrote: > Jason Andryuk writes ("[PATCH v5 05/21] libxl: Handle Linux stubdomain > specific QEMU options."): > > @@ -1974,8 +2006,10 @@ static int libxl__build_device_model_args(libxl__gc > > *gc, > >

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-17 Thread Jason Andryuk
On Thu, May 14, 2020 at 12:35 PM Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v5 09/21] libxl: add save/restore support for > qemu-xen in stubdomain"): > > From: Marek Marczykowski-Górecki > > > > Rely on a wrapper script in stubdomain to attach FD 3/4 of qemu to > > relevant consoles.

RoCE adapters and Xen.

2020-05-17 Thread Jason Long
Hello,The Xen hypervisor doesn't support the RoCE adapters? The Oracle migrates to the KVM because of it.Why not add this feature? Cheers.

[linux-linus test] 150221: tolerable FAIL - PUSHED

2020-05-17 Thread osstest service owner
flight 150221 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150221/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 15 guest-saverestorefail REGR. vs. 150213 Tests which did not

[xen-unstable-coverity test] 150224: all pass - PUSHED

2020-05-17 Thread osstest service owner
flight 150224 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/150224/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 664e1bc12f8658da124a4eff7a8f16da073bd47f baseline version: xen

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-17 Thread Manuel Bouyer
On Sat, May 16, 2020 at 05:18:45PM +0100, Andrew Cooper wrote: > On 15/05/2020 22:53, Manuel Bouyer wrote: > > On Fri, May 15, 2020 at 10:38:13PM +0100, Andrew Cooper wrote: > >>> [...] > >>> Does it help ? > >> Yes and no.  This is collateral damage of earlier bug. > >> > >> What failed was

[xen-unstable test] 150220: tolerable FAIL - PUSHED

2020-05-17 Thread osstest service owner
flight 150220 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150220/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150212

[libvirt test] 150222: regressions - FAIL

2020-05-17 Thread osstest service owner
flight 150222 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150222/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt