Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Jan Beulich
On 08.11.2022 18:15, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: >> On 08.11.2022 17:43, Roger Pau Monné wrote: >>> On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: On 08.11.2022 12:38, Roger Pau Monne wrote: > Like on the Arm side,

[qemu-mainline test] 174674: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174674 qemu-mainline real [real] flight 174686 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174674/ http://logs.test-lab.xenproject.org/osstest/logs/174686/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest

2022-11-08 Thread Michal Orzel
Hi Jiamei, On 09/11/2022 08:20, Jiamei Xie wrote: > > > Hi all, > > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux > AMBA PL011 driver will access PL011 DMACR register. But this register have > not been supported by vpl011 of Xen. Xen will inject a data abort into

RE: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S

2022-11-08 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年11月7日 4:06 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > ; Henry Wang > Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S

Xen Arm vpl011 UART will cause segmentation fault in Linux guest

2022-11-08 Thread Jiamei Xie
Hi all, When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux AMBA PL011 driver will access PL011 DMACR register. But this register have not been supported by vpl011 of Xen. Xen will inject a data abort into guest, this will cause segmentation fault of guest with the below

Re: [xen-unstable test] 174670: regressions - FAIL

2022-11-08 Thread Jan Beulich
On 08.11.2022 21:06, osstest service owner wrote: > flight 174670 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174670/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-arm64-pvops 6

Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error

2022-11-08 Thread Jan Beulich
On 09.11.2022 03:47, Henry Wang wrote: >> -Original Message- >> From: Edwin Török >> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build >> error >> >> Building with Dune in release mode fails with: >> ``` >> File "ocaml/xenstored/store.ml", line 464, characters

RE: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems

2022-11-08 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年11月7日 3:45 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU > systems > > Hi

RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform

2022-11-08 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年11月7日 3:20 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > ; Jiamei Xie > Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP >

[linux-5.4 test] 174672: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174672 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174665 REGR. vs. 174540 Tests

RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Henry Wang
Hi Edwin, > -Original Message- > > [1] > AS8PR08MB7991145C8063D6939AFFED8F92829@AS8PR08MB7991.eurprd08 > .prod.outlook.com > > > Hmm I thought that is my Outlook rewriting the link, but the archive at > lore.kernel.org seems to have this mangled URL as well which I cannot open. > Could

RE: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error

2022-11-08 Thread Henry Wang
Hi Edwin, > -Original Message- > From: Edwin Török > Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build > error > > Building with Dune in release mode fails with: > ``` > File "ocaml/xenstored/store.ml", line 464, characters 13-32: > Warning 18: this type-based

RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add > 'make format' and remove tabs > While I understand the goal and support, this seems to be a bit too late > to do it in Xen 4.17 (we are only a couple of weeks

RE: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Henry Wang
Hi Roger, > -Original Message- > Subject: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if > present > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. > > As such, this

[linux-linus test] 174671: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174671 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174671/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462

[xen-unstable-smoke test] 174679: tolerable all pass - PUSHED

2022-11-08 Thread osstest service owner
flight 174679 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174679/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[ovmf test] 174673: all pass - PUSHED

2022-11-08 Thread osstest service owner
flight 174673 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174673/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6c1a4a376e97800c555dab9ca9d9651a5676d231 baseline version: ovmf

[xen-unstable test] 174670: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174670 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 174663 Tests which are

Xen Security Advisory 422 v1 (CVE-2022-23824) - x86: Multiple speculative security issues

2022-11-08 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-23824 / XSA-422 x86: Multiple speculative security issues ISSUE DESCRIPTION = 1) Researchers have discovered that on some AMD CPUs, the implementation of IBPB (Indirect

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 17:26, Julien Grall wrote: > > > > On 08/11/2022 17:02, Edwin Torok wrote: >>> On 8 Nov 2022, at 16:03, Julien Grall wrote: >>> >>> Hi, >>> >>> On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using

Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 16:43, Roger Pau Monne wrote: > > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >> On 08.11.2022 12:38, Roger Pau Monne wrote: >>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>> operation on dying domains. >>> >>> The current logic

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Julien Grall
On 08/11/2022 17:02, Edwin Torok wrote: On 8 Nov 2022, at 16:03, Julien Grall wrote: Hi, On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using `ocp-indent` for now to just make minimal modifications in tabs vs spaces and get the right

[qemu-mainline test] 174668: tolerable FAIL - PUSHED

2022-11-08 Thread osstest service owner
flight 174668 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174668/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail blocked in 174662

Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Roger Pau Monné
On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: > On 08.11.2022 17:43, Roger Pau Monné wrote: > > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: > >> On 08.11.2022 12:38, Roger Pau Monne wrote: > >>> Like on the Arm side, return -EINVAL when attempting to do a p2m > >>>

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-08 Thread Luca Fancellu
> On 8 Nov 2022, at 15:49, Jan Beulich wrote: > > On 08.11.2022 15:00, Luca Fancellu wrote: >>> On 8 Nov 2022, at 11:48, Jan Beulich wrote: >>> On 08.11.2022 11:59, Luca Fancellu wrote: > On 07.11.2022 11:47, Luca Fancellu wrote: >> @@ -757,6 +758,51 @@ cppcheck-version: >>

Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Jan Beulich
On 08.11.2022 17:43, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >> On 08.11.2022 12:38, Roger Pau Monne wrote: >>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>> operation on dying domains. >>> >>> The current logic returns 0 and

Re: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 16:07, Julien Grall wrote: > > > > On 08/11/2022 15:34, Edwin Török wrote: >> If we are out of memory then strdup may return NULL, and passing NULL to >> syslog may cause a crash. >> Avoid this by using `caml_stat_strdup` which will raise an OCaml out of >> memory

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 16:03, Julien Grall wrote: > > Hi, > > On 08/11/2022 15:33, Edwin Török wrote: >> See CODING_STYLE: Xen uses spaces, not tabs. >> * OCaml code: >> Using `ocp-indent` for now to just make minimal modifications in >> tabs vs spaces and get the right indentation. >> We can

Re: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common

2022-11-08 Thread Jan Beulich
On 20.10.2022 08:14, Wei Chen wrote: > x86 has implemented a set of codes to process NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the process code like memory blocks validation, node memory > range

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Roger Pau Monné
On Tue, Nov 08, 2022 at 05:35:04PM +0100, Jan Beulich wrote: > On 08.11.2022 17:31, Roger Pau Monné wrote: > > On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: > >> On 08.11.2022 14:55, Roger Pau Monne wrote: > >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >

Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Roger Pau Monné
On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: > On 08.11.2022 12:38, Roger Pau Monne wrote: > > Like on the Arm side, return -EINVAL when attempting to do a p2m > > operation on dying domains. > > > > The current logic returns 0 and leaves the domctl parameter > > uninitialized for

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Jan Beulich
On 08.11.2022 17:31, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Jan Beulich
On 08.11.2022 17:16, Huang Rui wrote: > On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the physical >>>

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Roger Pau Monné
On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: > On 08.11.2022 14:55, Roger Pau Monne wrote: > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > > from the firmware instead of doing it on the PCI ROM on the physical > > device. > > I can't find any mention of

Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-11-08 Thread Jan Beulich
On 03.11.2022 16:41, Jan Beulich wrote: > On 03.11.2022 14:38, Jan Beulich wrote: >> On 29.07.2022 09:04, Jane Malalane wrote: >>> @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) >>> { >>> struct pt_regs *old_regs = set_irq_regs(regs); >>> >>> + if (xen_percpu_upcall)

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Huang Rui
On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote: > On 08.11.2022 14:55, Roger Pau Monne wrote: > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > > from the firmware instead of doing it on the PCI ROM on the physical > > device. > > I can't find any mention of

Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Jan Beulich
On 08.11.2022 12:38, Roger Pau Monne wrote: > Like on the Arm side, return -EINVAL when attempting to do a p2m > operation on dying domains. > > The current logic returns 0 and leaves the domctl parameter > uninitialized for any parameter fetching operations (like the > GET_ALLOCATION operation),

Re: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference

2022-11-08 Thread Julien Grall
On 08/11/2022 15:34, Edwin Török wrote: If we are out of memory then strdup may return NULL, and passing NULL to syslog may cause a crash. Avoid this by using `caml_stat_strdup` which will raise an OCaml out of memory exception instead. This then needs to be paired with caml_stat_free.

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Julien Grall
Hi, On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using `ocp-indent` for now to just make minimal modifications in tabs vs spaces and get the right indentation. We can introduce `ocamlformat` later. * C stubs: just replace tabs with

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Jan Beulich
On 08.11.2022 14:55, Roger Pau Monne wrote: > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere under Linux'es include/acpi/. I

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-08 Thread Jan Beulich
On 08.11.2022 15:00, Luca Fancellu wrote: >> On 8 Nov 2022, at 11:48, Jan Beulich wrote: >> On 08.11.2022 11:59, Luca Fancellu wrote: On 07.11.2022 11:47, Luca Fancellu wrote: > @@ -757,6 +758,51 @@ cppcheck-version: > $(objtree)/include/generated/compiler-def.h: > $(Q)$(CC)

[PATCH for-4.17 v3 10/15] tools/ocaml/xenstored: keep eventchn FD open across live update

2022-11-08 Thread Edwin Török
It has been discovered that the Windows PV drivers rebind their local port of the xenstore evtchn post migrate, which changes the eventchn port from e.g. the default of 3 (nVCPUs+1) to 1 without oxenstored knowing about it. And oxenstored goes and tries to rebind port 3, which is already in use by

[PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference

2022-11-08 Thread Edwin Török
If we are out of memory then strdup may return NULL, and passing NULL to syslog may cause a crash. Avoid this by using `caml_stat_strdup` which will raise an OCaml out of memory exception instead. This then needs to be paired with caml_stat_free. Signed-off-by: Edwin Török --- Reason for

[PATCH for-4.17 v3 12/15] tools/ocaml/xenstored: log live update issues at warning level

2022-11-08 Thread Edwin Török
During live update oxenstored tries a best effort approach to recover as many domains and information as possible even if it encounters errors restoring some domains. This defensive approach has already proven useful to recover domains after a bug in oxenstored. However the default log level is

[PATCH for-4.17 v3 11/15] tools/ocaml/xenstored: do not rebind event channels after live update

2022-11-08 Thread Edwin Török
See explanation in previous commit. This introduces a new field into the live update stream to retain both ports, and handles the missing value in a backward compatible way. Signed-off-by: Edwin Török --- Reason for inclusion 4.17: - fixes a bug in oxenstored live update, needed to make live

[PATCH for-4.17 v3 15/15] tools/ocaml/libs/xc: fix use of uninitialized memory in shadow_allocation_get

2022-11-08 Thread Edwin Török
It has been noticed in 2013 that shadow allocation sometimes returns the wrong value, which got worked around by adding a limit to the shadow multiplier of 1000 and ignoring the value from Xen in that case to avoid a shadow multiplier causing a VM to request 6PB of memory for example:

[PATCH for-4.17 v3 13/15] tools/ocaml/xenstored: set uncaught exception handler

2022-11-08 Thread Edwin Török
Helps debug fatal errors during live update Previously this would've just gone to /dev/null, because: * daemonize reopens stderr as /dev/null * systemd redirects stderr to /dev/null too Previously the only way to debug this was to manually run oxenstored with --no-fork, but when you have a fatal

[PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error

2022-11-08 Thread Edwin Török
Building with Dune in release mode fails with: ``` File "ocaml/xenstored/store.ml", line 464, characters 13-32: Warning 18: this type-based record disambiguation is not principal. File "ocaml/xenstored/store.ml", line 1: Error: Some fatal warnings were triggered (1 occurrences) ``` This is a

[PATCH for-4.17 v3 01/15] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat

2022-11-08 Thread Edwin Török
Add a finalizer on the event channel value, so that it calls `xenevtchn_close` when the value would be GCed. In practice oxenstored seems to be the only user of this, and it creates a single global event channel only, but freeing this could still be useful when run with OCAMLRUNPARAM=c The code

[PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order

2022-11-08 Thread Edwin Török
A better solution is being worked on for master, but for now use ocamldep -sort instead of a manually established link order. The manually established link order will be wrong when (security) patches introduce new dependencies between files that would require changing the link order. If dune was

[PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17

2022-11-08 Thread Edwin Török
These are the patches that I have outstanding for Xen 4.17. I have included a reason why I'm requesting them to be included in 4.17 after the --- line in each individual patch, see also a summary below. For convenience the patches are also available in a git repo: ``` git remote add edwintorok

[PATCH for-4.17 v3 08/15] tools/ocaml/libs/evtchn: add xenevtchn_fdopen bindings

2022-11-08 Thread Edwin Török
Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - needed for a bugfix in a followup commit Changes since v2: - new in v3 --- tools/ocaml/libs/eventchn/xeneventchn.ml | 6 +++- tools/ocaml/libs/eventchn/xeneventchn.mli | 9 +-

[PATCH for-4.17 v3 03/15] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper

2022-11-08 Thread Edwin Török
This is not strictly necessary since it is essentially a no-op currently: a cast to void* and value*, even in OCaml 5.0. However it does make it clearer that what we have here is not a regular OCaml value, but one allocated with Abstract_tag or Custom_tag, and follows the example from the manual

[PATCH for-4.17 v3 02/15] tools/ocaml/libs/xc: OCaml 5.0 compatibility

2022-11-08 Thread Edwin Török
Follow the manual to avoid naked pointers: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head No functional change, except on OCaml 5.0 where it is a bugfix. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- Reason for inclusion in 4.17: - bugfix for upcoming OCaml 5.0 compiler

[PATCH for-4.17 v3 05/15] tools/ocaml/Makefile.rules: do not run ocamldep on distclean

2022-11-08 Thread Edwin Török
Fixes: 2f2b76d47c5bcd9 ("tools/ocaml: do not run ocamldep during make clean") Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - addresses review comments received post commit Changes since v2: - add Fixes line - add 4.17 reason --- tools/ocaml/Makefile.rules | 2 +- 1 file

[PATCH for-4.17 v3 06/15] tools/ocaml/Makefile.rules: hide -include on *clean

2022-11-08 Thread Edwin Török
Fixes: 2f2b76d47c5bcd9 ("tools/ocaml: do not run ocamldep during make clean") Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - addresses review comments received post commit Changes since v2: - add Fixes line - add 4.17 reason --- tools/ocaml/Makefile.rules | 4 ++-- 1 file

[linux-5.4 test] 174665: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174665 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are

[libvirt test] 174667: tolerable all pass - PUSHED

2022-11-08 Thread osstest service owner
flight 174667 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174667/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 174643 test-armhf-armhf-libvirt-raw 15

Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Huang Rui
On Tue, Nov 08, 2022 at 09:55:16PM +0800, Roger Pau Monne wrote: > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. > > As such, this needs to be available for PVH dom0 to access, or else > the

[linux-linus test] 174664: regressions - FAIL

2022-11-08 Thread osstest service owner
flight 174664 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-08 Thread Luca Fancellu
> On 8 Nov 2022, at 11:48, Jan Beulich wrote: > > On 08.11.2022 11:59, Luca Fancellu wrote: >>> On 07.11.2022 11:47, Luca Fancellu wrote: +Here is an example to add a new justification in false-positive-.json:: >>> >>> With already present in the name, ... >>> +|{ +|

[PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present

2022-11-08 Thread Roger Pau Monne
The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image from the firmware instead of doing it on the PCI ROM on the physical device. As such, this needs to be available for PVH dom0 to access, or else the GPU won't work. Reported-by: Huang Rui Signed-off-by: Roger Pau Monné ---

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-08 Thread Luca Fancellu
> On 8 Nov 2022, at 11:32, Julien Grall wrote: > > Hi Luca, > > On 08/11/2022 11:00, Luca Fancellu wrote: >>> On 7 Nov 2022, at 19:06, Julien Grall wrote: >>> >>> >>> >>> On 07/11/2022 12:56, Jan Beulich wrote: On 07.11.2022 12:53, Luca Fancellu wrote: >> On 7 Nov 2022, at

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-08 Thread Jan Beulich
On 08.11.2022 11:59, Luca Fancellu wrote: >> On 07.11.2022 11:47, Luca Fancellu wrote: >>> +Here is an example to add a new justification in >>> false-positive-.json:: >> >> With already present in the name, ... >> >>> +|{ >>> +|"version": "1.0", >>> +|"content": [ >>> +|{ >>> +|

[PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains

2022-11-08 Thread Roger Pau Monne
Like on the Arm side, return -EINVAL when attempting to do a p2m operation on dying domains. The current logic returns 0 and leaves the domctl parameter uninitialized for any parameter fetching operations (like the GET_ALLOCATION operation), which is not helpful from a toolstack point of view,

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-08 Thread Julien Grall
Hi Luca, On 08/11/2022 11:00, Luca Fancellu wrote: On 7 Nov 2022, at 19:06, Julien Grall wrote: On 07/11/2022 12:56, Jan Beulich wrote: On 07.11.2022 12:53, Luca Fancellu wrote: On 7 Nov 2022, at 11:49, Jan Beulich wrote: On 07.11.2022 11:47, Luca Fancellu wrote: ---

[PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-11-08 Thread Viresh Kumar
This patch adds basic support for parsing generic Virtio backend. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Signed-off-by: Viresh Kumar --- tools/ocaml/libs/xl/genwrap.py | 1 +

[PATCH V6 3/3] docs: Add documentation for generic virtio devices

2022-11-08 Thread Viresh Kumar
This patch updates xl.cfg man page with details of generic Virtio device related information. Signed-off-by: Viresh Kumar --- docs/man/xl.cfg.5.pod.in | 21 + 1 file changed, 21 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index

[PATCH V6 0/3] Virtio toolstack support for I2C and GPIO on Arm

2022-11-08 Thread Viresh Kumar
Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backend [1]. This is based of

[PATCH V6 1/3] libxl: Add support for generic virtio device

2022-11-08 Thread Viresh Kumar
This patch adds basic support for configuring and assisting generic Virtio backend which could run in any domain. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Also to make this work on Arm, allocate Virtio MMIO params

Re: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic

2022-11-08 Thread Bertrand Marquis
Hi Ayan,, > On 8 Nov 2022, at 09:45, Ayan Kumar Halder wrote: > > From: Ayan Kumar Halder > > Xen provides helper to atomically read/write memory (see {read, > write}_atomic()). Those helpers can only work if the address is aligned > to the size of the access (see B2.2.1 ARM DDI 08476I.a). >

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-08 Thread Luca Fancellu
> On 7 Nov 2022, at 19:06, Julien Grall wrote: > > > > On 07/11/2022 12:56, Jan Beulich wrote: >> On 07.11.2022 12:53, Luca Fancellu wrote: On 7 Nov 2022, at 11:49, Jan Beulich wrote: On 07.11.2022 11:47, Luca Fancellu wrote: > --- a/xen/include/xen/kernel.h > +++

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-08 Thread Luca Fancellu
Hi Jan > > On 07.11.2022 11:47, Luca Fancellu wrote: >> +Here is an example to add a new justification in >> false-positive-.json:: > > With already present in the name, ... > >> +|{ >> +|"version": "1.0", >> +|"content": [ >> +|{ >> +|"id":

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-08 Thread Roger Pau Monné
On Mon, Nov 07, 2022 at 05:58:04PM +0100, Jan Beulich wrote: > On 04.11.2022 17:18, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, > > uint32_t leaf, > >

Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-08 Thread Roger Pau Monné
On Fri, Nov 04, 2022 at 05:35:23PM +, Paul Durrant wrote: > On 04/11/2022 16:10, Roger Pau Monné wrote: > > On Fri, Nov 04, 2022 at 04:05:05PM +, Paul Durrant wrote: > > > On 04/11/2022 16:01, Roger Pau Monné wrote: > > > > On Fri, Nov 04, 2022 at 03:55:54PM +, Paul Durrant wrote: > >

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-08 Thread Ayan Kumar Halder
On 08/11/2022 08:34, Bertrand Marquis wrote: Hi, Hi Julien/Bertrand/Michal, On 8 Nov 2022, at 07:26, Michal Orzel wrote: Hi Julien, On 07/11/2022 19:06, Julien Grall wrote: Hi Ayan, On 07/11/2022 12:49, Ayan Kumar Halder wrote: On 07/11/2022 10:44, Julien Grall wrote: Hi Ayan, Hi

[XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic

2022-11-08 Thread Ayan Kumar Halder
From: Ayan Kumar Halder Xen provides helper to atomically read/write memory (see {read, write}_atomic()). Those helpers can only work if the address is aligned to the size of the access (see B2.2.1 ARM DDI 08476I.a). On Arm32, the alignment is already enforced by the processor because HSCTLR.A

Re: [PATCH v3 0/4] Yocto Gitlab CI

2022-11-08 Thread Michal Orzel
Hi Bertrand, On 08/11/2022 09:42, Bertrand Marquis wrote: > > > Hi Michal, > >> On 7 Nov 2022, at 07:50, Michal Orzel wrote: >> >> Hi Bertrand and Stefano, >> >> On 31/10/2022 16:00, Bertrand Marquis wrote: >>> >>> >>> Hi Michal, >>> On 31 Oct 2022, at 14:39, Michal Orzel wrote:

[xen-unstable test] 174663: tolerable FAIL - PUSHED

2022-11-08 Thread osstest service owner
flight 174663 xen-unstable real [real] flight 174669 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174663/ http://logs.test-lab.xenproject.org/osstest/logs/174669/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH v3 0/4] Yocto Gitlab CI

2022-11-08 Thread Bertrand Marquis
Hi Michal, > On 7 Nov 2022, at 07:50, Michal Orzel wrote: > > Hi Bertrand and Stefano, > > On 31/10/2022 16:00, Bertrand Marquis wrote: >> >> >> Hi Michal, >> >>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>> >>> Hi Bertrand, >>> >>> On 31/10/2022 15:00, Bertrand Marquis wrote:

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-08 Thread Bertrand Marquis
Hi, > On 8 Nov 2022, at 07:26, Michal Orzel wrote: > > Hi Julien, > > On 07/11/2022 19:06, Julien Grall wrote: >> >> >> Hi Ayan, >> >> On 07/11/2022 12:49, Ayan Kumar Halder wrote: >>> >>> On 07/11/2022 10:44, Julien Grall wrote: Hi Ayan, >>> Hi Julien, On 07/11/2022 10:36,

Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction

2022-11-08 Thread Juergen Gross
On 07.11.22 19:37, Julien Grall wrote: On 07/11/2022 08:34, Juergen Gross wrote: On 06.11.22 23:00, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows