flight 178355 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178355/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-i386-xl-shadow 7 xen-install fail in 178260 pass in 178355
test-amd64-i386-xl-vhd 21
flight 178320 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178320/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042
On 2/24/23 23:33, Andrew Cooper wrote:
On 24/02/2023 8:08 pm, Xenia Ragiadakou wrote:
On 2/24/23 21:29, Andrew Cooper wrote:
On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote:
There are more detailed per-patch changesets.
Xenia Ragiadakou (14):
x86/svm: move declarations used only by svm
flight 178391 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178391/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote:
> On 19.02.2023 03:46, Demi Marie Obenour wrote:
> > --- a/stubdom/configure
> > +++ b/stubdom/configure
> > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then :
> > if test "x$extfiles" = "xy"; then :
> >
flight 178315 libvirt real [real]
flight 178389 libvirt real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/178315/
http://logs.test-lab.xenproject.org/osstest/logs/178389/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
On 24/02/2023 8:08 pm, Xenia Ragiadakou wrote:
>
> On 2/24/23 21:29, Andrew Cooper wrote:
>> On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote:
>>> There are more detailed per-patch changesets.
>>>
>>> Xenia Ragiadakou (14):
>>> x86/svm: move declarations used only by svm code from svm.h to
>>>
struct nestedvm uses mostly plain integer types, except for virt_ext_t which
is a union wrapping two bitfield names. But the nested virt logic only ever
deals with it as full opaque register.
Switch it to being a plain uint64_t, allowing us to hide even more of the SVM
internal infrastructure.
On 2/23/23 4:32 AM, Juergen Gross wrote:
+
+ for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) {
+ op.u.read_memtype.reg = reg;
+ if (HYPERVISOR_platform_op())
+ break;
If we fail on the first iteration, do we still want to mark MTRRs are
On 24/02/2023 8:28 pm, Xenia Ragiadakou wrote:
>
> On 2/24/23 22:12, Andrew Cooper wrote:
>> On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote:
>>> diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h
>>> b/xen/arch/x86/hvm/svm/nestedhvm.h
>>> new file mode 100644
>>> index 00..43245e13de
>>> ---
On 2/24/23 22:12, Andrew Cooper wrote:
On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote:
diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h
new file mode 100644
index 00..43245e13de
--- /dev/null
+++ b/xen/arch/x86/hvm/svm/nestedhvm.h
@@ -0,0 +1,77 @@
+/*
flight 178376 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178376/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote:
> diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h
> b/xen/arch/x86/hvm/svm/nestedhvm.h
> new file mode 100644
> index 00..43245e13de
> --- /dev/null
> +++ b/xen/arch/x86/hvm/svm/nestedhvm.h
> @@ -0,0 +1,77 @@
> +/* SPDX-License-Identifier:
On 2/24/23 21:29, Andrew Cooper wrote:
On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote:
There are more detailed per-patch changesets.
Xenia Ragiadakou (14):
x86/svm: move declarations used only by svm code from svm.h to private
header
x86/svm: make asid.h private
x86/svm: delete
On 2/24/23 21:58, Andrew Cooper wrote:
These days, this is just two length helpers. Move into the private svm.h
No functional change intended.
Signed-off-by: Andrew Cooper
Reviewed-by: Xenia Ragiadakou
--
Xenia
On 2/24/23 21:42, Andrew Cooper wrote:
Fold svm_asid_g_invlpg() into its single caller, deleting the #if 0 which has
been present for the entire 16 years this helper has existed: c/s 322a078ab140
"[HVM][SVM] Reintroduce ASIDs."
Move the two remaining prototypes into the private svm.h, forward
These days, this is just two length helpers. Move into the private svm.h
No functional change intended.
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Xenia Ragiadakou
---
xen/arch/x86/hvm/svm/emulate.c | 3 +-
xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote:
> The header asm/hvm/svm/emulate.h is used only internally by the SVM code,
> so it can be changed into a private header.
>
> Take the opportunity to use an SPDX tag for the licence.
>
> No functional change intended.
>
> Signed-off-by: Xenia
Fold svm_asid_g_invlpg() into its single caller, deleting the #if 0 which has
been present for the entire 16 years this helper has existed: c/s 322a078ab140
"[HVM][SVM] Reintroduce ASIDs."
Move the two remaining prototypes into the private svm.h, forward declaring
cpuinfo_x86 in preference to
On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote:
> There are more detailed per-patch changesets.
>
> Xenia Ragiadakou (14):
> x86/svm: move declarations used only by svm code from svm.h to private
> header
> x86/svm: make asid.h private
> x86/svm: delete header asm/hvm/svm/intr.h
Thankyou
Do not include the headers:
asm/hvm/vpic.h
asm/hvm/vpt.h
asm/io.h
asm/mce.h
asm/mem_sharing.h
asm/regs.h
public/arch-x86/cpuid.h
public/hvm/save.h
because none of the declarations and macro definitions in them is used.
Sort the rest of the headers alphabetically.
No functional
Create a new private header in arch/x86/hvm/vmx called vmcs.h and move
there all definitions and declarations that are used only by vmx code and
don't need to reside in an external header.
Take the opportunity to replace u* with uint*_t, bool_t with bool and to
re-arrange the header as follows,
Create a new private header in arch/x86/hvm/vmx called vvmx.h and move
there all definitions and declarations that are used only by vmx code and
don't need to reside in an external header.
Take the opportunity to replace u* with uint*_t, bool_t with bool and to
re-arrange the header as follows,
Create two new private headers in arch/x86/hvm/vmx called vmx.h and pi.h.
Move all the definitions and declarations that are used solely by vmx code
into the private vmx.h, apart from the ones related to posted interrupts that
are moved into pi.h.
EPT related declarations and definitions stay in
Create a new private header in arch/x86/hvm/svm called vmcb.h and move
there all definitions and declarations that are used only by svm code and
don't need to reside in an external header.
Take the opportunity to replace u* with uint*_t and remove redundant blank
lines.
No functional change
Reduce the scope of nvmx_enqueue_n2_exceptions() to static because it is used
only in this file.
Take the opportunity to remove a trailing space.
Signed-off-by: Xenia Ragiadakou
Reviewed-by: Jan Beulich
---
Changes in v3:
- add Jan's R-b tag
xen/arch/x86/hvm/vmx/vmx.c | 2 +-
1 file
Do not include the headers:
asm/i387.h
asm/hvm/trace.h
asm/processor.h
asm/regs.h
because none of the declarations and macro definitions in them is used in
this file. Sort the rest of the headers alphabetically.
Include asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy().
Take the
Move vmx_update_debug_state() in vmcs.c because it is used only in this
file and limit its scope to this file by declaring it static and removing
its declaration from vmx.h.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
- apply the change before moving the
Create a new private header in arch/x86/hvm/svm called nestedsvm.h and move
there all definitions and declarations that are used only by svm code and
don't need to reside in an external header.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
- new patch
Move the declarations in svmdebug.h to private vmcb.h because are vmcb
specific and are used only by internal svm code, and delete svmdebug.h.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
- new patch, suggested by Andrew
xen/arch/x86/hvm/svm/nestedsvm.c
Delete asm/hvm/svm/intr.h because it contains only the declaration of
svm_intr_assist() which is referenced only by assembly.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
- new patch, suggested by Andrew
xen/arch/x86/hvm/svm/intr.c | 1 -
The header asm/hvm/svm/emulate.h is used only internally by the SVM code,
so it can be changed into a private header.
Take the opportunity to use an SPDX tag for the licence.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
- new patch
The asm/hvm/svm/asid.h is used only internally by the SVM code, so it can be
changed into a private header.
Take the opportunity to use an SPDX tag for the licence and remove included
but unused xen/types.h.
No functional change intended.
Signed-off-by: Xenia Ragiadakou
---
Changes in v3:
-
Create a new private header in arch/x86/hvm/svm called svm.h and move there
all definitions and declarations that are used solely by svm code.
Take the opportunity to remove the forward declaration of struct vcpu, that is
a leftover since the removal of svm_update_guest_cr()'s declaration.
Take
This patch series attempts a cleanup of files {svm,vmx} files and headers
by removing redundant headers and sorting the rest, reducing the scope of
declarations and definitions, moving functions used only by internal {svm,vmx}
code to private headers, fix coding style, replace u* with uint*_t
On 24/02/2023 6:12 pm, Anthony PERARD wrote:
> On Fri, Feb 24, 2023 at 05:37:44PM +, Andrew Cooper wrote:
>> On 24/02/2023 5:29 pm, Anthony PERARD wrote:
>>> Patch series available in this git branch:
>>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
>>>
Viresh Kumar writes:
> The current model of memory mapping at the back-end works fine with
> Qemu, where a standard call to mmap() for the respective file
> descriptor, passed from front-end, is generally all we need to do before
> the front-end can start accessing the guest memory.
>
> There
On Fri, Feb 24, 2023 at 05:37:44PM +, Andrew Cooper wrote:
> On 24/02/2023 5:29 pm, Anthony PERARD wrote:
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> > br.gitlab-containers-update-v3
> >
> > v3:
> > - new patch which
flight 178275 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178275/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-i386-xsmbroken
build-arm64
flight 178273 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/178273/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174677
On 24/02/2023 5:29 pm, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> br.gitlab-containers-update-v3
>
> v3:
> - new patch which remove non-debug x86_32 builds
> - don't fix root certificates in jessie
In the interest of having less jobs, we remove the x86_32 build jobs
that do release build. Debug build is very likely to be enough to find
32bit build issues.
Signed-off-by: Anthony PERARD
---
Notes:
v3:
- new patch
Proposed here:
While the Let's Encrypt root certificate ISRG_Root_X1.crt is already
present, openssl seems to still check for the root certificate
DST_Root_CA_X3.crt which has expired. This prevent https connections.
Removing DST_Root_CA_X3 fix the issue.
Signed-off-by: Anthony PERARD
---
Notes:
v3:
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
br.gitlab-containers-update-v3
v3:
- new patch which remove non-debug x86_32 builds
- don't fix root certificates in jessie containers as those won't be used
anymore on the main branch.
As Jessie is EOL, the official tag isn't supported anymore. Also, the
GPG key for the packages on the repository on the official image are
expired and it isn't possible to update or install packages.
But we can use the image from "debian/eol" tag which use repositories
from archive.debian.org and
Jessie as rearch EOL in 2020.
Even if we update the containers, we would still not be able to reach
HTTPS webside with Let's Encrypt certificates and thus would need more
change to the container.
Signed-off-by: Anthony PERARD
---
Notes:
While we remove some x86_32 testing, there's still
2023-02-24 Report minutes Xen Gitlab Issues review meeting:
https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/
For next Week 2023-03-03 14 :00 UTC :
https://cryptpad.fr/pad/#/2/pad/edit/GBcZpfFD5WELm7mdE2C-anKD/
and https://meet.jit.si/XenIssuesReview
Marc Ungeschikts
On 24/02/2023 2:48 pm, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko
> ---
> xen/arch/riscv/setup.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index 154bf3a0bc..593bb471a4 100644
> ---
Looks good to me.
Thanks.
Reviewed-by: Oleksii Kurochko
~ Oleksii
On Fri, 2023-02-24 at 15:37 +, Andrew Cooper wrote:
> Use a single fairly generic string as the "all done" message to look
> for,
> which avoids the need to patch qemu-smoke-riscv64.sh each time a new
> feature
> is added.
On Fri, 2023-02-24 at 15:27 +, Andrew Cooper wrote:
> On 24/02/2023 3:06 pm, Oleksii Kurochko wrote:
> > The smoke test was updated to verify that MMU has been enabled.
> >
> > Signed-off-by: Oleksii Kurochko
> > ---
> > automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> > 1 file changed, 1
On Fri, 2023-02-24 at 15:56 +0100, Jan Beulich wrote:
> On 24.02.2023 15:48, Oleksii Kurochko wrote:
> > --- a/xen/arch/riscv/setup.c
> > +++ b/xen/arch/riscv/setup.c
> > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void)
> > early_printk("WARN is most likely working\n");
> > }
> >
On 23/01/2023 2:27 pm, Jan Beulich wrote:
> The shadow_mode_refcounts() check immediately ahead of the "emulate"
> label renders redundant two subsequent is_hvm_domain() checks (the
> latter of which was already redundant with the former).
>
> Also guest_mode() checks are pointless when we already
On 23/01/2023 2:27 pm, Jan Beulich wrote:
> The types p2m_is_readonly() checks for aren't applicable to PV;
> specifically get_gfn() won't ever return any such type for PV domains.
> Extend the HVM-conditional block of code, also past the subsequent HVM-
> only if(). This way the
On 23/01/2023 3:08 pm, Jan Beulich wrote:
> On 23.01.2023 15:26, Jan Beulich wrote:
>> Do away with the partly mis-named "mmio" label there, which really is
>> only about emulated MMIO. Move the code to the place where the sole
>> "goto" was. Re-order steps slightly: Assertion first, perfc
On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote:
> On 24.02.2023 15:48, Oleksii Kurochko wrote:
> > Signed-off-by: Oleksii Kurochko
> > ---
> > xen/arch/riscv/setup.c | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/xen/arch/riscv/setup.c
On 20/02/2023 11:51 am, Ross Lagerwall wrote:
>> From: Andrew Cooper
>> Sent: Monday, February 20, 2023 11:04 AM
>> To: Xen-devel
>> Cc: Andrew Cooper ; Jan Beulich
>> ; Roger Pau Monne ; Wei Liu
>> ; Konrad Rzeszutek Wilk ; Ross
>> Lagerwall
>> Subject: [PATCH] x86/asm: ELF metadata for
On 24.02.23 17:01, Julien Grall wrote:
Hi Juergen,
On 24/02/2023 16:00, Juergen Gross wrote:
On 24.02.23 16:00, Julien Grall wrote:
Hi Juergen,
For some internal purpose, I need to write a script that would do the following:
1) Start a transaction
2) Call GET_PERMS
3) Call
Hi Juergen,
On 24/02/2023 16:00, Juergen Gross wrote:
On 24.02.23 16:00, Julien Grall wrote:
Hi Juergen,
For some internal purpose, I need to write a script that would do the
following:
1) Start a transaction
2) Call GET_PERMS
3) Call SET_PERMS with the permission just retrieved
On 24.02.23 16:00, Julien Grall wrote:
Hi Juergen,
For some internal purpose, I need to write a script that would do the following:
1) Start a transaction
2) Call GET_PERMS
3) Call SET_PERMS with the permission just retrieved
4) Commit the transaction
(Don't ask why :))
This was
Today when finalizing a transaction the number of node quota is checked
to not being exceeded after the transaction. This check is always done,
even if the transaction is being performed by a privileged connection,
or if there were no nodes created in the transaction.
Correct that by checking
On Tue, Feb 21, 2023 at 06:01:19PM +, Andrew Cooper wrote:
> On 21/02/2023 5:59 pm, Andrew Cooper wrote:
> > On 21/02/2023 4:55 pm, Anthony PERARD wrote:
> >> Jessie as rearch EOL in 2020.
> >>
> >> Even if we update the containers, we would still not be able to reach
> >> HTTPS webside with
Use a single fairly generic string as the "all done" message to look for,
which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature
is added.
Signed-off-by: Andrew Cooper
---
CC: Oleksii Kurochko
CC: Bob Eshleman
CC: Alistair Francis
CC: Connor Davis
CC: Anthony PERARD
From: Oleksandr Tyshchenko
The "vdev->dev.parent" should be used instead of "vdev->dev" as a device
for which to perform the DMA operation in both
virtio_gpu_cmd_transfer_to_host_2d(3d).
Because the virtio-gpu device "vdev->dev" doesn't really have DMA OPS
assigned to it, but parent (virtio-pci
Hello Andrew and thanks for the comments,
On Thu, Feb 23, 2023 at 04:01:09PM +, Andrew Cooper wrote:
> On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote:
>
> A couple of observations, all unrelated to the stats themselves.
>
> Although overall, I'm not entirely certain that a tool
On 24/02/2023 3:06 pm, Oleksii Kurochko wrote:
> The smoke test was updated to verify that MMU has been enabled.
>
> Signed-off-by: Oleksii Kurochko
> ---
> automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
HI Jens,
> On 22 Feb 2023, at 16:33, Jens Wiklander wrote:
>
> Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A
> mediator.
>
> Signed-off-by: Jens Wiklander
NIT: I would s/note/enforce/ in the title:
xen/arm: ffa: enforce 4k pages
Reviewed-by: Bertrand Marquis
On 24/02/2023 3:06 pm, Oleksii Kurochko wrote:
> diff --git a/xen/arch/riscv/include/asm/page.h
> b/xen/arch/riscv/include/asm/page.h
> new file mode 100644
> index 00..fabbe1305f
> --- /dev/null
> +++ b/xen/arch/riscv/include/asm/page.h
> @@ -0,0 +1,90 @@
> +#ifndef _ASM_RISCV_PAGE_H
>
On Fri, 2023-02-24 at 17:06 +0200, Oleksii Kurochko wrote:
> The patch series introduces the following things:
> 1. Functionality to build the page tables for Xen that map the
> following:
> * The physical location of Xen (where the bootloader loaded it)
> * The link-time location of
On 24.02.23 16:00, Julien Grall wrote:
Hi Juergen,
For some internal purpose, I need to write a script that would do the following:
1) Start a transaction
2) Call GET_PERMS
3) Call SET_PERMS with the permission just retrieved
4) Commit the transaction
(Don't ask why :))
This was
On 24.02.2023 15:48, Oleksii Kurochko wrote:
> Disable FPU to detect illegal usage of floating point in kernel
> space.
>
> Signed-off-by: Oleksii Kurochko
> ---
> xen/arch/riscv/setup.c | 7 +++
> 1 file changed, 7 insertions(+)
This looks to contextually depend on earlier individually
Calculate load and linker linker image addresses and
setup initial pagetables.
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/setup.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index b7cd438a1d..f69bc278bb 100644
---
Mostly the code for setup_initial_pages was taken from Bobby's
repo except for the following changes:
* Use only a minimal part of the code enough to enable MMU
* rename {_}setup_initial_pagetables functions
* add writable argument for _setup_initial_pagetables to have
an opportunity to make
The patch series introduces the following things:
1. Functionality to build the page tables for Xen that map the
following:
* The physical location of Xen (where the bootloader loaded it)
* The link-time location of Xen (where the linker expected Xen's
addresses to be.
2. Load
The smoke test was updated to verify that MMU has been enabled.
Signed-off-by: Oleksii Kurochko
---
automation/scripts/qemu-smoke-riscv64.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/automation/scripts/qemu-smoke-riscv64.sh
b/automation/scripts/qemu-smoke-riscv64.sh
On 24.02.2023 15:48, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko
> ---
> xen/arch/riscv/setup.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index b3f8b10f71..154bf3a0bc 100644
> ---
On 24/02/2023 1:36 pm, Edwin Török wrote:
> From: Edwin Török
>
> From `man 2 realloc`:
> `If realloc() fails, the original block is left untouched; it is not freed or
> moved.`
>
> Found using GCC -fanalyzer:
> ```
> | 184 | backup->entries = realloc(backup->entries,
> | |
Hi Juergen,
For some internal purpose, I need to write a script that would do the
following:
1) Start a transaction
2) Call GET_PERMS
3) Call SET_PERMS with the permission just retrieved
4) Commit the transaction
(Don't ask why :))
This was executed from dom0 on every nodes. In some
On 24.02.2023 15:56, Jan Beulich wrote:
> On 24.02.2023 15:48, Oleksii Kurochko wrote:
>> +char *bss = &__bss_start;
>> +
>> +while ( bss < &__bss_end ) {
>> +*bss = 0;
>> +bss++;
>> +}
>> +}
>
> If you're sure you can defer this until being in C code, why not use
>
On 24/02/2023 1:36 pm, Edwin Török wrote:
> From: Edwin Török
>
> Prior to bd7a29c3d0 'out' would've always been executed and memory
> freed, but that commit changed it such that it returns early and leaks.
>
> Found using gcc 12.2.1 `-fanalyzer`:
> ```
> xg_core_x86.c: In function
On 24.02.2023 15:48, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void)
> early_printk("WARN is most likely working\n");
> }
>
> +static void __init init_bss(void)
> +{
> +extern char
Disable FPU to detect illegal usage of floating point in kernel
space.
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/setup.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index 593bb471a4..b7cd438a1d 100644
---
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/setup.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index 154bf3a0bc..593bb471a4 100644
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -24,6 +24,18 @@ static
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/setup.c | 12
1 file changed, 12 insertions(+)
diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index b3f8b10f71..154bf3a0bc 100644
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -26,6 +26,18 @@ static
From: Edwin Török
Using GCC 12.2.1 with -fanalyzer it has shown some memory leaks:
This is how I enabled -fanalyzer (adding it to CFLAGS for toplevel
configure didn't seem to work):
```
CFLAGS += $(call cc-option,$(CC),-fanalyzer)
```
Note that there are more errors shown than fixed here, but
From: Edwin Török
Prior to bd7a29c3d0 'out' would've always been executed and memory
freed, but that commit changed it such that it returns early and leaks.
Found using gcc 12.2.1 `-fanalyzer`:
```
xg_core_x86.c: In function ‘xc_core_arch_map_p2m_tree_rw’:
xg_core_x86.c:300:5: error: leak of
From: Edwin Török
>From `man 2 realloc`:
`If realloc() fails, the original block is left untouched; it is not freed or
moved.`
Found using GCC -fanalyzer:
```
| 184 | backup->entries = realloc(backup->entries,
| | ~~
| |
Hi Bertrand,
On Fri, Feb 24, 2023 at 10:30 AM Bertrand Marquis
wrote:
>
> Hi Jens,
>
> > On 22 Feb 2023, at 16:33, Jens Wiklander wrote:
> >
> > Defines flags used for the function FFA_PARTITION_INFO_GET.
> >
> > Signed-off-by: Jens Wiklander
> > ---
> > xen/arch/arm/tee/ffa.c | 26
flight 178260 xen-unstable real [real]
flight 178348 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/178260/
http://logs.test-lab.xenproject.org/osstest/logs/178348/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
On 24/02/2023 7:14 am, Jan Beulich wrote:
> On 23.02.2023 21:36, Andrew Cooper wrote:
>> https://github.com/llvm/llvm-project/issues/60792
>>
>> It turns out that Clang-IAS does not expand \@ uniquely in a translaition
>> unit, and the XSA-426 change tickles this bug:
>>
>> :4:1: error: invalid
Hi Stefano,
>> Hi Jan,
>>
>> my personal opinion is that we can’t handle them for files that needs to be
>> kept
>> in sync from an external source, because we can’t justify findings or tag
>> false
>> positives, if we are lucky we might fix the non compliances but even in that
>> case
>>
The patch modifies the grep pattern to reflect the usage of WARN.
Signed-off-by: Oleksii Kurochko
Reviewed-by: Alistair Francis
Acked-by: Stefano Stabellini
---
Changes in V4:
- Add Reviewed-by: Alistair Francis
and Acked-by: Stefano Stabellini
---
Changes in V3:
- Update commit message
The patch introduces macros: BUG(), WARN(), run_in_exception(),
assert_failed.
The implementation uses "ebreak" instruction in combination with
diffrent bug frame tables (for each type) which contains useful
information.
Signed-off-by: Oleksii Kurochko
---
Changes in V4:
- Updates in RISC-V's
The patch introduces stuff needed to decode a reason of an
exception.
Signed-off-by: Oleksii Kurochko
---
Changes in V4:
- fix string in decode_reserved_interrupt_cause()
---
Changes in V3:
- Nothing changed
---
Changes in V2:
- Make decode_trap_cause() more optimization friendly.
-
Signed-off-by: Oleksii Kurochko
Acked-by: Alistair Francis
---
Changes in V4:
- Add Acked-by: Alistair Francis
---
Changes in V3:
- Nothing changed
---
Changes in V2:
- Nothing changed
---
xen/arch/riscv/setup.c | 16
1 file changed, 16 insertions(+)
diff --git
Signed-off-by: Oleksii Kurochko
Reviewed-by: Alistair Francis
---
Changes in V4:
- Nothing changed
---
Changes in V3:
- Nothing changed
---
Changes in V2:
- Rename setup_trap_handler() to trap_init().
- Add Reviewed-by to the commit message.
---
xen/arch/riscv/include/asm/traps.h | 1 +
The patch series is based on [introduce generic implementation
of macros from bug.h] which hasn't been commited yet.
The patch series provides a basic implementation of exception handling.
It can do only basic things such as decode a cause of an exception,
save/restore registers and execute "wfi"
Since the generic version of bug.h stuff was introduced use
instead of unnecessary
Signed-off-by: Oleksii Kurochko
---
Changes in V3:
* Update patch 2 not to break compilation: move some parts from patches 3 and 4
to patch 2:
* move some generic parts from to
* add define
The following changes were made:
* Make GENERIC_BUG_FRAME mandatory for X86
* Update asm/bug.h using generic implementation in
* Change prototype of debugger_trap_fatal() in asm/debugger.h
to align it with generic prototype in .
* Update do_invalid_op using generic do_bug_frame()
A large part of the content of the bug.h is repeated among all
architectures, so it was decided to create a new config
CONFIG_GENERIC_BUG_FRAME.
The version of from x86 was taken as the base version.
The patch introduces the following stuff:
* common bug.h header
* generic implementation of
The following changes were made:
* make GENERIC_BUG_FRAME mandatory for ARM
* As do_bug_frame() returns -EINVAL in case something goes wrong
otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was
updated to check if the returned value is less than 0
* Change macros bug_file()
1 - 100 of 119 matches
Mail list logo
