[PATCH v6 0/4] [PATCH v5 0/4] introduce generic implementation of macros from bug.h

2023-03-07 Thread Oleksii Kurochko
A large part of the content of the bug.h is repeated among all architectures (especially x86 and RISCV have the same implementation), so it was created a new config CONFIG_GENERIC_BUG_FRAME which is used to introduce generic implementation of do_bug_frame() and move x86's to with the following

Re: [RFC PATCH v1 20/25] hw/xen: Hook up emulated implementation for event channel operations

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse We provided the backend-facing evtchn functions very early on as part of the core Xen platform support, since things like timers and xenstore need to use them. By what may or may not be an astonishing coincidence, those

Re: [RFC PATCH v1 19/25] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Whem emulating Xen, multi-page grants are distinctly non-trivial and we have elected not to support them for the time being. Don't advertise them to the guest. Signed-off-by: David Woodhouse --- hw/block/xen-block.c | 11

[linux-linus test] 179473: regressions - trouble: blocked/fail/pass/starved

2023-03-07 Thread osstest service owner
flight 179473 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179473/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 178042

Re: [RFC PATCH v1 18/25] hw/xen: Avoid crash when backend watch fires too early

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant The xen-block code ends up calling aio_poll() through blkconf_geometry(), which means we see watch events during the indirect call to xendev_class->realize() in xen_device_realize(). Unfortunately this call is made before

Re: [RFC PATCH v1 17/25] hw/xen: Build PV backend drivers for CONFIG_XEN_BUS

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Now that we have the redirectable Xen backend operations we can build the PV backends even without the Xen libraries. Signed-off-by: David Woodhouse --- hw/9pfs/meson.build| 2 +- hw/block/dataplane/meson.build

Re: [PATCH v1 2/2] arch/arm: time: Add support for parsing interrupts by names

2023-03-07 Thread Bertrand Marquis
Hi Andrei, > On 7 Mar 2023, at 11:09, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > Added support for parsing the ARM generic timer interrupts DT > node by the "interrupt-names" property, if it is available. > > If not available, the usual parsing based on the expected >

[xen-unstable test] 179451: tolerable trouble: fail/pass/starved

2023-03-07 Thread osstest service owner
flight 179451 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179451/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 179392

Re: [PATCH v1 1/2] arch/arm: irq: Add platform_get_irq_byname() implementation

2023-03-07 Thread Bertrand Marquis
Hi Andrei, > On 7 Mar 2023, at 11:09, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > Moved implementation for the function which parses the IRQs of a DT > node by the "interrupt-names" property from the SMMU-v3 driver > to the IRQ core code and made it non-static to be used

Re: [PATCH v1 0/2] Fix ARM Generic Timer interrupt parsing

2023-03-07 Thread Bertrand Marquis
Hi Andrei, When submitting patches, please use the add_maintainer.pl script so that maintainers of the code modified are added in CC. > On 7 Mar 2023, at 11:09, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > This 2-patch series fixes the parsing of the ARM Generic Timer >

Re: [PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-07 Thread Marek Marczykowski-Górecki
On Mon, Mar 06, 2023 at 03:02:51PM -0800, Stefano Stabellini wrote: > On Mon, 6 Mar 2023, Andrew Cooper wrote: > > On 03/03/2023 11:57 pm, Stefano Stabellini wrote: > > > + only: > > > +variables: > > > + - $XILINX_JOBS == "true" && $CI_COMMIT_REF_PROTECTED == "true" > > > > We don't

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Jan Beulich
On 07.03.2023 16:02, Juergen Gross wrote: > On 07.03.23 15:34, Jan Beulich wrote: >> On 07.03.2023 15:23, Juergen Gross wrote: >>> On 07.03.23 15:18, Jan Beulich wrote: On 07.03.2023 15:04, Juergen Gross wrote: > On 07.03.23 11:41, Jan Beulich wrote: >> On 07.03.2023 07:32, Juergen

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Juergen Gross
On 07.03.23 15:34, Jan Beulich wrote: On 07.03.2023 15:23, Juergen Gross wrote: On 07.03.23 15:18, Jan Beulich wrote: On 07.03.2023 15:04, Juergen Gross wrote: On 07.03.23 11:41, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@

Re: [RFC PATCH v1 16/25] hw/xen: Rename xen_common.h to xen_native.h

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse This header is now only for native Xen code, not PV backends that may be used in Xen emulation. Since the toolstack libraries may depend on the specific version of Xen headers that they pull in (and will set the __XEN_TOOLS__

Re: [RFC PATCH v1 13/25] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 07/03/2023 14:52, David Woodhouse wrote: On Tue, 2023-03-07 at 14:44 +, Paul Durrant wrote: On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- Reviewed-by: Paul Durrant You're reviewing your own code on

Re: [RFC PATCH v1 12/25] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 07/03/2023 14:48, David Woodhouse wrote: On Tue, 2023-03-07 at 14:40 +, Paul Durrant wrote: - -#define xenforeignmemory_unmap(h, p, s) munmap(p, s * XC_PAGE_SIZE) - Actually, probably best 'static inline' that, or at least put brackets round the 'p' and 's' for safety. That's the

Re: [RFC PATCH v1 13/25] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 14:44 +, Paul Durrant wrote: > On 02/03/2023 15:34, David Woodhouse wrote: > > From: Paul Durrant > > > > Signed-off-by: Paul Durrant > > Signed-off-by: David Woodhouse > > --- > > Reviewed-by: Paul Durrant You're reviewing your own code on some of those... :) Do

Re: [RFC PATCH v1 12/25] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 14:40 +, Paul Durrant wrote: > > > - > > -#define xenforeignmemory_unmap(h, p, s) munmap(p, s * XC_PAGE_SIZE) > > - > > Actually, probably best 'static inline' that, or at least put brackets > round the 'p' and 's' for safety. > That's the one we're *removing* :) >

Re: [RFC PATCH v1 15/25] hw/xen: Use XEN_PAGE_SIZE in PV backend drivers

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse XC_PAGE_SIZE comes from the actual Xen libraries, while XEN_PAGE_SIZE is provided by QEMU itself in xen_backend_ops.h. For backends which may be built for emulation mode, use the latter. Signed-off-by: David Woodhouse ---

Re: [RFC PATCH v1 14/25] hw/xen: Move xenstore_store_pv_console_info to xen_console.c

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse There's no need for this to be in the Xen accel code, and as we want to use the Xen console support with KVM-emulated Xen we'll want to have a platform-agnostic version of it. Make it use GString to build up the path while we're

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-03-07 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 23, 2023 at 01:42:08PM +0100, Jan Beulich wrote: > On 23.02.2023 13:16, Matias Ezequiel Vara Larsen wrote: > > On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan Beulich wrote: > >> On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > >>> On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan

Re: [RFC PATCH v1 13/25] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- accel/xen/xen-all.c | 11 +- hw/char/xen_console.c | 2 +- hw/i386/kvm/xen_xenstore.c | 3 -

Re: [RFC PATCH v1 12/25] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Paul Durrant --- hw/char/xen_console.c| 8 +++--- hw/display/xenfb.c | 20 +++--- hw/xen/xen-operations.c | 45

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Jan Beulich
On 07.03.2023 15:23, Juergen Gross wrote: > On 07.03.23 15:18, Jan Beulich wrote: >> On 07.03.2023 15:04, Juergen Gross wrote: >>> On 07.03.23 11:41, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -15,8 +15,11

Re: [RFC PATCH v1 11/25] hw/xen: Pass grant ref to gnttab unmap operation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse The previous commit introduced redirectable gnttab operations fairly much like-for-like, with the exception of the extra arguments to the ->open() call which were always NULL/0 anyway. This *changes* the arguments to the

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Juergen Gross
On 07.03.23 15:18, Jan Beulich wrote: On 07.03.2023 15:04, Juergen Gross wrote: On 07.03.23 11:41, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,8 +15,11 @@ config DEBUG_INFO bool "Compile Xen with debug info"

Re: [RFC PATCH v1 10/25] hw/xen: Add gnttab operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Move the existing code using libxengnttab to xen-operations.c and allow the operations to be redirected so that we can add emulation of grant table mapping for backend drivers. In emulation, mapping more than one grant ref to

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Jan Beulich
On 07.03.2023 15:04, Juergen Gross wrote: > On 07.03.23 11:41, Jan Beulich wrote: >> On 07.03.2023 07:32, Juergen Gross wrote: >>> --- a/xen/Kconfig.debug >>> +++ b/xen/Kconfig.debug >>> @@ -15,8 +15,11 @@ config DEBUG_INFO >>> bool "Compile Xen with debug info" >>> default DEBUG >>>

Re: [PATCH v6 20/20] irqdomain: Switch to per-domain locking

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 15:06 +0100, Juergen Gross wrote: > On 07.03.23 14:51, David Woodhouse wrote: > > On Mon, 2023-02-13 at 11:43 +0100, Johan Hovold wrote: > > > The IRQ domain structures are currently protected by the global > > > irq_domain_mutex. Switch to using more fine-grained per-domain

Re: [PATCH v6 20/20] irqdomain: Switch to per-domain locking

2023-03-07 Thread Juergen Gross
On 07.03.23 14:51, David Woodhouse wrote: On Mon, 2023-02-13 at 11:43 +0100, Johan Hovold wrote: The IRQ domain structures are currently protected by the global irq_domain_mutex. Switch to using more fine-grained per-domain locking, which can speed up parallel probing by reducing lock

Re: [RFC PATCH v1 09/25] hw/xen: Add evtchn operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse The existing implementation calling into the real libxenevtchn moves to a new file hw/xen/xen-operations.c, and is called via a function table which in a subsequent commit will also be able to invoke the emulated event channel

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Juergen Gross
On 07.03.23 11:41, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,8 +15,11 @@ config DEBUG_INFO bool "Compile Xen with debug info" default DEBUG ---help--- - If you say Y here the resulting Xen

Re: [RFC PATCH v1 08/25] hw/xen: Create initial XenStore nodes

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 70 ++ 1 file changed, 70 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH v6 20/20] irqdomain: Switch to per-domain locking

2023-03-07 Thread David Woodhouse
On Mon, 2023-02-13 at 11:43 +0100, Johan Hovold wrote: > The IRQ domain structures are currently protected by the global > irq_domain_mutex. Switch to using more fine-grained per-domain locking, > which can speed up parallel probing by reducing lock contention. > > On a recent arm64 laptop, the

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that. Yes. Assuming backends have properly implemented

[ovmf test] 179496: all pass - PUSHED

2023-03-07 Thread osstest service owner
flight 179496 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179496/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aa1cd447b346e8cc8141df2fe2d321b032c08acb baseline version: ovmf

Re: [RFC PATCH v1 06/25] hw/xen: Implement XenStore permissions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Store perms as a GList of strings, check permissions. Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 259 +---

Re: [RFC PATCH v1 05/25] hw/xen: Watches on XenStore transactions

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 13:32 +, Paul Durrant wrote: > > Reviewed-by: Paul Durrant > > ... with a couple of nits in comments called out below... Thanks, I'm fixing these and pushing them out to my tree at https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv (and

Re: [PATCH v5 4/4] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-07 Thread Oleksii
On Tue, 2023-03-07 at 13:59 +0100, Jan Beulich wrote: > On 07.03.2023 13:52, Oleksii wrote: > > On Mon, 2023-03-06 at 11:36 +0100, Jan Beulich wrote: > > > On 03.03.2023 11:38, Oleksii Kurochko wrote: > > > > --- a/xen/arch/x86/include/asm/bug.h > > > > +++ b/xen/arch/x86/include/asm/bug.h > > > >

Re: [RFC PATCH v1 05/25] hw/xen: Watches on XenStore transactions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Firing watches on the nodes that still exist is relatively easy; just walk the tree and look at the nodes with refcount of one. Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' and 'deleted_in_tx' flags to

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Oleksii
On Tue, 2023-03-07 at 14:16 +0100, Jan Beulich wrote: > On 07.03.2023 14:13, Oleksii wrote: > > > > > > > + > > > > > > > +#define BUG_FRAME(type, line, ptr, second_frame, msg) do > > > > > > > {   \ > > > > > > > +    BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + > > > > > > >

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Jan Beulich
On 07.03.2023 14:13, Oleksii wrote: >> + >> +#define BUG_FRAME(type, line, ptr, second_frame, msg) do >> {   \ >> +    BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + >> BUG_LINE_HI_WIDTH)); \ >> +    BUILD_BUG_ON((type) >= >> BUGFRAME_NR);   

Re: [RFC PATCH v1 04/25] hw/xen: Implement XenStore transactions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Given that the whole thing supported copy on write from the beginning, transactions end up being fairly simple. On starting a transaction, just take a ref of the existing root; swap it back in on a successful commit. The main

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Oleksii
> > > > > + > > > > > +#define BUG_FRAME(type, line, ptr, second_frame, msg) do > > > > > {   \ > > > > > +    BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + > > > > > BUG_LINE_HI_WIDTH)); \ > > > > > +    BUILD_BUG_ON((type) >= > > > > > BUGFRAME_NR);  

Re: [PATCH v5 4/4] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-07 Thread Jan Beulich
On 07.03.2023 13:52, Oleksii wrote: > On Mon, 2023-03-06 at 11:36 +0100, Jan Beulich wrote: >> On 03.03.2023 11:38, Oleksii Kurochko wrote: >>> --- a/xen/arch/x86/include/asm/bug.h >>> +++ b/xen/arch/x86/include/asm/bug.h >>> @@ -1,79 +1,12 @@ >>>  #ifndef __X86_BUG_H__ >>>  #define __X86_BUG_H__

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Jan Beulich
On 07.03.2023 12:32, Oleksii wrote: > On Mon, 2023-03-06 at 11:17 +0100, Jan Beulich wrote: >>> On 03.03.2023 11:38, Oleksii Kurochko wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL >  config ARCH_MAP_DOMAIN_PAGE >    

Re: [PATCH v5 4/4] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-07 Thread Oleksii
On Mon, 2023-03-06 at 11:36 +0100, Jan Beulich wrote: > On 03.03.2023 11:38, Oleksii Kurochko wrote: > > The following changes were made: > > * Make GENERIC_BUG_FRAME mandatory for X86 > > * Update asm/bug.h using generic implementation in > > * Change prototype of debugger_trap_fatal() in

Re: [PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-07 Thread Jan Beulich
On 07.03.2023 13:04, Juergen Gross wrote: > On 07.03.23 12:42, Jan Beulich wrote: >> On 07.03.2023 12:33, Juergen Gross wrote: >>> On 07.03.23 11:31, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: > Using a rather oldish gcc (7.5) it was verified that code generation >

Re: [RFC PATCH v1 03/25] hw/xen: Implement XenStore watches

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 11:29 +, Paul Durrant wrote: > > I think you could stash a tail pointer here... > > > +    } > > + > > +    if (dom_id && s->nr_domu_watches >= XS_MAX_WATCHES) { > > +    return E2BIG; > > +    } > > + > > +    w = g_new0(XsWatch, 1); > > +    w->token =

Re: [PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-07 Thread Juergen Gross
On 07.03.23 12:42, Jan Beulich wrote: On 07.03.2023 12:33, Juergen Gross wrote: On 07.03.23 11:31, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: Using a rather oldish gcc (7.5) it was verified that code generation doesn't really differ between CONFIG_DEBUG_INFO on or off

[qemu-mainline test] 179449: tolerable trouble: fail/pass/starved - PUSHED

2023-03-07 Thread osstest service owner
flight 179449 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179449/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342

Re: [PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-07 Thread Jan Beulich
On 07.03.2023 12:33, Juergen Gross wrote: > On 07.03.23 11:31, Jan Beulich wrote: >> On 07.03.2023 07:32, Juergen Gross wrote: >>> Using a rather oldish gcc (7.5) it was verified that code generation >>> doesn't really differ between CONFIG_DEBUG_INFO on or off without >>> CONFIG_DEBUG being set

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Oleksii
On Mon, 2023-03-06 at 11:41 +0100, Jan Beulich wrote: > On 03.03.2023 11:38, Oleksii Kurochko wrote: > > +int do_bug_frame(struct cpu_user_regs *regs, unsigned long pc) > > +{ > > +    const struct bug_frame *bug = NULL; > > +    const struct virtual_region *region; > > +    const char *prefix =

Re: [PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-07 Thread Juergen Gross
On 07.03.23 11:31, Jan Beulich wrote: On 07.03.2023 07:32, Juergen Gross wrote: In order to support hypervisor analysis of crash dumps, xen-syms needs to contain debug_info. It should be allowed to configure the hypervisor to be built with CONFIG_DEBUG_INFO in non-debug builds without having to

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-07 Thread Oleksii
On Mon, 2023-03-06 at 11:17 +0100, Jan Beulich wrote: > > On 03.03.2023 11:38, Oleksii Kurochko wrote: > > > > --- a/xen/common/Kconfig > > > > +++ b/xen/common/Kconfig > > > > @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL > > > >  config ARCH_MAP_DOMAIN_PAGE > > > > bool > > > >   > > > >

[ovmf test] 179487: all pass - PUSHED

2023-03-07 Thread osstest service owner
flight 179487 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179487/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c7c25997595aa34ce0a7a21ca2e1fc5b0f9b38a6 baseline version: ovmf

Re: [RFC PATCH v1 03/25] hw/xen: Implement XenStore watches

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Starts out fairly simple: a hash table of watches based on the path. Except there can be multiple watches on the same path, so the watch ends up being a simple linked list, and the head of that list is in the hash table. Which

Re: [RFC PATCH v1 02/25] hw/xen: Add basic XenStore tree walk and write/read/directory support

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse This is a fairly simple implementation of a copy-on-write tree. The node walk function starts off at the root, with 'inplace == true'. If it ever encounters a node with a refcount greater than one (including the root node),

Re: [RFC PATCH v1 01/25] hw/xen: Add xenstore wire implementation and implementation stubs

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse This implements the basic wire protocol for the XenStore commands, punting all the actual implementation to xs_impl_* functions which all just return errors for now. Signed-off-by: David Woodhouse --- hw/i386/kvm/meson.build

Re: [PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-07 Thread Jan Beulich
On 07.03.2023 07:32, Juergen Gross wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -15,8 +15,11 @@ config DEBUG_INFO > bool "Compile Xen with debug info" > default DEBUG > ---help--- > - If you say Y here the resulting Xen will include debugging info > -

Re: [PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-07 Thread Jan Beulich
On 07.03.2023 07:32, Juergen Gross wrote: > In order to support hypervisor analysis of crash dumps, xen-syms needs > to contain debug_info. It should be allowed to configure the hypervisor > to be built with CONFIG_DEBUG_INFO in non-debug builds without having > to enable EXPERT. In how far does

Re: [PATCH] tools/tests: remove vhpet tests

2023-03-07 Thread Juergen Gross
On 07.03.23 11:02, Jan Beulich wrote: On 06.03.2023 17:29, Juergen Gross wrote: tools/tests/vhpet tests don't build since ages (at least since 4.10) and they can't be activated from outside of tools/tests/vhpet. This isn't exactly true - see the run-tests-% goal in the top level Makefile.

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-07 Thread Jan Beulich
On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote: > Regarding your email, I have the following comments: > > - I still do not know how to choose the value of cacheline_size. I understand > this value shall be between the actual cacheline_size and PAGE_SIZE. A value > that could match most

[PATCH v1 2/2] arch/arm: time: Add support for parsing interrupts by names

2023-03-07 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu Added support for parsing the ARM generic timer interrupts DT node by the "interrupt-names" property, if it is available. If not available, the usual parsing based on the expected IRQ order is performed. Also added the "hyp-virt" PPI to the timer PPI list, even though

[PATCH v1 1/2] arch/arm: irq: Add platform_get_irq_byname() implementation

2023-03-07 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu Moved implementation for the function which parses the IRQs of a DT node by the "interrupt-names" property from the SMMU-v3 driver to the IRQ core code and made it non-static to be used as helper. Also changed it to receive a "struct dt_device_node*" as parameter, like

[PATCH v1 0/2] Fix ARM Generic Timer interrupt parsing

2023-03-07 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu This 2-patch series fixes the parsing of the ARM Generic Timer interrupts from the device tree. If the generic timer interrupts order in the DT was different than the expected order in Xen code, these interrupts would no longer be correctly parsed and registered by Xen,

Re: [PATCH] tools/tests: remove vhpet tests

2023-03-07 Thread Jan Beulich
On 06.03.2023 17:29, Juergen Gross wrote: > tools/tests/vhpet tests don't build since ages (at least since 4.10) > and they can't be activated from outside of tools/tests/vhpet. This isn't exactly true - see the run-tests-% goal in the top level Makefile. > Remove them as they seem to be

[ovmf test] 179476: all pass - PUSHED

2023-03-07 Thread osstest service owner
flight 179476 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179476/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 46f51898ff716e53921b93e8d78af0fc7d06a2f9 baseline version: ovmf

Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen

2023-03-07 Thread David Woodhouse
On Thu, 2023-02-02 at 10:10 +0100, Gerd Hoffmann wrote: > > Thanks, Kevin. > > > > I'd like to get the rest of the Xen platform support in to qemu 8.0 > > if > > possible. Which is currently scheduled for March. > > > > Is there likely to be a SeaBIOS release before then which Gerd > > would > >

<    1   2