Re: [PATCH libXi multitouch 2/4] Make users aware of the unstable nature of this development branch

2011-09-15 Thread Jamey Sharp
On Wed, Sep 14, 2011 at 10:33:55PM -0700, Chase Douglas wrote: +if ! test x$UNSTABLE_LIB = xyes; then +AC_MSG_ERROR([This branch contains elements which have not yet been finalised. When this branch is updated, you will probably need to recompile both the any clients using the library,

Re: [PATCH libXi multitouch 2/4] Make users aware of the unstable nature of this development branch

2011-09-15 Thread Chase Douglas
On Sep 15, 2011, at 12:01 AM, Jamey Sharp ja...@minilop.net wrote: On Wed, Sep 14, 2011 at 10:33:55PM -0700, Chase Douglas wrote: +if ! test x$UNSTABLE_LIB = xyes; then +AC_MSG_ERROR([This branch contains elements which have not yet been finalised. When this branch is updated, you will

Re: [PATCH 1/3] xfree86: fbdevhw: Remove unused include of pciaccess.h

2011-09-15 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net On Wed, Sep 14, 2011 at 08:17:39PM -0500, Jeremy Huddleston wrote: Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/fbdevhw/fbdevhw.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Jamey Sharp
On Wed, Sep 14, 2011 at 08:17:45PM -0500, Jeremy Huddleston wrote: This makes a difference on darwin (and apparently nowhere else) Signed-off-by: Jeremy Huddleston jerem...@apple.com --- According to the libtool manual, modules that can be dlopened need libtool's -module switch. So I think

Re: [PATCH 1/3] xfree86: fbdevhw: Remove unused include of pciaccess.h

2011-09-15 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net On Wed, Sep 14, 2011 at 08:17:39PM -0500, Jeremy Huddleston wrote: Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/fbdevhw/fbdevhw.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Jeremy Huddleston
On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote: +if HAVE_XMLTO_TEXT +noinst_DATA += $(docbook:.xml=.txt) +%.txt: %.xml $(chapters) + $(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $ +endif HAVE_XMLTO_TEXT ^^^ XMLTO_TEXT_FLAGS ?? ___

Re: [PATCH] int10: Delete #if 0'd implementation that's older than our git history.

2011-09-15 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 14, 2011, at 12:27 PM, Jamey Sharp wrote: Throughout the xserver git history, the generic portion of the int10 module has always used other methods for reading the video BIOS. For some time now it's been purely libpciaccess based. This

Re: [PATCH] fb: Rename wfbTriangles and wfbTrapezoids

2011-09-15 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 14, 2011, at 5:25 PM, Aaron Plattner wrote: These symbols were not renamed when they were added to libfb: # nm -D libwfb.so | grep ' fb' 00028d00 T fbTrapezoids 00028d60 T fbTriangles This causes corruption and/or

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Julien Cristau
On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote: Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly rather than inheriting a dependency from xorg-server.

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 2:58 AM, Julien Cristau wrote: On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote: Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Julien Cristau
On Thu, Sep 15, 2011 at 03:20:02 -0500, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:58 AM, Julien Cristau wrote: On Wed, Sep 14, 2011 at 20:17:41 -0500, Jeremy Huddleston wrote: Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly rather than inheriting a dependency from xorg-server. The thing is, most video drivers *do* need pixman and pciaccess,

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 3:30 AM, Julien Cristau wrote: On Thu, Sep 15, 2011 at 03:20:02 -0500, Jeremy Huddleston wrote: Wouldn't it be nice if the servers that we cared about were in the xorg-server tree itself, so I could try building with these changes on a linux machine to see what broke.

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Gaetan Nadon
On Thu, 2011-09-15 at 02:23 -0500, Jamey Sharp wrote: On Wed, Sep 14, 2011 at 08:17:45PM -0500, Jeremy Huddleston wrote: This makes a difference on darwin (and apparently nowhere else) Signed-off-by: Jeremy Huddleston jerem...@apple.com --- According to the libtool manual, modules

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Gaetan Nadon
On Wed, 2011-09-14 at 20:17 -0500, Jeremy Huddleston wrote: Every module building against xorg-server does not *Require* pixman nor libpciaccess. If such modules need pixman or pciaccess, they should be depending on them directly rather than inheriting a dependency from xorg-server. This

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Gaetan Nadon
On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote: On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote: +if HAVE_XMLTO_TEXT +noinst_DATA += $(docbook:.xml=.txt) +%.txt: %.xml $(chapters) + $(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $ +endif HAVE_XMLTO_TEXT ^^^

Re: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

2011-09-15 Thread Alan Coopersmith
On 09/15/11 04:41 AM, Jeremy Huddleston wrote: Actually, it looks like a bunch of drivers are not linking correctly to begin with, and nobody seems so have cared. The Solaris linker does, and I've long added a bunch of libraries to my LDFLAGS for each driver on Solaris. If we're now

Re: [PATCH] x86emu: There is no NO_INLINE implementation of unaligned access here.

2011-09-15 Thread Matt Turner
On Tue, Sep 13, 2011 at 5:32 PM, Jamey Sharp ja...@minilop.net wrote: Patch produced with:        unifdef -UNO_INLINE -B This change isn't relevant to the similar code in xfree86/common/compiler.h, because x86emu is expected to someday move out of xserver entirely and so should not depend on

[PATCH] Delete support for MGA's proprietary HAL: unifdef USEMGAHAL.

2011-09-15 Thread Jamey Sharp
This patch produced with: for f in `git grep -Fwl USEMGAHAL`; do unifdef -B -UUSEMGAHAL $f | sponge $f done Adam Jackson wrote: Hey, so, remember back in the dark ages when dualhead was this insanely wild differentiating feature? Matrox thought it

Xserver driver merging pros cons

2011-09-15 Thread Jesse Barnes
At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the pros cons of such a change. So I'd like to capture that here (from memory) to let us continue the discussion about

Re: Xserver driver merging pros cons

2011-09-15 Thread Michel Dänzer
On Don, 2011-09-15 at 10:45 -0500, Jesse Barnes wrote: Pros: 1) easier to propagate API changes across drivers (just like Linux) 1a) thus easier to change ABI 2) developers focused on driver development now have more incentive to make sure the server works well so regular

[PATCH libXi] inputlib: restore original title X Input Device Extension Library

2011-09-15 Thread Gaetan Nadon
Somehow the title got changed during troff to docbook conversion. Latest troff version: ftp://www.x.org/pub/X11R7.0/doc/PDF/XiLib.pdf Signed-off-by: Gaetan Nadon mems...@videotron.ca --- specs/inputlib.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH fonts-util 2/2] If cross-compiling, we don't have to run mkfontdir

2011-09-15 Thread Jon TURNEY
On 14/09/2011 00:09, Jeremy Huddleston wrote: This is confusing to me. Why do you add the extra ; echo '** mkfontdir'? On Sep 12, 2011, at 9:18 AM, Jon TURNEY wrote: +AC_DEFUN([XORG_FONT_MKFONTDIR],[ + if test x$cross_compiling != xno ; then + AC_PATH_PROG(MKFONTDIR,

Re: Xserver driver merging pros cons

2011-09-15 Thread Alex Deucher
On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: At XDC this week we discussed merging drivers back into the server tree.  One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the pros cons of such a change.  So

Re: Xserver driver merging pros cons

2011-09-15 Thread Dave Airlie
On Thu, Sep 15, 2011 at 5:34 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: At XDC this week we discussed merging drivers back into the server tree.  One thing I found frustrating about the discussion was that we

Re: Xserver driver merging pros cons

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 12:34:51 -0400, Alex Deucher alexdeuc...@gmail.com wrote: The number of ABI breaks is minimal (usually 1 per xserver) and those can usually be fixed within a day or so of the breakage. We don't get ABI changes because they're nearly impossible to handle. I don't rebuild

[PATCH xserver 2/8] bsd: Replacement screenFd on consoleFd because they are equivalent

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/common/xf86Globals.c |1 - hw/xfree86/common/xf86Privstr.h |2 -- hw/xfree86/os-support/bsd/alpha_video.c |2 +- hw/xfree86/os-support/bsd/arm_video.c |6 +++---

[PATCH xserver 3/8] bsd: Variable devConsoleFd need only if defined PCCONS_SUPPORT

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/os-support/bsd/bsd_init.c b/hw/xfree86/os-support/bsd/bsd_init.c index e5c8495..84c6b3d 100644 ---

[PATCH xserver 4/8] bsd: Remove dead code

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/hw/xfree86/os-support/bsd/bsd_init.c b/hw/xfree86/os-support/bsd/bsd_init.c index 84c6b3d..1825672

[PATCH xserver 5/8] bsd: Some clean up

2011-09-15 Thread Alexandr Shadchin
OpenBSD and NetBSD does not support syscons Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c |4 hw/xfree86/os-support/xf86_OSlib.h | 20 2 files changed, 8 insertions(+), 16 deletions(-) diff --git

[PATCH xserver 6/8] bsd: OpenBSD and NetBSD not need extra headers in PCVT_SUPPORT

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/xf86_OSlib.h | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/os-support/xf86_OSlib.h b/hw/xfree86/os-support/xf86_OSlib.h index cf92821..fddde8a 100644 ---

[PATCH xserver 7/8] bsd: ioctl KDENABIO/KDDISABIO do not matter for OpenBSD

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/os-support/bsd/bsd_init.c b/hw/xfree86/os-support/bsd/bsd_init.c index a0caee3..c8a4e05 100644 ---

[PATCH xserver 8/8] Remove unused vtSysreq

2011-09-15 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/common/xf86Config.c | 13 - hw/xfree86/common/xf86Globals.c|1 - hw/xfree86/common/xf86Privstr.h|1 - hw/xfree86/man/xorg.conf.man | 12

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Jeremy Huddleston
Ok, then this gets my structural review, but would be nice if someone who really understands docbook looks at invocation. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 15, 2011, at 8:41 AM, Gaetan Nadon wrote: On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote: On Sep

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:34 AM, Alex Deucher wrote: For me personally, I don't seem much advantage in moving the drivers into the xserver. The number of ABI breaks is minimal (usually 1 per xserver) and those can usually be fixed within a day or so of the breakage. I don't rebuild the

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:02 AM, Michel Dänzer wrote: 3) Out of tree drivers will become second class citizens. I don't see that as a con. I see that as a benefit. If something is not in the tree, it IS a second class citizen, and users should not expect it to work any more. If the trident

Re: [PATCH fonts-util 2/2] If cross-compiling, we don't have to run mkfontdir

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 11:06 AM, Jon TURNEY wrote: On 14/09/2011 00:09, Jeremy Huddleston wrote: This is confusing to me. Why do you add the extra ; echo '** mkfontdir'? On Sep 12, 2011, at 9:18 AM, Jon TURNEY wrote: +AC_DEFUN([XORG_FONT_MKFONTDIR],[ + if test x$cross_compiling != xno ;

Re: Xserver driver merging pros cons

2011-09-15 Thread Dave Airlie
3) Out of tree drivers will become second class citizens. I don't see that as a con.  I see that as a benefit.  If something is not in the tree, it IS a second class citizen, and users should not expect it to work any more.  If the trident driver breaks, they can always use vesa. This

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-15 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_bell.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git

Re: [PATCH xserver 2/8] bsd: Replacement screenFd on consoleFd because they are equivalent

2011-09-15 Thread Jamey Sharp
Based purely on code inspection, this patch looks right to me. Reviewed-by: Jamey Sharp ja...@minilop.net On Thu, Sep 15, 2011 at 11:20:22PM +0600, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/common/xf86Globals.c |1 -

Re: [PATCH xserver 3/8] bsd: Variable devConsoleFd need only if defined PCCONS_SUPPORT

2011-09-15 Thread Jamey Sharp
Again, based purely on code inspection, this looks right. Reviewed-by: Jamey Sharp ja...@minilop.net On Thu, Sep 15, 2011 at 11:20:23PM +0600, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c |5 + 1 files

Re: Xserver driver merging pros cons

2011-09-15 Thread Arkadiusz Miśkiewicz
On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the pros cons of such a change. So I'd like to capture that

Re: [PATCH xserver 4/8] bsd: Remove dead code

2011-09-15 Thread Jamey Sharp
It wasn't immediately obvious to me that the comment (stdin is already closed, so this won't work) was actually true. I've confirmed that the other comment is true (stdin is already closed in OsInit()), so I believe this patch is correct. I'd like to see some explanation in the commit message,

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

2011-09-15 Thread Jeremy Huddleston
I review this in the sense that the comments match the src changes and look well formed. Hopefully another BSD developer can vouch for whether they actually do the right thing rather than just do the stated thing Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 15, 2011, at 12:20 PM,

Re: [PATCH xserver 8/8] Remove unused vtSysreq

2011-09-15 Thread Jamey Sharp
It looks to me like you should also delete VTSYSRQ from hw/xfree86/parser/xf86tokens.h. If you fix that, Reviewed-by: Jamey Sharp ja...@minilop.net I can't review the remaining patches in this series because I'm not familiar enough with the BSDs. Jamey On Thu, Sep 15, 2011 at 11:20:28PM

Re: Xserver driver merging pros cons

2011-09-15 Thread Arkadiusz Miśkiewicz
On Thursday 15 of September 2011, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the

[PATCH rendercheck] t_tsrccoords: Skip this test when using indexed picture formats

2011-09-15 Thread Damien Leone
This test would fail at, for example, depth 8 because indexed color comparisons are not implemented in rendercheck yet. This commit workarounds this by passing the test if indexed picture formats are used. Signed-off-by: Damien Leone dle...@nvidia.com Reviewed-by: Aaron Plattner

Re: Xserver driver merging pros cons

2011-09-15 Thread Chase Douglas
On 09/15/2011 01:00 PM, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was

Re: Xserver driver merging pros cons

2011-09-15 Thread Rémi Cardona
Le 15/09/2011 17:45, Jesse Barnes a écrit : At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about the discussion was that we didn't have a whiteboard nor a list of the pros cons of such a change. So I'd like to capture that here (from

Re: [PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Gaetan Nadon
On Thu, 2011-09-15 at 13:18 -0500, Jeremy Huddleston wrote: Ok, then this gets my structural review, but would be nice if someone who really understands docbook looks at invocation. I would love to as well. However, from a risk management perspective, this new version is mainly a reshuffle of

Re: Xserver driver merging pros cons

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 3:30 PM, Chase Douglas wrote: On 09/15/2011 01:00 PM, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: On Thursday 15 of September 2011, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One

Re: Xserver driver merging pros cons

2011-09-15 Thread Peter Hutterer
On Thu, Sep 15, 2011 at 06:05:46PM +0100, Dave Airlie wrote: On Thu, Sep 15, 2011 at 5:34 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: At XDC this week we discussed merging drivers back into the server tree.  

Re: Xserver driver merging pros cons

2011-09-15 Thread Alex Deucher
On Thu, Sep 15, 2011 at 1:17 PM, Keith Packard kei...@keithp.com wrote: On Thu, 15 Sep 2011 12:34:51 -0400, Alex Deucher alexdeuc...@gmail.com wrote: The number of ABI breaks is minimal (usually 1 per xserver) and those can usually be fixed within a day or so of the breakage. We don't get

Re: [PATCH] render: export TriStrip and TriFan to the drivers

2011-09-15 Thread Aaron Plattner
Reviewed-by: Aaron Plattner aplatt...@nvidia.com Thanks for doing this, it was bugging me that we couldn't wrap these functions at this level. Only somewhat related, but what do you think of the idea of creating RENDER path objects to allow clients to shove entire path descriptions over to the

Re: Xserver driver merging pros cons

2011-09-15 Thread Matt Turner
On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: Pros:  1) easier to propagate API changes across drivers (just like Linux)     1a) thus easier to change ABI I suppose that's true. How often are we breaking the ABI though? How often do we break the ABI and it

Re: [PATCH] render: export TriStrip and TriFan to the drivers

2011-09-15 Thread Chris Wilson
On Thu, 15 Sep 2011 14:37:01 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Reviewed-by: Aaron Plattner aplatt...@nvidia.com Thanks for doing this, it was bugging me that we couldn't wrap these functions at this level. Only somewhat related, but what do you think of the idea of creating

Re: Xserver driver merging pros cons

2011-09-15 Thread Chase Douglas
On 09/15/2011 02:41 PM, Matt Turner wrote: On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: Pros: 1) easier to propagate API changes across drivers (just like Linux) 1a) thus easier to change ABI I suppose that's true. How often are we breaking the ABI

Re: Xserver driver merging pros cons

2011-09-15 Thread Jamey Sharp
On Thu, Sep 15, 2011 at 01:30:02PM -0700, Chase Douglas wrote: Personally, I would prefer a monolithic tree with separate branches for backporting driver changes to older server versions. I would also prefer each driver having a stated policy of how many back revisions of servers are supported

Re: [PATCH] configure.ac: Remove unreachable check for VM86 headers.

2011-09-15 Thread Gaetan Nadon
On Wed, 2011-09-14 at 10:07 -0500, Jamey Sharp wrote: configure --with-int10=yes is not a valid configuration, and the check It depends what is the definition of valid in this context. Running ./configure --with-int10 will set INT10 to yes. You may choose to ignore this value. I can only guess

Re: [PATCH libXi] inputlib: restore original title X Input Device Extension Library

2011-09-15 Thread Alan Coopersmith
On 09/15/11 09:01, Gaetan Nadon wrote: Somehow the title got changed during troff to docbook conversion. Latest troff version: ftp://www.x.org/pub/X11R7.0/doc/PDF/XiLib.pdf Signed-off-by: Gaetan Nadonmems...@videotron.ca --- specs/inputlib.xml |2 +- 1 files changed, 1 insertions(+), 1

[PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

2011-09-15 Thread Gaetan Nadon
The developer docs are generated from a subset of docbook.am which is sometimes updated. The one difference for xserver is the embedded css style in the HEAD element. Reviewed-by: Jeremy Huddleston jerem...@apple.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- devbook.am | 45

Re: Xserver driver merging pros cons

2011-09-15 Thread Alan Coopersmith
On 09/15/11 08:45, Jesse Barnes wrote: Cons: 1) more work for distros to backport just driver changes to old servers (especially if people follow through on (3) above) 1a) if backporting is harder, new hardware support will be more difficult to land in enterprise level

Re: Xserver driver merging pros cons

2011-09-15 Thread Alan Coopersmith
On 09/15/11 14:41, Matt Turner wrote: 4) increased test coverage for the server as users wanting current driver code will be building new servers too Maybe. I'd hate to force users to do that just to get new hardware support or a simple driver bug fix. The server will often require

Re: Xserver driver merging pros cons

2011-09-15 Thread Alan Coopersmith
On 09/15/11 14:01, Jeremy Huddleston wrote: On Sep 15, 2011, at 3:30 PM, Chase Douglas wrote: On 09/15/2011 01:00 PM, Jeremy Huddleston wrote: On Sep 15, 2011, at 2:45 PM, Arkadiusz Miśkiewicz wrote: From distro package maintainer point of view I _love_ split drivers. It's so much easier

Re: [PATCH xserver 8/8] Remove unused vtSysreq

2011-09-15 Thread Alan Coopersmith
On 09/15/11 13:07, Jamey Sharp wrote: It looks to me like you should also delete VTSYSRQ from hw/xfree86/parser/xf86tokens.h. Please ensure that any changes result in the X server simply ignoring the VTSysReq option in existing xorg.conf and not erroring out refusing to start on a file that

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Alan Coopersmith
On 09/15/11 05:57, Gaetan Nadon wrote: A couple of things to verify: * OpenBSD still uses libtool 1.5 So does Solaris - 1.5.22, though I have a local install of 2.2 I usually use for building X.Org modules from git. I don't think that's an issue though, as -module has worked fine for us

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Alan Coopersmith
diff --git a/hw/xfree86/ramdac/Makefile.am b/hw/xfree86/ramdac/Makefile.am index 3c37805..d29ded5 100644 --- a/hw/xfree86/ramdac/Makefile.am +++ b/hw/xfree86/ramdac/Makefile.am @@ -1,5 +1,6 @@ noinst_LTLIBRARIES = libramdac.la +libramdac_la_LDFLAGS = -module -avoid-version

Re: [PATCH] fb: Rename wfbTriangles and wfbTrapezoids

2011-09-15 Thread Alan Coopersmith
On 09/14/11 15:25, Aaron Plattner wrote: These symbols were not renamed when they were added to libfb: # nm -D libwfb.so | grep ' fb' 00028d00 T fbTrapezoids 00028d60 T fbTriangles This causes corruption and/or crashes on wfb-ful drivers like nvidia: Is there any

Re: [PATCH] configure.ac: Remove unreachable check for VM86 headers.

2011-09-15 Thread Alan Coopersmith
On 09/14/11 09:11, Jamey Sharp wrote: On Wed, Sep 14, 2011 at 10:39:53AM -0500, Alan Coopersmith wrote: On 09/14/11 10:07 AM, Jamey Sharp wrote: configure --with-int10=yes is not a valid configuration, and the check for sys/vm86.h and sys/io.h is not used. Delete it.

Re: [PATCH] configure.ac: Remove unreachable check for VM86 headers.

2011-09-15 Thread Jamey Sharp
On Thu, Sep 15, 2011 at 07:28:25PM -0400, Gaetan Nadon wrote: On Wed, 2011-09-14 at 10:07 -0500, Jamey Sharp wrote: configure --with-int10=yes is not a valid configuration, and the check It depends what is the definition of valid in this context. Running ./configure --with-int10 will set

Re: [PATCH v2 7/7] dix: NewCurrentScreen must work on pointers where possible

2011-09-15 Thread Keith Packard
On Fri, 2 Sep 2011 11:36:51 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: void NewCurrentScreen(DeviceIntPtr pDev, ScreenPtr newScreen, int x, int y) { -SpritePtr pSprite = pDev-spriteInfo-sprite; +DeviceIntPtr ptr; +SpritePtr pSprite; + +ptr = IsFloating(pDev)

Re: [PATCH xserver 8/8] Remove unused vtSysreq

2011-09-15 Thread Jamey Sharp
On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote: On 09/15/11 13:07, Jamey Sharp wrote: It looks to me like you should also delete VTSYSRQ from hw/xfree86/parser/xf86tokens.h. Please ensure that any changes result in the X server simply ignoring the VTSysReq option in

Re: [PATCH xserver 8/8] Remove unused vtSysreq

2011-09-15 Thread Alan Coopersmith
On 09/15/11 20:51, Jamey Sharp wrote: On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote: On 09/15/11 13:07, Jamey Sharp wrote: It looks to me like you should also delete VTSYSRQ from hw/xfree86/parser/xf86tokens.h. Please ensure that any changes result in the X server simply

Re: [PATCH libICE] specs: use DocBook suggested markup for Copyrights

2011-09-15 Thread Alan Coopersmith
On 09/11/11 14:08, Gaetan Nadon wrote: Puts the statement on a single line, using commas to separate years -- Copyright © 1993, 1994, 1996 X Consortium As opposed to 3 double-spaced lines. Signed-off-by: Gaetan Nadonmems...@videotron.ca --- doc/ICElib.xml |7 --- 1 files

Re: [PATCH fonts-util 2/2] If cross-compiling, we don't have to run mkfontdir

2011-09-15 Thread Alan Coopersmith
On 09/12/11 07:18, Jon TURNEY wrote: +# XORG_FONT_MKFONTDIR() +# --- +# Minimum version: 1.1.1 Shouldn't that be 1.3.0 since we already released 1.2.0? -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window

Re: [PATCH fonts-util 1/2] Never run fc-cache if cross-compiling

2011-09-15 Thread Alan Coopersmith
On 09/12/11 07:18, Jon TURNEY wrote: Since the cache files produced by fc-cache are arch-dependent, there is no point in running fc-cache if cross-compiling So, even if we aren't using a DESTDIR, but are installing directly into (a hopefully non-default) prefix, don't run fc-cache when

Re: Xserver driver merging pros cons

2011-09-15 Thread Dave Airlie
If you're talking enterprise distros though, that means committing to at least one long-term support stable branch, that you backport new driver support to for years, not just the 6 months until the next one. Just a note from an enterprise distro maintainer, we are currently rebasing the X

Re: [PATCH 3/3] xfree86: Link modules with -module

2011-09-15 Thread Jeremy Huddleston
Ah good catch. Removed in my tree. On Sep 15, 2011, at 8:55 PM, Alan Coopersmith wrote: diff --git a/hw/xfree86/ramdac/Makefile.am b/hw/xfree86/ramdac/Makefile.am index 3c37805..d29ded5 100644 --- a/hw/xfree86/ramdac/Makefile.am +++ b/hw/xfree86/ramdac/Makefile.am @@ -1,5 +1,6 @@

Re: [PATCH] fb: Rename wfbTriangles and wfbTrapezoids

2011-09-15 Thread Jeremy Huddleston
On Sep 15, 2011, at 9:29 PM, Alan Coopersmith wrote: On 09/14/11 15:25, Aaron Plattner wrote: These symbols were not renamed when they were added to libfb: # nm -D libwfb.so | grep ' fb' 00028d00 T fbTrapezoids 00028d60 T fbTriangles This causes corruption and/or