[PATCH] xwayland: Throttle our cursor surface updates with a frame callback

In some extreme cases with animated cursors at a high frame rate we could end up filling the wl_display outgoing buffer and end up with wl_display_flush() failing. In any case, using the frame callback to throttle ourselves is the right thing to do. Signed-off-by: Rui Matos --- v2: ensure that

Re: [PATCH] xwayland: Throttle our cursor surface updates with a frame callback

Hi, On 26 May 2015 at 16:37, Rui Matos wrote: > In some extreme cases with animated cursors at a high frame rate we > could end up filling the wl_display outgoing buffer and end up with > wl_display_flush() failing. > > In any case, using the frame callback to throttle ourselves is the > right th

Re: [PATCH try2] dix: Send KeyPress and KeyRelease events to the XACE_KEY_AVAIL hook

Hey, anyone have any comments on this patch? Thanks, Andrew On Fri, May 15, 2015 at 03:10:13PM -0500, Andrew Eikum wrote: > While it's documented in the XACE spec, the XACE_KEY_AVAIL hook is > currently never actually invoked by the xserver. > > This hook was added in 13c6713c82 (25 Aug 2006), b

[PATCH 5/5] render: Eliminate temporary mask when drawing glyphs

The temporary mask was supposed to do a better job when drawing glyphs sharing pixels than just drawing them one at a time. However, the way it was defined assumed that the glyphs didn't actually overlap, and the computational cost for this minor adjustment is quite high. Signed-off-by: Keith Pack

[PATCH 4/5] glamor: Set composite glyphs source offset to origin of first glyph

Pull the location of the first glyph out of the first list element and adjust the source position to align them. Signed-off-by: Keith Packard --- glamor/glamor_composite_glyphs.c | 8 1 file changed, 8 insertions(+) diff --git a/glamor/glamor_composite_glyphs.c b/glamor/glamor_composit

[PATCH 3/5] glamor: Pass source offset to glamor_use_program_render

We need the source offset when setting up a source pixmap to position it in the destination correctly. Signed-off-by: Keith Packard --- glamor/glamor_composite_glyphs.c | 17 + glamor/glamor_program.c | 16 +--- glamor/glamor_program.h | 6 -- 3

[PATCH 2/5] glamor: New render code can't handle non-repeating sources

GL doesn't have a texture wrap mode that matches Renders non-repeating sources, so for now, we'll just bail on this case. Signed-off-by: Keith Packard --- glamor/glamor_program.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_program.c b/glamor/glamor_pro

[PATCH 1/5] glamor: Force GL_REPEAT mode for source tiles and pictures

This ensures that wrap mode changes elsewhere in glamor don't affect tiles and repeating source pictures. Signed-off-by: Keith Packard --- glamor/glamor_transform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/glamor/glamor_transform.c b/glamor/glamor_transform.c index f476a99..cc97ea5

[PATCH] renderproto: Fix compositeglyph dst position. eliminate use of mask-format

Change the definition of composite glyphs from using an explicit dst-x/dst-y location to match current implementation which uses the dx/dy values from the first glyphitem for the destination location. Define the source pattern origin to align with that first glyph location. Eliminate use of the m

Re: [PATCH] xwayland: Throttle our cursor surface updates with a frame callback

Daniel Stone writes: >> Signed-off-by: Rui Matos > > Thanks! > > Reviewed-by: Daniel Stone > > Keith, please pull. Looks like there have been some other updates in this area? Can I get one of you to build a patch on master? -- -keith signature.asc Description: PGP signature ___

Re: [PATCH 2/3] present: Query the Window's CRTC every time

Michel Dänzer writes: > The old code also called present_get_crtc() unless pixmap == NULL, so > the problem couldn't affect flips but only MSC waits. The original code was trying to let the client control which CRTC to track for each window. For PresentPixmap requests, there's an explicit CRTC a

Re: [PATCH v2] backtrace.c: Fix word cast to a pointer

Keith Packard writes: > Vicente Olivert Riera writes: > >> Making the cast to a pointer-sized integer, and then to a pointer fixes >> the problem. > > Reviewed-by: Keith Packard Merged (thanks for the ping): 76636ac..baa50f6 master -> master -- -keith signature.asc Description: PGP sig

Re: [PATCH 1/3] present: Copy unflip contents back to the Screen Pixmap

Michel Dänzer writes: > Keith, this is also an important fix: > > On 06.02.2015 17:25, Chris Wilson wrote: >> As we unflip after the flip Window no longer passes the pixel ownership >> test for the full Screen Pixmap, we can no longer utilize that Window to >> copy the contents back to the backin

Re: [PATCH] renderproto: Fix compositeglyph dst position. eliminate use of mask-format

On Tue, May 26, 2015 at 01:55:09PM -0700, Keith Packard wrote: > Change the definition of composite glyphs from using an explicit > dst-x/dst-y location to match current implementation which uses the > dx/dy values from the first glyphitem for the destination location. > > Define the source patter

Re: [PATCH 5/5] render: Eliminate temporary mask when drawing glyphs

On Tue, May 26, 2015 at 01:47:55PM -0700, Keith Packard wrote: > The temporary mask was supposed to do a better job when drawing glyphs > sharing pixels than just drawing them one at a time. However, the way > it was defined assumed that the glyphs didn't actually overlap, and > the computational c

Re: [PATCH 2/3] present: Query the Window's CRTC every time

On 27.05.2015 06:30, Keith Packard wrote: > Michel Dänzer writes: > >> The problem I was hitting was that this code was running for an MSC wait >> when the CRTC referenced by window_priv->crtc was already disabled for >> DPMS off. This caused hangs at the GNOME lock screen. This patch seems >> to

Re: [PATCH 1/3] present: Copy unflip contents back to the Screen Pixmap

On 27.05.2015 07:12, Keith Packard wrote: > Michel Dänzer writes: > >> Keith, this is also an important fix: >> >> On 06.02.2015 17:25, Chris Wilson wrote: >>> As we unflip after the flip Window no longer passes the pixel ownership >>> test for the full Screen Pixmap, we can no longer utilize tha

Re: [PATCH 2/3] present: Query the Window's CRTC every time

On Tue, May 26, 2015 at 02:30:32PM -0700, Keith Packard wrote: > Michel Dänzer writes: > > > The old code also called present_get_crtc() unless pixmap == NULL, so > > the problem couldn't affect flips but only MSC waits. > > The original code was trying to let the client control which CRTC to >