Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 29, 2011, at 3:11 PM, Peter Hutterer wrote:
If the new cursor is the NULL cursor, don't dereference it and use zeros
instead.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Not sure when this broke given that most
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 29, 2011, at 3:40 PM, Peter Hutterer wrote:
Instead of requiring the caller to know which private field indicates
failure, just return true on success or false on failure.
No functional change.
Signed-off-by: Peter Hutterer
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 29, 2011, at 4:03 PM, Peter Hutterer wrote:
The remainder of the code take try through all protocols, taking the device
into account (as of xf86-input-synaptics-1.4.0-34-g241254e)
Reported-by: Martin Bruse zondol...@gmail.com
Signed
Does anything trigger usage() now? Can you send a followup (or squash in)
support for 'xinput --help' for further consistency?
On Nov 29, 2011, at 4:57 PM, Bryce Harrington wrote:
xrandr lists all outputs by default when run with no args. So, make
xinput list all inputs by default when run
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
src/xinput.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/xinput.c b/src/xinput.c
index 27fb23e..2d9a893 100644
--- a/src/xinput.c
+++ b/src/xinput.c
@@ -357,6 +357,11 @@ main(int argc, char * argv
For the first hunk,
Reviewed-by: Jeremy Huddleston jerem...@apple.com
For the second hunk, we don't use glib for the tests any more. I'd just delete
the sentence about g_test_bug. See:
commit 196d679bed2e9959d2fca89d4ee4bbc551681d0b
Author: Peter Hutterer peter.hutte...@who-t.net
Date: Fri
On Nov 25, 2011, at 3:44 PM, Keith Packard wrote:
On Fri, 25 Nov 2011 16:38:06 -0200, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com
---
hw/xfree86/parser/scan.c |4 ++--
1 files changed, 2 insertions(+), 2
4689c84..bed7d7f server-1.11-branch - server-1.11-branch
On Nov 28, 2011, at 5:02 AM, Rui Tiago Cação Matos wrote:
Hi
please consider
http://cgit.freedesktop.org/xorg/xserver/commit/?id=9cc44b955b27de33348d6a20bebc9704930ee18e
for 1.11.3. It's an important fix for people using
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 24, 2011, at 3:47 PM, Tobias Droste wrote:
Status is defined as int - NULL is not a valid return value
v2: Remove unneeded cast to Status
Signed-off-by: Tobias Droste tdro...@gmx.de
---
src/XpNotifyPdm.c |8
1 files
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 25, 2011, at 10:38, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com
---
hw/xfree86/parser/scan.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
Fixes regression introduced by: 6e6d732bac3c21cb85f8e998908f9b393630e5f8
Found-by: Tinderbox
Signed-off-by: Jeremy Huddleston jerem...@apple.com
CC: Alan Coopersmith alan.coopersm...@oracle.com
---
hw/dmx/config/dmxcompat.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
I'd rather deprecate serverGeneration in this build and remove it in the next.
In addition to not breaking ABI, this gives a compiler warning about the
deprecation which removing the symbol doesn't:
misc.h:
extern _X_EXPORT _X_DEPRECATED unsigned long serverGeneration;
globals.c:
unsigned
Reviewed and pushed:
3d7be5c..7f26709 master - master
I'm going to followup later re: a more complete solution to that ifdef insanity.
On Nov 14, 2011, at 15:22, Yaakov (Cygwin/X) wrote:
From: Yaakov Selkowitz yselkow...@users.sourceforge.net
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 19, 2011, at 09:43, Alan Coopersmith wrote:
Needed to resolve gcc -Wwrite-strings warnings in callers.
These functions only pass the strings to strcmp before calling
strdup to make their own private copy for storing away.
While
1 2 are:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
assuming you re-order them per your later email.
3 hurts my head. I'll look at it again tomorrow, but for now, 12 are good
bite-sized correctness fixes.
On Nov 20, 2011, at 03:48, Jamey Sharp wrote:
I'm tired of dealing
Ugh ... rrgh... Ok, I'll take a look at this...
On Nov 14, 2011, at 10:57, Jon TURNEY wrote:
On 11/11/2011 18:19, Jeremy Huddleston wrote:
src/XpmI.h |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 4cedf181bcfe13e5d206554c51edb82cb17e7ad5
Author: Jeremy Huddleston jerem
ping ... I think there are 3 or 4 other PULL requests pending too...
On Nov 6, 2011, at 5:17 PM, Jeremy Huddleston wrote:
The following changes since commit f0d50cc6651dce3a8a3cd3fb84210aa92b139763:
Fix vesa's VBE PanelID interpretation (2011-11-06 16:41:44 -0800)
are available
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 11, 2011, at 17:44, Gaetan Nadon wrote:
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
doc/Xinput.xml|2 +-
doc/Xserver-spec.xml |2
Series:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 11, 2011, at 22:49, Alan Coopersmith wrote:
Allows gcc to check printf format strings instead of just giving warnings.
Since these #defines are only used in config.c, define them directly there,
instead of in the config.h header
-by: Jeremy Huddleston jerem...@apple.com
---
Good catch, I must have read over this 50 times. I guess Jeremy's rev-by
still stands so I left the tag in, I suspect he just read over this as well.
src/XExtInt.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/XExtInt.c
If someone wants to tune that in the future, they can make a configure option
for it, so it can live in autoconf's config.h ...
On Nov 12, 2011, at 02:25, Mark Kettenis wrote:
From: Alan Coopersmith alan.coopersm...@oracle.com
Date: Fri, 11 Nov 2011 22:49:09 -0800
The only file that needed
On Nov 12, 2011, at 11:39, Martin-Éric Racine wrote:
I do. However, it hasn't built succesfully since about version 1.5 of
xserver. That's why most distributions haven't shipped it in ages.
cyrix_driver.c:164:1: error: unknown type name 'IsaChipsets'
cyrix_driver.c:1297:15: error:
Why can't you just use malloc() ... do we really need an Xmalloc macro any more?
Either way, all 3 are:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 10, 2011, at 8:50 PM, Peter Hutterer wrote:
Xmalloc is a macro evaluating its argument twice.
Signed-off-by: Peter Hutterer
It's nice to see more of our codebase starting to make use of language features
introduced 20 years ago... ;)
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 9, 2011, at 10:19 PM, Alan Coopersmith wrote:
plus a bonus cleanup of ancient cruft noticed in the process.
Changes
fixes on Sunray with Xinerama on
Reviewed-by: Dave Airlie airl...@redhat.com
2011BRB_Reviewed: Jeremy Huddleston jerem...@freedesktop.org
Signed-off-by: Arvind Umrao arvind.um...@oracle.com
---
Xext/panoramiXprocs.c | 215 +
1 files changed
For all 3:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 29, 2011, at 2:08 PM, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
1,152 bytes in 1 blocks are definitely lost in loss record 536 of 575
at 0x4C25E84: calloc (in
/usr/lib/valgrind
For the series:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
I submitted a patch to xorg-devel yesterday for hw/dmx warnings/errors after
the macros update. Would you mind reviewing it and throwing it into your set
for [PULL]?
Thanks,
Jeremy
On Nov 8, 2011, at 12:42 PM, Alan Coopersmith
On Nov 8, 2011, at 1:35 PM, Gaetan Nadon wrote:
On Thu, 2011-11-03 at 01:19 -0700, Jeremy Huddleston wrote:
See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 47
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/dmx/glxProxy/compsize.c |1 +
hw/dmx/glxProxy/compsize.h | 51
hw/dmx/glxProxy/g_renderswap.c |1 +
hw/dmx/glxProxy/glxcmds.c |2 +
hw/dmx/glxProxy/glxcmds.h | 37
lazy
What branch should I merge from your tree to test this?
/lazy
On Nov 7, 2011, at 1:39 PM, Peter Hutterer wrote:
This set of patches is some of the groundwork for the multitouch work.
01/12 is a real fix, patch 12/12 is required for easier access to the event
masks. 02/12 through to
On Nov 5, 2011, at 5:42 PM, Gaetan Nadon wrote:
I am not sure if some of the flags I tested make sense, for example:
checking if gcc -std=gnu99 supports -!!!... yes
checking if gcc -std=gnu99 supports -12345... yes
Well gcc doesn't seem to complain when given those options,
This seems to have fallen off the radar. I've pulled it into my tree, so it'll
eventually be pulled into master.
--Jeremy
On Oct 4, 2011, at 2:25 AM, Rami Ylimäki wrote:
Any pad bytes in replies are written to the client from a zeroed
array. However, record extension tries to incorrectly
with no modes
DRI2: Avoid a NULL pointer dereference
dri2: Register the DRI2DrawableType after server regeneration
Derek Buitenhuis (1):
Fix vesa's VBE PanelID interpretation
Jeremy Huddleston (2):
xfree86: Fix powerpc build with -Werror=int-to-pointer-cast
-Werror=pointer-to-int
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 3, 2011, at 7:56 PM, Alan Coopersmith wrote:
This series updates the unit testing macros in util-macros and updates
the xserver configure Makefile to take advantage of them if possible.
The usage in the xserver files gracefully
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 3, 2011, at 10:34 PM, Alan Coopersmith wrote:
Some resends that didn't get reviewed yet, some reworked based on review
comments so far, and some really new patches.
Alan Coopersmith (11):
Convert some malloc + strncpy pairs
This push has parse errors:
http://tinderbox.x.org/builds/2011-11-06-0018/logs/xf86-video-intel/#check
basic-copyarea.c: In function 'rect_tests':
basic-copyarea.c:269: error: expected ')' before '}' token
basic-copyarea.c:269: error: expected ';' before '}' token
make[2]: *** [basic-copyarea.o]
The current test was always failing to compile because 'return 0;' was
global rather than in the body of a function.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 52
1 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index 534afba..1ece326 100644
--- a/xorg-macros.m4.in
+++ b
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 29 ++---
1 files changed, 10 insertions(+), 19 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index 1ece326..123bdaa 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4
See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 47 ++-
1 files changed, 46 insertions(+), 1 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 16 +++-
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index 7de333c..a23aaf6 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4.in
@@ -1479,21
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index a23aaf6..22837ea 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 2, 2011, at 5:37 PM, Peter Hutterer wrote:
We dereference dev-proximity for proximity events in UpdateDeviceState().
Unconditionally, on the premise that a device that sends proximity events
has a ProximityClassRec. Let that premise
-by: Chase Douglas chase.doug...@canonical.com
Yeah, if you're gonna break it, might as well polish it when you're picking up
the rest of the pieces...
Reviewed-by: Jeremy Huddleston jerem...@apple.com
___
xorg-devel@lists.x.org: X.Org development
Archives
Yuck.
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Nov 1, 2011, at 4:52 PM, Peter Hutterer wrote:
Introduced in xf86-input-evdev-2.6.0-26-g4969389
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Cutting long to int for the return value loses us some values, notably
This introduces a regression:
http://xquartz.macosforge.org/trac/ticket/517#comment:10
I see similar behavior changes in wine on Linux as I do on XQuartz, so I don't
think it's specific to XQuartz.
I'm planning on reverting this change from the 1.11 branch for tomorrow's
release unless
Ping. This one should be fairly trivial, and I'd like to get it in before the
first beta xserver release.
Thanks,
Jeremy
On Oct 30, 2011, at 8:45 PM, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/common/xf86PciInfo.h |2 ++
hw/xfree86
Ah, I squashed that into the wrong commit.
This line should be in commit 4:
+AC_REQUIRE([XORG_COMPILER_FLAGS])
On Nov 3, 2011, at 12:55, Alan Coopersmith wrote:
On 11/03/11 01:19, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddlestonjerem...@apple.com
---
xorg-macros.m4.in | 29
memType is a uint64_t on powerpc. Using memType only really makes
sense for *physical* addresses, which can be 64-bit for 32-bit
systems running on 64-bit hardware.
However, unmapVidMem() only deals with *virtual* addresses, which
are guaranteed to fit into an uintptr_t.
Signed-off-by: Jeremy
The current test was always failing to compile because 'return 0;' was
global rather than in the body of a function.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index 3b02190..c4a521f 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 28 +---
1 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index c4a521f..456f78f 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4
See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 47 ++-
1 files changed, 46 insertions(+), 1 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 16 +++-
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index c362943..a2bf35c 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4.in
@@ -1454,21
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index a2bf35c..f9d633e 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4
the two is that CWARNFLAGS will include -fno-strict-aliasing).
--Jeremy
On Nov 1, 2011, at 1:16 PM, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff
Please ignore the bad grammar in the comment in this change. I'll fix it ;)
On Nov 1, 2011, at 1:16 PM, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
xorg-macros.m4.in | 28 +---
1 files changed, 9 insertions(+), 19 deletions
/html_node/Generating-Sources.html
Did you mean to change the macro to AC_LANG_PROGRAM?
-alan-
On 11/01/11 13:16, Jeremy Huddleston wrote:
The current test was always failing to compile because 'return 0;' was
global rather than in the body of a function.
Signed-off-by: Jeremy
memType is a uint64_t on powerpc
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/os-support/linux/lnx_video.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xfree86/os-support/linux/lnx_video.c
b/hw/xfree86/os-support/linux/lnx_video.c
index
interfaces. This eliminates all calls to mapPciRom,
which in turn allows the elimination of hw/xfree86/int10/pci.c.
On Nov 1, 2011, at 3:01 PM, Jeremy Huddleston wrote:
memType is a uint64_t on powerpc
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/os-support/linux
On Nov 1, 2011, at 5:48 PM, Daniel Stone wrote:
Hi,
On 1 November 2011 22:05, Jeremy Huddleston jerem...@apple.com wrote:
While this does fix the build failure, I'd much rather change memType to be
a uintptr_t everywhere, but it was explicitly set to uint64_t for 32bit
powerpc by Ian
You need to declare InputOption tmp; in input_option_free_list.
With that, both are Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 30, 2011, at 21:41, Peter Hutterer wrote:
ABI 14 made the InputOption type opaque, move the existing code to ifdefs
and use the new function calls
Does this need ifdef based on some ABI version?
On Oct 30, 2011, at 22:49, Peter Hutterer wrote:
Technically this shouldn't just work on the VCP since any master pointer may
end up in the dead area. However, I suspect the Venn diagramm of MPX users
and sis merged framebuffer users shows
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 31, 2011, at 3:41 PM, Peter Hutterer wrote:
ABI 14 made the InputOption type opaque, move the existing code to ifdefs
and use the new function calls otherwise.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Changes to v1
On Oct 20, 2011, at 15:22, Alan Coopersmith wrote:
I do see some warnings in build logs that it would turn into errors, and they
all seem to be in drivers, and frankly, only the first two of them do I really
care about:
radeon_accel.c, line 433: warning: implicit function declaration:
Wow, I wish I knew about this series before I started cleaning up the drivers...
Where was this series sent? I don't see it in my xorg-devel log.
By all means, take it over. Do you want to maintain it? If so, get yourself
an fd.o account, so you can get yourself commit access to the driver.
On Oct 30, 2011, at 18:18, Timo Aaltonen wrote:
30.10.2011 15:27, Jeremy Huddleston kirjoitti:
Wow, I wish I knew about this series before I started cleaning up the
drivers...
Where was this series sent? I don't see it in my xorg-devel log.
Looks like it was on 6th of April. I got
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/common/xf86PciInfo.h |2 ++
hw/xfree86/common/xf86pciBus.c |3 +++
hw/xfree86/doc/ddxDesign.xml|7 ---
hw/xfree86/fbdevhw/fbdevhw.c|1 -
hw/xfree86/os-support/bus/Pci.h |1 -
hw/xfree86/sdksyms.sh
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 27, 2011, at 22:07, Aaron Plattner wrote:
Commit 587c3a2d1961834558193e8e14e8e381a077a253 fixed DoGetImage to
check windows against their backing drawables, rather than against the
screen dimensions, to prevent reading outside
Yuck. Is there really no other way to do that? What exactly are the conflicts?
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Xext/shm.c |6 ++
hw/xfree86/os-support/xf86_OSlib.h |2 +-
2
Sorry.
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
Since the check is for !(compilers that support __builtin_constant_p)
it needs to be !(gcc or new enough Sun cc), but was written as
!(gcc or too old Sun cc).
Signed-off-by: Alan
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac|2 +
include/dix-config.h.in |3 ++
include/os.h|4 +++
os/Makefile.am
For all of them,
Reviewed-by: Jeremy Huddleston jerem...@apple.com
In this one, it looks like fp should be a (const char *) also. If you throw
that in there in a followup patch, consider it r-b as well.
On Oct 28, 2011, at 21:41, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith
For darwin, please also add:
DYLD_INSERT_LIBRARIES=/usr/lib/libgmalloc.dylib
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac | 16
test/Makefile.am |1 +
test/xi2/Makefile.am |
Reviewed-by: Jeremy Huddleston jerem...@apple.com
Why does xi2 need -wrap? Can we do these tests in a more portable way with
some clever macros?
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
test/Makefile.am |2 --
1
What about namespacing the ones in xserver instead? I'm sure it's possible
they could conflict with other platforms as well.
On Oct 29, 2011, at 10:24, Alan Coopersmith wrote:
On 10/29/11 00:16, Jeremy Huddleston wrote:
Yuck. Is there really no other way to do that? What exactly
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 29, 2011, at 10:39, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Split out of the prior patch Convert strncpy/strncat to strlcpy/strlcat
hw/xfree86/common/xf86pciBus.c |5 ++---
1
On Oct 29, 2011, at 14:01, Tormod Volden wrote:
On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston jerem...@apple.com
wrote:
So, what's the point of having all these in common? Why don't they just
live in the drivers? It seems silly to have these defined in the server's
SDK rather
For future reference, please send patches to the list as a new thread,
preferibly with git-send-email or git-format-patch and your own mailer.
On Oct 29, 2011, at 12:54, Michal Suchanek wrote:
Hello,
Sending the patch for bug 41653.
The following changes since commit
Seems like the right thing to me
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 29, 2011, at 09:40, Anssi Hannula wrote:
On 20.04.2011 14:34, Anssi Hannula wrote:
From 003e32786053eb01e2a84697487aa134214f140c Mon Sep 17 00:00:00 2001
From: Anssi Hannula anssi.hann...@iki.fi
Date
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
1) Is DixReadAccess the right access for these?
2) What conditional CPP logic should I use for doing LookupWindow on older
servers?
src/sis_driver.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src
The following 7 bug reports are in either the 1.11 or 1.12 tracker and have
patches attached or sent to the list which either fix the underlying issue or
work around a crash due to the issue. I'd like to get these reviewed and
merged. If you're in the CC of this email, then you have dropped
The following changes since commit 5701ab4a441eb113abd0851b0d71b82d12112854:
Merge remote-tracking branch 'whot/for-keith' (2011-10-24 22:09:00 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (3):
XQuartz: applewm
On Oct 25, 2011, at 1:22 AM, Mark Kettenis wrote:
From: Jeremy Huddleston jerem...@apple.com
Date: Mon, 24 Oct 2011 19:41:00 -0700
On Oct 24, 2011, at 7:05 PM, Keith Packard wrote:
And, do we allow the use of
strndup in the server?
Alan just asked that a few days ago ;).
I
While we do need to get to the root cause, the extra sanity checking in here is
good.
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 11, 2011, at 5:38 AM, Michal Suchanek wrote:
Looks like Xorg crashes on exit after 463dd87
To reproduce:
export DISPLAY=:1 ; X :1 sleep 2 ; dwm
On Oct 20, 2011, at 06:04, Ville Syrjälä wrote:
On Wed, Oct 19, 2011 at 05:26:09PM -0700, Keith Packard wrote:
On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala syrj...@sci.fi wrote:
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=22566
Merged.
e4787ec..a5266dc master - master
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 23, 2011, at 23:02, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/xiquerydevice.c |7 +++
dix/eventconvert.c | 14 --
2 files changed, 7 insertions(+), 14 deletions(-)
diff
On Oct 24, 2011, at 7:05 PM, Keith Packard wrote:
And, do we allow the use of
strndup in the server?
Alan just asked that a few days ago ;).
I wouldn't be against using strndup, but there would need to be an in-tree
implementation provided for systems that lack it (like OSX 10.6 and prior)
Thanks. Sorry for missing those.
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 24, 2011, at 8:41 PM, Alan Coopersmith wrote:
Two instances found in the SIOCGIFCONF code for listing network interfaces.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
os/access.c
Why not change the format string to use %ld for sizeof() instead of casting?
For the others (and this one if you feel strongly about the casting):
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 21, 2011, at 20:56, Alan Coopersmith wrote:
Mostly due to difference between sizeof int
Should those commit messages really have v2 and v3 in them? It sounds like
they were updated based on feedback during review, which isn't really something
that needs to be mentioned in the commit log...
On Oct 20, 2011, at 01:52, Dave Airlie wrote:
Fixes from RHEL coverity scan + fbdev
I'm confused by the comment, and just using master ... because the prototype
changes:
-XISendDeviceChangedEvent(DeviceIntPtr device, DeviceIntPtr master,
DeviceChangedEvent *dce)
+XISendDeviceChangedEvent(DeviceIntPtr device, DeviceChangedEvent *dce)
which seems like you were just using
On Oct 19, 2011, at 23:45, Jamey Sharp wrote:
I think we coddled the drivers enough with the current set of
just-deprecations. This is too trivial. I'll just go through and
make sure nobody is actually using it because drivers still build
successfully due to us not using
On Oct 20, 2011, at 12:08, Julien Cristau wrote:
if (xnestParentWindow != (Window) 0
X.xdestroywindow.window == xnestParentWindow)
+CloseWellKnownConnections();
+OsCleanup(1);
exit (0);
That looks broken, don't you need braces around the if branch? Also I'm
not
So the tdfx driver has this hunk of code in it currently does the following:
#if USE_PCIVGAIO
hwp-PIOOffset = pTDFX-PIOBase[0] - 0x300;
#endif
Can someone please explain to me why it's doing that?
___
xorg-devel@lists.x.org: X.Org development
This partially reverts b3d56d06ef840bbbe16ec3c37e170078b7f98b04 to allow
driver developers time to adjust.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
The commit that deprecated the PCITAG type had these leftovers that I didn't
mean to get rid of just yet.
hw/xfree86/os-support
Reviewed-by: Jeremy Huddleston jerem...@apple.com
Looks good, but style-wise, I liked the mode = pScrn-monitor-Modes where it
was before ... meh
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda sets an xorg.conf with a fixed 800x600
I actually prefer Alan's suggestion, so with his version:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:51 AM, Alan Coopersmith wrote:
On 10/19/11 09:01, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
Initialise the pAttr-values to NULL so if the values
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code had an off-by-one and would allow writing one past the end of
the callbacks array.
Pointed out by coverity.
Signed-off-by: Dave Airlie airl
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
this code wasn't allocating enough space and was assigning the NULL
one past the end.
Pointed out by coverity.
Signed-off-by: Dave Airlie airl
401 - 500 of 1288 matches
Mail list logo
