[PATCH xserver 3/6] Create a threaded mechanism for input

e by default on non-Linux This also splits out the actual enabling of input threads to DDX-specific patches which follow Signed-off-by: Adam Jackson <a...@redhat.com> Signed-off-by: Keith Packard <kei...@keithp.com> --- configure.ac | 29 dix/globals.c | 2 + dix

[PATCH xserver 4/6] xfree86: Use threaded input mechanism

Switch the XFree86 DDX over to threaded input Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xfree86/common/xf86Events.c | 5 +++-- hw/xfree86/common/xf86Helper.c | 2 +- hw/xfree86/common/xf86Init.c | 3 +++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/x

[PATCH xserver 6/6] dix: Reallocate touchpoint buffer at input event time

Now that input is threaded, malloc can be used at event time to resize the touchpoint buffer as needed.x --- dix/touch.c | 89 + 1 file changed, 30 insertions(+), 59 deletions(-) diff --git a/dix/touch.c b/dix/touch.c index

[PATCH xserver 1/6] Add stubs to input.h

--- include/input.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/input.h b/include/input.h index d8bd9c6..5bc60f0 100644 --- a/include/input.h +++ b/include/input.h @@ -712,4 +712,10 @@ extern _X_HIDDEN void input_constrain_cursor(DeviceIntPtr pDev, ScreenPtr screen

[PATCH xserver 2/6] Remove SIGIO support.

-off-by: Keith Packard <kei...@keithp.com> --- Xi/exevents.c | 4 +- config/config.c | 4 +- dix/devices.c | 10 +- dix/ptrveloc.c| 4 +- dix/touch.c

[PATCH xserver 5/6] kdrive: Use threaded input

Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/src/kinput.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/kdrive/src/kinput.c b/hw/kdrive/src/kinput.c index a3e352c..a2fff1c 100644 --- a/hw/kdrive/src/kinput.c +++ b/hw/kdrive/src/kinput.c @@

Re: [PATCH xserver 2/6] Remove SIGIO support.

Alan Coopersmith writes: > Shouldn't this also remove all the USE_SIGIO_BY_DEFAULT references in > configure.ac? Yes. Thanks! -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 0/5] Remove DRI1

Michel Dänzer writes: > FWIW, the latter is no reason to remove DRI1 support as a whole AFAICT: > SIGIO was only used for DRI1 kernel driven context switching, It looks like the only non-SIGIO path would be for drivers using DRI_KERNEL_SWAP; DRI_HIDE_X_CONTEXT and

Re: [PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

Adam Jackson writes: > I've left off the libXfont2 bit in 5/20, since there's neither a > release nor bits in git to build against yet; 18/20 and 19/20 since > they require that 5/20 be already in; and 20/20 since xwayland is using > that API now. I've released the first version

Re: [PATCH xserver 0/6] Use a thread for input

Keith Packard <kei...@keithp.com> writes: > Here's a series which revives Tiago's ancient threaded input > patch. I've spent some time debugging and cleaning this up further; I found a couple of deadlocks, and then I also fixed mieqEnqueue to resize the input event queue when

Re: Deliver input events only to window owner

Peter Hutterer writes: > the main problem is: I don't know what we'll break with this. I really don't > know who uses raw keyboard events, or if anyone does. We'll clearly have to leave people with the option to re-enable whatever we disable for the sake of security.

Re: Deliver input events only to window owner

Peter Hutterer writes: > that's going to be fun to work out. raw events are delivered to the root > window only so you don't really know which client they get delivered to. > They're before the actual event in the pipe, and in some cases the event > isn't delivered to

Re: xserver: Branch 'master' - 16 commits

Michel Dänzer writes: > This commit broke input for me with xf86-input-libinput. No keyboard or > mouse input is received. There are no errors in the log file. > > xf86-input-evdev works. I didn't test xf86-input-libinput at all, I'm afraid, thanks for catching this. --

Re: Deliver input events only to window owner

Peter Hutterer writes: > note that this does not handle XI2 raw keyboard events, they will need to be > handled as well. Hrm. So, there's a problem here -- raw events get delivered separately From core events. Having the window owner select for core events will have no

Re: Disabling RECORD by default

Peter Hutterer writes: > Really, the only sensible solution is what we did with libinput, but > that's not going to find its way back into synaptics. Yeah, trading security for features only on non libinput-based systems seems entirely reasonable to me. -- -keith

Re: Deliver input events only to window owner

Peter Hutterer writes: > looks correct, and it would also be fairly trivial to add test cases for > this to XIT. I didn't check the spec for the exact wording, but either way > we should add it. > Reviewed-by: Peter Hutterer Did you like the

Re: Disabling RECORD by default

Peter Hutterer writes: > disable _the_ XTEST extension? in at least two places. One comment, just to > be annoying: I'd prefer this split in two patches, with the second one just > toggling the true/false switch for RECORD and having the git subject line of > "Disable

Re: unifdef INET6 ?

Adam Jackson writes: > --disable-ipv6 seems to save you all of 5k of binary size, which really > isn't enough for me to care.  I'd be fine with making that code > unconditional if we also silenced the warning chirp from xtrans when > running on a v6-less kernel. Yeah, seems like

Re: Hiding keyboard state

Adam Jackson <a...@nwnk.net> writes: > On Mon, 2015-11-23 at 11:04 -0800, Keith Packard wrote: >> One of the many security holes in X is that any application can monitor >> the state of the keyboard device by querying the list of pressed keys on >> a regular basis.

Disabling RECORD by default

Keith Packard <kei...@keithp.com> writes: Here's a patch, which first splits out the command line and config file options for XTEST and RECORD, and then disables RECORD by default but leaves XTEST enabled by default. From 2f1872f518ca7640efc42870800536f8e45c4b23 Mon Sep 17 00:00:00 200

Re: [PATCH xserver 18/20] Remove readmask from screen block/wakeup handler

elongs in here, > Xext/sleepuntil.c at least. 19/20 is the RegisterBlockAndWakeupHandler interfaces, I think I got all of them into the right patch? At least the compiler doesn't complain with this version (which does fix a couple of pTimeout/timeout mistakes): From 9b4979091276e6a1e1726473e95b7474454993c4 Mon Sep 17 00:

Re: Disabling RECORD by default

:00:00 2001 From: Keith Packard <kei...@keithp.com> Date: Mon, 23 Nov 2015 14:49:33 -0800 Subject: [PATCH xserver] Allow RECORD and XTEST to be controlled separately [v2] RECORD and XTEST were both controlled by the -tst server option and XTEST extension selection. Split these out and then m

Deliver input events only to window owner

2001 From: Keith Packard <kei...@keithp.com> Date: Mon, 23 Nov 2015 16:04:54 -0800 Subject: [PATCH xserver] Deliver input events exclusively to window owner When the window owner selects for core keyboard and mouse events, don't go looking for other clients to deliver those events to. This

Re: Disabling RECORD by default

Jeremy Huddleston Sequoia writes: > The XQuartz option was meant mainly for RECORD. I'll followup later > to add a preference option for RECORD in XQuartz. I'm not surprised to hear that; XTEST is quite a bit more useful and less scary. -- -keith signature.asc

Re: Disabling RECORD by default

Emil Velikov writes: > Although TEST being unconditionally set (in configure.ac) we have the > above guard and a second one in include/extinit.h. I take it that > those are just left over from the olden days ? Yes, I think so. -- -keith signature.asc Description:

Re: Disabling RECORD by default

nged to: .TP 8 .B \-tst disables XTEST extension. From ff5b0d12391932b13cd93fddc802a01bd5e52f2b Mon Sep 17 00:00:00 2001 From: Keith Packard <kei...@keithp.com> Date: Mon, 23 Nov 2015 14:49:33 -0800 Subject: [PATCH xserver 2/3] Allow RECORD and XTEST to be controlled separately [v3] RECORD

Re: [PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

Peter Harris writes: > Data point: > > I've got a Dell box (also Ivy Bridge) where calling GetTimeInMillis() > after each request dings noop performance by like 30% because the TSC is > unstable. That's terrible. > That said, this box is an outlier. Every other recent box

Hiding keyboard state

eful hacks and extensions take advantage of being able to get contents from other windows. 3) breaking screen saver security. We've got an extension, let's make it work. -keith From 627815391d2d6845f7e0a66d447c6b379be9d3cb Mon Sep 17 00:00:00 2001 From: Keith Packard <kei...@keithp.com> D

Re: [PATCH] composite: Don't bother copying the pixmap for ForgetGravity windows (v3)

Adam Jackson writes: > I think this still needs to address what I wrote in paragraph 2 here: > > http://lists.freedesktop.org/archives/xorg-devel/2015-May/046376.html Yeah, I was just looking at the implementation and not the architecture... -- -keith signature.asc

Re: [PATCH] composite: Don't bother copying the pixmap for ForgetGravity windows (v3)

"Jasper St. Pierre" writes: > +static Bool > +needsPixmapCopy(WindowPtr pWin) > +{ > +WindowPtr pChild; > + > +if (pWin->bitGravity != ForgetGravity) > +return TRUE; > + > +for (pChild = pWin->firstChild; pChild; pChild = pChild->nextSib) > +if

Re: [PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

Adam Jackson <a...@nwnk.net> writes: > On Wed, 2015-11-11 at 22:02 -0800, Keith Packard wrote: >> This allows the server to call GetTimeInMillis() after each request is >> processed to avoid needing setitimer. -dumbSched now turns off the >> setitimer. > > I'm not

Re: [PATCH xserver 03/20] os: Implement support for NotifyFd X_NOTIFY_WRITE

Adam Jackson writes: > ISTR the server currently has a "write then read" strategy for deadlock > avoidance (and accidentally better reliability when low on memory).  Do > we want to do that here too, and if we do, do we split this into > walking the list twice to enforce the

Re: [PATCH xserver 08/20] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Adam Jackson writes: > This tripped me up at first (here and elsewhere in the series), it > looks weird to read an fd that isn't the one passed in as an argument. Yeah, trying for minimal patches sometimes doesn't result in the best code. I can change these easily enough. --

Re: [PATCH xserver 1/2] dix: Call screen block/wakeup handlers closest to blocking

Adam Jackson <a...@nwnk.net> writes: > On Fri, 2015-11-13 at 08:37 -0800, Keith Packard wrote: > >> @@ -132,6 +131,7 @@ shadowSetup(ScreenPtr pScreen) >>   >>  wrap(pBuf, pScreen, CloseScreen); >>  wrap(pBuf, pScreen, GetImage); >> +wrap(

Re: glamor and the sync extension

Mark Kettenis writes: > Currently glamor hits an assertion on systems that don't have > xshmfence. This happens when the glamor code calls > miSyncGetScreenFuncs() because the miSyncScreenPrivateKey has not been > set up. For systems with xshmfence, this happens when >

Re: [PATCH 2/2] modesetting: setup entity for pci probed devices.

Dave Airlie writes: > +pEnt = xf86GetEntityInfo(entity_num); Can this fail? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] glamor: Make glamor_name_from_pixmap work without DRI3

Mark Kettenis writes: > This function is used by the modesetting driver to implement DRI2 and > shouldn't fail on systems that don't support DRI3. If glamor_egl_dri3_fd_name_from_tex works on systems not using DRI3, then it better have its name changed to match reality.

Re: [PATCH xlib] Add support for a display-specific error handler

"Jasper St. Pierre" writes: > Writing error-safe code that uses Xlib is too obnoxious, and using XCB > is tedious and not performant, as we can't catch events on a giant > stream -- we have to check every operation manually. You get errors returned in the event stream; is

Re: [PATCH xserver 10/20] kdrive/ephyr: Use NotifyFd for XCB connection input [v2]

Uli Schlachter writes: > If "something" uses xcb (even just sending a request is enough, doesn't have > to > be waiting for a reply), xcb could read an event from its FD and append it to > its internal queue. At this point there is a pending event in the queue, but > the >

Re: [PATCH xserver 10/20] kdrive/ephyr: Use NotifyFd for XCB connection input [v2]

Uli Schlachter writes: > Yup. > > If I understand the code correctly, that's exactly what the "old" code does. Well, I went digging (always a bad thing on Friday morning) and discovered that the block handlers were being called in the wrong order to allow the driver to reliably

[PATCH xserver 1/2] dix: Call screen block/wakeup handlers closest to blocking

and not unwrapping. And composite might as well join in that fun, just to make things consistent. Signed-off-by: Keith Packard <kei...@keithp.com> --- dix/dixutils.c| 16 glamor/glamor.c | 6 +++--- miext/shadow/shadow.c | 19 ++- miext/

[PATCH xserver 0/2] Reorder block handlers to avoid polling in ephyr

Here's a pair of patches which removes the need for ephyr to poll for input by fixing the block and wakeup handler ordering in the server so that the driver is the last one in the pool before the server goes to sleep. -keith ___ xorg-devel@lists.x.org:

Re: [PATCH xf86-input-libinput 3/3] Split mixed pointer/keyboard devices into two separate X devices

o = xf86NextOption(o); > + } Everything else was quite clear until I got to this, but I waded through and this looks fine too :-) Reviewed-by: Keith Packard <kei...@keithp.com> -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.o

[PATCH xserver 08/20] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Replace the block/wakeup handlers with a NotifyFd callback Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/linux/linux.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/kdrive/linux/linux.c b/hw/kdrive/linux/linux.c index 73a8169..a

[PATCH xserver 03/20] os: Implement support for NotifyFd X_NOTIFY_WRITE

This adds the ability to be notified when a file descriptor is available for writing. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/WaitFor.c| 30 -- os/connection.c | 40 +++- os/io.c | 8 os/o

[PATCH xserver 20/20] mi: Remove miPointerRec from API

This moves the definition of miPionterRec from mipointrst.h to mipointer.c so that it is no longer visible in the API, allowing it to be changed while the API/ABI is frozen. Signed-off-by: Keith Packard <kei...@keithp.com> --- mi/mipointer.c | 12 mi/mipointrst.

[PATCH xserver 12/20] hw/xwayland: Use NotifyFd handler to monitor wayland socket

Replace the block/wakeup handler with a NotifyFd callback instead. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xwayland/xwayland.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index e

[PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

This allows the server to call GetTimeInMillis() after each request is processed to avoid needing setitimer. -dumbSched now turns off the setitimer. Signed-off-by: Keith Packard <kei...@keithp.com> --- configure.ac| 2 +- dix/dispatch.c | 17 ++--- inclu

[PATCH xserver 18/20] Remove readmask from screen block/wakeup handler

With no users of the interface needing the readmask anymore, we can remove it from the argument passed to these functions. Signed-off-by: Keith Packard <kei...@keithp.com> --- composite/compalloc.c | 4 ++-- dix/dixutils.c | 14 ++---

[PATCH xserver 05/20] dix: Switch to the libXfont2 API (v2)

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. v2: Use libXfont2 instead of libXfont_2 Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/xf86bigfont.c

[PATCH xserver 10/20] kdrive/ephyr: Use NotifyFd for XCB connection input [v2]

Eliminates polling every 20ms for device input. v2: rename ephyrPoll to ephyrXcbNotify and fix the API so it can be used directly for SetNotifyFd. Thanks to Daniel Martin <consume.no...@gmail.com> Signed-off-by: Keith Packard <kei...@keithp.com> Cc: Daniel Martin <consume.

[PATCH xserver 07/20] config: Use NotifyFd interface for udev

This uses the NotifyFd interface to monitor the udev file descriptor rather than adding another block/wakeup handler Signed-off-by: Keith Packard <kei...@keithp.com> --- config/udev.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-)

[PATCH xserver 02/20] os: Add NotifyFd interfaces

); RemoveNotifyFd may be called from the notify function. Signed-off-by: Keith Packard <kei...@keithp.com> --- include/os.h| 13 os/WaitFor.c| 4 +++ os/connection.c | 93 + os/osdep.h | 5 os/osinit.c |

[PATCH xserver 09/20] hw/kdrive: Use NotifyFd for kdrive input devices

This switches the kdrive code to use FD notification for input devices, rather than the block and wakeup handlers. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/src/kinput.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --gi

[PATCH xserver 13/20] Xext/xselinux: Use NotifyFd interface

Replace block/wakeup handlers with SetNotifyFd. Much nicer now. Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/xselinux_hooks.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/Xext/xselinux_hooks.c b/Xext/xselinux_hooks.c index d9f2f68..2

[PATCH xserver 04/20] dix: Move InitFonts up above screen initialization

to ResetFontPrivateIndex inside InitFonts. Signed-off-by: Keith Packard <kei...@keithp.com> --- dix/dixfonts.c | 2 ++ dix/main.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 300bf04..19db141 100644 --- a/dix/dixfonts.c +++

[PATCH xserver 14/20] os/xdmcp: Replace xdmcp block/wakeup handlers with timer and NotifyFd

This removes the block and wakeup handlers and replaces them with a combination of a NotifyFd callback and timers. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/xdmcp.c | 114 +++-- 1 file changed, 36 insertions(+), 78 del

[PATCH xserver 06/20] config: Use NotifyFd for dbus interface

This uses the NotifyFd interface to monitor the dbus socket rather than a block/wakeup handler. Signed-off-by: Keith Packard <kei...@keithp.com> --- config/dbus-core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/config/dbus-core.c b/config/dbus-

[PATCH xserver 16/20] hw/xfree86: Use NotifyFd for device and other input fd wakeups

Remove code in xf86Wakeup for dealing with device and other input and switch to using the new NotifyFd interface. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xfree86/common/xf86Events.c | 67 -- 1 file changed, 26 insertions(+), 41 del

[PATCH xserver 19/20] Remove fd_set from Block/Wakeup handler API

This removes the last uses of fd_set from the server interfaces outside of the OS layer itself. Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/sleepuntil.c | 17 +++-- Xext/sync.c | 12 ++-- dix/dixfonts.c

Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

Eric Anholt writes: > I think it's a safe enough assumption that we're not generating non-OOM > errors. And, now that we're logging errors, we should get reports of > them sooner than we used to. Would it be sensible to wrap the glGetError call like this? GLenum

[PATCH xserver 15/20] render: Use OsTimer for animated cursor timing

This replaces the block/wakeup handlers with an OsTimer. This also avoids problems with performing rendering during the wakeup handler. Signed-off-by: Keith Packard <kei...@keithp.com> --- render/animcur.c | 57 +--- 1 file chang

Re: [PATCH evdev] Only map x and y to axes 0 and 1

reedesktop.org/show_bug.cgi?id=92856 > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Reviewed-by: Keith Packard <kei...@keithp.com> (who was surprised that "if (mapping == i) i++;" already existed in the code for no good reason un

Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

Eric Anholt writes: > +if (glGetError() == GL_OUT_OF_MEMORY) { It seems like you'll need to call this in a loop in case multiple error bits are set? And, don't you need to call this (repeatedly) before the function which might generate an error in case there was an

Re: X server commit process

Jeremy Huddleston Sequoia writes: > What is the current process for pulling into release branches? Are > the breakdowns the same, or is someone specific going to manage > release branches? We didn't discuss making any changes, and I think we can probably leave that up

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

Jeremy Huddleston Sequoia writes: > I thought we required C99 now. Was I mistaken in that? If not, I'm > fine with just leaving it as is and ignoring the warning. We're not (yet) allowing mixed declarations and code. To get rid of the warning (a good idea), you'll just

Re: [PATCH] glamor: fix crash when drawing nothing

Rob Clark writes: > On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> For example, in the PolyFillRect() path w/ nrect==0, we end up in >>> glamor_get_vbo_space(size=0): >> >> I wonder instead if we

Re: [PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

Alan Coopersmith writes: > Long long ago, the xserver's include/misc.h had: > #define abs(a) ((a) > 0 ? (a) : -(a)) > which worked for code like this, but git history says that was removed in > XFree86 4.3.0.1 (commit d568221710959cf in the current xserver git repo)

X server commit process

- security * Peter Hutterer - input * Adam Jackson - xfree86 backend * Keith Packard- misc All of us will also pick up minor patches throughout the tree and get them merged. We still have a requirement that each patch be marked as Reviewed-by: and include a Signed-off-by: line, and need

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > Yes, otherwise we'd crash in miPointerUpdateSprite when trying to access > pCursor->bits. pSpriteCursor, not pCursor. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xwayland 1/2] events: Stop tracking current cursor ourself

ndant code like this. Reviewed-by: Keith Packard <kei...@keithp.com> ` -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > As mentioned, a different approach would be to work-around the issue in > xwayland, but I consider such a solution more hacky than this. Please let > me know what you think. All you need do in xwayland is smash pSpriteCursor to some other value, like

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl <jad...@gmail.com> writes: > On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote: >> Jonas Ådahl <jad...@gmail.com> writes: >> >> > As mentioned, a different approach would be to work-around the issue in >> > xwayland, b

Re: [PATCH xwayland] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > Sure, if relying on mipointer doing this is fine then why not. Yeah, there are lots of places where the original API design from 1987 doesn't make much sense in 2015. Who would have thought? > I'd still need to add the 'invalidate' state to mipointer.c

Re: [PATCH xserver 07/24] os: Add NotifyFd interfaces

Alan Coopersmith <alan.coopersm...@oracle.com> writes: > On 09/20/15 11:16 PM, Keith Packard wrote: >> This provides a callback-based interface to monitor file >> descriptors beyond the usual client and device interfaces. >> >> Modules within the server u

Re: [PATCH xwayland] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > The reason I didn't do this was that we'd send duplicate set_cursor > requests when the cursor actually did change. What the patch does is > make it so that the path that actually does change the cursor when it > changes according to the X server always

Re: [RFC] [PATCH] Extend block and wakeup handling to cover writes as well

Pierre Ossman writes: > Ping. Still in the list? :) Did you see my recent patches that add a new API for file descriptor monitoring? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

[PATCH xserver 08/24] os: Implement support for NotifyFd X_NOTIFY_WRITE

This adds the ability to be notified when a file descriptor is available for writing. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/WaitFor.c| 30 -- os/connection.c | 40 +++- os/io.c | 8 os/o

[PATCH xserver 09/24] dix: Move InitFonts up above screen initialization

to ResetFontPrivateIndex inside InitFonts. Signed-off-by: Keith Packard <kei...@keithp.com> --- dix/dixfonts.c | 2 ++ dix/main.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 300bf04..19db141 100644 --- a/dix/dixfonts.c +++

[PATCH xserver 21/24] hw/xfree86: Use NotifyFd for device and other input fd wakeups

Remove code in xf86Wakeup for dealing with device and other input and switch to using the new NotifyFd interface. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xfree86/common/xf86Events.c | 67 -- 1 file changed, 26 insertions(+), 41 del

[PATCH xserver 15/24] kdrive/ephyr: Use NotifyFd for XCB connection input

Eliminates polling every 20ms for device input. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/ephyr/ephyr.c | 10 +- hw/kdrive/ephyr/ephyr.h | 3 --- hw/kdrive/ephyr/hostx.c | 6 ++ hw/kdrive/ephyr/hostx.h | 2 ++ hw/kdrive/ephyr/os.c| 1 - 5 files c

[PATCH xserver 07/24] os: Add NotifyFd interfaces

); RemoveNotifyFd may be called from the notify function. Signed-off-by: Keith Packard <kei...@keithp.com> --- include/os.h| 13 os/WaitFor.c| 4 +++ os/connection.c | 93 + os/osdep.h | 5 os/osinit.c |

[PATCH xserver 02/24] Xext/xselinux: Warning fixes

There's a 'const char *' adventure here that I'm mostly ignoring; some client information gets const poisoned. Worked around by adding a couple of casts. Ick. Added an _X_ATTRIBUTE_PRINTF to SELinuxLog. Ignore a couple of unused return values. Signed-off-by: Keith Packard <kei...@keithp.

[PATCH xserver 12/24] config: Use NotifyFd interface for udev

This uses the NotifyFd interface to monitor the udev file descriptor rather than adding another block/wakeup handler Signed-off-by: Keith Packard <kei...@keithp.com> --- config/udev.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-)

[PATCH xserver 05/24] os/xdmcp: Remove dead 'restart' code

from the server some time before XFree86 4.3.99.16, so the remaining bits of code have been dead for over a decade, and no-one ever noticed. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/xdmcp.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/os/xdm

[PATCH xserver 22/24] os: Use NotifyFd interface for listen descriptors

Replace the custom path for dealing with new incoming connections with the general-purpose NotifyFd API. Signed-off-by: Keith Packard <kei...@keithp.com> --- include/os.h| 3 -- os/WaitFor.c| 4 --- os/connection.c | 104 +++--

[PATCH xserver 19/24] os/xdmcp: Replace xdmcp block/wakeup handlers with timer and NotifyFd

This removes the block and wakeup handlers and replaces them with a combination of a NotifyFd callback and timers. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/xdmcp.c | 114 +++-- 1 file changed, 36 insertions(+), 78 del

[PATCH xserver 24/24] Remove fd_set from Block/Wakeup handler API

This removes the last uses of fd_set from the server interfaces outside of the OS layer itself. Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/sleepuntil.c | 17 +++-- Xext/sync.c | 12 ++-- dix/dixfonts.c

[PATCH xserver 14/24] hw/kdrive: Use NotifyFd for kdrive input devices

This switches the kdrive code to use FD notification for input devices, rather than the block and wakeup handlers. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/src/kinput.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --gi

[PATCH xserver 00/24] Eliminate fd_set from non-OS code

Here's the latest version of the patch set to make the non-OS bits of the X server stop using fd_set. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 20/24] render: Use OsTimer for animated cursor timing

This replaces the block/wakeup handlers with an OsTimer. This also avoids problems with performing rendering during the wakeup handler. Signed-off-by: Keith Packard <kei...@keithp.com> --- render/animcur.c | 57 +--- 1 file chang

[PATCH xserver 18/24] Xext/xselinux: Use NotifyFd interface

Replace block/wakeup handlers with SetNotifyFd. Much nicer now. Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/xselinux_hooks.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/Xext/xselinux_hooks.c b/Xext/xselinux_hooks.c index d9f2f68..2

[PATCH xserver 06/24] os/xdmcp: Just send XDMCP keepalive packets once every three minutes

select masks easier. Signed-off-by: Keith Packard <kei...@keithp.com> --- os/xdmcp.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/os/xdmcp.c b/os/xdmcp.c index b1ee5d2..7939b41 100644 --- a/os/xdmcp.c +++ b/os/xdmcp.c @@ -84,8 +84,6 @@ stat

[PATCH xserver 01/24] fonts: Continue when font calls return Suspended more than once

previous behaviour, which permitted multiple Suspended returns and simply waited for the client to be signaled again so that the callback could continue processing the request. Signed-off-by: Keith Packard <kei...@keithp.com> Cc: Adam Jackson <a...@redhat.com> --- dix/dix

[PATCH xserver 13/24] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Replace the block/wakeup handlers with a NotifyFd callback Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/kdrive/linux/linux.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/kdrive/linux/linux.c b/hw/kdrive/linux/linux.c index 73a8169..a

[PATCH xserver 10/24] dix: Switch to the libXfont2 API (v2)

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. v2: Use libXfont2 instead of libXfont_2 Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/xf86bigfont.c

[PATCH xserver 16/24] modesetting: Use NotifyFd for drm event monitoring

Replace the block/wakeup handlers with a NotifyFd callback. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xfree86/drivers/modesetting/vblank.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/vblank.c b/hw/x

[PATCH xserver 23/24] Remove readmask from screen block/wakeup handler

With no users of the interface needing the readmask anymore, we can remove it from the argument passed to these functions. Signed-off-by: Keith Packard <kei...@keithp.com> --- composite/compalloc.c | 4 ++-- dix/dixutils.c | 14 ++---

[PATCH xserver 17/24] hw/xwayland: Use NotifyFd handler to monitor wayland socket

Replace the block/wakeup handler with a NotifyFd callback instead. Signed-off-by: Keith Packard <kei...@keithp.com> --- hw/xwayland/xwayland.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index b

[PATCH xserver 03/24] Xext, os: Remove OS-internal usages within XACE and XSELinux

These extensions were accessing internal OS functions and structures. Expose the necessary functionality to them and remove their use of osdep.h Signed-off-by: Keith Packard <kei...@keithp.com> --- Xext/xace.c | 13 ++--- Xext/xselinux_hooks.c | 1 - include/os.h

<    5   6   7   8   9   10   11   12   13   14   >