Re: libinput TabletToolAreaRatio pins cursor to 0,0

2024-11-04 Thread Peter Hutterer
Hi Edmund, Please file a bug against the xorg libinput driver here: https://gitlab.freedesktop.org/xorg/driver/xf86-input-libinput/ This feature is implemented in that driver so any bug will be in that code. Description is good enough, you can copy/paste that in there but it'll be easier to hand

Re: Does anyone still feel strongly about -Wdeclaration-after-statement ?

2024-08-07 Thread Peter Hutterer
On Sun, Jul 28, 2024 at 05:48:45PM -0700, Alan Coopersmith wrote: > Back when we first added a default set of compiler warning flags to our > xorg-macros.m4 for autoconf in 2008, we included -Wdeclaration-after-statement > since not all the compilers at the time supported this C99 feature (most > n

Re: Adding a new label "Regression" to xorg/xserver gitlab project

2024-07-24 Thread Peter Hutterer
On Tue, Jul 23, 2024 at 11:44:11AM +0200, Olivier Fourdan wrote: > Hi all, > > The master branch of the xserver is seeing a lot of changes, and people are > sometimes reporting regressions. > > I am proposing to add a new label "Regression" that would help quickly > identifying such issues in git

Re: consolidating CI builds

2024-06-11 Thread Peter Hutterer
On Tue, Jun 11, 2024 at 10:49:35AM +0200, Enrico Weigelt, metux IT consult wrote: > On 11.06.24 09:09, Peter Hutterer wrote: > > hi folks, > > > With my ci-templates maintainer hat on: no to xorg-specific templates in > > there, it gets too messy. > > Indeed that

Re: consolidating CI builds

2024-06-11 Thread Peter Hutterer
On Mon, Jun 10, 2024 at 12:11:56PM -0700, Alan Coopersmith wrote: > On 5/24/24 03:12, Enrico Weigelt, metux IT consult wrote: > > So, I'm thinking about creating some standard templates that all drivers > > can use. The interesting question now becomes: where to put these ? > > > > Abuse xorg/util

Re: CI/yaml: inlining or providing an "upstream" utility

2024-03-27 Thread Peter Hutterer
On Mon, Mar 25, 2024 at 11:19:49AM +0100, tlaro...@kergis.com wrote: > On Mon, Mar 25, 2024 at 08:07:24PM +1000, Peter Hutterer wrote: > > On Mon, Mar 25, 2024 at 08:36:44AM +0100, tlaro...@kergis.com wrote: > > > In a previous mail, I proposed, when autotools and meson are both

Re: CI/yaml: inlining or providing an "upstream" utility

2024-03-25 Thread Peter Hutterer
On Mon, Mar 25, 2024 at 08:36:44AM +0100, tlaro...@kergis.com wrote: > In a previous mail, I proposed, when autotools and meson are both > provided to build a module, to not verify what they provide by simply > diffing the resulting installation directories, but to treat pkgconfig > generated *.pc

Re: Why does xf86-input-evdev ignore the xkb_rules option?

2024-03-19 Thread Peter Hutterer
On Mon, Mar 18, 2024 at 05:55:04PM +0100, Martin Burggraf wrote: > Hi, >   > I have an input device/keyboard, which I reconfigured greatly, wrote my own > geometry files, symbols, keycodes and so on. > To make it work with X11 I wanted to write my own rules file for use with the > xf86-input-evde

Re: gitlab: remove old pipelines ?

2024-02-27 Thread Peter Hutterer
On Tue, Feb 27, 2024 at 01:09:41PM +0100, Enrico Weigelt, metux IT consult wrote: > Hello folks, > > > Is there a way to actually remove old pipelines ? > > Gitlab offers a "delete" button, but this doens't seem to work: > when pressing it, the button just spins forever - and after reload > not

Re: Can we rely on #pragma once ?

2024-02-19 Thread Peter Hutterer
On Mon, Feb 19, 2024 at 03:02:18PM +0100, Mark Kettenis wrote: > > Date: Mon, 19 Feb 2024 12:13:34 +0100 > > From: "Enrico Weigelt, metux IT consult" > > > > Hello folks, > > Hi Enrico, > > > we've got a lot of include files, therefore lots of guards. > > > > Modern C compilers should understa

marge-bot enabled on the xserver repo

2024-02-19 Thread Peter Hutterer
Just a heads-up, I've enabled marge-bot on the xserver repo so from now on please assign to @marge-bot to get the MR to merge which will then do the right thing (whatever it already does in mesa and other projects, it's all the same commandline anyway). Advantages include easier merging of multipl

Re: Licenses: being finicky

2024-02-16 Thread Peter Hutterer
On Fri, Feb 16, 2024 at 12:42:29PM +0100, tlaro...@kergis.com wrote: > On Fri, Feb 16, 2024 at 08:22:59PM +1000, Peter Hutterer wrote: > > On Wed, Feb 14, 2024 at 09:37:43PM +0100, tlaro...@kergis.com wrote: > > > Some meson.build, for example, have a SPDX-License-Identifier: tag

Re: Licenses: being finicky

2024-02-16 Thread Peter Hutterer
On Wed, Feb 14, 2024 at 09:37:43PM +0100, tlaro...@kergis.com wrote: > Some meson.build, for example, have a SPDX-License-Identifier: tag, > where "MIT" is mentionned, applying (I think) to the file itself, and > the project has an entry with a pair (license: 'MIT') applying to the > data by itself

Re: gitlab: failing check-merge-request on non MR branches

2024-02-15 Thread Peter Hutterer
On Thu, Feb 15, 2024 at 12:15:52PM +0100, Enrico Weigelt, metux IT consult wrote: > Hello friends, > > > is it intended that the check-merge-request job is always failing on > non MR branches ? See commit 88637d42dbc5c488c9a75a6042e6778c4928b007 in ci-templates for the motivation. I think that

Re: issues and merge requests

2024-02-06 Thread Peter Hutterer
On Tue, Feb 06, 2024 at 11:41:06AM +0100, Enrico Weigelt, metux IT consult wrote: > On 05.02.24 22:56, Peter Hutterer wrote: > > > Best approach is to add a line "Fixes #123" into the commit message > > and/or the merge request and gitlab will automatically link to

Re: issues and merge requests

2024-02-05 Thread Peter Hutterer
On Mon, Feb 05, 2024 at 09:52:50PM +0100, tlaro...@kergis.com wrote: > Alan Coopersmith has applied the merge request for libXau---thanks! > > I had written 2 issues, related, against libXau, that the patches > address, so I have closed the issues after the merge. > > It seems to me that writing

Re: Fork permissions on gitlab

2024-01-31 Thread Peter Hutterer
On Wed, Jan 31, 2024 at 12:21:58PM +0100, Enrico Weigelt, metux IT consult wrote: > Hello folks, > > > any operator here who could grant me fork permission in gitlab ? > I'm currently preparing several patch queues I'd like to submit. Please see https://gitlab.freedesktop.org/freedesktop/freede

Re: Release of access to Logs environment CI - GitLab- Xorg

2023-06-25 Thread Peter Hutterer
Hi Willian, On Mon, Jun 19, 2023 at 01:23:18PM -0300, Willian Mendonça wrote: [...] > To perform better validations of our approaches, we have developed a tool > for downloading and mining logs: > https://github.com/jacksonpradolima/gitlabci-torrent. However, in order to > use this tool, we need t

Re: X11 based application does not respond to touch after first touch ( ILI210x Touchscreen)

2023-06-08 Thread Peter Hutterer
bout it I have well and truly forgotten. Cheers, Peter > > Regards, > Vishnu > > On Thu, 8 Jun 2023 at 08:30, Peter Hutterer > wrote: > > > On Wed, Jun 07, 2023 at 01:04:02PM +0530, Vishnu Motghare wrote: > > > Hello All, > > > > > > X11

Re: X11 based application does not respond to touch after first touch ( ILI210x Touchscreen)

2023-06-07 Thread Peter Hutterer
On Wed, Jun 07, 2023 at 01:04:02PM +0530, Vishnu Motghare wrote: > Hello All, > > X11-based applications like xterm & xinput_calibrator do not respond to > touch after the first touch. > > We have an ILI210x Touchscreen controller & the kernel version is 5.15, > touch was working fine with the 5.

Re: Making new releases of X.Org modules

2022-12-08 Thread Peter Hutterer
On Thu, Dec 08, 2022 at 12:34:33PM -0800, Alan Coopersmith wrote: > On 12/7/22 19:07, Peter Hutterer wrote: > > fwiw, I've done similar things in the past, pushing a release out just > > to make some internal processes easier. It's simpler to update to a new > > vers

Re: Making new releases of X.Org modules

2022-12-07 Thread Peter Hutterer
On Wed, Dec 07, 2022 at 05:37:27PM -0800, Alan Coopersmith wrote: > Normally when I go through the list of modules which have had git commits > since their last release was tagged to decide what to make new releases of, > I skip over those which only have changes that don't really affect the > inst

Re: 504 to gitlab.freedesktop.org

2022-06-12 Thread Peter Hutterer
On Sun, Jun 12, 2022 at 05:57:05PM -0700, Jeremy Sequoia wrote: > Hey folks, > > I was going to spend a little bit of time putting out an update to XQuartz > to address a few bugs that I've been meaning to squash, but I'm having a bit > of an issue pulling down sources. > > Fetching via ssh://g..

Re: Buildability of the Xorg drivers

2022-02-04 Thread Peter Hutterer
On Thu, Feb 03, 2022 at 02:07:08AM +, Zack Rusin wrote: > > > > On Feb 2, 2022, at 15:27, Matt Turner wrote: > > > > On Sun, Jan 30, 2022 at 4:16 PM Alan Coopersmith > > wrote: > >> xf86-input-vmmouse > >> xf86-video-vmware > >> - do not allow merge requests > > > > This has been an iss

Re: tarball types (was: [ANNOUNCE] xf86-input-libinput 1.2.1)

2022-01-24 Thread Peter Hutterer
On Mon, Jan 24, 2022 at 03:53:23PM -0800, Alan Coopersmith wrote: > On 1/23/22 21:18, Peter Hutterer wrote: > > xf86-input-libinput 1.2.1 is now available. Primarily a few typos and misc > > minor fixes, the most visible change to distributions is that we now ship an > > xz t

Re: xinput: HUION H420 Pen: XChangeDeviceProperty: data: format questions.

2021-06-14 Thread Peter Hutterer
On Fri, Jun 11, 2021 at 12:46:59AM -0500, Mike Mestnik wrote: > Plz redirect me to where I can get assistance with this... > > Hello, > Using the xinput cmdline tool I'm fully able to leverage my > understanding of the HUION H420 Pen and it's properties. When using > xfconf-query I don't believ

Re: Fixing a bug in Synaptics driver but autogen ignores prefix

2020-11-30 Thread Peter Hutterer
On Mon, Nov 30, 2020 at 07:29:29PM +0100, Andrea G. Monaco wrote: > > > I don't think there's a configure flag for it but you can hack around that > > locally. > > > Thanks Peter, now I found it. > > But I'm still perplexed: I think that a software package should fully > respect the prefix

Re: Fixing a bug in Synaptics driver but autogen ignores prefix

2020-11-29 Thread Peter Hutterer
On Mon, Nov 30, 2020 at 02:17:53AM +0100, Andrea G. Monaco wrote: > Hello everyone, > > > I'm trying to understand and maybe fix a slightly annoying bug in the > Synaptics driver 1.9.1: sometimes the touchpad cursor on my Acer Aspire > E15 starts flickering or clicking furiously or stops; at time

Re: release fonttosfnt 1.1.1 ?

2020-10-18 Thread Peter Hutterer
Hi Matthieu, On Sun, Oct 18, 2020 at 10:18:42AM +0200, Matthieu Herrb wrote: > Would you be ok if I make a release of xfonttosfnt (or if you have > some time to do it on your side) to make the recent > work of Christopher Zimmerman and others available ? > > With the removal of bitmapped fonts su

new tool - xisxwayland

2020-05-11 Thread Peter Hutterer
Hi all, I'm planning to move this little tool to the xorg/app folder, but I'd like to double-check that we don't already have something like this: https://gitlab.freedesktop.org/whot/xisxwayland/ it's a tiny C program that connects to the X server and exits with status 0 if the X server is Xwayla

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Peter Hutterer
On Sat, Apr 04, 2020 at 11:16:08AM -0700, Rob Clark wrote: > On Sat, Apr 4, 2020 at 10:47 AM Nicolas Dufresne wrote: > > > > Le samedi 04 avril 2020 à 08:11 -0700, Rob Clark a écrit : > > > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > >

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Peter Hutterer
On Sat, Apr 04, 2020 at 08:11:23AM -0700, Rob Clark wrote: > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion

Re: US International (AltGr dead keys) and Ł

2020-03-20 Thread Peter Hutterer
On Sat, Mar 14, 2020 at 10:06:54AM -0500, Justin Eberlein wrote: > The US international (AltGr dead keys) layout has two Œ keys. Is it > possible to move Ø from L to K, make X the only Œ key, and make L Ł instead? https://gitlab.freedesktop.org/xkeyboard-config/ is where you can file an MR for thi

Re: X.Org modules which could use some help to release

2019-07-16 Thread Peter Hutterer
On Sun, Jul 14, 2019 at 06:34:20PM -0700, Alan Coopersmith wrote: > As you may have noticed, I've been working through the various modules to make > releases of those with significant enough change to justify a release (i.e. > more than just the autogen.sh cleanups & gitlab README/configure.ac upda

Re: How do I compile and package the X Server code?

2019-02-12 Thread Peter Hutterer
On Tue, Feb 12, 2019 at 01:19:51PM -0500, Adam Jackson wrote: > On Tue, 2019-02-12 at 17:22 +0100, Kevin Brace wrote: > > > I am able to compile X Server, although I do not know at this point > > how to install it to my preferred location (I will like to install it > > to /opt for testing purposes

Re: [PATCH xf86-input-synaptics] Use fabs() instead of abs() on double values.

2019-02-10 Thread Peter Hutterer
On Sun, Feb 10, 2019 at 06:46:12PM +0100, Walter Harms wrote: > > > > Matthieu Herrb hat am 10. Februar 2019 um 17:29 > > geschrieben: > > > > > > Silences clang warnings. > > > > Signed-off-by: Matthieu Herrb > > seems resonable > Reviewed-by: Walter Harms wharms@bfs,de remote: remote: Up

Re: [PATCH] XF86keysym: Add XF86XK_RotationLockToggle

2019-01-21 Thread Peter Hutterer
e latest kernel correctly generates > KEY_ROTATE_LOCK_TOGGLE events for this. So now I'm hooking up support for > it through all the higher layers. > > Signed-off-by: Hans de Goede Reviewed-by: Peter Hutterer Cheers, Peter > --- > include/X11/XF86keysym.h | 2 ++ >

Re: xkb_layout documentation

2019-01-02 Thread Peter Hutterer
yout option found in the config snippets. GNOME hasn't used the xorg.conf settings in a long long time now, it will apply the user-configured layout on login. that layout is stored in gsettings and will overwrite anything you set in the xorg.conf. Cheers, Peter > Am Mi., 2. Jan. 2019 u

Re: xkb_layout documentation

2019-01-01 Thread Peter Hutterer
On Wed, Dec 26, 2018 at 11:41:11AM +0100, Jens Harms wrote: > Hi All, > please point me to the current "InputClass" documentatation (if available). should be in man xorg.conf, not sure there's more than that short of google. > I tried to configure my keyboard. because setting the option "XkbLayou

Re: xorg-driver-xf86-input-libinput and input-keyboard

2019-01-01 Thread Peter Hutterer
On Wed, Dec 26, 2018 at 11:28:23AM +0100, Jens Harms wrote: > Hi All, > xf86libinput.c is initialising "xkb_layout" while kbd.c is using > "XkbLayout". > Someone? see my answer to your other email, xf86nameCompare() in the server ignores underscores and uppercase so these two are the same option.

Re: [PATCH app/xcursorgen v3] Update README for gitlab migration

2018-11-12 Thread Peter Hutterer
On Mon, Nov 12, 2018 at 11:55:18AM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer > --- > > v2: Moved to README.md and reduced whitespace in front of URLs so that > gitlab renders them as links instead of code fragements - s

Re: [PATCH v3] Allow fd.o to join forces with X.Org

2018-11-08 Thread Peter Hutterer
--- > > We're looking for feedback and comments on this patch. If it's not > widely controversial the final version of the patch will be put to a > vote at the 2019 X.Org elections. > > The patch applies to the X.Org bylaws git repo, which can be found at >

[PATCH app/fonttosfnt] Mark vsprintf_alloc as printf-like function

2018-10-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Review this quickly please, we have another release coming up in 9 years time and I don't want to miss the merge window. util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util.c b/util.c index 81c0489..5a23eeb 100644 --- a/util.c +++ b/u

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-25 Thread Peter Hutterer
On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > On Tue, 16 Oct 2018 at 08:17, Peter Hutterer > > wrote: > > > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > &

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-15 Thread Peter Hutterer
On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > The leadership of freedesktop.org (fd.o) has recently expressed interest > in having an elected governing body. Given the tight connection between > fd.o and X.Org and the fact that X.Org has such a governing body it > seemed obvious

[PATCH xf86-video-v4l 4/4] Fix ioctl return value handling

2018-10-07 Thread Peter Hutterer
Found by coverity Signed-off-by: Peter Hutterer --- src/v4l.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/v4l.c b/src/v4l.c index 8c2408c..9c6fabe 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -769,12 +769,15 @@ V4lSetPortAttribute(ScrnInfoPtr pScrn

[PATCH xf86-video-v4l 3/4] Fix handling of realloc failure

2018-10-07 Thread Peter Hutterer
Coverity complaint and whatnot Signed-off-by: Peter Hutterer --- src/v4l.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/v4l.c b/src/v4l.c index 583c7b8..8c2408c 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -1120,6 +1120,7 @@ V4LInit(ScrnInfoPtr pScrn

[PATCH xf86-video-v4l 2/4] Ensure the device name is null-terminated

2018-10-07 Thread Peter Hutterer
And expand the size to 18, because the stack array we copied this into is 18 bytes long. This covers us for up to 999 (kernel) v4l devices and that is definitely not a reason to use the "640k ought to be enough" meme. Found by - you guessed it - coverity! Signed-off-by: Peter Hutterer

[PATCH xf86-video-v4l 1/4] Remove unused variable osname

2018-10-07 Thread Peter Hutterer
Coverity is unhappy and there's enough unhappiness in this world already, so let's go for the low-hanging fruit. Signed-off-by: Peter Hutterer --- src/v4l.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/v4l.c b/src/v4l.c index 8db8f7d..0f1058e 100644 --- a/src/v4l.c +++ b

Re: [PATCH libXpm] After fdopen(), use fclose() instead of close() in error path

2018-10-01 Thread Peter Hutterer
ileToBuffer > '. > fp initialized at line 86 with fdopen > fp leaks when len < 0 at line 92. > > Introduced-by: commit 8b3024e6871ce50b34bf2dff924774bd654703bc > > Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Cheers, Peter &

Re: [PATCH app/xcursorgen] Update README for gitlab migration

2018-10-01 Thread Peter Hutterer
On Mon, Oct 01, 2018 at 10:11:07AM -0700, Alan Coopersmith wrote: > Does anyone have feedback on changing our README's like this? While I > sent this out as a patch to a specific repo, I figured once we have > an agreed upon template, we'd apply it to all of the repos. oh well, if you ask... :)

[PATCH app/xrandr] init the name to 0

2018-09-12 Thread Peter Hutterer
re obvious than the previous "use whatever memory is leftover from breakfast". This patch also adds a missing init_name(), much for the same reason. Signed-off-by: Peter Hutterer --- xrandr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xrandr.c b/xrandr.c index 7f1e867..

Re: [PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-12 Thread Peter Hutterer
On Wed, Sep 12, 2018 at 09:09:22AM +0200, Walter Harms wrote: > > > > Peter Hutterer hat am 12. September 2018 um 06:50 > > geschrieben: > > > > > > Fixes coverity complaints about potentially unterminated strings > > > > Signed-off

[PATCH xinput] property: plug a memory leak

2018-09-11 Thread Peter Hutterer
Not that it matters since we'll exit after this call anyway, but coverity is unhappy and that makes us all unhappy, doesn't it? Signed-off-by: Peter Hutterer --- src/property.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/proper

[PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-11 Thread Peter Hutterer
Fixes coverity complaints about potentially unterminated strings Signed-off-by: Peter Hutterer --- sessreg.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/sessreg.c b/sessreg.c index 0a8fdb2..53b30b0 100644 --- a/sessreg.c +++ b/sessreg.c

Re: [PATCH] devices: break after finding and removing device from lists

2018-09-11 Thread Peter Hutterer
fix it. > > Signed-off-by: Dave Airlie Reviewed-by: Peter Hutterer Cheers, Peter > --- > dix/devices.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dix/devices.c b/dix/devices.c > index 4a628afb0..1b18b168e 100644 > --- a/dix/devices.c > +++

Re: [PATCH xserver] hw/xwin: Fix 'make distcheck'

2018-08-30 Thread Peter Hutterer
On Mon, Aug 27, 2018 at 12:41:22PM +0100, Jon Turney wrote: > Add internal.h to SOURCES, omitted from 126c1cfa > > Signed-off-by: Jon Turney cd285922c..a9a5bd002 master -> master Cheers, Peter > --- > hw/xwin/winclipboard/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --

Re: [PATCH xserver] xwayland: use wayland axis_discrete event

2018-08-30 Thread Peter Hutterer
On Wed, Aug 15, 2018 at 08:54:25PM +1200, Scott Anderson wrote: > On 6/08/18 6:09 PM, Scott Anderson wrote: > > This prevents multiple scroll events happening for wayland compositors > > which send axis values other than 10. For example, libinput will > > typically return 15 for each scroll wheel s

Re: [PATCH xserver] man: Mention that InputClass overrides InputDevice.

2018-08-21 Thread Peter Hutterer
On Tue, Aug 21, 2018 at 10:02:14AM +0200, Michal Srb wrote: > To prevent confusion, since user may consider InputDevice as "stronger > selector" and expect that it will take priority over InputClass. I don't think this is correct, because the two are completely different. InputClass will pick up a

Re: [PATCH xserver] xwayland: use wayland axis_discrete event

2018-08-09 Thread Peter Hutterer
n axis event > following an axis_discrete event. However, it does not gurantee that > other events (including other axis_discrete+axis pairs) will not happen > in between them. So we must keep a list of outstanding axis_discrete > events. > > Signed-off-by: Scott Anderson Reviewed-by: P

Re: [PATCH xserver] meson: Add an option to build XSELINUX.

2018-08-09 Thread Peter Hutterer
On Thu, Aug 09, 2018 at 08:05:05PM -0700, Eric Anholt wrote: > Peter Hutterer writes: > > > On Thu, Aug 09, 2018 at 01:02:41PM -0700, Eric Anholt wrote: > >> Dependencies are ported from the automake build. > >> > >> v2: Make it a tristate defaulting

Re: [PATCH xserver] meson: Add an option to build XSELINUX.

2018-08-09 Thread Peter Hutterer
required: get_option('xselinux') == 'true') > +dep_audit = dependency('audit', required: get_option('xselinux') == > 'true') > + if get_option('xselinux') == 'true' > +build_xselinux = true > +

[PATCH xserver] dix: check_modmap_change() returns Success, not true

2018-08-07 Thread Peter Hutterer
Not sure what if anything calls XSetDeviceModifierMapping() but this would've failed all the time. check_modmap_change() returns Successs but we were treating it like a boolean. Fix this. Reported-by: Adam Jackson Signed-off-by: Peter Hutterer --- dix/inpututils.c | 2 +- 1 file chang

Re: [PATCH xserver 10/10] meson: Add detection of libsystemd-daemon.

2018-08-07 Thread Peter Hutterer
209', > required: false) > +if not libsystemd_daemon_dep.found() > +libsystemd_daemon_dep = dependency('libsystemd-daemon', required: false) > +endif we require meson > 0.42, released Sep 2017, but check for systemd > 209, released in Feb 2014

Re: [PATCH xserver 6/6] meson: Automatically detect HAVE_PTHREAD_SETNAME_NP

2018-08-01 Thread Peter Hutterer
On Wed, Aug 01, 2018 at 01:49:54PM -0700, Eric Anholt wrote: > Signed-off-by: Eric Anholt series Reviewed-by: Peter Hutterer Cheers, Peter > --- > include/meson.build | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/include/mes

Re: [PATCH app/fonttosfnt 5/5] Replace _BSD_SOURCE with _DEFAULT_SOURCE

2018-07-31 Thread Peter Hutterer
On Tue, Jul 31, 2018 at 05:48:54PM +0200, Walter Harms wrote: > > > > Peter Hutterer hat am 31. Juli 2018 um 03:53 > > geschrieben: > > > > > > /usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and > > _SVID_SOURCE > > are de

[PATCH app/fonttosfnt 3/5] Remove shadowing rc variable

2018-07-30 Thread Peter Hutterer
All code paths assign rc and heck it immedately after. We can re-use the one from the outer loop. Signed-off-by: Peter Hutterer --- read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read.c b/read.c index bee518c..98522b5 100644 --- a/read.c +++ b/read.c @@ -107,7 +107,7

[PATCH app/fonttosfnt 5/5] Replace _BSD_SOURCE with _DEFAULT_SOURCE

2018-07-30 Thread Peter Hutterer
/usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" Signed-off-by: Peter Hutterer --- Makefile.am | 2 +- 1 file change

[PATCH app/fonttosfnt 2/5] README: update repository URL to gitlab

2018-07-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- README | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/README b/README index 58f1062..fa3ad08 100644 --- a/README +++ b/README @@ -12,9 +12,7 @@ Please submit bug reports to the Xorg bugzilla: The master development code repository can

[PATCH app/fonttosfnt 4/5] Fix shadowing i variable complaint

2018-07-30 Thread Peter Hutterer
C99 is a magical thing! Signed-off-by: Peter Hutterer --- read.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/read.c b/read.c index 98522b5..632c7e7 100644 --- a/read.c +++ b/read.c @@ -58,7 +58,7 @@ FT_Ensure_Inited(void) int readFile(char *filename, FontPtr font

[PATCH app/fonttosfnt 1/5] Constify a few string arguments

2018-07-30 Thread Peter Hutterer
Cuts down on compiler warning by at least 64%, what a bargain! Signed-off-by: Peter Hutterer --- fonttosfnt.h | 8 util.c | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/fonttosfnt.h b/fonttosfnt.h index d6aa004..159535f 100644 --- a/fonttosfnt.h

Re: [PATCH app/xev] xev: fix 'mode' in default case (version 2)

2018-07-30 Thread Peter Hutterer
On Sat, Jul 28, 2018 at 08:28:36AM +, Eitan Adler wrote: > Signed-off-by: Eitan Adler To ssh://gitlab.freedesktop.org/xorg/app/xev d1f08f6..25bb70e master -> master thanks Cheers, Peter > --- > xev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xev.

Re: xmodmap really slow

2018-07-26 Thread Peter Hutterer
On Thu, Jul 26, 2018 at 12:25:49PM +0100, Alan Hourihane wrote: > Anyone tried just doing this recently > > xmodmap -pke > /tmp/keydump > xmodmap /tmp/keydump > > And watch the Xserver hang for quite some time. anything in the log? Just tried this locally and it worked just fine. what server

Re: [PATCH xserver] Xext: dynamically allocate the PanoramiXDepths[j].vids array

2018-07-18 Thread Peter Hutterer
On Tue, Jul 17, 2018 at 10:12:55PM -0700, Keith Packard wrote: > Peter Hutterer writes: > > > Control flow is: > >PanoramiXMaybeAddDepth() allocates an array size 240 (pDepth->numVisuals) > >PanoramiXMaybeAddVisual() finds up to 270 matches (pScreen->numVi

[PATCH xserver] Xext: dynamically allocate the PanoramiXDepths[j].vids array

2018-07-17 Thread Peter Hutterer
e-free abort. Reproduced with xorg-integration-tests server test XineramaTest.ScreenCrossing/* (and a bunch of others). Signed-off-by: Peter Hutterer --- Xext/panoramiX.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Xext/panoramiX.c b/Xext/panoramiX.c index 844

[PATCH xf86-input-libinput] draglock: fix memory overwrite during draglock parsing

2018-07-09 Thread Peter Hutterer
Passing in the size of the array but using it as "number of elements" inside the function. Rename a bunch of arguments to avoid this. https://bugs.freedesktop.org/show_bug.cgi?id=107166 Signed-off-by: Peter Hutterer --- Martin: this is the same basic change as your patch in 107166,

Re: [PATCH man xmodmap] Removing reference to XKeysymDB

2018-07-08 Thread Peter Hutterer
On Thu, Jul 05, 2018 at 02:58:49PM +0200, Wolfgang Pfeiffer wrote: > Removing a reference in 'man xmodmap' to a file called XKeysymDB that > was, IIUC, already remvoved around 2010 - please see: > > https://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=eb023c0f8919e809b8b609e1467b14d20a290aa7 >

Re: [PATCH xserver] meson: use absolute paths in manpage substitutions

2018-07-01 Thread Peter Hutterer
On Sat, Jun 30, 2018 at 12:53:35PM +0100, Jon Turney wrote: > paths returned by get_option('foodir') are potentially relative to prefix > > Noticed when comparing manpages generated by a meson build with those > generated by an autotools build > > Signed-off-by: Jon Turney pushed, thanks To gi

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

2018-07-01 Thread Peter Hutterer
On Fri, Jun 29, 2018 at 09:44:27AM +0200, Laurent Carlier wrote: > Le jeudi 28 juin 2018, 07:16:42 CEST Peter Hutterer a écrit : > > On Tue, Jun 26, 2018 at 09:51:58PM -0700, Aaron Plattner wrote: > > > On 06/26/2018 06:12 PM, Peter Hutterer wrote: > > > > On Tue, Ju

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

2018-06-27 Thread Peter Hutterer
On Tue, Jun 26, 2018 at 09:51:58PM -0700, Aaron Plattner wrote: > On 06/26/2018 06:12 PM, Peter Hutterer wrote: > > On Tue, Jun 26, 2018 at 01:07:23PM -0700, Aaron Plattner wrote: > > > On 06/24/2018 11:45 PM, Laurent Carlier wrote: > > > > Le samedi 16 juin 2018, 1

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

2018-06-26 Thread Peter Hutterer
On Tue, Jun 26, 2018 at 01:07:23PM -0700, Aaron Plattner wrote: > On 06/24/2018 11:45 PM, Laurent Carlier wrote: > > Le samedi 16 juin 2018, 13:00:01 CEST Laurent Carlier a écrit : > >> bugzilla: https://bugs.kde.org/show_bug.cgi?id=395419 > >> bugzilla: https://bugs.archlinux.org/task/59025 > >> >

Re: [PATCH] Improve the ButtonInfo description.

2018-06-26 Thread Peter Hutterer
On Tue, Jun 26, 2018 at 04:49:21PM +0100, Emil Velikov wrote: > On 8 June 2018 at 01:59, Peter Hutterer wrote: > > On Thu, Jun 07, 2018 at 03:32:08AM +0200, Roman Kapl wrote: > >> It failed to mention it is followed by a bit-mask and then the atoms. > >> >

Re: [PATCH xserver] xfree86: Makefile shouldn't rely on superuser being named 'root'

2018-06-11 Thread Peter Hutterer
rg/27726 > Signed-off-by: Adam Jackson > Signed-off-by: Michał Górny > --- Reviewed-by: Peter Hutterer Cheers, Peter > hw/xfree86/Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am > inde

Re: [PATCH xserver] xwayland: add "tablet" into the tablet device names

2018-06-11 Thread Peter Hutterer
On Mon, Jun 11, 2018 at 11:21:25AM +0200, Olivier Fourdan wrote: > Hi Peter, > On Mon, 11 Jun 2018 at 01:12, Peter Hutterer wrote: > > > > Changes the device name from "xwayland-stylus" to "xwayland-tablet stylus". > > This doesn't fully address

[PATCH xserver] xwayland: add "tablet" into the tablet device names

2018-06-10 Thread Peter Hutterer
Changes the device name from "xwayland-stylus" to "xwayland-tablet stylus". This doesn't fully address #26 but it goes a little step into making it more human-readable. https://gitlab.freedesktop.org/wayland/wayland/issues/26 Signed-off-by: Peter Hutterer --- hw/xway

Re: [PATCH xserver 2/2] Xi: add forgotten byte-swaps for Valuator fields

2018-06-07 Thread Peter Hutterer
On Thu, Jun 07, 2018 at 03:31:42AM +0200, Roman Kapl wrote: > This has caused nonsensical values in xinput output. > > Signed-off-by: Roman Kapl > --- > Xi/xiquerydevice.c | 3 +++ > 1 file changed, 3 insertions(+) pushed, thanks remote: Updating patchwork state for https://patchwork.freedesk

Re: [PATCH] Improve the ButtonInfo description.

2018-06-07 Thread Peter Hutterer
On Thu, Jun 07, 2018 at 03:32:08AM +0200, Roman Kapl wrote: > It failed to mention it is followed by a bit-mask and then the atoms. > > Signed-off-by: Roman Kapl > --- > include/X11/extensions/XI2proto.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Patch content is correct, than

[PATCH xkbcomp] Ignore xkb_keycodes.maximum of > 255

2018-06-06 Thread Peter Hutterer
on purpose so we get this for the first key that actually matters. Reproducible with xkeyboard-config 2.24 which has a maximum of 374. https://bugzilla.redhat.com/show_bug.cgi?id=1587998 Signed-off-by: Peter Hutterer --- keycodes.c | 10 +- 1 file changed, 9 insertions(+), 1 delet

[PATCH evdev 2/2] Fix generation of proximity-in/out events.

2018-05-27 Thread Peter Hutterer
remember the last value of the valuator (and is updated to the current values before processing the frame). We expect the prox in to have x/y, so let's just unconditionally use old_vals for proximity events.] Signed-off-by: Peter Hutterer --- src/evdev.c | 2 +- 1 file changed, 1 insertion(

[PATCH evdev 1/2] Ignore x/y axis changes on proximity out

2018-05-27 Thread Peter Hutterer
: Peter Hutterer --- src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 3d7b6f0..d07ee0a 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -551,6 +551,16 @@ EvdevProcessProximityState(InputInfoPtr pInfo) } } +/* Wacom's

[PATCH synaptics] eventcomm: if we get a read error other than EAGAIN, remove the fd

2018-05-13 Thread Peter Hutterer
t of space scenarios but otherwise a bit pointless. Those FS developers should write their own tests instead of relying on the synaptics driver! Signed-off-by: Peter Hutterer --- src/eventcomm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/eventcomm.c b/src/eventcomm.c index c69cb66..2cd8

Re: [PATCH xserver] meson: Fix module_dir configuration (v2)

2018-05-02 Thread Peter Hutterer
uledir=/X/xorg/modules > > Fix this by using the module_dir variable when generating xorg-server.pc, and > by > using join_paths() to assign module_dir unconditionally. > > v2: Keep the 'xorg/modules' default path, but use join_paths() > unconditionally (Thierry R

[PATCH xf86-input-libinput] Use the libinput touch count to init the right number of touches

2018-05-01 Thread Peter Hutterer
Initial version by Johannes Pointner Signed-off-by: Peter Hutterer --- configure.ac | 12 +++- src/xf86libinput.c | 10 +- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5892c5e..9c7174c 100644 --- a/configure.ac +++ b

Re: [PATCH xts] Add 'q' command line option to count subtests

2018-04-26 Thread Peter Hutterer
inary; we > don't support building that anyway, but this change would assuredly > break it too. > > Signed-off-by: Adam Jackson Reviewed-by: Peter Hutterer but: any specific reason you don't just name it --count? it's just a strcmp and would make things clearer

Re: [PATCH xserver] animcur: Fix crash when removing a master device

2018-04-23 Thread Peter Hutterer
ned-off-by: Adam Jackson Reviewed-by: Peter Hutterer Cheers, Peter > --- > render/animcur.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/render/animcur.c b/render/animcur.c > index 65327df655..ef27bda278 100644 > --- a/r

[PATCH xf86-input-libinput] Implement the custom acceleration curve options

2018-04-19 Thread Peter Hutterer
when the curve is set multiple times. Also helps to identify those that bother to read the man page before playing with random driver values. Signed-off-by: Peter Hutterer --- Note, the matching libinput patch is not yet on git master. configure.ac | 17 include/libinput

Re: [PATCH xserver] xwayland: Don't crash on WarpPointer(dest_w = None)

2018-04-12 Thread Peter Hutterer
.c:3618 > > In this case, x/y are the screen-space coordinates where the pointer > ends up, and we need to look up the (X) window there. > > Signed-off-by: Adam Jackson Reviewed-by: Peter Hutterer Cheers, Peter > --- > hw/xwayland/xwayland.c | 3 +++ > 1 file chang

Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-11 Thread Peter Hutterer
N { > sub(/[^a-zA-Z0-9_].*/, "", symbol); > > #print; > - printf("(void *) &%-50s /* %s:%s */\n", symbol ",", header, line); > + if (symbol != "") my awk skills are non-existent but shouldn't this be $symbol? The c

Re: [PATCH xserver] dix: always send focus event on grab change

2018-04-09 Thread Peter Hutterer
Samuel Thibault good catch, thanks. Reviewed-by: Peter Hutterer Ajax - feel free to take this one or wait for 1.20.1. It should be safe but there could be subtle bugs. Proably not any worse than having this broken for the last 10 years. Cheers, Peter > --- > dix/enterleave.c | 2 +- &g

Re: [PATCH xserver 2/8] dmx: Fix some snprintf warnings.

2018-04-06 Thread Peter Hutterer
On Thu, Apr 05, 2018 at 01:13:55PM -0400, Adam Jackson wrote: > snprintf doesn't terminate the string if it truncates, so things like > this are lurking crashers: it doesn't? which platforms is that on? Apparently windows, from a quick google but that's about it, right? Cheers, Peter > > ..

  1   2   3   4   5   6   7   8   9   10   >