[jira] [Commented] (YARN-10854) Support marking inactive node as untracked without configured include path

2021-07-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388210#comment-17388210 ] Daniel Templeton commented on YARN-10854: - The new description looks good. My only other ask

[jira] [Commented] (YARN-10854) Support marking inactive node as untracked without configured include path

2021-07-20 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384440#comment-17384440 ] Daniel Templeton commented on YARN-10854: - In principle the change looks fine to me. I'd like

[jira] [Commented] (YARN-6886) AllocationFileLoaderService.loadQueue() should validate that setting do not conflict with parent

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069205#comment-17069205 ] Daniel Templeton commented on YARN-6886: OK, I spent some time digging around in the code. It's

[jira] [Commented] (YARN-6551) Validate SLS input

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069193#comment-17069193 ] Daniel Templeton commented on YARN-6551: Try pulling the repo again and then reapplying your

[jira] [Commented] (YARN-5913) Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069191#comment-17069191 ] Daniel Templeton commented on YARN-5913: Looks like you need to update your repo and try again.

[jira] [Comment Edited] (YARN-6886) AllocationFileLoaderService.loadQueue() should validate that setting do not conflict with parent

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069185#comment-17069185 ] Daniel Templeton edited comment on YARN-6886 at 3/28/20, 2:21 AM: -- Nope,

[jira] [Commented] (YARN-6886) AllocationFileLoaderService.loadQueue() should validate that setting do not conflict with parent

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069185#comment-17069185 ] Daniel Templeton commented on YARN-6886: Nope, hasn't been fixed. It's just that the code where

[jira] [Commented] (YARN-6886) AllocationFileLoaderService.loadQueue() should validate that setting do not conflict with parent

2020-03-27 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069178#comment-17069178 ] Daniel Templeton commented on YARN-6886: [~ykabusalah], looks like you need to update your repo.

[jira] [Commented] (YARN-5913) Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext

2019-09-16 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931077#comment-16931077 ] Daniel Templeton commented on YARN-5913: The issue at hand is that in

[jira] [Commented] (YARN-2497) Fair scheduler should support strict node labels

2019-09-10 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926755#comment-16926755 ] Daniel Templeton commented on YARN-2497: You're welcome to play with the patch, but as noted, it's

[jira] [Assigned] (YARN-5913) Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext

2019-09-01 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-5913: -- Assignee: Yousef Abu-Salah > Consolidate "resource" and "amResourceRequest" in

[jira] [Assigned] (YARN-6425) Move out FS state dump code out of method update()

2019-09-01 Thread Daniel Templeton (Jira)
[ https://issues.apache.org/jira/browse/YARN-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-6425: -- Assignee: Yousef Abu-Salah > Move out FS state dump code out of method update() >

[jira] [Commented] (YARN-8480) Add boolean option for resources

2019-07-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894020#comment-16894020 ] Daniel Templeton commented on YARN-8480: I still hold that boolean resources are the way to go,

[jira] [Assigned] (YARN-6551) Validate SLS input

2019-07-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-6551: -- Assignee: Yousef Abu-Salah > Validate SLS input > -- > >

[jira] [Assigned] (YARN-6886) AllocationFileLoaderService.loadQueue() should validate that setting do not conflict with parent

2019-07-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-6886: -- Assignee: Yousef Abu-Salah > AllocationFileLoaderService.loadQueue() should validate

[jira] [Comment Edited] (YARN-6046) Documentation correction in YarnApplicationSecurity

2019-07-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884376#comment-16884376 ] Daniel Templeton edited comment on YARN-6046 at 7/18/19 4:26 PM: - LGTM +1

[jira] [Commented] (YARN-6046) Documentation correction in YarnApplicationSecurity

2019-07-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884376#comment-16884376 ] Daniel Templeton commented on YARN-6046: LGTM +1 . I'll commit it when I get a dev environment

[jira] [Assigned] (YARN-6046) Documentation correction in YarnApplicationSecurity

2019-06-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-6046: -- Assignee: Yousef Abu-Salah (was: Prashant Jha) > Documentation correction in

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797212#comment-16797212 ] Daniel Templeton commented on YARN-9398: Oh, yeah. Forgot about the fact that there were also a

[jira] [Updated] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-9398: --- Attachment: YARN-9398.001.patch > Javadoc error on FPGA related java files >

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797185#comment-16797185 ] Daniel Templeton commented on YARN-9398: I went ahead and posted patch. > Javadoc error on FPGA

[jira] [Comment Edited] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797185#comment-16797185 ] Daniel Templeton edited comment on YARN-9398 at 3/20/19 1:46 PM: - I went

[jira] [Assigned] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-9398: -- Assignee: Daniel Templeton (was: Peter Bacsko) > Javadoc error on FPGA related java

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797166#comment-16797166 ] Daniel Templeton commented on YARN-9398: I see it now. You're right, [~eyang]. > Javadoc error

[jira] [Commented] (YARN-9358) Add javadoc to new methods introduced in FSQueueMetrics with YARN-9322

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796305#comment-16796305 ] Daniel Templeton commented on YARN-9358: I just did a super quick pass. There are a couple issues

[jira] [Commented] (YARN-9398) Javadoc error on FPGA related java files

2019-03-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795995#comment-16795995 ] Daniel Templeton commented on YARN-9398: I'm seeing a ton of errors in the javadoc when I do a

[jira] [Assigned] (YARN-9340) [Clean-up] Remove NULL check before instanceof in ResourceRequestSetKey

2019-03-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned YARN-9340: -- Assignee: Shweta > [Clean-up] Remove NULL check before instanceof in

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780068#comment-16780068 ] Daniel Templeton commented on YARN-9322: And thanks to [~sunilg] for the review! > Store metrics

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780059#comment-16780059 ] Daniel Templeton commented on YARN-9322: OK, then. +1 and let's commit. > Store metrics for

[jira] [Commented] (YARN-9323) FSLeafQueue#computeMaxAMResource does not override zero values for custom resources

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779861#comment-16779861 ] Daniel Templeton commented on YARN-9323: Looking at {{FSLeafQueue.computeMaxAMResource()}}, I'm

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779827#comment-16779827 ] Daniel Templeton commented on YARN-9322: OK, +1 from me.  Please file a follow-up JIRA, though, to

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779614#comment-16779614 ] Daniel Templeton commented on YARN-9322: YARN-9318 is in, so let's rebase this and deal with the

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779582#comment-16779582 ] Daniel Templeton commented on YARN-9318: The @param tag shouldn't have a colon after the name, but

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779522#comment-16779522 ] Daniel Templeton commented on YARN-9322: LGTM except that it will still conflict with YARN-9318. 

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779516#comment-16779516 ] Daniel Templeton commented on YARN-9318: Nice. Love that you added JavaDocs. Could you finish out

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778721#comment-16778721 ] Daniel Templeton commented on YARN-9318: That looks much cleaner. My last comment is that in the

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778716#comment-16778716 ] Daniel Templeton commented on YARN-9322: Thanks, [~snemeth]. Comments: # I think this patch will

[jira] [Comment Edited] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778716#comment-16778716 ] Daniel Templeton edited comment on YARN-9322 at 2/27/19 12:02 AM: --

[jira] [Comment Edited] (YARN-9323) FSLeafQueue#computeMaxAMResource does not override zero values for custom resources

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778685#comment-16778685 ] Daniel Templeton edited comment on YARN-9323 at 2/26/19 11:31 PM: --

[jira] [Commented] (YARN-9323) FSLeafQueue#computeMaxAMResource does not override zero values for custom resources

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778685#comment-16778685 ] Daniel Templeton commented on YARN-9323: Thanks, [~snemeth]. Comments: # The patch doesn't

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778600#comment-16778600 ] Daniel Templeton commented on YARN-9318: Thanks for the patch, [~snemeth]. I have a few comments:

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778589#comment-16778589 ] Daniel Templeton commented on YARN-9322: I just retriggered the tests. > Store metrics for custom

[jira] [Commented] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

2019-02-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777087#comment-16777087 ] Daniel Templeton commented on YARN-9326: Thanks for catching that, [~adam.antal]. A couple of

[jira] [Commented] (YARN-8990) Fix fair scheduler race condition in app submit and queue cleanup

2018-11-09 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681743#comment-16681743 ] Daniel Templeton commented on YARN-8990: Thanks for finding and fixing this one, [~wilfreds]! It

[jira] [Updated] (YARN-8990) FS: race condition in app submit and queue cleanup

2018-11-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-8990: --- Priority: Blocker (was: Major) > FS: race condition in app submit and queue cleanup >

[jira] [Commented] (YARN-8985) FSParentQueue: debug log missing when assigning container

2018-11-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679315#comment-16679315 ] Daniel Templeton commented on YARN-8985: Doesn't look like Jenkins started yet, so I just kicked

[jira] [Commented] (YARN-8985) FSParentQueue: debug log missing when assigning container

2018-11-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679314#comment-16679314 ] Daniel Templeton commented on YARN-8985: LGTM +1 pending Jenkins. > FSParentQueue: debug log

[jira] [Commented] (YARN-8985) FSParentQueue: debug log missing when assigning container

2018-11-08 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679352#comment-16679352 ] Daniel Templeton commented on YARN-8985: The findbugs warning is legit. No idea what build error

[jira] [Created] (YARN-8681) Wrong error message in RM placement constraints check

2018-08-17 Thread Daniel Templeton (JIRA)
Daniel Templeton created YARN-8681: -- Summary: Wrong error message in RM placement constraints check Key: YARN-8681 URL: https://issues.apache.org/jira/browse/YARN-8681 Project: Hadoop YARN

[jira] [Commented] (YARN-8621) Add REST API tests for Resource Types fields for the apps/ endpoint

2018-08-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584336#comment-16584336 ] Daniel Templeton commented on YARN-8621: I don't think we need to return the resource requests

[jira] [Commented] (YARN-7133) Clean up lock-try order in fair scheduler

2018-07-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553202#comment-16553202 ] Daniel Templeton commented on YARN-7133: For one, it's the format set as the standard by Sun. See

[jira] [Commented] (YARN-8480) Add boolean option for resources

2018-07-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551228#comment-16551228 ] Daniel Templeton commented on YARN-8480: I read through both node attributes and rich placement

[jira] [Commented] (YARN-8480) Add boolean option for resources

2018-07-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540885#comment-16540885 ] Daniel Templeton commented on YARN-8480: I don't disagree that in terms of general use cases

[jira] [Commented] (YARN-8480) Add boolean option for resources

2018-07-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535129#comment-16535129 ] Daniel Templeton commented on YARN-8480: A boolean resource wouldn't be consumed by its use. The

[jira] [Created] (YARN-8480) Add boolean option for resources

2018-06-29 Thread Daniel Templeton (JIRA)
Daniel Templeton created YARN-8480: -- Summary: Add boolean option for resources Key: YARN-8480 URL: https://issues.apache.org/jira/browse/YARN-8480 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2018-06-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514617#comment-16514617 ] Daniel Templeton commented on YARN-7556: The findbugs and unit test issues are unrelated. I think

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2018-06-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514447#comment-16514447 ] Daniel Templeton commented on YARN-7556: Eeew. That's a lot of failures. It doesn't look like

[jira] [Commented] (YARN-6995) Improve use of ResourceNotFoundException in resource types code

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511754#comment-16511754 ] Daniel Templeton commented on YARN-6995: I rebased to latest trunk. [~sunilg], I agree that the

[jira] [Updated] (YARN-6995) Improve use of ResourceNotFoundException in resource types code

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-6995: --- Attachment: YARN-6995.005.patch > Improve use of ResourceNotFoundException in resource types

[jira] [Updated] (YARN-6964) Fair scheduler misuses Resources operations

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-6964: --- Attachment: YARN-6964.012.patch > Fair scheduler misuses Resources operations >

[jira] [Commented] (YARN-6964) Fair scheduler misuses Resources operations

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511728#comment-16511728 ] Daniel Templeton commented on YARN-6964: I made an arbitrary choice to set demand to twice the

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511692#comment-16511692 ] Daniel Templeton commented on YARN-7556: New patch addresses [~wilfreds] docs concerns and rebases

[jira] [Updated] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2018-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7556: --- Attachment: YARN-7556.007.patch > Fair scheduler configuration should allow resource types in

[jira] [Commented] (YARN-7467) FSLeafQueue unnecessarily calls ComputeFairShares.computeShare() to calculate fair share for apps

2018-06-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508639#comment-16508639 ] Daniel Templeton commented on YARN-7467: [~zhuqi], a couple of comments on the patch from

[jira] [Commented] (YARN-7467) FSLeafQueue unnecessarily calls ComputeFairShares.computeShare() to calculate fair share for apps

2018-06-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508628#comment-16508628 ] Daniel Templeton commented on YARN-7467: Go for it. > FSLeafQueue unnecessarily calls

[jira] [Commented] (YARN-6132) SliderClient bondToCluster should call findInstance with live states filter

2018-06-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508193#comment-16508193 ] Daniel Templeton commented on YARN-6132: Can be add a fixed in version for this issue? >

[jira] [Resolved] (YARN-4353) Provide short circuit user group mapping for NM/AM

2018-05-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton resolved YARN-4353. Resolution: Won't Fix Hadoop Flags: Reviewed I'm fine with closing this out. I added

[jira] [Comment Edited] (YARN-8200) Backport resource types/GPU features to branch-2

2018-04-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450136#comment-16450136 ] Daniel Templeton edited comment on YARN-8200 at 4/24/18 4:05 PM: - The

[jira] [Comment Edited] (YARN-8200) Backport resource types/GPU features to branch-2

2018-04-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450136#comment-16450136 ] Daniel Templeton edited comment on YARN-8200 at 4/24/18 4:05 PM: - The

[jira] [Commented] (YARN-8200) Backport resource types/GPU features to branch-2

2018-04-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450136#comment-16450136 ] Daniel Templeton commented on YARN-8200: The challenge in backporting resource types into 3.0 was

[jira] [Commented] (YARN-7292) Revisit Resource Profile Behavior

2018-02-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361805#comment-16361805 ] Daniel Templeton commented on YARN-7292: Hang on. If I understand that correctly, you're saying

[jira] [Commented] (YARN-7292) Revisit Resource Profile Behavior

2018-02-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361217#comment-16361217 ] Daniel Templeton commented on YARN-7292: Sorry, still running way behind. Looking at the patch, it

[jira] [Commented] (YARN-7819) Allow PlacementProcessor to be used with the FairScheduler

2018-01-31 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347834#comment-16347834 ] Daniel Templeton commented on YARN-7819: Comments: * The write lock should be locked outside the

[jira] [Commented] (YARN-7739) DefaultAMSProcessor should properly check customized resource types against minimum/maximum allocation

2018-01-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345920#comment-16345920 ] Daniel Templeton commented on YARN-7739: It would be nice to have the test not hard-coded to CS. 

[jira] [Commented] (YARN-7292) Revisit Resource Profile Behavior

2018-01-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345918#comment-16345918 ] Daniel Templeton commented on YARN-7292: I these are still relevant questions and something I'd

[jira] [Commented] (YARN-7528) Resource types that use units need to be defined at RM level and NM level or when using small units you will overflow max_allocation calculation

2018-01-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345503#comment-16345503 ] Daniel Templeton commented on YARN-7528: If you do not specify a maximum value for a resource, it's

[jira] [Commented] (YARN-7528) Resource types that use units need to be defined at RM level and NM level or when using small units you will overflow max_allocation calculation

2018-01-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344290#comment-16344290 ] Daniel Templeton commented on YARN-7528: Sorry it took me a while to respond.  Did you try

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2018-01-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344252#comment-16344252 ] Daniel Templeton commented on YARN-7556: During my break I realized that I need to make sure that

[jira] [Commented] (YARN-7159) Normalize unit of resource objects in RM and avoid to do unit conversion in critical path

2018-01-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329136#comment-16329136 ] Daniel Templeton commented on YARN-7159: I'll add it to my list.  I'm just back from being out for

[jira] [Commented] (YARN-7528) Resource types that use units need to be defined at RM level and NM level or when using small units you will overflow max_allocation calculation

2018-01-09 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318568#comment-16318568 ] Daniel Templeton commented on YARN-7528: Fine with me. > Resource types that use units need to be

[jira] [Commented] (YARN-7557) It should be possible to specify resource types in the fair scheduler increment value

2017-12-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287931#comment-16287931 ] Daniel Templeton commented on YARN-7557: YARN-7556 is about setting the max and min resources in

[jira] [Commented] (YARN-7624) RM gives YARNFeatureNotEnabledException even when resource profile feature is not enabled

2017-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283013#comment-16283013 ] Daniel Templeton commented on YARN-7624: This is against trunk/3.1, yes? > RM gives

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

2017-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282133#comment-16282133 ] Daniel Templeton commented on YARN-7119: +1 [~sunilg], wanna do the commit? I'm on vacation

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280739#comment-16280739 ] Daniel Templeton commented on YARN-7556: Test failures are still unrelated. [~rkanter] or

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

2017-12-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280559#comment-16280559 ] Daniel Templeton commented on YARN-7119: LGTM. Last thing, it would be nice to clean up the

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279476#comment-16279476 ] Daniel Templeton commented on YARN-7556: Test failures are all unrelated. > Fair scheduler

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279185#comment-16279185 ] Daniel Templeton commented on YARN-7119: Looks good to me, except one tiny issue, which might not

[jira] [Updated] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7556: --- Attachment: YARN-7556.006.patch Reposting patch 6 because I think it might have been

[jira] [Updated] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7556: --- Attachment: (was: YARN-7556.006.patch) > Fair scheduler configuration should allow

[jira] [Updated] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7556: --- Attachment: YARN-7556.006.patch Whoops. Used the wrong branch. Here's a trunk patch. > Fair

[jira] [Updated] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7556: --- Attachment: YARN-7556.005.patch I reworked the patch to not use -1 as a flag, so there's no

[jira] [Commented] (YARN-7556) Fair scheduler configuration should allow resource types in the minResources and maxResources properties

2017-12-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277085#comment-16277085 ] Daniel Templeton commented on YARN-7556: The -1's also bother me. I mitigated the risk by keeping

[jira] [Commented] (YARN-7600) Yarn NODE_LOCAL request downgraded to RACK_LOCAL didn't cancel the original NODE_LOCAL request

2017-12-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275687#comment-16275687 ] Daniel Templeton commented on YARN-7600: [~rkanter], any insights from you? > Yarn NODE_LOCAL

[jira] [Commented] (YARN-7600) Yarn NODE_LOCAL request downgraded to RACK_LOCAL didn't cancel the original NODE_LOCAL request

2017-12-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275686#comment-16275686 ] Daniel Templeton commented on YARN-7600: We are both out on vacation for December. :) If I get

[jira] [Commented] (YARN-7589) TestPBImplRecords fails with NullPointerException

2017-12-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275099#comment-16275099 ] Daniel Templeton commented on YARN-7589: Thanks for the review and commit, [~jlowe]! >

[jira] [Updated] (YARN-7589) TestPBImplRecords fails with NullPointerException

2017-12-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7589: --- Affects Version/s: 3.0.0 Target Version/s: 3.0.0, 3.1.0, 3.0.1 (was: 3.1.0, 3.0.1)

[jira] [Commented] (YARN-7589) TestPBImplRecords fails with NullPointerException

2017-12-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274932#comment-16274932 ] Daniel Templeton commented on YARN-7589: Findbugs issue is unrelated. > TestPBImplRecords fails

[jira] [Updated] (YARN-7589) TestPBImplRecords fails with NullPointerException

2017-12-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-7589: --- Attachment: YARN-7589.001.patch Silly oversight on my part. This patch fixes the issue but

[jira] [Commented] (YARN-7541) Node updates don't update the maximum cluster capability for resources other than CPU and memory

2017-11-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273967#comment-16273967 ] Daniel Templeton commented on YARN-7541: Weird. That test didn't fail in the pre-commits. I'll

[jira] [Commented] (YARN-7589) TestPBImplRecords fails with NullPointerException

2017-11-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273432#comment-16273432 ] Daniel Templeton commented on YARN-7589: I will take a look when I get a chance. >

  1   2   3   4   5   6   7   8   9   10   >