[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099929#comment-17099929 ] Hudson commented on YARN-10257: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-05 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099915#comment-17099915 ] Szilard Nemeth commented on YARN-10257: --- Thanks [~pbacsko], Committed this to trunk

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099854#comment-17099854 ] Hadoop QA commented on YARN-10257: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-05 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099776#comment-17099776 ] Szilard Nemeth commented on YARN-10257: --- Hi [~pbacsko], LGTM, one nit only: In org

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-05 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099767#comment-17099767 ] Peter Bacsko commented on YARN-10257: - [~adam.antal] 1. "Do you plan to do something

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-04 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099573#comment-17099573 ] Adam Antal commented on YARN-10257: --- Thanks for the patch [~pbacsko]! Do you plan to do

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-04 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099218#comment-17099218 ] Peter Bacsko commented on YARN-10257: - Note: I modified how we call {{System.exit()}}

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-04 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099216#comment-17099216 ] Peter Bacsko commented on YARN-10257: - Checkstyle is not relevant. [~snemeth] please

[jira] [Commented] (YARN-10257) FS-CS converter: skip increment properties for mem/vcores and fix DRF check

2020-05-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099068#comment-17099068 ] Hadoop QA commented on YARN-10257: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote