[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345849#comment-17345849
]
Qi Zhu commented on YARN-10763:
---
Thanks [~chaosju] for update.
The latest patch LGTM +1.
> add the
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345684#comment-17345684
]
Hadoop QA commented on YARN-10763:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345646#comment-17345646
]
chaosju commented on YARN-10763:
Thanks [~pbacsko] for review and comments.
The new patch addressed
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344518#comment-17344518
]
Peter Bacsko commented on YARN-10763:
-
Thanks [~chaosju] just a final update, very minor things:
1.
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344279#comment-17344279
]
chaosju commented on YARN-10763:
I think the unit test failures not related patch-007, Please take a
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343984#comment-17343984
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343815#comment-17343815
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343324#comment-17343324
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343305#comment-17343305
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343232#comment-17343232
]
chaosju commented on YARN-10763:
[~pbacsko]
Thank you for your detailed and patient reviews, I have got
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343152#comment-17343152
]
Peter Bacsko commented on YARN-10763:
-
Some further comments:
1. {{private volatile AtomicLong
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343139#comment-17343139
]
Peter Bacsko commented on YARN-10763:
-
[~chaosju] I added you to the list of contributors so you can
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343131#comment-17343131
]
chaosju commented on YARN-10763:
I have attached .004 patch with fixed whitespace、spotbugs etc
> add
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343049#comment-17343049
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343045#comment-17343045
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342963#comment-17342963
]
chaosju commented on YARN-10763:
Hi [~pbacsko]
I have attached .003 patch with latest changes. Please
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342750#comment-17342750
]
Hadoop QA commented on YARN-10763:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342634#comment-17342634
]
chaosju commented on YARN-10763:
Thanks a lot [~zhuqi] [~pbacsko] for review.
You suggestion is very
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342360#comment-17342360
]
Peter Bacsko commented on YARN-10763:
-
[~chaosju] some comments:
1. {{Timer}} / {{TimerTask}} are
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340883#comment-17340883
]
Qi Zhu commented on YARN-10763:
---
Thanks [~chaosju] for report.
If you can use aggregateContainersAllocated
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340875#comment-17340875
]
chaosju commented on YARN-10763:
[~chaosju]
> add the speed of containers assigned metrics to
[
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340874#comment-17340874
]
chaosju commented on YARN-10763:
[~ebadger] [~pbacsko] [~gandras] [~bilwa_st] [~zhuqi]
Could you help
22 matches
Mail list logo