[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221310#comment-14221310 ] Wangda Tan commented on YARN-2762: -- [~rohithsharma], Thanks for patch, I've updated the ti

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222428#comment-14222428 ] Rohith commented on YARN-2762: -- Thanks [~leftnoteasy] for reviewing patch. I updated the patch

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222438#comment-14222438 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223219#comment-14223219 ] Rohith commented on YARN-2762: -- Am little confused about HadoopQA result. Am able to apply pat

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223303#comment-14223303 ] Rohith commented on YARN-2762: -- I updated patch by creating patch from different branch,but I

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223386#comment-14223386 ] Hadoop QA commented on YARN-2762: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230864#comment-14230864 ] Rohith commented on YARN-2762: -- Hi [~leftnoteasy] Kindly review the patch. > RMAdminCLI node-

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233812#comment-14233812 ] Wangda Tan commented on YARN-2762: -- Hi [~rohithsharma], Thanks for working on this, the tr

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233900#comment-14233900 ] Rohith commented on YARN-2762: -- bq. If no node-to-labels mapping specified when replace labels

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234164#comment-14234164 ] Rohith commented on YARN-2762: -- Updated patch with log message consistency.Kindly review > RM

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234499#comment-14234499 ] Wangda Tan commented on YARN-2762: -- [~rohithsharma], I thought you uploaded a wrong patch

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234521#comment-14234521 ] Rohith commented on YARN-2762: -- I updated correct patch, Kindly review. The difference from pr

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234526#comment-14234526 ] Wangda Tan commented on YARN-2762: -- [~rohithsharma], The Jenkins should have some issues,

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235807#comment-14235807 ] Sunil G commented on YARN-2762: --- HI [~rohithsharma] Good catch. I have some minor nits. 1.

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235879#comment-14235879 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236384#comment-14236384 ] Wangda Tan commented on YARN-2762: -- [~sunilg], Thanks for comment, #1, #3 makes sense to m

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236631#comment-14236631 ] Rohith commented on YARN-2762: -- bq. Better we can use labels.isEmpty() Make sense, I will do

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236633#comment-14236633 ] Rohith commented on YARN-2762: -- [~sunilg] [~leftnoteasy] Kindly review the updated patch. > R

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236654#comment-14236654 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1423#comment-1423 ] Rohith commented on YARN-2762: -- I believe test failures are either unrelated or temporary. >

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238130#comment-14238130 ] Wangda Tan commented on YARN-2762: -- [~rohithsharma], Thanks for update, Last two minor com

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238176#comment-14238176 ] Rohith commented on YARN-2762: -- Updated the patch fixing review comment. Kindly review updated

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238237#comment-14238237 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238357#comment-14238357 ] Wangda Tan commented on YARN-2762: -- Looks good, thanks for update, test failure shouldn't

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238902#comment-14238902 ] Rohith commented on YARN-2762: -- For all the syserr and sysout , findbug warning has been gener

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239051#comment-14239051 ] Rohith commented on YARN-2762: -- I believe these findbug errors are ocuring due to either chang

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239052#comment-14239052 ] Wangda Tan commented on YARN-2762: -- bq. I believe these findbug errors are ocuring due to

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240595#comment-14240595 ] Rohith commented on YARN-2762: -- Thanks [~leftnoteasy] for reviewing patch:-) > RMAdminCLI nod

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243567#comment-14243567 ] Jian He commented on YARN-2762: --- looks good, one minor comment: we can have a common method f

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243660#comment-14243660 ] Rohith commented on YARN-2762: -- Thanks [~jianhe] for review. I updated the patch by refactorin

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243675#comment-14243675 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243735#comment-14243735 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247258#comment-14247258 ] Hadoop QA commented on YARN-2762: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247271#comment-14247271 ] Jian He commented on YARN-2762: --- [~rohithsharma], could you check if the test failure is rela

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247638#comment-14247638 ] Rohith commented on YARN-2762: -- I have checked test failures. These are not introduced by this

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247678#comment-14247678 ] Rohith commented on YARN-2762: -- YARN-2783 YARN-2710 are the corresponding issues for test fail

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248722#comment-14248722 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-trunk-Commit #6730 (See [https:

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249740#comment-14249740 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #44 (See [http

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249746#comment-14249746 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-Yarn-trunk #778 (See [https://b

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249900#comment-14249900 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1976 (See [https://

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249910#comment-14249910 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #41 (See [http

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249953#comment-14249953 ] Hudson commented on YARN-2762: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #45 (See

[jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM

[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250008#comment-14250008 ] Hudson commented on YARN-2762: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1995 (See [htt