[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199472#comment-16199472
]
Jian He commented on YARN-7202:
---
bq. After discussion with Jian, we agree to revert back to Patch 03,
Ok, I
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199443#comment-16199443
]
Jian He commented on YARN-7202:
---
bq. This is the reason that MiniHDFSCluster and MiniYARNCluster are both
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199438#comment-16199438
]
Billie Rinaldi commented on YARN-7202:
--
Instead of the patch 08 changes to updateService, I suggest
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198976#comment-16198976
]
Eric Yang commented on YARN-7202:
-
[~jianhe] wrote:
{code}
Confused. I'm seeing the opposite.
Before the
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198881#comment-16198881
]
Eric Yang commented on YARN-7202:
-
[~jianhe] I took another look at the code from patch 08, and I have
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198013#comment-16198013
]
Hadoop QA commented on YARN-7202:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198012#comment-16198012
]
Eric Yang commented on YARN-7202:
-
[~jianhe] PUT method throws YarnException for both Service Not Found,
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197999#comment-16197999
]
Hadoop QA commented on YARN-7202:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197860#comment-16197860
]
Jian He commented on YARN-7202:
---
confused, isn't this code not part of this patch ? I did clean before build.
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197669#comment-16197669
]
Eric Yang commented on YARN-7202:
-
[~jianhe] Thank you for the review. The new code enables the logic to
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197421#comment-16197421
]
Jian He commented on YARN-7202:
---
bq. If Service config changed, save configuration.
bq. If Service should
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196544#comment-16196544
]
Eric Yang commented on YARN-7202:
-
[~jianhe] ServiceClient code is partially completed in YARN-7202.
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196338#comment-16196338
]
Jian He commented on YARN-7202:
---
Thanks for the patch, few comments:
- STARTED and STOPPED are mutually
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194957#comment-16194957
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192146#comment-16192146
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191835#comment-16191835
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190594#comment-16190594
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190567#comment-16190567
]
Hadoop QA commented on YARN-7202:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188942#comment-16188942
]
Eric Yang commented on YARN-7202:
-
TestYarnNativeServices and TestApiServer combination provides end-to-end
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184996#comment-16184996
]
Jian He commented on YARN-7202:
---
oh, ok, didn't know we can still re-open it.
> End-to-end UT for
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184914#comment-16184914
]
Eric Yang commented on YARN-7202:
-
[~jianhe] I am able to re-open HADOOP-9122. I can move powermock
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184881#comment-16184881
]
Jian He commented on YARN-7202:
---
Once the issue is closed, it cannot be reopened. If the issue is only
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184870#comment-16184870
]
Eric Yang commented on YARN-7202:
-
[~jianhe] Sure, I will add to javadoc to indicate the purpose of test
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184648#comment-16184648
]
Jian He commented on YARN-7202:
---
could you also add the comments in your first comment of this jira here to
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184640#comment-16184640
]
Jian He commented on YARN-7202:
---
bq. If both mocked version of ServiceClient, and ApiServer are in agreement
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182886#comment-16182886
]
Eric Yang commented on YARN-7202:
-
[~jianhe] In the example that you provided, it is showing what ApiServer
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181778#comment-16181778
]
Jian He commented on YARN-7202:
---
I'm just worried some ended up testing the ServiceClientForTest instead of
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181706#comment-16181706
]
Eric Yang commented on YARN-7202:
-
[~jianhe] The test case are designed to be unit tests for ApiServer
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181680#comment-16181680
]
Jian He commented on YARN-7202:
---
[~eyang], thanks for working on the patch.
I looked at the patch, looks like
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181567#comment-16181567
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181251#comment-16181251
]
Hadoop QA commented on YARN-7202:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
31 matches
Mail list logo
