[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083823#comment-17083823 ] Szilard Nemeth commented on YARN-9995: -- Thanks [~BilwaST], Committed your patch to branch-3.2. Thanks

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079668#comment-17079668 ] Bilwa S T commented on YARN-9995: - Hi [~snemeth]  TestSchedConfCLI#testFormatSchedulerConf  fails in

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079639#comment-17079639 ] Hadoop QA commented on YARN-9995: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079462#comment-17079462 ] Bilwa S T commented on YARN-9995: - HI [~snemeth]  Thanks for committing. i have attached patch for

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079378#comment-17079378 ] Hudson commented on YARN-9995: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18132 (See

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079361#comment-17079361 ] Szilard Nemeth commented on YARN-9995: -- Hi [~BilwaST], I was able to backport your patch to

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079356#comment-17079356 ] Szilard Nemeth commented on YARN-9995: -- Hi [~BilwaST], Thanks for working on this. Latest patch LGTM,

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078647#comment-17078647 ] Hadoop QA commented on YARN-9995: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078599#comment-17078599 ] Hadoop QA commented on YARN-9995: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078566#comment-17078566 ] Benjamin Teke commented on YARN-9995: - [~BilwaST] Thanks. LGTM, +1 (non-binding). > Code cleanup in

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078548#comment-17078548 ] Bilwa S T commented on YARN-9995: - [~bteke] Thanks for review. I just missed it. Updated latest patch >

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078530#comment-17078530 ] Benjamin Teke commented on YARN-9995: - Hi [~BilwaST],   Thanks for the quick reply. One last thing:

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078504#comment-17078504 ] Bilwa S T commented on YARN-9995: - Hi [~bteke], Thanks for reviewing. I have handled all comments given. 

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078441#comment-17078441 ] Benjamin Teke commented on YARN-9995: - Hi [~BilwaST], Thanks for the patch! Looks good to me overall.

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077991#comment-17077991 ] Bilwa S T commented on YARN-9995: - cc [~snemeth] > Code cleanup in TestSchedConfCLI >

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073748#comment-17073748 ] Bilwa S T commented on YARN-9995: - [~snemeth] can you please review? > Code cleanup in TestSchedConfCLI >

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069246#comment-17069246 ] Hadoop QA commented on YARN-9995: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068346#comment-17068346 ] Hadoop QA commented on YARN-9995: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068278#comment-17068278 ] Bilwa S T commented on YARN-9995: - Hi [~snemeth] Thanks for clarification. I have uploaded a patch. Please

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065444#comment-17065444 ] Szilard Nemeth commented on YARN-9995: -- Hi [~BilwaST], No, I didn't mean to use reflection at all.

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063148#comment-17063148 ] Bilwa S T commented on YARN-9995: - Hi [~snemeth] do u mean something like below ?  {quote} Object

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063146#comment-17063146 ] Bilwa S T commented on YARN-9995: - Hi [~snemeth] do u mean something like below? Object

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060040#comment-17060040 ] Szilard Nemeth commented on YARN-9995: -- Hi [~BilwaST], Yes, you are right. Rephrased the description

[jira] [Commented] (YARN-9995) Code cleanup in TestSchedConfCLI

[ https://issues.apache.org/jira/browse/YARN-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060026#comment-17060026 ] Bilwa S T commented on YARN-9995: - Hi [~snemeth] I have a small doubt. Why do we need a Builder for