On 07/28/2014 09:53 AM, Wang Weijun wrote:
Yes, you are right.
Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02.
GendataJavaSecurity.gmk and MakeJavaSecurity.java updated.
There's an unnecessary indent at line 1 of GendataJavaSecurity.gmk
In CheckSecurityProvider.java, ucrypto is in the closed sources, so
Security.getProviders() will not return it if you are testing an OpenJDK
build. You need to adjust the test to not include this provider if
testing an OpenJDK build.
--Sean
Thanks
Max
On Jul 28, 2014, at 19:43, Erik Joelsson <erik.joels...@oracle.com> wrote:
Hello Max,
Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on
$(RESTRICTED_PKGS_SRC) so that updates to the pkgs file triggers a rebuild? For
that to work, the variable $(RESTRICTED_PKGS_SRC) needs to be empty for the
OPENJDK case rather than have a dummy name and MakeJavaSecurity.java needs to
handle missing the last argument.
/Erik
On 2014-07-28 03:44, Wang Weijun wrote:
Webrev updated at
http://cr.openjdk.java.net/~weijun/6997010/webrev.01/
New test CheckSecurityProvider.java, and updates to
MakeJavaSecurity.addPackages().
Thanks
Max
On Jul 25, 2014, at 22:44, Wang Weijun
<weijun.w...@oracle.com>
wrote:
On Jul 25, 2014, at 22:30, Sean Mullan <sean.mul...@oracle.com>
wrote:
http://cr.openjdk.java.net/~weijun/6997010/webrev.00/
4. *IMPORTANT*: In order to easily maintain platform-related entries,
every line (including the last line) in package.access and
package.definition MUST end with ',\' now. A blank line MUST exist
after the last line. This avoid ugly lines like
#ifndef windows entry1. #endif #ifdef windows entry1.,\ entry2
#endif
What happens if someone (inevitably) adds a new package to the list and forgets
to do either of these? Does it result in a build failure?
No build failure, but
test/java/security/SecurityManager/CheckPackageAccess.java will fail.
I can add check in the build tool.
Otherwise looks good, although I think it would be useful to write an
additional test to make sure the correct providers are installed and ordered
correctly on the different platforms, something similar to the
java/lang/SecurityManager/CheckPackageAccess.java test but specific to
providers.
OK.
Thanks
Max
