On Wed, 14 Oct 2020 00:00:38 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> src/java.base/share/classes/sun/security/util/SignatureUtil.java line 164:
>
>> 162: }
>> 163: } else {
>> 164: paramSpec = getDefaultAlgorithmParameterSpec(sigName, null);
>
> Same comment here as for the getParamSpec(String, AlgorithmParameters) above.
> Given that there are two methods named
> getParamSpec(...), maybe add a boolean argument to indicate whether to return
> default value if the to-be-converted
> object is null?
Same reply. I'll see if it's OK to return a null.
> src/java.base/share/classes/sun/security/util/SignatureUtil.java line 290:
>
>> 288: * that must be initialized with a AlgorithmParameterSpec now.
>> 289: */
>> 290: public static AlgorithmParameterSpec
>> getDefaultAlgorithmParameterSpec(
>
> Maybe we can just use "getDefaultParamSpec" to match other methods' name in
> this class. Just a suggestion.
Sure.
-------------
PR: https://git.openjdk.java.net/jdk/pull/322
