On Wed, 14 Oct 2020 04:03:46 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> signing time, jarsigner -directsign, and digest algorithm check
>
> src/java.base/share/classes/sun/security/util/KnownOIDs.java line 147:
>
>> 145: SHAKE128("2.16.840.1.101.3.4.2.11"),
>> 146: SHAKE256("2.16.840.1.101.3.4.2.12"),
>> 147: SHAKE256_LEN("2.16.840.1.101.3.4.2.18", "SHAKE256-LEN"),
>
> Can we move this down a little? The ordering within the section is based on
> the oid value. It's easier to check for
> unlisted/unsupported oid value this way. Why not also add SHAKE128_LEN?
I'll add one.
-------------
PR: https://git.openjdk.java.net/jdk/pull/322
